JAL-2443: Remove getResidueBoxColour from api.SequenceRenderer


CR-JAL-27 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Total   0m 0  


    Calls to SequenceRenderer.getResidueBoxColour are always followed by a call to findFeatureColour (unless feature display is turned off).

    This logic is already encapsulated in method SequenceRenderer.getResidueColour() so it would be simpler always to use this method instead.

    Remove getResidueBoxColour from the api and change all calls to it to just call getResidueColour. This method now accepts a FeatureColourFinder (JAL-2438) so it can do the feature colour lookup after the colour scheme lookup.

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/MCview/AppletPDBCanvas.java Changed
    /src/MCview/PDBCanvas.java Changed
    /src/jalview/api/SequenceRenderer.java Changed
    Open in IDE #permalink
    /src/jalview/appletgui/OverviewPanel.java Changed
    /src/.../appletgui/SequenceRenderer.java Changed
    /src/jalview/ext/jmol/JmolCommands.java Changed
    /src/jalview/ext/varna/VarnaCommands.java Changed
    /src/jalview/gui/OverviewPanel.java Changed
    /src/jalview/gui/SequenceRenderer.java Changed
    /test/.../gui/SequenceRendererTest.java Changed
    /test/.../schemes/ColourSchemesTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against