CR-JAL-27 JAL-2443: Remove getResidueBoxColour from api.SequenceRenderer

draft for 3 years

Author

JAL-2443: Remove getResidueBoxColour from api.SequenceRenderer

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 11

jalview 0
- Folder src 0
  - Folder MCview 0
    - File AppletPDBCanvas.java 0 Remove
    - File PDBCanvas.java 0 Remove
  - Folder jalview 0
    - Folder api 0
      - File SequenceRenderer.java 0 Remove
    - Folder appletgui 0
      - File OverviewPanel.java 0 Remove
      - File SequenceRenderer.java 0 Remove
    - Folder ext 0
      - Folder jmol 0
        
        File JmolCommands.java 0 Remove
      - Folder varna 0
        
        File VarnaCommands.java 0 Remove
    - Folder gui 0
      - File OverviewPanel.java 0 Remove
      - File SequenceRenderer.java 0 Remove
- Folder test/jalview 0
  - Folder gui 0
    - File SequenceRendererTest.java 0 Remove
  - Folder schemes 0
    - File ColourSchemesTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Mungo Carstairs	Author
Total		0m	0

Linked Issue:
JAL-2443

#permalink

Objectives

Calls to SequenceRenderer.getResidueBoxColour are always followed by a call to findFeatureColour (unless feature display is turned off).

This logic is already encapsulated in method SequenceRenderer.getResidueColour() so it would be simpler always to use this method instead.

Remove getResidueBoxColour from the api and change all calls to it to just call getResidueColour. This method now accepts a FeatureColourFinder (JAL-2438) so it can do the feature colour lookup after the colour scheme lookup.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-27

JAL-2443: Remove getResidueBoxColour from api.SequenceRenderer

CR-JAL-27 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2443: Remove getResidueBoxColour from api.SequenceRenderer

CR-JAL-27 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against