CR-JAL-27 0
- Details
- Objectives
- General Comments 0
- Unresolved
- Resolved
- Number of files included: 11
-
jalview
0
-
Folder
src
0
-
Folder
MCview
0
- File AppletPDBCanvas.java 0 Remove
- File PDBCanvas.java 0 Remove
-
Folder
jalview
0
-
Folder
api
0
- File SequenceRenderer.java 0 Remove
-
Folder
appletgui
0
- File OverviewPanel.java 0 Remove
- File SequenceRenderer.java 0 Remove
-
Folder
ext
0
-
Folder
jmol
0
- File JmolCommands.java 0 Remove
-
Folder
varna
0
- File VarnaCommands.java 0 Remove
-
Folder
jmol
0
-
Folder
gui
0
- File OverviewPanel.java 0 Remove
- File SequenceRenderer.java 0 Remove
-
Folder
api
0
-
Folder
MCview
0
-
Folder
test/jalview
0
-
Folder
gui
0
- File SequenceRendererTest.java 0 Remove
-
Folder
schemes
0
- File ColourSchemesTest.java 0 Remove
-
Folder
gui
0
-
Folder
src
0
-
Filter
- Only show me content:
- Unfiltered files: dynamically added content
- Filtered files: dynamically added content
- Clear filters
Keyboard shortcuts
Summarize the review outcomes (optional)
#permalink
Details
Warning: no files are visible, they have all been filtered.
Participant | Role | Time Spent | Comments | Latest Comment |
---|---|---|---|---|
Author | ||||
Total | 0m | 0 |
-
Linked Issue:
JAL-2443
-
#permalink
Objectives
Calls to SequenceRenderer.getResidueBoxColour are always followed by a call to findFeatureColour (unless feature display is turned off).
This logic is already encapsulated in method SequenceRenderer.getResidueColour() so it would be simpler always to use this method instead.
Remove getResidueBoxColour from the api and change all calls to it to just call getResidueColour. This method now accepts a FeatureColourFinder (JAL-2438) so it can do the feature colour lookup after the colour scheme lookup.
Branches in review
Repository | Branch to review | Branched from |
---|
/src/MCview/AppletPDBCanvas.java
Changed
0
(0)
/src/MCview/PDBCanvas.java
Changed
0
(0)
/src/jalview/api/SequenceRenderer.java
Changed
0
(0)
/src/jalview/appletgui/OverviewPanel.java
Changed
0
(0)
/src/.../appletgui/SequenceRenderer.java
Changed
0
(0)
/src/jalview/ext/jmol/JmolCommands.java
Changed
0
(0)
/src/jalview/ext/varna/VarnaCommands.java
Changed
0
(0)
/src/jalview/gui/OverviewPanel.java
Changed
0
(0)
/src/jalview/gui/SequenceRenderer.java
Changed
0
(0)
/test/.../gui/SequenceRendererTest.java
Changed
0
(0)
/test/.../schemes/ColourSchemesTest.java
Changed
0
(0)