CR-JAL-30 JAL-2385: Colour threshold slider doesn't update value when switching groups

closed on 12 Apr 17

Author

Reviewers

JAL-2385: Colour threshold slider doesn't update value when switching groups

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 20

jalview 0
- Folder src/jalview 0
  - Folder api 0
    - File AlignViewportI.java 0 Remove
  - Folder appletgui 0
    - File AlignFrame.java 0 Remove
    - File SeqPanel.java 0 Remove
    - File SliderPanel.java 0 Remove
  - Folder gui 0
    - File AlignFrame.java 0 Remove
    - File AlignViewport.java 0 Remove
    - File PopupMenu.java 0 Remove
    - File SeqPanel.java 0 Remove
    - File SliderPanel.java 0 Remove
  - Folder renderer 0
    - File ResidueShader.java 0 Remove
  - Folder schemes 0
    - File PIDColourScheme.java 0 Remove
    - File ResidueProperties.java 0 Remove
  - Folder viewmodel 0
    - File AlignmentViewport.java 0 Remove
- Folder test/jalview 0
  - Folder gui 0
    - File AlignFrameTest.java 0 Remove
    - File AlignViewportTest.java 0 Remove
  - Folder io 0
    - File FileFormatsTest.java 0 Remove
    - File Jalview2xmlTests.java 0 Remove
    - File JalviewFileViewTest.java 0 Remove
  - Folder renderer 0
    - File ScaleRendererTest.java 0 Remove
  - Folder schemes 0
    - File PIDColourSchemeTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Mungo Carstairs	Author	1m
Kira Mourão	Reviewer - Complete	6m
Total		6m	0

Linked Issue:
JAL-2385

#permalink

Objectives

Open an alignment and create two groups. Set Colour by Conservation, with different increment values, on the background alignment and each of the two groups. Leave the increment slider open.
As you click on the groups or the background, the title of the slider panel changes to the group or 'background', but the slider value doesn't change (to the current setting for the corresponding region).
Similar problem if the slider panel is open on 'New View' or change view tab: the slider is still linked to the view it was opened for; changes in the slider affect the 'wrong' view (not the one displayed).

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-30

JAL-2385: Colour threshold slider doesn't update value when switching groups

CR-JAL-30 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2385: Colour threshold slider doesn't update value when switching groups

CR-JAL-30 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against