JAL-2385: Colour threshold slider doesn't update value when switching groups

Activity

CR-JAL-30 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m    
    Reviewer - Complete 6m    
    Total   6m 0  
    #permalink

    Objectives

    Open an alignment and create two groups. Set Colour by Conservation, with different increment values, on the background alignment and each of the two groups. Leave the increment slider open.
    As you click on the groups or the background, the title of the slider panel changes to the group or 'background', but the slider value doesn't change (to the current setting for the corresponding region).
    Similar problem if the slider panel is open on 'New View' or change view tab: the slider is still linked to the view it was opened for; changes in the slider affect the 'wrong' view (not the one displayed).

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/jalview/api/AlignViewportI.java Changed
    /src/jalview/appletgui/AlignFrame.java Changed
    /src/jalview/appletgui/SeqPanel.java Changed
    /src/jalview/appletgui/SliderPanel.java Changed
    /src/jalview/gui/AlignFrame.java Changed
    /src/jalview/gui/AlignViewport.java Changed
    /src/jalview/gui/PopupMenu.java Changed
    /src/jalview/gui/SeqPanel.java Changed
    /src/jalview/gui/SliderPanel.java Changed
    /src/jalview/renderer/ResidueShader.java Changed
    /src/jalview/schemes/PIDColourScheme.java Changed
    /src/.../schemes/ResidueProperties.java Changed
    /src/.../viewmodel/AlignmentViewport.java Changed
    /test/jalview/gui/AlignFrameTest.java Changed
    /test/jalview/gui/AlignViewportTest.java Changed
    /test/jalview/io/FileFormatsTest.java Changed
    Open in IDE #permalink
    /test/jalview/io/Jalview2xmlTests.java Changed
    /test/jalview/io/JalviewFileViewTest.java Changed
    Open in IDE #permalink
    /test/.../renderer/ScaleRendererTest.java Changed
    /test/.../schemes/PIDColourSchemeTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against