JAL-2423: incorrect title in output window when exporting tree calculated in...

Activity

CR-JAL-54 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 0m    
    Reviewer - Complete 4m    
    Total   4m 0  
    #permalink

    Objectives

    In 2.10.1 if you compute a tree and output to textbox, the title says "...using PID" - regardless of the method used.
    Code reads:
    if (pwtype.equals("BL")) // not true even for BLOSUM62

    Unknown macro: { buffer.append("BLOSUM62"); }

    else

    Unknown macro: { buffer.append("PID"); }


    This looks like a hangover from the applet where the same window gets a cryptic title e.g. "AV BL".

    Can be corrected in the course of allowing additional score matrices.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /resources/lang/Messages.properties Changed
    /resources/lang/Messages_es.properties Changed
    /src/jalview/analysis/NJTree.java Changed
    /src/jalview/gui/AlignFrame.java Changed
    /src/jalview/gui/TreePanel.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against