JAL-2504: 'New feature' from Find results has incorrect default feature name

Activity

CR-JAL-58 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 0m    
    Reviewer - 100% reviewed 2m    
    Total   2m 0  
    #permalink

    Objectives

    The Find dialog has the option to create new features on the match results. The feature type defaults to the Find search string, but only if this is the first new feature created. After a preceding 'feature from Find', or manual feature creation, the feature name defaults to the previous new feature type.
    This is the desired behaviour for manual feature creation, but not for features from Find results, as the default could be the search string for the previous, not the current, search pattern.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/jalview/appletgui/APopupMenu.java Changed
    /src/.../appletgui/FeatureRenderer.java Changed
    /src/jalview/appletgui/Finder.java Changed
    /src/jalview/appletgui/SeqPanel.java Changed
    /src/jalview/gui/FeatureRenderer.java Changed
    /src/jalview/gui/Finder.java Changed
    /src/jalview/gui/PopupMenu.java Changed
    /src/jalview/gui/SeqPanel.java Changed
    /src/jalview/jbgui/GFinder.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against