CR-JAL-58 JAL-2504: 'New feature' from Find results has incorrect default feature name

open for 3 years

Author

Reviewers

JAL-2504: 'New feature' from Find results has incorrect default feature name

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 9

jalview 0
- Folder src/jalview 0
  - Folder appletgui 0
    - File APopupMenu.java 0 Remove
    - File FeatureRenderer.java 0 Remove
    - File Finder.java 0 Remove
    - File SeqPanel.java 0 Remove
  - Folder gui 0
    - File FeatureRenderer.java 0 Remove
    - File Finder.java 0 Remove
    - File PopupMenu.java 0 Remove
    - File SeqPanel.java 0 Remove
  - Folder jbgui 0
    - File GFinder.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Mungo Carstairs	Author	0m
Kira Mourão	Reviewer - 100% reviewed	2m
Total		2m	0

Linked Issue:
JAL-2504

#permalink

Objectives

The Find dialog has the option to create new features on the match results. The feature type defaults to the Find search string, but only if this is the first new feature created. After a preceding 'feature from Find', or manual feature creation, the feature name defaults to the previous new feature type.
This is the desired behaviour for manual feature creation, but not for features from Find results, as the default could be the search string for the previous, not the current, search pattern.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-58

JAL-2504: 'New feature' from Find results has incorrect default feature name

CR-JAL-58 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2504: 'New feature' from Find results has incorrect default feature name

CR-JAL-58 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against