JAL-2544: Sort by features buggy with gapped selection region


CR-JAL-59 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Reviewer - 100% reviewed 6m    
    Total   6m 0  


    If Sort by Feature Density (or Score) is on a selection region, and the region includes trailing spaces, then features to the right of the region may be counted.
    Example: uniref50.fa + exampleFeatures.txt.
    Select columns 8-10 (only FER1_MAIZE has 1 feature) and Sequence sort by Density in Feature Settings. Sure enough FER1_MAIZE sorts to the bottom (or the top on a second, inverting sort).
    Now insert one ore more gaps before the first features in FER1_SPIOL (at column 11).
    Widen the selection region to include one or more of the gapped columns (but not the SPIOL features).
    Sort by Density again - FER1_SPIOL is now sorted to bottom / top.

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/jalview/analysis/AlignmentSorter.java Changed
    /src/jalview/analysis/AlignmentSorter.java Changed
    /test/.../analysis/AlignmentSorterTest.java Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against