CR-JAL-61 JAL-2358: 'Add to viewer' sometimes offered for a closed viewer

closed on 12 Sep 18

Author

Reviewers

JAL-2358: 'Add to viewer' sometimes offered for a closed viewer

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 4

jalview 0
- Folder src/jalview 0
  - Folder gui 0
    - File AppJmol.java 0 Remove
    - File ChimeraViewFrame.java 0 Remove
    - File StructureViewerBase.java 0 Remove
  - Folder structure 0
    - File StructureSelectionManager.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Mungo Carstairs	Author	1m	1	I guess this should be 'ready for test', the only problem...
Tochukwu Charles N Ofoegbu	Reviewer - 100% reviewed	1m
Jim Procter	Reviewer - Complete	2m	1	just checked this against develop with "git show develop....
Total		4m	2

Linked Issue:
JAL-2358

#permalink

Objectives

Reported on 'Chimera spike branch'.

open one or more structure viewers, show structures
close some of the viewers
save and reload the project
view a structure
a prompt is offered to add the structure to a viewer which no longer exists

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jim Procter

just checked this against develop with "git show develop..origin/bug/JAL-2358...

just checked this against develop with "git show develop..origin/bug/JAL-2358phantomChimera". Patches seem sane, and should perhaps remove the upper/lowercase issue, but I'd appreciate if you take a look, Charles.

25 May 17

Mungo Carstairs

I guess this should be 'ready for test', the only problem being that the issu...

I guess this should be 'ready for test', the only problem being that the issue was not reproducible, so how to test it?
At the least, should get another pair of eyes to review whether the functional change (in StructureSelectionManager) might have any unwanted impact.

26 May 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-61

JAL-2358: 'Add to viewer' sometimes offered for a closed viewer

CR-JAL-61 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jim Procter

Mungo Carstairs

Log time against

JAL-2358: 'Add to viewer' sometimes offered for a closed viewer

CR-JAL-61 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jim Procter

Mungo Carstairs

Log time against