JAL-2358: 'Add to viewer' sometimes offered for a closed viewer

Activity

CR-JAL-61 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m 1 I guess this should be 'ready for test', the only problem...
    Reviewer - 100% reviewed 1m    
    Reviewer - Complete 2m 1 just checked this against develop with "git show develop....
    Total   4m 2  
    #permalink

    Objectives

    Reported on 'Chimera spike branch'.

    • open one or more structure viewers, show structures
    • close some of the viewers
    • save and reload the project
    • view a structure
    • a prompt is offered to add the structure to a viewer which no longer exists

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Jim Procter

    just checked this against develop with "git show develop..origin/bug/JAL-2358...

    just checked this against develop with "git show develop..origin/bug/JAL-2358phantomChimera". Patches seem sane, and should perhaps remove the upper/lowercase issue, but I'd appreciate if you take a look, Charles.

    Mungo Carstairs

    I guess this should be 'ready for test', the only problem being that the issu...

    I guess this should be 'ready for test', the only problem being that the issue was not reproducible, so how to test it?
    At the least, should get another pair of eyes to review whether the functional change (in StructureSelectionManager) might have any unwanted impact.

    /src/jalview/gui/AppJmol.java Changed
    /src/jalview/gui/ChimeraViewFrame.java Changed
    /src/jalview/gui/StructureViewerBase.java Changed
    /src/.../structure/StructureSelectionManager.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against