JAL-2291: Popup->hide insertions should operate on currently selected sequences,...


CR-JAL-83 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 8m    
    Total   8m 0  


    The 'hide insertions' option in the popup menu does not preserve insertions amongst selected sequences, only the one that was under the mouse when the popup menu was opened.

    Two options are needed:

    • Hide Insertions for Sequence
    • current behaviour - suggest this is moved to the 'Sequence' submenu
    • Hide Insertions for Selection
    • hides columns gapped in all selected sequences - remains on top-level for convenience, also added to Selection dropdown menu.

    Hide insertions for selection when the whole alignment is selected is effectively 'Hide gapped columns' - which will be of use to people working on subsets of alignments where the original column numbering must be preserved.

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /help/html/menus/popupMenu.html Changed
    Open in IDE #permalink
    /help/html/releases.html Changed
    /help/html/whatsNew.html Changed
    /src/jalview/datamodel/HiddenColumns.java Changed
    /src/jalview/datamodel/Sequence.java Changed
    /src/jalview/datamodel/SequenceI.java Changed
    Open in IDE #permalink
    /src/jalview/gui/PopupMenu.java Changed
    /test/.../datamodel/HiddenColumnsTest.java Changed
    /test/jalview/datamodel/SequenceTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against