CR-JAL-83 JAL-2291: Popup->hide insertions should operate on currently selected sequences, not just the first

open for 3 years

Author

JAL-2291: Popup->hide insertions should operate on currently selected sequences,...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 9

jalview 0
- Folder help/html 0
  - Folder menus 0
    - File popupMenu.html 0 Remove
  - File releases.html 0 Remove
  - File whatsNew.html 0 Remove
- Folder src/jalview 0
  - Folder datamodel 0
    - File HiddenColumns.java 0 Remove
    - File Sequence.java 0 Remove
    - File SequenceI.java 0 Remove
  - Folder gui 0
    - File PopupMenu.java 0 Remove
- Folder test/jalview/datamodel 0
  - File HiddenColumnsTest.java 0 Remove
  - File SequenceTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jim Procter	Author	8m
Total		8m	0

Linked Issue:
JAL-2291

#permalink

Objectives

The 'hide insertions' option in the popup menu does not preserve insertions amongst selected sequences, only the one that was under the mouse when the popup menu was opened.

Two options are needed:

Hide Insertions for Sequence

current behaviour - suggest this is moved to the 'Sequence' submenu

Hide Insertions for Selection

hides columns gapped in all selected sequences - remains on top-level for convenience, also added to Selection dropdown menu.

Hide insertions for selection when the whole alignment is selected is effectively 'Hide gapped columns' - which will be of use to people working on subsets of alignments where the original column numbering must be preserved.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-83

JAL-2291: Popup->hide insertions should operate on currently selected sequences,...

CR-JAL-83 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2291: Popup->hide insertions should operate on currently selected sequences,...

CR-JAL-83 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against