JAL-2704: Gap colour should not be affected by PID or Conservation shading


CR-JAL-88 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)


    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Reviewer - Complete 1m    
    Total   1m 0  


    A User Defined colour scheme can specify a colour other than white for gaps. Currently, this colour gets faded if Colour by Conservation is applied, and is always white where conservation score is zero. If Colour Above Identity Threshold is applied, gaps are always white, as they do not match the consensus residue. A bespoke gap colour should be left unchanged in these scenarios.

    Branches in review


    Issues Raised From Comments

    Key Summary State Assignee

    General Comments

    There are no general comments on this review.
    /src/jalview/renderer/ResidueShader.java Changed
    Open in IDE #permalink
    /test/.../renderer/ResidueShaderTest.java Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against