JAL-2745: Update www.ebi.ac.uk to https

Activity

CR-JAL-91 3

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1m 1 Do we want to include the ability to read the domain from...
    Reviewer - Complete 7m 2 I think we should leave that for 2.10.3, to give us more ...
    Total   8m 3  
    #permalink

    Objectives

    PDBe announced on 21/09 that requests over http to the rest service /pdbe/api would from 1st October be redirected to https.

    Today they further clarified that this would be for all requests on this domain, not just the rest service.

    Jalview should update its configured URLs to https.
    Whether or not the Jalview client code will fail, or follow the 302 redirect response, is at present unknown.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mungo Carstairs

    Do we want to include the ability to read the domain from .jalview_properties?

    Do we want to include the ability to read the domain from .jalview_properties?

    Jim Procter

    I think we should leave that for 2.10.3, to give us more time to test. It's n...

    I think we should leave that for 2.10.3, to give us more time to test. It's not as simple a patch as this, and if the patch doesn't actually work then allowing these constants to be configurable isn't going to help anyhow.

    /src/jalview/.../pdb/PDBFTSRestClient.java Changed
    Open in IDE #permalink
    /src/.../datamodel/DasSourceRegistry.java Changed
    Open in IDE #permalink
    /src/jalview/ws/ebi/EBIFetchClient.java Changed 1

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against