CR-JAL-99 JAL-2225: structure viewer doesn't get mappings for all chains when viewing 'cached' structures

open for 3 years

Author

Reviewers

JAL-2225: structure viewer doesn't get mappings for all chains when viewing...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 5

jalview 0
- Folder src/jalview/gui 0
  - File AlignViewport.java 0 Remove
  - File StructureChooser.java 0 Remove
  - File StructureViewer.java 15 Remove
- Folder test/jalview/gui 0
  - File AlignViewportTest.java 0 Remove
  - File StructureViewerTest.java 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Mungo Carstairs	Author	8m	6	Have done so (hopefully)
Kira Mourão	Reviewer - Complete	21m	9	ok I see - agree map passing would be preferable!
Total		29m	15

Linked Issue:
JAL-2225

#permalink

Objectives

Carry over from JAL-1962 following the 'to reproduce' instructions reveals a different problem:

1. I loaded a local copy of 3a6s.pdb
2. I added 1gaq via File->Add Sequences and the PDB fetcher.
3. Selected all sequences, right-clicked on the 3A6S|A sequence and opened 'View Structure...'
4. Changed view to 'Cached PDB Files' and selected all chains.
5. Hit View

View mappings had the right mappings in it, but only one chain was coloured and mapped in the structure view.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-JAL-99

JAL-2225: structure viewer doesn't get mappings for all chains when viewing...

CR-JAL-99 15

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

JAL-2225: structure viewer doesn't get mappings for all chains when viewing...

CR-JAL-99 15

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against