JAL-2225: structure viewer doesn't get mappings for all chains when viewing...

Activity

CR-JAL-99 15

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 8m 6 Have done so (hopefully)
    Reviewer - Complete 21m 9 ok I see - agree map passing would be preferable!
    Total   29m 15  
    #permalink

    Objectives

    Carry over from JAL-1962 following the 'to reproduce' instructions reveals a different problem:

    1. I loaded a local copy of 3a6s.pdb
    2. I added 1gaq via File->Add Sequences and the PDB fetcher.
    3. Selected all sequences, right-clicked on the 3A6S|A sequence and opened 'View Structure...'
    4. Changed view to 'Cached PDB Files' and selected all chains.
    5. Hit View

    View mappings had the right mappings in it, but only one chain was coloured and mapped in the structure view.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/jalview/gui/AlignViewport.java Changed
    /src/jalview/gui/StructureChooser.java Changed
    /src/jalview/gui/StructureViewer.java Changed 15
    /test/jalview/gui/AlignViewportTest.java Changed
    Open in IDE #permalink
    /test/jalview/gui/StructureViewerTest.java Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against