Jalview Code Reviews

Update annotation operation WIP

JAL-3878 Add dataset and viewport arguments to ResultSupplier.

    • -4
    • +22
    /src/jalview/ws2/slivka/SlivkaWebService.java
SequencesInfo which is an individual object is doable, but I feel like it would be just a wrapper around a Map. What additional functionality would SequencesInfo have over a traditional Map? I'm n...

SequencesInfo which is an individual object is doable, but I feel like it would be just a wrapper around a Map. What additional functionality would SequencesInfo have over a traditional Map?

I'm not very familiar with serialization in java, I know there are libraries that can serialize beans to json or xml, but what are your expectations in this case?

one class with a static factory method seems to be better than two classes and an external mutable object.

one class with a static factory method seems to be better than two classes and an external mutable object.

JAL-3899 Replace prints with logger messages.

    • -10
    • +17
    /src/jalview/analysis/SeqsetUtils.java
What's wrong with static classes? They are just like regular classes but within other class' namespace. That's non-static inner classes that are special. About factory pattern, I think it would be ...

What's wrong with static classes? They are just like regular classes but within other class' namespace. That's non-static inner classes that are special.
About factory pattern, I think it would be an overkill for a class that is only used by SeqsetUtils' methods.

yes, I see that, but do you really need a nested static class ? in line with my general comments re encapsulating the Map<String,SequenceInfo> further: perhaps it might make sense to simply apply a...

yes, I see that, but do you really need a nested static class ? in line with my general comments re encapsulating the Map<String,SequenceInfo> further: perhaps it might make sense to simply apply a factory pattern rather than have an internal bean that a generic map holds references to ?

(lets not get stuck on this though, the main thing is that the implementation works fine for now, though needs more work in order to save/restore sequenceInfo objects from Jalview project files)

Because it's instantiated in a static context e.g. uniquify and it does not need an instance of SeqsetUtils object to work.

Because it's instantiated in a static context e.g. uniquify and it does not need an instance of SeqsetUtils object to work.

we won't see this messages unless asserts are enabled. Cache.log.warn is perhaps better ?

we won't see this messages unless asserts are enabled. Cache.log.warn is perhaps better ?

it's a reasonable first pass, though stylistically all you've done is transformed a single concrete instance (Hashtable) to a more strongly typed verbose instance (Map<String,SequenceInfo>). Why no...

it's a reasonable first pass, though stylistically all you've done is transformed a single concrete instance (Hashtable) to a more strongly typed verbose instance (Map<String,SequenceInfo>). Why not go further and have a SequencesInfo object that records metadata for one or more sequences ?

There are also other requirements: SequenceInfo sets will need to be persisted for a web services job. You could expand JAL-3899 to incorporate this perhaps - JAL-1786 is the relevant epic for that.

why does this class need to be static ?

why does this class need to be static ?

this should probably be Cache.log.warn(..)

this should probably be Cache.log.warn(..)

JAL-3899 Refactor sequence de/uniquification.
JAL-3899 Refactor sequence de/uniquification.
JAL-3899 Update usages of uniquify and deuniquify.

    • -4
    • +5
    /src/jalview/io/packed/JalviewDataset.java
    • -9
    • +11
    /src/jalview/ws/jws1/JPredThread.java
tmp

    • -4
    • +5
    /src/jalview/io/packed/JalviewDataset.java
JAL-3899 Refactor sequence de/uniquification.

    • -103
    • +71
    /src/jalview/analysis/SeqsetUtils.java
JAL-3416 make flat default laf for linux

JAL-3878 Annotation operation skeleton.

    • -0
    • +261
    /src/jalview/ws2/operations/AnnotationOperation.java
    • -0
    • +30
    /src/jalview/ws2/slivka/SlivkaWebService.java
JAL-3416 updated FlatLaf to 1.6 and added some tabbed pane properties

    • binary
    /j11lib/flatlaf-1.6.jar
    • binary
    /j8lib/flatlaf-1.6.jar
Merge branch 'develop' into JAL-3416_different_look_and_feel_on_linux

JAL-2909 JAL-3894 hack in support to import regions of an unindexed SAM file.

    • -1
    • +10
    /src/jalview/datamodel/CigarParser.java
Merge branch 'develop' into features/JAL-2909_bamImport_2_11_2

Merge branch 'develop' into releases/Release_2_11_2_Branch

JAL-3616 show name of structure viewer in ‘new view’ button

    • -1
    • +5
    /src/jalview/jbgui/GStructureChooser.java
JAL-3616 explicit configure external viewer config

JAL-3878 Fix workers done condition to account for broken jobs.

    • -2
    • +3
    /src/jalview/ws2/WebServiceExecutor.java
    • -1
    • +1
    /src/jalview/ws2/WebServiceWorkerI.java
Merge branch 'develop' into improvement/JAL-3594_BG_and_UoD_logos_added

Merge branch 'develop' into releases/Release_2_11_2_Branch

Merge branch 'features/r2_11_2/JAL-3829_3dbeacons' into develop