X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;ds=inline;f=src%2Fjalview%2Fhttpserver%2FHttpServer.java;h=fcfefaa82ac3678dac4196c8b3a3ebb7ecf1e6ba;hb=e2d6753e8cf3c5eaf8bccf34f4f5e9d651e9cb8e;hp=d39ada12fdb57a998bb195e605d6b2554b919a44;hpb=f2f654875a6eb5f4e90b2c5c545bfed3a70f2b5f;p=jalview.git
diff --git a/src/jalview/httpserver/HttpServer.java b/src/jalview/httpserver/HttpServer.java
index d39ada1..fcfefaa 100644
--- a/src/jalview/httpserver/HttpServer.java
+++ b/src/jalview/httpserver/HttpServer.java
@@ -11,19 +11,31 @@ import javax.servlet.http.HttpServletResponse;
import org.eclipse.jetty.server.Handler;
import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.ServerConnector;
import org.eclipse.jetty.server.handler.ContextHandler;
import org.eclipse.jetty.server.handler.HandlerCollection;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
+import jalview.rest.RestHandler;
+
/**
- * An HttpServer built on Jetty
+ * An HttpServer built on Jetty. To use it
+ *
+ * - call getInstance() to create and start the server
+ * - call registerHandler to add a handler for a path (below /jalview)
+ * - when finished, call removedHandler
+ *
*
* @author gmcarstairs
* @see http://eclipse.org/jetty/documentation/current/embedding-jetty.html
*/
public class HttpServer
{
- private static final String JALVIEW_PATH = "/jalview";
+ /*
+ * 'context root' - actually just prefixed to the path for each handler for
+ * now - see registerHandler
+ */
+ private static final String JALVIEW_PATH = "jalview";
/*
* Singleton instance of this server
@@ -76,10 +88,15 @@ public class HttpServer
private HttpServer() throws BindException
{
startServer();
+
+ /*
+ * Provides a REST server by default; add more programmatically as required
+ */
+ registerHandler(RestHandler.getInstance());
}
/**
- * Start the http server with a default thread pool size of 1
+ * Start the http server
*
* @throws BindException
*/
@@ -87,11 +104,15 @@ public class HttpServer
{
try
{
- // problem: how to both limit thread pool size and
- // pick a random free port - two alternative constructors
- QueuedThreadPool tp = new QueuedThreadPool(1, 1);
- // server = new Server(tp); // ? fails with URI null
- server = new Server(0); // pick a free port number
+ /*
+ * Create a server with a small number of threads; jetty will allocate a
+ * free port
+ */
+ QueuedThreadPool tp = new QueuedThreadPool(4, 1); // max, min
+ server = new Server(tp);
+ // 2 selector threads to handle incoming connections
+ ServerConnector connector = new ServerConnector(server, 0, 2);
+ server.addConnector(connector);
/*
* HttpServer shuts down with Jalview process
@@ -100,13 +121,15 @@ public class HttpServer
/*
* Create a mutable set of handlers (can add handlers while the server is
- * running)
+ * running). Using vanilla handlers here rather than servlets
*/
- // TODO how to combine this with context root "/jalview"
+ // TODO how to properly configure context root "/jalview"
contextHandlers = new HandlerCollection(true);
server.setHandler(contextHandlers);
-
server.start();
+ // System.out.println(String.format(
+ // "HttpServer started with %d threads", server.getThreadPool()
+ // .getThreads()));
contextRoot = server.getURI();
System.out.println("Jalview endpoint " + contextRoot);
} catch (Exception e)
@@ -184,19 +207,26 @@ public class HttpServer
}
/**
- * Register a handler for the given path and returns its URI
+ * Register a handler for the given path and set its URI
*
- * @param path
- * a path below the context root (without leading or trailing
- * separator)
* @param handler
* @return
+ * @throws IllegalStateException
+ * if handler path has not been set
*/
- public String registerHandler(String path, AbstractRequestHandler handler)
+ public void registerHandler(AbstractRequestHandler handler)
{
+ String path = handler.getPath();
+ if (path == null)
+ {
+ throw new IllegalStateException(
+ "Must set handler path before registering handler");
+ }
+
// http://stackoverflow.com/questions/20043097/jetty-9-embedded-adding-handlers-during-runtime
ContextHandler ch = new ContextHandler();
- ch.setContextPath("/" + path);
+ ch.setAllowNullPathInfo(true);
+ ch.setContextPath("/" + JALVIEW_PATH + "/" + path);
ch.setResourceBase(".");
ch.setClassLoader(Thread.currentThread()
.getContextClassLoader());
@@ -220,7 +250,9 @@ public class HttpServer
+ e.getMessage());
}
- return this.contextRoot + ch.getContextPath().substring(1);
+ handler.setUri(this.contextRoot + ch.getContextPath().substring(1));
+ System.out.println("Jalview " + handler.getName()
+ + " handler started on " + handler.getUri());
}
/**