X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;ds=sidebyside;f=src%2Fjalview%2Fgui%2FWsJobParameters.java;h=b3e40c120fb7d63beb3e328383926e3894fc931d;hb=9876fdccf311378e690c1f9e18db52675d427b89;hp=b936efbce4a629177ef8368334aecbb2664cbcf3;hpb=307ae9b511d84ed8a4170ccff49186dee4b51747;p=jalview.git
diff --git a/src/jalview/gui/WsJobParameters.java b/src/jalview/gui/WsJobParameters.java
index b936efb..b3e40c1 100644
--- a/src/jalview/gui/WsJobParameters.java
+++ b/src/jalview/gui/WsJobParameters.java
@@ -1,24 +1,28 @@
/*
- * Jalview - A Sequence Alignment Editor and Viewer (Version 2.7)
- * Copyright (C) 2011 J Procter, AM Waterhouse, J Engelhardt, LM Lui, G Barton, M Clamp, S Searle
+ * Jalview - A Sequence Alignment Editor and Viewer (Version 2.9)
+ * Copyright (C) 2015 The Jalview Authors
*
* This file is part of Jalview.
*
* Jalview is free software: you can redistribute it and/or
* modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
- *
+ * as published by the Free Software Foundation, either version 3
+ * of the License, or (at your option) any later version.
+ *
* Jalview is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty
* of MERCHANTABILITY or FITNESS FOR A PARTICULAR
* PURPOSE. See the GNU General Public License for more details.
*
- * You should have received a copy of the GNU General Public License along with Jalview. If not, see .
+ * You should have received a copy of the GNU General Public License
+ * along with Jalview. If not, see .
+ * The Jalview Authors are detailed in the 'AUTHORS' file.
*/
package jalview.gui;
import jalview.gui.OptsAndParamsPage.OptionBox;
import jalview.gui.OptsAndParamsPage.ParamBox;
+import jalview.util.MessageManager;
import jalview.ws.jws2.JabaParamStore;
import jalview.ws.jws2.JabaPreset;
import jalview.ws.jws2.Jws2Discoverer;
@@ -114,8 +118,6 @@ public class WsJobParameters extends JPanel implements ItemListener,
*/
JPanel paramList = new JPanel();
-
-
JPanel SetNamePanel = new JPanel();
JPanel setDetails = new JPanel();
@@ -124,7 +126,6 @@ public class WsJobParameters extends JPanel implements ItemListener,
JPanel jobPanel = new JPanel();
-
JScrollPane jobOptionsPane = new JScrollPane();
JButton createpref = new JButton();
@@ -145,9 +146,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
JScrollPane paramPane = new JScrollPane();
-
-// ScrollablePanel optsAndparams = new ScrollablePanel();
+ // ScrollablePanel optsAndparams = new ScrollablePanel();
JPanel optsAndparams = new JPanel();
+
RunnerConfig serviceOptions;
ParamDatastoreI paramStore;
@@ -217,25 +218,28 @@ public class WsJobParameters extends JPanel implements ItemListener,
frame = new JDialog(Desktop.instance, true);
- frame.setTitle("Edit parameters for " + service.getActionText());
+ frame.setTitle(MessageManager.formatMessage("label.edit_params_for",
+ new String[] { service.getActionText() }));
Rectangle deskr = Desktop.instance.getBounds();
Dimension pref = this.getPreferredSize();
- frame.setBounds(new Rectangle((int) (deskr.getCenterX() - pref.width/2),
- (int) (deskr.getCenterY() - pref.height/2), pref.width, pref.height));
+ frame.setBounds(new Rectangle(
+ (int) (deskr.getCenterX() - pref.width / 2), (int) (deskr
+ .getCenterY() - pref.height / 2), pref.width,
+ pref.height));
frame.setContentPane(this);
-
+
// should perhaps recover defaults from user prefs.
frame.validate();
javax.swing.SwingUtilities.invokeLater(new Runnable()
{
- public void run()
- {
- //jobPanel.setDividerLocation(0.25);
+ public void run()
+ {
+ // jobPanel.setDividerLocation(0.25);
- }
- });
- frame.setVisible(true);
+ }
+ });
+ frame.setVisible(true);
if (response > 0)
{
@@ -248,22 +252,23 @@ public class WsJobParameters extends JPanel implements ItemListener,
{
this.addHierarchyBoundsListener(new HierarchyBoundsListener()
{
-
+
@Override
public void ancestorResized(HierarchyEvent arg0)
{
refreshParamLayout();
}
-
+
@Override
public void ancestorMoved(HierarchyEvent arg0)
{
// TODO Auto-generated method stub
-
+
}
});
- updatepref = JvSwingUtils.makeButton("Update",
- "Update this existing user parameter set.",
+ updatepref = JvSwingUtils.makeButton(
+ MessageManager.getString("action.update"),
+ MessageManager.getString("label.update_user_parameter_set"),
new ActionListener()
{
@@ -272,8 +277,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
update_actionPerformed(e);
}
});
- deletepref = JvSwingUtils.makeButton("Delete",
- "Delete the currently selected user parameter set.",
+ deletepref = JvSwingUtils.makeButton(
+ MessageManager.getString("action.delete"),
+ MessageManager.getString("label.delete_user_parameter_set"),
new ActionListener()
{
@@ -282,8 +288,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
delete_actionPerformed(e);
}
});
- createpref = JvSwingUtils.makeButton("Create",
- "Create a new parameter set with the current settings.",
+ createpref = JvSwingUtils.makeButton(
+ MessageManager.getString("action.create"),
+ MessageManager.getString("label.create_user_parameter_set"),
new ActionListener()
{
@@ -292,8 +299,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
create_actionPerformed(e);
}
});
- revertpref = JvSwingUtils.makeButton("Revert",
- "Undo all changes to the current parameter set",
+ revertpref = JvSwingUtils.makeButton(MessageManager
+ .getString("action.revert"), MessageManager
+ .getString("label.revert_changes_user_parameter_set"),
new ActionListener()
{
@@ -302,16 +310,20 @@ public class WsJobParameters extends JPanel implements ItemListener,
revert_actionPerformed(e);
}
});
- startjob = JvSwingUtils.makeButton("Start Job",
- "Start Job with current settings.", new ActionListener()
+ startjob = JvSwingUtils.makeButton(
+ MessageManager.getString("action.start_job"),
+ MessageManager.getString("label.start_job_current_settings"),
+ new ActionListener()
{
public void actionPerformed(ActionEvent e)
{
startjob_actionPerformed(e);
}
});
- canceljob = JvSwingUtils.makeButton("Cancel Job",
- "Close this dialog and cancel job.", new ActionListener()
+ canceljob = JvSwingUtils.makeButton(
+ MessageManager.getString("action.cancel_job"),
+ MessageManager.getString("label.cancel_job_close_dialog"),
+ new ActionListener()
{
public void actionPerformed(ActionEvent e)
{
@@ -319,7 +331,8 @@ public class WsJobParameters extends JPanel implements ItemListener,
}
});
- setDetails.setBorder(new TitledBorder("Details"));
+ setDetails.setBorder(new TitledBorder(MessageManager
+ .getString("label.details")));
setDetails.setLayout(new BorderLayout());
setDescr.setColumns(40);
setDescr.setWrapStyleWord(true);
@@ -327,9 +340,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
setDescr.setBackground(getBackground());
setDescr.setEditable(true);
setDescr.getDocument().addDocumentListener(this);
- setDescr.setToolTipText("Click to edit the notes for this parameter set.");
+ setDescr.setToolTipText(MessageManager
+ .getString("label.edit_notes_parameter_set"));
JScrollPane setDescrView = new JScrollPane();
- // setDescrView.setPreferredSize(new Dimension(350, 200));
setDescrView.getViewport().setView(setDescr);
setName.setEditable(true);
setName.addItemListener(this);
@@ -338,12 +351,13 @@ public class WsJobParameters extends JPanel implements ItemListener,
GridBagLayout gbl = new GridBagLayout();
SetNamePanel.setLayout(gbl);
- JLabel setNameLabel = new JLabel("Current parameter set name :");
+ JLabel setNameLabel = new JLabel(
+ MessageManager.getString("label.current_parameter_set_name"));
setNameLabel.setFont(new java.awt.Font("Verdana", Font.PLAIN, 10));
-
+
setNameInfo.add(setNameLabel);
setNameInfo.add(setName);
-
+
// initial button visibility
updatepref.setVisible(false);
deletepref.setVisible(false);
@@ -354,13 +368,13 @@ public class WsJobParameters extends JPanel implements ItemListener,
((FlowLayout) setsavebuts.getLayout()).setHgap(10);
((FlowLayout) setsavebuts.getLayout()).setVgap(0);
JPanel spacer = new JPanel();
- spacer.setPreferredSize(new Dimension(2,30));
+ spacer.setPreferredSize(new Dimension(2, 30));
setsavebuts.add(spacer);
setsavebuts.add(deletepref);
setsavebuts.add(revertpref);
setsavebuts.add(createpref);
setsavebuts.add(updatepref);
-// setsavebuts.setSize(new Dimension(150, 30));
+ // setsavebuts.setSize(new Dimension(150, 30));
JPanel buttonArea = new JPanel(new GridLayout(1, 1));
buttonArea.add(setsavebuts);
SetNamePanel.add(setNameInfo);
@@ -377,22 +391,25 @@ public class WsJobParameters extends JPanel implements ItemListener,
// paramPane.setPreferredSize(new Dimension(360, 400));
// paramPane.setPreferredSize(null);
- jobOptions.setBorder(new TitledBorder("Options"));
+ jobOptions.setBorder(new TitledBorder(MessageManager
+ .getString("label.options")));
jobOptions.setOpaque(true);
- paramList.setBorder(new TitledBorder("Parameters"));
+ paramList.setBorder(new TitledBorder(MessageManager
+ .getString("label.parameters")));
paramList.setOpaque(true);
- JPanel bjo=new JPanel(new BorderLayout()),bjp=new JPanel(new BorderLayout());
+ JPanel bjo = new JPanel(new BorderLayout()), bjp = new JPanel(
+ new BorderLayout());
bjo.add(jobOptions, BorderLayout.CENTER);
bjp.add(paramList, BorderLayout.CENTER);
bjp.setOpaque(true);
bjo.setOpaque(true);
- //optsAndparams.setScrollableWidth(ScrollableSizeHint.FIT);
+ // optsAndparams.setScrollableWidth(ScrollableSizeHint.FIT);
// optsAndparams.setScrollableHeight(ScrollableSizeHint.NONE);
- // optsAndparams.setLayout(new BorderLayout());
+ // optsAndparams.setLayout(new BorderLayout());
optsAndparams.setLayout(new BorderLayout());
optsAndparams.add(jobOptions, BorderLayout.NORTH);
optsAndparams.add(paramList, BorderLayout.CENTER);
- JPanel jp=new JPanel(new BorderLayout());
+ JPanel jp = new JPanel(new BorderLayout());
jp.add(optsAndparams, BorderLayout.CENTER);
paramPane.getViewport().setView(jp);
paramPane.setBorder(null);
@@ -401,7 +418,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
jobPanel.setLayout(new BorderLayout());
jobPanel.add(setDetails, BorderLayout.NORTH);
jobPanel.add(paramPane, BorderLayout.CENTER);
-// jobPanel.setOrientation(JSplitPane.VERTICAL_SPLIT);
+ // jobPanel.setOrientation(JSplitPane.VERTICAL_SPLIT);
add(SetNamePanel, BorderLayout.NORTH);
add(jobPanel, BorderLayout.CENTER);
@@ -409,6 +426,11 @@ public class WsJobParameters extends JPanel implements ItemListener,
JPanel dialogpanel = new JPanel();
dialogpanel.add(startjob);
dialogpanel.add(canceljob);
+ // JAL-1580: setMaximumSize() doesn't work, so just size for the worst case:
+ // check for null is for JUnit usage
+ final int windowHeight = Desktop.instance == null ? 540
+ : Desktop.instance.getHeight();
+ setPreferredSize(new Dimension(540, windowHeight));
add(dialogpanel, BorderLayout.SOUTH);
validate();
}
@@ -416,7 +438,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
protected void revert_actionPerformed(ActionEvent e)
{
reInitDialog(lastParmSet);
-
+ updateWebServiceMenus();
}
protected void update_actionPerformed(ActionEvent e)
@@ -445,6 +467,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
_deleteUserPreset(lastParmSet);
}
reInitDialog(null); // service default
+ updateWebServiceMenus();
}
protected void create_actionPerformed(ActionEvent e)
@@ -455,7 +478,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
_storeCurrentPreset(curname);
lastParmSet = curname;
isUserPreset = true;
+ reInitDialog(curname);
initArgSetModified();
+ updateWebServiceMenus();
}
else
{
@@ -510,7 +535,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
Hashtable exnames = new Hashtable();
for (int i = 0, iSize = setName.getItemCount(); i < iSize; i++)
{
- exnames.put((String) setName.getItemAt(i), setName.getItemAt(i));
+ exnames.put(setName.getItemAt(i), setName.getItemAt(i));
}
servicePresets = new Hashtable();
// Add the default entry - if not present already.
@@ -548,7 +573,10 @@ public class WsJobParameters extends JPanel implements ItemListener,
if (jobArgset != null && jobArgset.size() > 0)
{
curSetName = "Supplied Settings";
+ isUserPreset = false;
updateTable(p, jobArgset);
+ setName.setSelectedItem(curSetName);
+ updateButtonDisplay();
}
else
{
@@ -563,12 +591,25 @@ public class WsJobParameters extends JPanel implements ItemListener,
@SuppressWarnings("unchecked")
private void updateTable(WsParamSetI p, List jobArgset)
{
+ boolean setDefaultParams = false;
+ if (lastParmSet == null)
+ {
+ isUserPreset = false;
+ // First call - so provide Service default settings
+ setName.setSelectedItem(lastSetName = SVC_DEF);
+ }
+ if (p == null && SVC_DEF.equals("" + setName.getSelectedItem()))
+ {
+ // indicate that service defaults should be set if available
+ setDefaultParams = true;
+ }
// populate table from default parameter set.
List args = paramStore.getServiceParameters();
// split to params and required arguments
{
- int cw=0;
+ int cw = 0;
+ boolean optset = false;
for (ArgumentI myarg : args)
{
// Ideally, Argument would implement isRequired !
@@ -583,13 +624,13 @@ public class WsJobParameters extends JPanel implements ItemListener,
{
OptionI opt = (OptionI) myarg;
OptionBox ob = opanp.addOption(opt);
- ob.resetToDefault();
+ ob.resetToDefault(setDefaultParams);
if (MAX_OPTWIDTH < ob.getPreferredSize().width)
{
MAX_OPTWIDTH = ob.getPreferredSize().width;
}
ob.validate();
- cw+=ob.getPreferredSize().width+5;
+ cw += ob.getPreferredSize().width + 5;
}
else
{
@@ -617,16 +658,6 @@ public class WsJobParameters extends JPanel implements ItemListener,
// TODO: check if args should be unselected prior to resetting using the
// preset
}
- else
- {
- if (lastParmSet == null)
- {
- isUserPreset = false;
- // first call - so create a dummy name
-
- setName.setSelectedItem(lastSetName = SVC_DEF);
- }
- }
if (jobArgset != null)
{
@@ -796,99 +827,115 @@ public class WsJobParameters extends JPanel implements ItemListener,
settingDialog = stn;
}
-
public void refreshParamLayout()
{
-// optsAndparams.setPreferredSize(null);
+ // optsAndparams.setPreferredSize(null);
FlowLayout fl = new FlowLayout(FlowLayout.LEFT);
- int sep=fl.getVgap();
- boolean fh=true;
- int os=0,s = jobOptions.getBorder().getBorderInsets(jobOptions).bottom+jobOptions.getBorder().getBorderInsets(jobOptions).top+2 * sep;
+ int sep = fl.getVgap();
+ boolean fh = true;
+ int os = 0, s = jobOptions.getBorder().getBorderInsets(jobOptions).bottom
+ + jobOptions.getBorder().getBorderInsets(jobOptions).top
+ + 2
+ * sep;
/**
* final height for viewport
*/
- int finalh=s;
- int panewidth = paramPane.getViewport().getSize().width-120-jobOptions.getBorder().getBorderInsets(jobOptions).left+jobOptions.getBorder().getBorderInsets(jobOptions).right;
-
- int w = 2 * fl.getHgap() + (MAX_OPTWIDTH > OptsAndParamsPage.PARAM_WIDTH ? MAX_OPTWIDTH : OptsAndParamsPage.PARAM_WIDTH);
- int hgap=fl.getHgap(),cw=hgap;
-
+ int finalh = s;
+ int panewidth = paramPane.getViewport().getSize().width - 120
+ - jobOptions.getBorder().getBorderInsets(jobOptions).left
+ + jobOptions.getBorder().getBorderInsets(jobOptions).right;
+
+ int w = 2
+ * fl.getHgap()
+ + (MAX_OPTWIDTH > OptsAndParamsPage.PARAM_WIDTH ? MAX_OPTWIDTH
+ : OptsAndParamsPage.PARAM_WIDTH);
+ int hgap = fl.getHgap(), cw = hgap;
+
if (opanp.getOptSet().size() > 0)
{
-
- jobOptions.setLayout(new MigLayout("","", ""));
+
+ jobOptions.setLayout(new MigLayout("", "", ""));
jobOptions.removeAll();
-
+
for (OptionBox pbox : opanp.getOptSet().values())
{
pbox.validate();
- cw+=pbox.getSize().width+hgap;
- if (cw+120>panewidth)
- {
- jobOptions.add(pbox, "wrap");
- // System.out.println("Wrap on "+pbox.option.getName());
- cw=hgap+pbox.getSize().width;
- fh=true;
- } else {
- jobOptions.add(pbox);
- }
- if (fh)
- {
- finalh+=pbox.getSize().height+fl.getVgap();
- fh=false;
+ cw += pbox.getSize().width + hgap;
+ if (cw + 120 > panewidth)
+ {
+ jobOptions.add(pbox, "wrap");
+ // System.out.println("Wrap on "+pbox.option.getName());
+ cw = hgap + pbox.getSize().width;
+ fh = true;
+ }
+ else
+ {
+ jobOptions.add(pbox);
+ }
+ if (fh)
+ {
+ finalh += pbox.getSize().height + fl.getVgap();
+ fh = false;
+ }
}
- }
- jobOptions.revalidate();
+ jobOptions.revalidate();
}
else
{
jobOptions.setVisible(false);
}
- // Now layout the parameters assuming they occupy one column - to calculate total height of options+parameters
+ // Now layout the parameters assuming they occupy one column - to calculate
+ // total height of options+parameters
fl = new FlowLayout(FlowLayout.LEFT);
- // helpful hint from http://stackoverflow.com/questions/2743177/top-alignment-for-flowlayout
+ // helpful hint from
+ // http://stackoverflow.com/questions/2743177/top-alignment-for-flowlayout
fl.setAlignOnBaseline(true);
if (opanp.getParamSet().size() > 0)
{
paramList.removeAll();
- paramList.setLayout(new MigLayout("","",""));
- fh=true;
- for (ParamBox pbox:opanp.getParamSet().values())
+ paramList.setLayout(new MigLayout("", "", ""));
+ fh = true;
+ for (ParamBox pbox : opanp.getParamSet().values())
{
pbox.validate();
- cw+=pbox.getSize().width+hgap;
- if (cw+160>panewidth) {
+ cw += pbox.getSize().width + hgap;
+ if (cw + 160 > panewidth)
+ {
paramList.add(pbox, "wrap");
- cw=pbox.getSize().width+hgap;
- fh=true;
- } else {
+ cw = pbox.getSize().width + hgap;
+ fh = true;
+ }
+ else
+ {
paramList.add(pbox);
}
if (fh)
{
- finalh+=pbox.getSize().height+fl.getVgap();
- fh=false;
+ finalh += pbox.getSize().height + fl.getVgap();
+ fh = false;
}
}
-/* s = 2 * sep;
- for (ParamBox pbox : opanp.getParamSet().values())
- {
- pbox.validate();
- s += sep + pbox.getPreferredSize().height+pbox.getBorder().getBorderInsets(pbox).bottom;
- }
-
-// paramList.setPreferredSize(new Dimension(w, s));
- os+=s+2*sep+paramList.getBorder().getBorderInsets(paramList).bottom+paramList.getBorder().getBorderInsets(paramList).top;
- */
+ /*
+ * s = 2 * sep; for (ParamBox pbox : opanp.getParamSet().values()) {
+ * pbox.validate(); s += sep +
+ * pbox.getPreferredSize().height+pbox.getBorder
+ * ().getBorderInsets(pbox).bottom; }
+ *
+ * // paramList.setPreferredSize(new Dimension(w, s));
+ * os+=s+2*sep+paramList
+ * .getBorder().getBorderInsets(paramList).bottom+paramList
+ * .getBorder().getBorderInsets(paramList).top;
+ */
paramList.revalidate();
}
else
{
paramList.setVisible(false);
}
- // TODO: waste some time trying to eliminate any unnecessary .validate calls here
+ // TODO: waste some time trying to eliminate any unnecessary .validate calls
+ // here
// System.out.println("Size will be : "+w+","+os);
// optsAndparams.setPreferredSize(null);
// paramPane.getViewport().setView(optsAndparams);
@@ -911,7 +958,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
{
Vector services = new Vector();
services.addElement(args[p++]);
- Jws2Discoverer.setServiceUrls(services);
+ Jws2Discoverer.getDiscoverer().setServiceUrls(services);
}
try
{
@@ -1052,8 +1099,9 @@ public class WsJobParameters extends JPanel implements ItemListener,
}
WsJobParameters pgui = new WsJobParameters(lastserv,
new JabaPreset(lastserv, pr));
- JFrame jf = new JFrame("Parameters for "
- + lastserv.getActionText());
+ JFrame jf = new JFrame(MessageManager.formatMessage(
+ "label.ws_parameters_for",
+ new String[] { lastserv.getActionText() }));
JPanel cont = new JPanel(new BorderLayout());
pgui.validate();
cont.setPreferredSize(pgui.getPreferredSize());
@@ -1128,8 +1176,10 @@ public class WsJobParameters extends JPanel implements ItemListener,
public boolean isServiceDefaults()
{
- return (!isModified() && (lastParmSet != null && lastParmSet.equals(SVC_DEF)));
+ return (!isModified() && (lastParmSet != null && lastParmSet
+ .equals(SVC_DEF)));
}
+
public List getJobParams()
{
return opanp.getCurrentSettings();
@@ -1250,7 +1300,18 @@ public class WsJobParameters extends JPanel implements ItemListener,
SetNamePanel.validate();
validate();
settingDialog = false;
+ }
+ /**
+ * Rebuild the AlignFrame web service menus (after add/delete of a preset
+ * option).
+ */
+ protected void updateWebServiceMenus()
+ {
+ for (AlignFrame alignFrame : Desktop.getAlignFrames())
+ {
+ alignFrame.BuildWebServiceMenu();
+ }
}
String curSetName = null;
@@ -1361,7 +1422,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
if (src.getParent() == setName)
{
// rename any existing records we know about for this set.
- String newname = (String) e.getActionCommand().trim();
+ String newname = e.getActionCommand().trim();
String msg = null;
if (isServicePreset(newname))
{
@@ -1375,9 +1436,10 @@ public class WsJobParameters extends JPanel implements ItemListener,
{
public void run()
{
- JOptionPane.showMessageDialog(ourframe,
- "Invalid name - preset already exists.",
- "Invalid name", JOptionPane.WARNING_MESSAGE);
+ JOptionPane.showMessageDialog(ourframe, MessageManager
+ .getString("label.invalid_name_preset_exists"),
+ MessageManager.getString("label.invalid_name"),
+ JOptionPane.WARNING_MESSAGE);
}
});