X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;ds=sidebyside;f=test%2Fjalview%2Fext%2Frbvi%2Fchimera%2FJalviewChimeraView.java;h=d397a6bd40231f9246ee6e06de556634a4c7822d;hb=5ee9c5f4c92a8dcebe6c31697181983efb116e8a;hp=734f7ebd19fc54adfd3ff54487a51db49286d937;hpb=4c6cd08af580ff73cfce39bec34ae4658a4b4b34;p=jalview.git diff --git a/test/jalview/ext/rbvi/chimera/JalviewChimeraView.java b/test/jalview/ext/rbvi/chimera/JalviewChimeraView.java index 734f7eb..d397a6b 100644 --- a/test/jalview/ext/rbvi/chimera/JalviewChimeraView.java +++ b/test/jalview/ext/rbvi/chimera/JalviewChimeraView.java @@ -25,6 +25,16 @@ import static org.testng.Assert.assertFalse; import static org.testng.Assert.assertNotNull; import static org.testng.Assert.assertTrue; +import java.io.File; +import java.io.IOException; +import java.util.List; +import java.util.Vector; + +import org.testng.annotations.AfterClass; +import org.testng.annotations.AfterMethod; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + import jalview.api.FeatureRenderer; import jalview.api.structures.JalviewStructureDisplayI; import jalview.bin.Cache; @@ -41,22 +51,13 @@ import jalview.gui.StructureViewer; import jalview.gui.StructureViewer.ViewerType; import jalview.io.DataSourceType; import jalview.io.FileLoader; +import jalview.structure.StructureCommand; import jalview.structure.StructureMapping; import jalview.structure.StructureSelectionManager; import jalview.ws.sifts.SiftsClient; import jalview.ws.sifts.SiftsException; import jalview.ws.sifts.SiftsSettings; -import java.io.File; -import java.io.IOException; -import java.util.List; -import java.util.Vector; - -import org.testng.annotations.AfterClass; -import org.testng.annotations.AfterMethod; -import org.testng.annotations.BeforeClass; -import org.testng.annotations.Test; - @Test(singleThreaded = true) public class JalviewChimeraView { @@ -148,7 +149,7 @@ public class JalviewChimeraView } } - assertTrue(binding.isChimeraRunning(), "Failed to start Chimera"); + assertTrue(binding.isViewerRunning(), "Failed to start Chimera"); assertEquals(chimeraViewer.getBinding().getPdbCount(), 1); chimeraViewer.closeViewer(true); @@ -208,7 +209,7 @@ public class JalviewChimeraView } } while (!binding.isFinishedInit()); - assertTrue(binding.isChimeraRunning(), "Failed to launch Chimera"); + assertTrue(binding.isViewerRunning(), "Failed to launch Chimera"); assertEquals(binding.getPdbCount(), 1); @@ -290,7 +291,8 @@ public class JalviewChimeraView /* * ask Chimera for its residue attribute names */ - List reply = binding.sendChimeraCommand("list resattr", true); + List reply = binding + .executeCommand(new StructureCommand("list resattr"), true); // prefixed and sanitised attribute names for Jalview features: assertTrue(reply.contains("resattr jv_domain")); assertTrue(reply.contains("resattr jv_metal_ion_binding_site")); @@ -306,8 +308,9 @@ public class JalviewChimeraView * ask Chimera for residues with an attribute * 91 and 96 on sequence --> residues 40 and 45 on chains A and B */ - reply = binding.sendChimeraCommand( - "list resi att jv_metal_ion_binding_site", true); + reply = binding.executeCommand( + new StructureCommand("list resi att jv_metal_ion_binding_site"), + true); assertEquals(reply.size(), 4); assertTrue(reply .contains("residue id #0:40.A jv_metal_ion_binding_site \"Iron-Sulfur (2Fe-2S)\" index 40")); @@ -322,7 +325,8 @@ public class JalviewChimeraView * check attributes with score values * sequence positions 62 and 65 --> residues 11 and 14 on chains A and B */ - reply = binding.sendChimeraCommand("list resi att jv_kd", true); + reply = binding.executeCommand( + new StructureCommand("list resi att jv_kd"), true); assertEquals(reply.size(), 4); assertTrue(reply.contains("residue id #0:11.A jv_kd -2.1 index 11")); assertTrue(reply.contains("residue id #0:14.A jv_kd 3.6 index 14")); @@ -332,8 +336,9 @@ public class JalviewChimeraView /* * list residues with positive kd score */ - reply = binding.sendChimeraCommand( - "list resi spec :*/jv_kd>0 attr jv_kd", true); + reply = binding.executeCommand( + new StructureCommand("list resi spec :*/jv_kd>0 attr jv_kd"), + true); assertEquals(reply.size(), 2); assertTrue(reply.contains("residue id #0:14.A jv_kd 3.6 index 14")); assertTrue(reply.contains("residue id #0:14.B jv_kd 3.6 index 14")); @@ -397,13 +402,13 @@ public class JalviewChimeraView } } while (!binding.isFinishedInit()); - assertTrue(binding.isChimeraRunning(), "Failed to launch Chimera"); + assertTrue(binding.isViewerRunning(), "Failed to launch Chimera"); assertEquals(binding.getPdbCount(), 1); /* - * 'perform' menu action to copy visible features to - * attributes in Chimera + * 'perform' menu action to copy Chimera attributes + * to features in Jalview */ // TODO rename and pull up method to binding interface // once functionality is added for Jmol as well @@ -440,14 +445,9 @@ public class JalviewChimeraView binding.copyStructureAttributesToFeatures("phi", af.getViewport() .getAlignPanel()); fr.setVisible("phi"); - List fs = fer2Arath.getFeatures().findFeatures(54, 54); - assertEquals(fs.size(), 3); - /* - * order of returned features is not guaranteed - */ - assertTrue("RESNUM".equals(fs.get(0).getType()) - || "RESNUM".equals(fs.get(1).getType()) - || "RESNUM".equals(fs.get(2).getType())); + List fs = fer2Arath.getFeatures().findFeatures(54, 54, + "phi"); + assertEquals(fs.size(), 2); assertTrue(fs.contains(new SequenceFeature("phi", "A", 54, 54, -131.0713f, "Chimera"))); assertTrue(fs.contains(new SequenceFeature("phi", "B", 54, 54, @@ -473,11 +473,11 @@ public class JalviewChimeraView int res, String featureType) { String where = "at position " + res; - List fs = seq.getFeatures().findFeatures(res, res); + List fs = seq.getFeatures().findFeatures(res, res, + featureType); - assertEquals(fs.size(), 2, where); - assertEquals(fs.get(0).getType(), "RESNUM", where); - SequenceFeature sf = fs.get(1); + assertEquals(fs.size(), 1, where); + SequenceFeature sf = fs.get(0); assertEquals(sf.getType(), featureType, where); assertEquals(sf.getFeatureGroup(), "Chimera", where); assertEquals(sf.getDescription(), "True", where);