X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=forester%2Fjava%2Fsrc%2Forg%2Fforester%2Fsdi%2FSDIR.java;h=88a2f2c9dce475998a05626e396ed51ec147bd82;hb=aec065f948a075773794133f102ea19eb1d59f64;hp=98f1cc5c20fe95b29774332a70de34c3ae042dfe;hpb=eee996a6476a1e3d84c07f8f690dcde3ff4b2ef5;p=jalview.git

diff --git a/forester/java/src/org/forester/sdi/SDIR.java b/forester/java/src/org/forester/sdi/SDIR.java
index 98f1cc5..88a2f2c 100644
--- a/forester/java/src/org/forester/sdi/SDIR.java
+++ b/forester/java/src/org/forester/sdi/SDIR.java
@@ -23,7 +23,7 @@
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
 //
 // Contact: phylosoft @ gmail . com
-// WWW: www.phylosoft.org/forester
+// WWW: https://sites.google.com/site/cmzmasek/home/software/forester
 
 package org.forester.sdi;
 
@@ -212,6 +212,7 @@ public class SDIR {
      *            Array) must be no lower than 1
      * @return array of rooted Trees with duplication vs. speciation assigned if
      *         return_trees is set to true, null otherwise
+     * @throws SDIException 
      */
     public Phylogeny[] infer( final Phylogeny gene_tree,
                               final Phylogeny species_tree,
@@ -219,9 +220,9 @@ public class SDIR {
                               boolean minimize_sum_of_dup,
                               final boolean minimize_height,
                               final boolean return_trees,
-                              int max_trees_to_return ) {
+                              int max_trees_to_return ) throws SDIException {
         init();
-        SDIse sdise = null;
+        SDI sdise = null;
         final ArrayList<Phylogeny> trees = new ArrayList<Phylogeny>();
         Phylogeny[] tree_array = null;
         List<PhylogenyBranch> branches = null;
@@ -265,26 +266,23 @@ public class SDIR {
             final PhylogenyNode n = iter.next();
             if ( n.isRoot() ) {
                 if ( ( n.getNumberOfDescendants() != 2 ) && ( n.getNumberOfDescendants() != 3 ) ) {
-                    throw new IllegalArgumentException( "attempt to run SDI on gene tree with "
-                            + n.getNumberOfDescendants() + " child nodes at its root" );
+                    throw new SDIException( "gene tree has " + n.getNumberOfDescendants() + " descendents at its root" );
                 }
             }
             else if ( !n.isExternal() && ( n.getNumberOfDescendants() != 2 ) ) {
-                throw new IllegalArgumentException( "attempt to run SDI on gene tree which is not completely binary [found node with "
-                        + n.getNumberOfDescendants() + " child nodes]" );
+                throw new SDIException( "gene tree is not completely binary" );
             }
         }
         for( final PhylogenyNodeIterator iter = species_tree.iteratorPostorder(); iter.hasNext(); ) {
             final PhylogenyNode n = iter.next();
             if ( !n.isExternal() && ( n.getNumberOfDescendants() != 2 ) ) {
-                throw new IllegalArgumentException( "attempt to run SDI with a species tree which is not completely binary (after stripping) [found node with "
-                        + n.getNumberOfDescendants() + " child nodes]" );
+                throw new SDIException( "species tree (after stripping) is not completely binary" );
             }
         }
         g.reRoot( g.getFirstExternalNode() );
         branches = SDIR.getBranchesInPreorder( g );
         if ( minimize_mapping_cost || minimize_sum_of_dup ) {
-            sdise = new SDIse( g, species_tree );
+            sdise = new SDI( g, species_tree );
             duplications = sdise.getDuplicationsSum();
         }
         final Set<PhylogenyBranch> used_root_placements = new HashSet<PhylogenyBranch>();
@@ -420,7 +418,7 @@ public class SDIR {
                     height = height__diff[ 0 ];
                     diff = height__diff[ 1 ];
                     if ( Math.abs( diff ) < SDIR.ZERO_DIFF ) {
-                        sdise = new SDIse( g, species_tree );
+                        sdise = new SDI( g, species_tree );
                         min_duplications = sdise.getDuplicationsSum();
                         min_height = height;
                         min_diff = Math.abs( diff );
@@ -496,8 +494,8 @@ public class SDIR {
             branches.add( new PhylogenyBranch( t.getRoot().getChildNode1(), t.getRoot().getChildNode2() ) );
             return branches;
         }
-        final Set<Integer> one = new HashSet<Integer>();
-        final Set<Integer> two = new HashSet<Integer>();
+        final Set<Long> one = new HashSet<Long>();
+        final Set<Long> two = new HashSet<Long>();
         PhylogenyNode node = t.getRoot();
         while ( !node.isRoot() || !two.contains( node.getId() ) ) {
             if ( !node.isExternal() && !two.contains( node.getId() ) ) {