X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2FMCview%2FPDBfile.java;h=3f9bc9def3b3f22e6ddeb5cc43d7fc62667abc26;hb=c9cb2ef932ff18d9f0b7318df8b622e7d665f9ef;hp=3df320c553571ebc6cf6a33dcb2bd8dc3660211e;hpb=2a198f35d10d35bd4c3eef1b0f5e623252bfa564;p=jalview.git

diff --git a/src/MCview/PDBfile.java b/src/MCview/PDBfile.java
index 3df320c..3f9bc9d 100755
--- a/src/MCview/PDBfile.java
+++ b/src/MCview/PDBfile.java
@@ -1,20 +1,19 @@
 /*
- * Jalview - A Sequence Alignment Editor and Viewer (Development Version 2.4.1)
- * Copyright (C) 2009 AM Waterhouse, J Procter, G Barton, M Clamp, S Searle
+ * Jalview - A Sequence Alignment Editor and Viewer (Version 2.7)
+ * Copyright (C) 2011 J Procter, AM Waterhouse, G Barton, M Clamp, S Searle
  * 
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
+ * This file is part of Jalview.
  * 
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+ * Jalview is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License 
+ * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
  * 
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ * Jalview is distributed in the hope that it will be useful, but 
+ * WITHOUT ANY WARRANTY; without even the implied warranty 
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR 
+ * PURPOSE.  See the GNU General Public License for more details.
+ * 
+ * You should have received a copy of the GNU General Public License along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
  */
 package MCview;
 
@@ -54,33 +53,37 @@ public class PDBfile extends jalview.io.AlignFile
 
   public void parse() throws IOException
   {
-    // TODO set the filename sensibly
-    id = (inFile == null || inFile.getName()==null || inFile.getName().length()==0) ? "PDBFILE" : inFile.getName();
-    try
-    {
+    // TODO set the filename sensibly - try using data source name.
+    id = safeName(getDataName());
+
       chains = new Vector();
 
       PDBChain tmpchain;
-      String line;
+      String line=null;
       boolean modelFlag = false;
       boolean terFlag = false;
-      String lastID="";
+      String lastID = "";
 
       int index = 0;
-      String atomnam=null;
+      String atomnam = null;
+      try
+      {
       while ((line = nextLine()) != null)
       {
         if (line.indexOf("HEADER") == 0)
         {
-          if (line.length()>62)
+          if (line.length() > 62)
           {
             String tid;
-            if (line.length()>67) {
+            if (line.length() > 67)
+            {
               tid = line.substring(62, 67).trim();
-            } else {
-              tid=line.substring(62).trim();
             }
-            if (tid.length()>0)
+            else
+            {
+              tid = line.substring(62).trim();
+            }
+            if (tid.length() > 0)
             {
               id = tid;
             }
@@ -124,7 +127,7 @@ public class PDBfile extends jalview.io.AlignFile
           {
             if (tmpatom.resNumIns.trim().equals(lastID))
             {
-              //  phosphorylated protein - seen both CA and P..
+              // phosphorylated protein - seen both CA and P..
               continue;
             }
             tmpchain.atoms.addElement(tmpatom);
@@ -157,10 +160,15 @@ public class PDBfile extends jalview.io.AlignFile
         {
           entry.setFile(inFile.getAbsolutePath());
         }
+        else
+        {
+          // TODO: decide if we should dump the datasource to disk
+          entry.setFile(getDataName());
+        }
         dataset.addPDBId(entry);
         SequenceI chainseq = dataset.deriveSequence(); // PDBChain objects
-                                                        // maintain reference to
-                                                        // dataset
+        // maintain reference to
+        // dataset
         seqs.addElement(chainseq);
         AlignmentAnnotation[] chainannot = chainseq.getAnnotation();
         if (chainannot != null)
@@ -177,6 +185,29 @@ public class PDBfile extends jalview.io.AlignFile
       System.out.println("OUT OF MEMORY LOADING PDB FILE");
       throw new IOException("Out of memory loading PDB File");
     }
+    catch (NumberFormatException ex)
+    {
+      if (line!=null) {
+        System.err.println("Couldn't read number from line:");
+        System.err.println(line);
+      }
+    }
+  }
+
+  /**
+   * make a friendly ID string.
+   * 
+   * @param dataName
+   * @return truncated dataName to after last '/'
+   */
+  private String safeName(String dataName)
+  {
+    int p = 0;
+    while ((p = dataName.indexOf("/")) > -1 && p < dataName.length())
+    {
+      dataName = dataName.substring(p + 1);
+    }
+    return dataName;
   }
 
   public void makeResidueList()