X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fanalysis%2FAlignmentUtils.java;h=6ac59baf4a6dc8777b41eef470ada4e6152957d5;hb=d01453133dd3b6247e4d0a12a6dd6886d6053a6c;hp=fd540da22595e0e53aae6501513faeefa0414c56;hpb=a1984b1c8c273ed33c7ce9283039f4027dcae2de;p=jalview.git diff --git a/src/jalview/analysis/AlignmentUtils.java b/src/jalview/analysis/AlignmentUtils.java index fd540da..6ac59ba 100644 --- a/src/jalview/analysis/AlignmentUtils.java +++ b/src/jalview/analysis/AlignmentUtils.java @@ -38,7 +38,7 @@ import java.util.Set; import java.util.SortedMap; import java.util.TreeMap; -import jalview.bin.Cache; +import jalview.bin.Console; import jalview.commands.RemoveGapColCommand; import jalview.datamodel.AlignedCodon; import jalview.datamodel.AlignedCodonFrame; @@ -186,8 +186,8 @@ public class AlignmentUtils .getSequence(s.getStart() - 1 - ustream_ds, s.getStart() - 1)) .toLowerCase(Locale.ROOT).toCharArray(); char[] downstream = new String( - ds.getSequence(s_end - 1, s_end + dstream_ds)).toLowerCase(Locale.ROOT) - .toCharArray(); + ds.getSequence(s_end - 1, s_end + dstream_ds)) + .toLowerCase(Locale.ROOT).toCharArray(); char[] coreseq = s.getSequence(); char[] nseq = new char[offset + upstream.length + downstream.length + coreseq.length]; @@ -465,7 +465,8 @@ public class AlignmentUtils if (cdnaLength != mappedLength && cdnaLength > 2) { String lastCodon = String.valueOf(cdnaSeqChars, - cdnaLength - CODON_LENGTH, CODON_LENGTH).toUpperCase(Locale.ROOT); + cdnaLength - CODON_LENGTH, CODON_LENGTH) + .toUpperCase(Locale.ROOT); for (String stop : ResidueProperties.STOP_CODONS) { if (lastCodon.equals(stop)) @@ -482,7 +483,8 @@ public class AlignmentUtils */ int startOffset = 0; if (cdnaLength != mappedLength && cdnaLength > 2 - && String.valueOf(cdnaSeqChars, 0, CODON_LENGTH).toUpperCase(Locale.ROOT) + && String.valueOf(cdnaSeqChars, 0, CODON_LENGTH) + .toUpperCase(Locale.ROOT) .equals(ResidueProperties.START)) { startOffset += CODON_LENGTH; @@ -976,8 +978,8 @@ public class AlignmentUtils mapList = mapList.getInverse(); } final int cdsLength = cdsDss.getLength(); - int mappedFromLength = MappingUtils.getLength(mapList - .getFromRanges()); + int mappedFromLength = MappingUtils + .getLength(mapList.getFromRanges()); int mappedToLength = MappingUtils .getLength(mapList.getToRanges()); boolean addStopCodon = (cdsLength == mappedFromLength @@ -1462,28 +1464,31 @@ public class AlignmentUtils final List result = new ArrayList<>(); for (AlignmentAnnotation dsann : datasetAnnotations) { - /* - * Find matching annotations on the alignment. If none is found, then - * add this annotation to the list of 'addable' annotations for this - * sequence. - */ - final Iterable matchedAlignmentAnnotations = al - .findAnnotations(seq, dsann.getCalcId(), dsann.label); - if (!matchedAlignmentAnnotations.iterator().hasNext()) + if (dsann.annotations != null) // ignore non-positional annotation { - result.add(dsann); - if (labelForCalcId != null) + /* + * Find matching annotations on the alignment. If none is found, then + * add this annotation to the list of 'addable' annotations for this + * sequence. + */ + final Iterable matchedAlignmentAnnotations = al + .findAnnotations(seq, dsann.getCalcId(), dsann.label); + if (!matchedAlignmentAnnotations.iterator().hasNext()) { - labelForCalcId.put(dsann.getCalcId(), dsann.label); + result.add(dsann); + if (labelForCalcId != null) + { + labelForCalcId.put(dsann.getCalcId(), dsann.label); + } } } - } - /* - * Save any addable annotations for this sequence - */ - if (!result.isEmpty()) - { - candidates.put(seq, result); + /* + * Save any addable annotations for this sequence + */ + if (!result.isEmpty()) + { + candidates.put(seq, result); + } } } } @@ -1651,8 +1656,8 @@ public class AlignmentUtils productSeqs = new HashSet<>(); for (SequenceI seq : products) { - productSeqs.add(seq.getDatasetSequence() == null ? seq : seq - .getDatasetSequence()); + productSeqs.add(seq.getDatasetSequence() == null ? seq + : seq.getDatasetSequence()); } } @@ -1756,7 +1761,7 @@ public class AlignmentUtils dataset.addSequence(cdsSeqDss); AlignedCodonFrame cdsToProteinMapping = new AlignedCodonFrame(); cdsToProteinMapping.addMap(cdsSeqDss, proteinProduct, - cdsToProteinMap); + cdsToProteinMap); /* * guard against duplicating the mapping if repeating this action @@ -1809,20 +1814,21 @@ public class AlignmentUtils List primrefs = dnaDss.getPrimaryDBRefs(); for (int ip = 0, np = primrefs.size(); ip < np; ip++) { - DBRefEntry primRef = primrefs.get(ip); + DBRefEntry primRef = primrefs.get(ip); /* * create a cross-reference from CDS to the source sequence's * primary reference and vice versa */ String source = primRef.getSource(); String version = primRef.getVersion(); - DBRefEntry cdsCrossRef = new DBRefEntry(source, source + ":" - + version, primRef.getAccessionId()); - cdsCrossRef.setMap(new Mapping(dnaDss, new MapList(cdsToDnaMap))); + DBRefEntry cdsCrossRef = new DBRefEntry(source, + source + ":" + version, primRef.getAccessionId()); + cdsCrossRef + .setMap(new Mapping(dnaDss, new MapList(cdsToDnaMap))); cdsSeqDss.addDBRef(cdsCrossRef); - dnaSeq.addDBRef(new DBRefEntry(source, version, cdsSeq - .getName(), new Mapping(cdsSeqDss, dnaToCdsMap))); + dnaSeq.addDBRef(new DBRefEntry(source, version, + cdsSeq.getName(), new Mapping(cdsSeqDss, dnaToCdsMap))); // problem here is that the cross-reference is synthesized - // cdsSeq.getName() may be like 'CDS|dnaaccession' or // 'CDS|emblcdsacc' @@ -1831,8 +1837,8 @@ public class AlignmentUtils DBRefEntry proteinToCdsRef = new DBRefEntry(source, version, cdsSeq.getName()); // - proteinToCdsRef.setMap(new Mapping(cdsSeqDss, cdsToProteinMap - .getInverse())); + proteinToCdsRef.setMap( + new Mapping(cdsSeqDss, cdsToProteinMap.getInverse())); proteinProduct.addDBRef(proteinToCdsRef); } /* @@ -1844,8 +1850,8 @@ public class AlignmentUtils } } - AlignmentI cds = new Alignment(cdsSeqs.toArray(new SequenceI[cdsSeqs - .size()])); + AlignmentI cds = new Alignment( + cdsSeqs.toArray(new SequenceI[cdsSeqs.size()])); cds.setDataset(dataset); return cds; @@ -2056,8 +2062,9 @@ public class AlignmentUtils } else { - Cache.error( - "JAL-2154 regression: warning - found (and ignored) a duplicate CDS sequence:" + mtch.toString()); + Console.error( + "JAL-2154 regression: warning - found (and ignored) a duplicate CDS sequence:" + + mtch.toString()); } } } @@ -2181,9 +2188,9 @@ public class AlignmentUtils /* * get features, optionally restricted by an ontology term */ - List sfs = select == null ? fromSeq.getFeatures() - .getPositionalFeatures() : fromSeq.getFeatures() - .getFeaturesByOntology(select); + List sfs = select == null + ? fromSeq.getFeatures().getPositionalFeatures() + : fromSeq.getFeatures().getFeaturesByOntology(select); int count = 0; for (SequenceFeature sf : sfs) @@ -2328,8 +2335,8 @@ public class AlignmentUtils { List result = new ArrayList<>(); - List sfs = dnaSeq.getFeatures().getFeaturesByOntology( - SequenceOntologyI.CDS); + List sfs = dnaSeq.getFeatures() + .getFeaturesByOntology(SequenceOntologyI.CDS); if (sfs.isEmpty()) { return result; @@ -2341,11 +2348,11 @@ public class AlignmentUtils int phase = 0; try { - String s = sf.getPhase(); - if (s != null) - { - phase = Integer.parseInt(s); - } + String s = sf.getPhase(); + if (s != null) + { + phase = Integer.parseInt(s); + } } catch (NumberFormatException e) { // leave as zero @@ -2401,11 +2408,11 @@ public class AlignmentUtils SequenceIdMatcher matcher = new SequenceIdMatcher(seqs); if (xrefs != null) { - // BH 2019.01.25 recoded to remove iterators - + // BH 2019.01.25 recoded to remove iterators + for (int ix = 0, nx = xrefs.length; ix < nx; ix++) { - SequenceI xref = xrefs[ix]; + SequenceI xref = xrefs[ix]; List dbrefs = xref.getDBRefs(); if (dbrefs != null) { @@ -2520,10 +2527,10 @@ public class AlignmentUtils * true; else returns false * * @param unaligned - * - sequences to be aligned based on aligned + * - sequences to be aligned based on aligned * @param aligned - * - 'guide' alignment containing sequences derived from same - * dataset as unaligned + * - 'guide' alignment containing sequences derived from same dataset + * as unaligned * @return */ static boolean alignAsSameSequences(AlignmentI unaligned, @@ -2559,8 +2566,7 @@ public class AlignmentUtils { return false; } - SequenceI alignedSeq = alignedDatasets.get(ds) - .get(0); + SequenceI alignedSeq = alignedDatasets.get(ds).get(0); int startCol = alignedSeq.findIndex(seq.getStart()); // 1.. leftmost = Math.min(leftmost, startCol); }