X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fanalysis%2FSequenceIdMatcher.java;h=a85c7f36fc7bd9cefb35e7d5d1209c6e5dfc0cb4;hb=ec8f3cedf60fb1feed6d34de6b49f6bfa78b9dd8;hp=3fd05817e9ba495761d33ae6566f8952f301eab3;hpb=807a7b06a2f933d220e368d96f09b4ee6c9bd98a;p=jalview.git

diff --git a/src/jalview/analysis/SequenceIdMatcher.java b/src/jalview/analysis/SequenceIdMatcher.java
index 3fd0581..a85c7f3 100755
--- a/src/jalview/analysis/SequenceIdMatcher.java
+++ b/src/jalview/analysis/SequenceIdMatcher.java
@@ -74,13 +74,13 @@ public class SequenceIdMatcher
       dbseq = dbseq.getDatasetSequence();
     }
     // add in any interesting identifiers
-    if (dbseq.getDBRefs() != null)
+    List<DBRefEntry> dbr = dbseq.getDBRefs(); 
+    if (dbr != null)
     {
-      DBRefEntry dbr[] = dbseq.getDBRefs();
       SeqIdName sid = null;
-      for (int r = 0; r < dbr.length; r++)
+      for (int r = 0, nr = dbr.size(); r < nr; r++)
       {
-        sid = new SeqIdName(dbr[r].getAccessionId());
+        sid = new SeqIdName(dbr.get(r).getAccessionId());
         if (!names.containsKey(sid))
         {
           names.put(sid, seq);
@@ -147,9 +147,8 @@ public class SequenceIdMatcher
       names.put(new SeqIdName(cand.getName()), cand);
       int q, w, candlen = cand.getName().length();
       // keep the one with an id 'closer' to the given seqnam string
-      if ((q = Math.abs(matchlen - namlen)) > (w = Math.abs(candlen
-              - namlen))
-              && candlen > matchlen)
+      if ((q = Math.abs(matchlen - namlen)) > (w = Math
+              .abs(candlen - namlen)) && candlen > matchlen)
       {
         best.clear();
         match = cand;
@@ -290,7 +289,7 @@ public class SequenceIdMatcher
     {
       if (s != null)
       {
-        id = new String(s.toLowerCase());
+        id = s.toLowerCase();
       }
       else
       {
@@ -301,8 +300,8 @@ public class SequenceIdMatcher
     @Override
     public int hashCode()
     {
-      return ((id.length() >= 4) ? id.substring(0, 4).hashCode() : id
-              .hashCode());
+      return ((id.length() >= 4) ? id.substring(0, 4).hashCode()
+              : id.hashCode());
     }
 
     @Override
@@ -348,14 +347,27 @@ public class SequenceIdMatcher
     {
       if (id.length() > s.length())
       {
-        return id.startsWith(s) ? (WORD_SEP.indexOf(id.charAt(s.length())) > -1)
+        return id.startsWith(s)
+                ? (WORD_SEP.indexOf(id.charAt(s.length())) > -1)
                 : false;
       }
       else
       {
-        return s.startsWith(id) ? (s.equals(id) ? true : (WORD_SEP
-                .indexOf(s.charAt(id.length())) > -1)) : false;
+        return s.startsWith(id)
+                ? (s.equals(id) ? true
+                        : (WORD_SEP.indexOf(s.charAt(id.length())) > -1))
+                : false;
       }
     }
+
+    /**
+     * toString method returns the wrapped sequence id. For debugging purposes
+     * only, behaviour not guaranteed not to change.
+     */
+    @Override
+    public String toString()
+    {
+      return id;
+    }
   }
 }