X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fappletgui%2FRotatableCanvas.java;h=2a49d0be7453792b970b0ed9797a9d39e059fa33;hb=b04c79d1a830aa7ae7b88b2a5ddd07c9216c826f;hp=300036358d722c73d0ddbd215ca5b997905dd3b7;hpb=0615edf610baff76b1675e2f174f22d855fd3fe4;p=jalview.git

diff --git a/src/jalview/appletgui/RotatableCanvas.java b/src/jalview/appletgui/RotatableCanvas.java
index 3000363..2a49d0b 100755
--- a/src/jalview/appletgui/RotatableCanvas.java
+++ b/src/jalview/appletgui/RotatableCanvas.java
@@ -41,7 +41,7 @@ import java.awt.event.KeyListener;
 import java.awt.event.MouseEvent;
 import java.awt.event.MouseListener;
 import java.awt.event.MouseMotionListener;
-import java.util.Vector;
+import java.util.List;
 
 public class RotatableCanvas extends Panel implements MouseListener,
         MouseMotionListener, KeyListener, RotatableCanvasI
@@ -82,7 +82,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
 
   int npoint;
 
-  Vector<SequencePoint> points;
+  List<SequencePoint> points;
 
   Point[] orig;
 
@@ -123,7 +123,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
   }
 
   @Override
-  public void setPoints(Vector<SequencePoint> points, int npoint)
+  public void setPoints(List<SequencePoint> points, int npoint)
   {
     this.points = points;
     this.npoint = npoint;
@@ -134,7 +134,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
 
     for (int i = 0; i < npoint; i++)
     {
-      SequencePoint sp = points.elementAt(i);
+      SequencePoint sp = points.get(i);
       orig[i] = sp.coord;
     }
 
@@ -346,7 +346,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
   {
     for (int i = 0; i < npoint; i++)
     {
-      SequencePoint sp = points.elementAt(i);
+      SequencePoint sp = points.get(i);
       SequenceI sequence = sp.getSequence();
       Color sequenceColour = av.getSequenceColour(sequence);
       g.setColor(
@@ -394,13 +394,11 @@ public class RotatableCanvas extends Panel implements MouseListener,
   {
     if (evt.getKeyCode() == KeyEvent.VK_UP)
     {
-      scalefactor = (float) (scalefactor * 1.1);
-      scale = findScale();
+      zoom(1.1f);
     }
     else if (evt.getKeyCode() == KeyEvent.VK_DOWN)
     {
-      scalefactor = (float) (scalefactor * 0.9);
-      scale = findScale();
+      zoom(0.9f);
     }
     else if (evt.getKeyChar() == 's')
     {
@@ -499,31 +497,16 @@ public class RotatableCanvas extends Panel implements MouseListener,
     int xPos = evt.getX();
     int yPos = evt.getY();
 
-    RotatableMatrix rotmat = new RotatableMatrix();
-
-    rotmat.rotate(yPos - mouseY, Axis.X);
-    rotmat.rotate(xPos - mouseX, Axis.Y);
-
-    for (int i = 0; i < npoint; i++)
+    if (xPos == mouseX && yPos == mouseY)
     {
-      SequencePoint sp = points.elementAt(i);
-      sp.translateBack(centre);
-
-      // Now apply the rotation matrix
-      sp.coord = rotmat.vectorMultiply(sp.coord);
-
-      // Now translate back again
-      sp.translate(centre);
+      return;
     }
 
-    for (int i = 0; i < 3; i++)
-    {
-      axisEndPoints[i] = rotmat.vectorMultiply(axisEndPoints[i]);
-    }
-    mouseX = xPos;
-    mouseY = yPos;
+    int xDelta = xPos - mouseX;
+    int yDelta = yPos - mouseY;
 
-    paint(this.getGraphics());
+    rotate(xDelta, yDelta);
+    repaint();
   }
 
   public void rectSelect(int x1, int y1, int x2, int y2)
@@ -531,7 +514,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
     // boolean changedSel = false;
     for (int i = 0; i < npoint; i++)
     {
-      SequencePoint sp = points.elementAt(i);
+      SequencePoint sp = points.get(i);
       int tmp1 = (int) ((sp.coord.x - centre.x) * scale
               + getSize().width / 2.0);
       int tmp2 = (int) ((sp.coord.y - centre.y) * scale
@@ -571,7 +554,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
     for (int i = 0; i < npoint; i++)
     {
 
-      SequencePoint sp = points.elementAt(i);
+      SequencePoint sp = points.get(i);
       int px = (int) ((sp.coord.x - centre.x) * scale)
               + halfwidth;
       int py = (int) ((sp.coord.y - centre.y) * scale)
@@ -586,7 +569,7 @@ public class RotatableCanvas extends Panel implements MouseListener,
 
     if (found != -1)
     {
-      return points.elementAt(found).getSequence();
+      return points.get(found).getSequence();
     }
     else
     {
@@ -603,4 +586,70 @@ public class RotatableCanvas extends Panel implements MouseListener,
     resetAxes();
   }
 
+  @Override
+  public void zoom(float factor)
+  {
+    if (factor > 0f)
+    {
+      scalefactor *= factor;
+    }
+    scale = findScale();
+  }
+
+  @Override
+  public void rotate(float x, float y)
+  {
+    if (x == 0f && y == 0f)
+    {
+      return;
+    }
+  
+    /*
+     * get the identity transformation...
+     */
+    RotatableMatrix rotmat = new RotatableMatrix();
+  
+    /*
+     * rotate around the X axis for change in Y
+     * (mouse movement up/down); note we are equating a
+     * number of pixels with degrees of rotation here!
+     */
+    if (y != 0)
+    {
+      rotmat.rotate(y, Axis.X);
+    }
+  
+    /*
+     * rotate around the Y axis for change in X
+     * (mouse movement left/right)
+     */
+    if (x != 0)
+    {
+      rotmat.rotate(x, Axis.Y);
+    }
+  
+    /*
+     * apply the composite transformation to sequence points
+     */
+    for (int i = 0; i < npoint; i++)
+    {
+      SequencePoint sp = points.get(i);
+      sp.translate(-centre.x, -centre.y, -centre.z);
+
+      // Now apply the rotation matrix
+      sp.coord = rotmat.vectorMultiply(sp.coord);
+
+      // Now translate back again
+      sp.translate(centre.x, centre.y, centre.z);
+    }
+  
+    /*
+     * rotate the x/y/z axis positions
+     */
+    for (int i = 0; i < DIMS; i++)
+    {
+      axisEndPoints[i] = rotmat.vectorMultiply(axisEndPoints[i]);
+    }
+  }
+
 }