X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fdatamodel%2FContactMapHolder.java;h=45c0d18773e044d9705a8eec53174c71c977a03d;hb=85299bc2db43c8b108169661ebc1c4d9b2d3d2e5;hp=d80a7198677810e164315fa60be718c454d4b86a;hpb=9e40070f757fc662aba39ba6314be4937276ead4;p=jalview.git diff --git a/src/jalview/datamodel/ContactMapHolder.java b/src/jalview/datamodel/ContactMapHolder.java index d80a719..45c0d18 100644 --- a/src/jalview/datamodel/ContactMapHolder.java +++ b/src/jalview/datamodel/ContactMapHolder.java @@ -3,6 +3,7 @@ package jalview.datamodel; import java.util.Collection; import java.util.Collections; import java.util.HashMap; +import java.util.HashSet; import java.util.Map; import jalview.ws.datamodel.MappableContactMatrixI; @@ -17,7 +18,9 @@ public class ContactMapHolder implements ContactMapHolderI { if (contactmaps != null && contactmaps.size() > 0) { - return contactmaps.values(); + // defensive copy, and return non redundant set of ContactMatrixI + // instances + return new HashSet(contactmaps.values()); } return Collections.EMPTY_LIST; } @@ -32,9 +35,10 @@ public class ContactMapHolder implements ContactMapHolderI } if (cm instanceof MappableContactMatrixI) { - if (_aa.sequenceRef!=null) + if (_aa.sequenceRef != null) { - return ((MappableContactMatrixI)cm).getMappableContactList(_aa.sequenceRef, column); + return ((MappableContactMatrixI) cm) + .getMappableContactList(_aa.sequenceRef, column); } } // TODO: could resolve sequence position to column position here