(feature);
- return true;
- }
- return nestedFeatures.add(feature, false);
- }
+ abstract protected void addNestedFeature(SequenceFeature feature);
/**
- * Add a feature to the list of non-nested features, maintaining the ordering
- * of the list. A check is made for whether the feature is nested in (properly
- * contained by) an existing feature. If there is no nesting, the feature is
- * added to the list and the method returns true. If nesting is found, the
- * feature is not added and the method returns false.
- *
- * Contact features are added at the position of their first contact point
+ * Adds the feature to the list of non-positional features (with lazy
+ * instantiation of the list if it is null), and returns true. The feature
+ * group is added to the set of distinct feature groups for non-positional
+ * features. This method allows duplicate features, so test before calling to
+ * prevent this.
*
* @param feature
- * @return
*/
- protected boolean addNonNestedFeature(SequenceFeature feature)
+ protected boolean addNonPositionalFeature(SequenceFeature feature)
{
- synchronized (nonNestedFeatures)
+ if (nonPositionalFeatures == null)
{
- int insertPosition = binarySearchForAdd(nonNestedFeatures, feature);
+ nonPositionalFeatures = new ArrayList<>();
+ }
- /*
- * fail if we detect feature enclosure - of the new feature by
- * the one preceding it, or of the next feature by the new one
- */
- if (insertPosition > 0)
- {
- if (encloses(nonNestedFeatures.get(insertPosition - 1), feature))
- {
- return false;
- }
- }
- if (insertPosition < nonNestedFeatures.size())
- {
- if (encloses(feature, nonNestedFeatures.get(insertPosition)))
- {
- return false;
- }
- }
+ nonPositionalFeatures.add(feature);
- /*
- * checks passed - add or append the feature
- */
- if (insertPosition == nonNestedFeatures.size())
- {
- nonNestedFeatures.add(feature);
- }
- else
- {
- nonNestedFeatures.add(insertPosition, feature);
- }
- return true;
- }
+ nonPositionalFeatureGroups.add(feature.getFeatureGroup());
+
+ return true;
}
/**
- * Answers true if range1 properly encloses range2, else false
+ * Answers true if this store contains the given feature (testing by
+ * SequenceFeature.equals), else false
*
- * @param range1
- * @param range2
+ * @param feature
* @return
*/
- protected boolean encloses(ContiguousI range1, ContiguousI range2)
+ @Override
+ public boolean contains(SequenceFeature feature)
{
- int begin1 = range1.getBegin();
- int begin2 = range2.getBegin();
- int end1 = range1.getEnd();
- int end2 = range2.getEnd();
- if (begin1 == begin2 && end1 > end2)
+ if (feature.isNonPositional())
{
- return true;
+ return nonPositionalFeatures == null ? false
+ : nonPositionalFeatures.contains(feature);
}
- if (begin1 < begin2 && end1 >= end2)
+
+ if (feature.isContactFeature())
{
- return true;
+ return contactFeatureStarts != null
+ && listContains(contactFeatureStarts, feature);
}
- return false;
+
+ return features == null ? false : containsFeature(feature);
}
+
+ abstract protected boolean containsFeature(SequenceFeature feature);
+
/**
- * Answers the index of the first element in the given list which follows or
- * matches the given feature in the sort order. If no such element, answers
- * the length of the list.
- *
- * @param list
- * @param feature
+ * Deletes the given feature from the store, returning true if it was found
+ * (and deleted), else false. This method makes no assumption that the feature
+ * is in the 'expected' place in the store, in case it has been modified since
+ * it was added.
*
- * @return
+ * @param sf
*/
- protected int binarySearchForAdd(List list, SequenceFeature feature)
+
+ @Override
+ public synchronized boolean delete(SequenceFeature sf)
{
- // TODO binary search!
- int i = 0;
- while (i < list.size())
+ boolean removed = false;
+
+ /*
+ * try contact positions (and if found, delete
+ * from both lists of contact positions)
+ */
+ if (!removed && contactFeatureStarts != null)
{
- if (startOrdering.compare(nonNestedFeatures.get(i), feature) >= 0)
+ removed = contactFeatureStarts.remove(sf);
+ if (removed)
{
- break;
+ contactFeatureEnds.remove(sf);
}
- i++;
}
- return i;
- }
- /**
- * Add a contact feature to the lists that hold them ordered by start (first
- * contact) and by end (second contact) position, ensuring the lists remain
- * ordered, and returns true. If the contact feature lists already contain the
- * given feature (by test for equality), does not add it and returns false.
- *
- * @param feature
- * @return
- */
- protected synchronized boolean addContactFeature(SequenceFeature feature)
- {
- if (contactFeatureStarts == null)
+ boolean removedNonPositional = false;
+
+ /*
+ * if not found, try non-positional features
+ */
+ if (!removed && nonPositionalFeatures != null)
{
- contactFeatureStarts = new ArrayList();
+ removedNonPositional = nonPositionalFeatures.remove(sf);
+ removed = removedNonPositional;
}
- if (contactFeatureEnds == null)
+
+ /*
+ * if not found, try nested features
+ */
+ if (!removed && features != null)
{
- contactFeatureEnds = new ArrayList();
+ removed = features.remove(sf);
}
- // TODO binary search for insertion points!
- if (contactFeatureStarts.contains(feature))
+ if (removed)
{
- return false;
+ rescanAfterDelete();
}
- contactFeatureStarts.add(feature);
- Collections.sort(contactFeatureStarts, startOrdering);
- contactFeatureEnds.add(feature);
- Collections.sort(contactFeatureEnds, endOrdering);
-
- return true;
+ return removed;
}
- /**
- * Returns a (possibly empty) list of entries whose range overlaps the given
- * range. The returned list is not ordered. Contact features are included if
- * either of the contact points lies within the range.
- *
- * @param start
- * start position of overlap range (inclusive)
- * @param end
- * end position of overlap range (inclusive)
- * @return
- */
- public List findOverlappingFeatures(long start, long end)
- {
- List result = new ArrayList();
+ abstract protected void findContactFeatures(long from, long to,
+ List result);
- findNonNestedFeatures(start, end, result);
+ abstract protected int findFirstBegin(List list,
+ long pos);
- findContactFeatures(start, end, result);
+ abstract protected int findFirstEnd(List list, long pos);
- if (nestedFeatures != null)
- {
- result.addAll(nestedFeatures.findOverlaps(start, end));
- }
+ @Override
+ public List findOverlappingFeatures(long start, long end)
+ {
+ return findOverlappingFeatures(start, end, null);
+ }
- return result;
+ @Override
+ public List getContactFeatures()
+ {
+ return getContactFeatures(new ArrayList<>());
}
/**
- * Adds contact features to the result list where either the second or the
- * first contact position lies within the target range.
+ * Answers a list of all contact features. If there are none, returns an
+ * immutable empty list.
*
- * @param from
- * @param to
- * @param result
+ * @return
*/
- protected void findContactFeatures(long from, long to,
+
+ @Override
+ public List getContactFeatures(
List result)
{
if (contactFeatureStarts != null)
{
- findContactStartFeatures(from, to, result);
- }
- if (contactFeatureEnds != null)
- {
- findContactEndFeatures(from, to, result);
+ result.addAll(contactFeatureStarts);
}
+ return result;
}
/**
- * @param from
- * @param to
- * @param result
+ * Answers the number of positional (or non-positional) features stored.
+ * Contact features count as 1.
+ *
+ * @param positional
+ * @return
*/
- protected void findContactEndFeatures(long from, long to,
- List result)
+
+ @Override
+ public int getFeatureCount(boolean positional)
{
- // TODO binary search for startPosition
- for (int startPosition = 0; startPosition < contactFeatureEnds.size(); startPosition++)
+ if (!positional)
{
- SequenceFeature sf = contactFeatureEnds.get(startPosition);
- if (!sf.isContactFeature())
- {
- System.err.println("Error! non-contact feature type "
- + sf.getType() + " in contact features list");
- continue;
- }
- int begin = sf.getBegin();
- if (begin >= from && begin <= to)
- {
- /*
- * this feature's first contact position lies in the search range
- * so we don't include it in results a second time
- */
- continue;
- }
- int end = sf.getEnd();
- if (end >= from && end <= to)
- {
- result.add(sf);
- }
+ return nonPositionalFeatures == null ? 0
+ : nonPositionalFeatures.size();
}
+
+ return (contactFeatureStarts == null ? 0 : contactFeatureStarts.size())
+ + features.size();
+
}
/**
- * Returns the index of the first contact feature found whose end (second
- * contact position) is not before the given start position. If no such
- * feature is found, returns the length of the contact features list.
+ * Answers the set of distinct feature groups stored, possibly including null,
+ * as an unmodifiable view of the set. The parameter determines whether the
+ * groups for positional or for non-positional features are returned.
*
- * @param start
+ * @param positionalFeatures
* @return
*/
- protected int contactsBinarySearch(long start)
+
+ @Override
+ public Set getFeatureGroups(boolean positionalFeatures)
{
- // TODO binary search!!
- int i = 0;
- while (i < contactFeatureEnds.size())
+ if (positionalFeatures)
{
- if (contactFeatureEnds.get(i).getEnd() >= start)
- {
- break;
- }
- i++;
+ return Collections.unmodifiableSet(positionalFeatureGroups);
+ }
+ else
+ {
+ return nonPositionalFeatureGroups == null
+ ? Collections. emptySet()
+ : Collections.unmodifiableSet(nonPositionalFeatureGroups);
}
+ }
- return i;
+ @Override
+ public Collection getFeatures()
+ {
+ return features;
}
/**
- * Adds features to the result list that are at a single position which lies
- * within the target range. Non-positional features (start=end=0) and contact
- * features are excluded.
+ * Answers a list of all either positional or non-positional features whose
+ * feature group matches the given group (which may be null)
*
- * @param from
- * @param to
- * @param result
+ * @param positional
+ * @param group
+ * @return
*/
- protected void findNonNestedFeatures(long from, long to,
- List result)
+
+ @Override
+ public List getFeaturesForGroup(boolean positional,
+ String group)
{
- int startIndex = binarySearch(nonNestedFeatures, from);
- findNonNestedFeatures(startIndex, from, to, result);
+ List result = new ArrayList<>();
+
+ /*
+ * if we know features don't include the target group, no need
+ * to inspect them for matches
+ */
+ if (positional && !positionalFeatureGroups.contains(group)
+ || !positional && !nonPositionalFeatureGroups.contains(group))
+ {
+ return result;
+ }
+
+ if (positional)
+ {
+ addFeaturesForGroup(group, contactFeatureStarts, result);
+ addFeaturesForGroup(group, features, result);
+ }
+ else
+ {
+ addFeaturesForGroup(group, nonPositionalFeatures, result);
+ }
+ return result;
}
/**
- * Scans the list of non-nested features, starting from startIndex, to find
- * those that overlap the from-to range, and adds them to the result list.
- * Returns the index of the first feature whose start position is after the
- * target range (or the length of the whole list if none such feature exists).
+ * Answers the maximum score held for positional or non-positional features.
+ * This may be Float.NaN if there are no features, are none has a non-NaN
+ * score.
*
- * @param startIndex
- * @param from
- * @param to
- * @param result
+ * @param positional
* @return
*/
- protected int findNonNestedFeatures(final int startIndex, long from,
- long to,
- List result)
+
+ @Override
+ public float getMaximumScore(boolean positional)
{
- int i = startIndex;
- while (i < nonNestedFeatures.size())
- {
- SequenceFeature sf = nonNestedFeatures.get(i);
- if (sf.getBegin() > to)
- {
- break;
- }
- int start = sf.getBegin();
- int end = sf.getEnd();
- if (start <= to && end >= from)
- {
- result.add(sf);
- }
- i++;
- }
- return i;
+ return positional ? positionalMaxScore : nonPositionalMaxScore;
}
/**
- * Performs a binary search of the (sorted) list to find the index of the
- * first entry whose end position is not less than the target position (i.e.
- * skip all features that properly precede the given position)
+ * Answers the minimum score held for positional or non-positional features.
+ * This may be Float.NaN if there are no features, are none has a non-NaN
+ * score.
*
- * @param features
- * @param target
+ * @param positional
* @return
*/
- protected int binarySearch(List features, long target)
+
+ @Override
+ public float getMinimumScore(boolean positional)
{
- int width = features.size() / 2;
- int lastpos = width;
- while (width > 0)
- {
- int end = features.get(lastpos).getEnd();
- width = width / 2;
- if (end > target)
- {
- lastpos -= width;
- }
- else
- {
- lastpos += width;
- }
- }
- // todo correct binary search
- return lastpos > 1 ? lastpos - 2 : 0;
- // return lastpos;
+ return positional ? positionalMinScore : nonPositionalMinScore;
+ }
+
+ @Override
+ public List getNonPositionalFeatures()
+ {
+ return getNonPositionalFeatures(new ArrayList<>());
}
/**
- * Adds contact features whose start position lies in the from-to range to the
- * result list
+ * Answers a list of all non-positional features. If there are none, returns
+ * an immutable empty list.
*
- * @param from
- * @param to
- * @param result
+ * @return
*/
- protected void findContactStartFeatures(long from, long to,
+
+ @Override
+ public List getNonPositionalFeatures(
List result)
{
- // TODO binary search for startPosition
- for (int startPosition = 0; startPosition < contactFeatureStarts.size(); startPosition++)
+ if (nonPositionalFeatures != null)
{
- SequenceFeature sf = contactFeatureStarts.get(startPosition);
- if (!sf.isContactFeature())
- {
- System.err.println("Error! non-contact feature type "
- + sf.getType() + " in contact features list");
- continue;
- }
- int begin = sf.getBegin();
- if (begin >= from && begin <= to)
- {
- result.add(sf);
- }
+ result.addAll(nonPositionalFeatures);
}
+ return result;
+ }
+
+ @Override
+ public List getPositionalFeatures()
+ {
+ return getPositionalFeatures(new ArrayList<>());
}
/**
@@ -525,13 +615,11 @@ public class FeatureStore
*
* @return
*/
- public List getPositionalFeatures()
+
+ @Override
+ public List getPositionalFeatures(
+ List result)
{
- /*
- * add non-nested features (may be all features for many cases)
- */
- List result = new ArrayList();
- result.addAll(nonNestedFeatures);
/*
* add any contact features - from the list by start position
@@ -544,191 +632,138 @@ public class FeatureStore
/*
* add any nested features
*/
- if (nestedFeatures != null)
+ if (features != null)
{
- result.addAll(nestedFeatures.getEntries());
+ result.addAll(features);
}
return result;
}
/**
- * Answers a list of all contact features. If there are none, returns an
- * immutable empty list.
+ * Answers the total length of positional features (or zero if there are
+ * none). Contact features contribute a value of 1 to the total.
*
* @return
*/
- public List getContactFeatures()
+
+ @Override
+ public int getTotalFeatureLength()
{
- if (contactFeatureStarts == null)
- {
- return Collections.emptyList();
- }
- return new ArrayList(contactFeatureStarts);
+ return totalExtent;
}
/**
- * Answers a list of all non-positional features. If there are none, returns
- * an immutable empty list.
+ * Answers true if this store has no features, else false
*
* @return
*/
- public List getNonPositionalFeatures()
+
+ @Override
+ public boolean isEmpty()
{
- if (nonPositionalFeatures == null)
- {
- return Collections.emptyList();
- }
- return new ArrayList(nonPositionalFeatures);
+ boolean hasFeatures = (contactFeatureStarts != null
+ && !contactFeatureStarts.isEmpty())
+ || (nonPositionalFeatures != null
+ && !nonPositionalFeatures.isEmpty())
+ || features.size() > 0;
+
+ return !hasFeatures;
}
/**
- * Deletes the given feature from the store, returning true if it was found
- * (and deleted), else false. This method makes no assumption that the feature
- * is in the 'expected' place in the store, in case it has been modified since
- * it was added.
- *
- * @param sf
+ * Rescan all features to recompute any cached values after an entry has been
+ * deleted. This is expected to be an infrequent event, so performance here is
+ * not critical.
*/
- public synchronized boolean delete(SequenceFeature sf)
+ protected synchronized void rescanAfterDelete()
{
+ positionalFeatureGroups.clear();
+ nonPositionalFeatureGroups.clear();
+ totalExtent = 0;
+ positionalMinScore = Float.NaN;
+ positionalMaxScore = Float.NaN;
+ nonPositionalMinScore = Float.NaN;
+ nonPositionalMaxScore = Float.NaN;
/*
- * try the non-nested positional features first
+ * scan non-positional features for groups and scores
*/
- boolean removed = nonNestedFeatures.remove(sf);
-
- /*
- * if not found, try contact positions (and if found, delete
- * from both lists of contact positions)
- */
- if (!removed && contactFeatureStarts != null)
+ if (nonPositionalFeatures != null)
{
- removed = contactFeatureStarts.remove(sf);
- if (removed)
+ for (SequenceFeature sf : nonPositionalFeatures)
{
- contactFeatureEnds.remove(sf);
+ nonPositionalFeatureGroups.add(sf.getFeatureGroup());
+ float score = sf.getScore();
+ nonPositionalMinScore = min(nonPositionalMinScore, score);
+ nonPositionalMaxScore = max(nonPositionalMaxScore, score);
}
}
- boolean removedNonPositional = false;
-
- /*
- * if not found, try non-positional features
- */
- if (!removed && nonPositionalFeatures != null)
- {
- removedNonPositional = nonPositionalFeatures.remove(sf);
- removed = removedNonPositional;
- }
-
/*
- * if not found, try nested features
+ * scan positional features for groups, scores and extents
*/
- if (!removed && nestedFeatures != null)
- {
- removed = nestedFeatures.delete(sf);
- }
- if (removed)
- {
- rebuildFeatureGroups(sf.getFeatureGroup(), removedNonPositional);
- }
-
- return removed;
+ rescanPositional(contactFeatureStarts);
+ rescanPositional(features);
}
- /**
- * Check whether the given feature group is still represented, in either
- * positional or non-positional features, and if not, remove it from the set
- * of feature groups
- *
- * @param featureGroup
- * @param nonPositional
- */
- protected void rebuildFeatureGroups(String featureGroup,
- boolean nonPositional)
+ private void rescanPositional(Collection sfs)
{
- if (nonPositional && nonPositionalFeatures != null)
+ if (sfs == null)
{
- boolean found = false;
- for (SequenceFeature sf : nonPositionalFeatures)
- {
- String group = sf.getFeatureGroup();
- if (featureGroup == group
- || (featureGroup != null && featureGroup.equals(group)))
- {
- found = true;
- break;
- }
- }
- if (!found)
- {
- nonPositionalFeatureGroups.remove(featureGroup);
- }
+ return;
}
- else if (!findFeatureGroup(featureGroup))
+ for (SequenceFeature sf : sfs)
{
- positionalFeatureGroups.remove(featureGroup);
+ positionalFeatureGroups.add(sf.getFeatureGroup());
+ float score = sf.getScore();
+ positionalMinScore = min(positionalMinScore, score);
+ positionalMaxScore = max(positionalMaxScore, score);
+ totalExtent += getFeatureLength(sf);
}
}
/**
- * Scans all positional features to check whether the given feature group is
- * found, and returns true if found, else false
+ * Adds the shift amount to the start and end of all positional features whose
+ * start position is at or after fromPosition. Returns true if at least one
+ * feature was shifted, else false.
*
- * @param featureGroup
+ * @param fromPosition
+ * @param shiftBy
* @return
*/
- protected boolean findFeatureGroup(String featureGroup)
+
+ @Override
+ public synchronized boolean shiftFeatures(int fromPosition, int shiftBy)
{
+ /*
+ * Because begin and end are final fields (to ensure the data store's
+ * integrity), we have to delete each feature and re-add it as amended.
+ * (Although a simple shift of all values would preserve data integrity!)
+ */
+ boolean modified = false;
for (SequenceFeature sf : getPositionalFeatures())
{
- String group = sf.getFeatureGroup();
- if (group == featureGroup
- || (group != null && group.equals(featureGroup)))
+ if (sf.getBegin() >= fromPosition)
{
- return true;
+ modified = true;
+ int newBegin = sf.getBegin() + shiftBy;
+ int newEnd = sf.getEnd() + shiftBy;
+
+ /*
+ * sanity check: don't shift left of the first residue
+ */
+ if (newEnd > 0)
+ {
+ newBegin = Math.max(1, newBegin);
+ SequenceFeature sf2 = new SequenceFeature(sf, newBegin, newEnd,
+ sf.getFeatureGroup(), sf.getScore());
+ addFeature(sf2);
+ }
+ delete(sf);
}
}
- return false;
- }
-
- /**
- * Answers true if this store has no features, else false
- *
- * @return
- */
- public boolean isEmpty()
- {
- boolean hasFeatures = !nonNestedFeatures.isEmpty()
- || (contactFeatureStarts != null && !contactFeatureStarts
- .isEmpty())
- || (nonPositionalFeatures != null && !nonPositionalFeatures
- .isEmpty())
- || (nestedFeatures != null && nestedFeatures.size() > 0);
-
- return !hasFeatures;
+ return modified;
}
- /**
- * Answers the set of distinct feature groups stored, possibly including null,
- * as an unmodifiable view of the set. The parameter determines whether the
- * groups for positional or for non-positional features are returned.
- *
- * @param positionalFeatures
- * @return
- */
- public Set getFeatureGroups(boolean positionalFeatures)
- {
- if (positionalFeatures)
- {
- return Collections.unmodifiableSet(positionalFeatureGroups);
- }
- else
- {
- return nonPositionalFeatureGroups == null ? Collections
- . emptySet() : Collections
- .unmodifiableSet(nonPositionalFeatureGroups);
- }
- }
}