X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fdatamodel%2Ffeatures%2FFeatureStore.java;h=ccd8b66af9774e88b13d58b6720b3f6feb91484a;hb=8406f2ced29d2c04dbabaf1cde80b1a7fa8ce8ce;hp=bd94c8a5dea1411bcf83d42a3e8ade101493fa8e;hpb=51728d3951398f9c12d7017c776953f17322cc68;p=jalview.git diff --git a/src/jalview/datamodel/features/FeatureStore.java b/src/jalview/datamodel/features/FeatureStore.java index bd94c8a..ccd8b66 100644 --- a/src/jalview/datamodel/features/FeatureStore.java +++ b/src/jalview/datamodel/features/FeatureStore.java @@ -1,32 +1,141 @@ +/* + * Jalview - A Sequence Alignment Editor and Viewer ($$Version-Rel$$) + * Copyright (C) $$Year-Rel$$ The Jalview Authors + * + * This file is part of Jalview. + * + * Jalview is free software: you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, either version 3 + * of the License, or (at your option) any later version. + * + * Jalview is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with Jalview. If not, see . + * The Jalview Authors are detailed in the 'AUTHORS' file. + */ package jalview.datamodel.features; import jalview.datamodel.SequenceFeature; import java.util.ArrayList; +import java.util.Collection; import java.util.Collections; -import java.util.Comparator; +import java.util.HashSet; import java.util.List; +import java.util.Set; -/** - * A data store for a set of sequence features that supports efficient lookup of - * features overlapping a given range. - * - * @author gmcarstairs - * - */ -public class FeatureStore +public abstract class FeatureStore implements FeatureStoreI { - Comparator startOrdering = new RangeComparator(true); - Comparator endOrdering = new RangeComparator(false); + /** + * Answers the 'length' of the feature, counting 0 for non-positional features + * and 1 for contact features + * + * @param feature + * @return + */ + protected static int getFeatureLength(SequenceFeature feature) + { + if (feature.isNonPositional()) + { + return 0; + } + if (feature.isContactFeature()) + { + return 1; + } + return 1 + feature.getEnd() - feature.getBegin(); + } + + /** + * Answers true if the list contains the feature, else false. This method is + * optimised for the condition that the list is sorted on feature start + * position ascending, and will give unreliable results if this does not hold. + * + * @param features + * @param feature + * @return + */ + @Override + public boolean listContains(List features, + SequenceFeature feature) + { + if (features == null || feature == null) + { + return false; + } + + /* + * locate the first entry in the list which does not precede the feature + */ + int pos = findFirstBegin(features, feature.begin); + int len = features.size(); + while (pos < len) + { + SequenceFeature sf = features.get(pos); + if (sf.getBegin() > feature.getBegin()) + { + return false; // no match found + } + if (sf.equals(feature)) + { + return true; + } + pos++; + } + return false; + } + + /** + * A helper method to return the maximum of two floats, where a non-NaN value + * is treated as 'greater than' a NaN value (unlike Math.max which does the + * opposite) + * + * @param f1 + * @param f2 + */ + protected static float max(float f1, float f2) + { + if (Float.isNaN(f1)) + { + return Float.isNaN(f2) ? f1 : f2; + } + else + { + return Float.isNaN(f2) ? f1 : Math.max(f1, f2); + } + } + + /** + * A helper method to return the minimum of two floats, where a non-NaN value + * is treated as 'less than' a NaN value (unlike Math.min which does the + * opposite) + * + * @param f1 + * @param f2 + */ + protected static float min(float f1, float f2) + { + if (Float.isNaN(f1)) + { + return Float.isNaN(f2) ? f1 : f2; + } + else + { + return Float.isNaN(f2) ? f1 : Math.min(f1, f2); + } + } /* - * An ordered list of features, with the promise that no feature in the list - * properly contains any other. This constraint allows bounded linear search - * of the list for features overlapping a region. - * Contact features are not included in this list. + * Non-positional features have no (zero) start/end position. + * Kept as a separate list in case this criterion changes in future. */ - List nonNestedFeatures; + List nonPositionalFeatures; /* * contact features ordered by first contact position @@ -39,407 +148,622 @@ public class FeatureStore List contactFeatureEnds; /* - * Nested Containment List is used to hold any features that are nested - * within (properly contained by) any other feature. This is a recursive tree - * which supports depth-first scan for features overlapping a range. - * It is used here as a 'catch-all' fallback for features that cannot be put - * into a simple ordered list without invalidating the search methods. + * IntervalStore holds remaining features and provides efficient + * query for features overlapping any given interval + */ + Collection features; + + /* + * Feature groups represented in stored positional features + * (possibly including null) + */ + Set positionalFeatureGroups; + + /* + * Feature groups represented in stored non-positional features + * (possibly including null) */ - NCList nestedFeatures; + Set nonPositionalFeatureGroups; + + /* + * the total length of all positional features; contact features count 1 to + * the total and 1 to size(), consistent with an average 'feature length' of 1 + */ + int totalExtent; + + float positionalMinScore; + + float positionalMaxScore; + + float nonPositionalMinScore; + + float nonPositionalMaxScore; /** * Constructor */ public FeatureStore() { - nonNestedFeatures = new ArrayList(); - // we only construct contactFeatures and the NCList if we need to + positionalFeatureGroups = new HashSet<>(); + nonPositionalFeatureGroups = new HashSet<>(); + positionalMinScore = Float.NaN; + positionalMaxScore = Float.NaN; + nonPositionalMinScore = Float.NaN; + nonPositionalMaxScore = Float.NaN; + + // we only construct nonPositionalFeatures, contactFeatures if we need to } /** - * Add one entry to the data store + * Add a contact feature to the lists that hold them ordered by start (first + * contact) and by end (second contact) position, ensuring the lists remain + * ordered, and returns true. This method allows duplicate features to be + * added, so test before calling to avoid this. + * + * @param feature + * @return + */ + protected synchronized boolean addContactFeature(SequenceFeature feature) + { + if (contactFeatureStarts == null) + { + contactFeatureStarts = new ArrayList<>(); + contactFeatureEnds = new ArrayList<>(); + } + + /* + * insert into list sorted by start (first contact position): + * binary search the sorted list to find the insertion point + */ + contactFeatureStarts.add( + findFirstBegin(contactFeatureStarts, feature.begin), feature); + /* + * insert into list sorted by end (second contact position): + * binary search the sorted list to find the insertion point + */ + contactFeatureEnds.add(findFirstEnd(contactFeatureEnds, feature.end), + feature); + + return true; + } + + /** + * Adds one sequence feature to the store, and returns true, unless the + * feature is already contained in the store, in which case this method + * returns false. Containment is determined by SequenceFeature.equals() + * comparison. * * @param feature */ - public void addFeature(SequenceFeature feature) + + @Override + public boolean addFeature(SequenceFeature feature) { + if (contains(feature)) + { + return false; + } + + /* + * keep a record of feature groups + */ + if (!feature.isNonPositional()) + { + positionalFeatureGroups.add(feature.getFeatureGroup()); + } + if (feature.isContactFeature()) { addContactFeature(feature); } + else if (feature.isNonPositional()) + { + addNonPositionalFeature(feature); + } else { - boolean added = addNonNestedFeature(feature); - if (!added) + addNestedFeature(feature); + } + + /* + * record the total extent of positional features, to make + * getTotalFeatureLength possible; we count the length of a + * contact feature as 1 + */ + totalExtent += getFeatureLength(feature); + + /* + * record the minimum and maximum score for positional + * and non-positional features + */ + float score = feature.getScore(); + if (!Float.isNaN(score)) + { + if (feature.isNonPositional()) { - /* - * detected a nested feature - put it in the NCList structure - */ - addNestedFeature(feature); + nonPositionalMinScore = min(nonPositionalMinScore, score); + nonPositionalMaxScore = max(nonPositionalMaxScore, score); + } + else + { + positionalMinScore = min(positionalMinScore, score); + positionalMaxScore = max(positionalMaxScore, score); } } + + return true; } - /** - * Adds one feature to the NCList that can manage nested features (creating - * the NCList if necessary) - */ - protected synchronized void addNestedFeature(SequenceFeature feature) + private void addFeaturesForGroup(String group, + Collection sfs, List result) { - if (nestedFeatures == null) + if (sfs == null) { - nestedFeatures = new NCList(feature); + return; } - else + for (SequenceFeature sf : sfs) { - nestedFeatures.add(feature); + String featureGroup = sf.getFeatureGroup(); + if (group == null && featureGroup == null + || group != null && group.equals(featureGroup)) + { + result.add(sf); + } } } /** - * Add a feature to the list of non-nested features, maintaining the ordering - * of the list. A check is made for whether the feature is nested in (properly - * contained by) an existing feature. If there is no nesting, the feature is - * added to the list and the method returns true. If nesting is found, the - * feature is not added and the method returns false. - *

- * Contact features are added at the position of their first contact point + * Adds one feature to the IntervalStore that can manage nested features + * (creating the IntervalStore if necessary) + */ + abstract protected void addNestedFeature(SequenceFeature feature); + + /** + * Adds the feature to the list of non-positional features (with lazy + * instantiation of the list if it is null), and returns true. The feature + * group is added to the set of distinct feature groups for non-positional + * features. This method allows duplicate features, so test before calling to + * prevent this. * * @param feature - * @return */ - protected boolean addNonNestedFeature(SequenceFeature feature) + protected boolean addNonPositionalFeature(SequenceFeature feature) { - synchronized (nonNestedFeatures) + if (nonPositionalFeatures == null) { - int insertPosition = binarySearchForAdd(nonNestedFeatures, feature); + nonPositionalFeatures = new ArrayList<>(); + } - /* - * fail if we detect feature enclosure - of the new feature by - * the one preceding it, or of the next feature by the new one - */ - if (insertPosition > 0) - { - if (encloses(nonNestedFeatures.get(insertPosition - 1), feature)) - { - return false; - } - } - if (insertPosition < nonNestedFeatures.size()) - { - if (encloses(feature, nonNestedFeatures.get(insertPosition))) - { - return false; - } - } + nonPositionalFeatures.add(feature); - /* - * checks passed - add or append the feature - */ - if (insertPosition == nonNestedFeatures.size()) - { - nonNestedFeatures.add(feature); - } - else - { - nonNestedFeatures.add(insertPosition, feature); - } - return true; - } + nonPositionalFeatureGroups.add(feature.getFeatureGroup()); + + return true; } /** - * Answers true if range1 properly encloses range2, else false + * Answers true if this store contains the given feature (testing by + * SequenceFeature.equals), else false * - * @param range1 - * @param range2 + * @param feature * @return */ - protected boolean encloses(ContiguousI range1, ContiguousI range2) + @Override + public boolean contains(SequenceFeature feature) { - int begin1 = range1.getBegin(); - int begin2 = range2.getBegin(); - int end1 = range1.getEnd(); - int end2 = range2.getEnd(); - if (begin1 == begin2 && end1 > end2) + if (feature.isNonPositional()) { - return true; + return nonPositionalFeatures == null ? false + : nonPositionalFeatures.contains(feature); } - if (begin1 < begin2 && end1 >= end2) + + if (feature.isContactFeature()) { - return true; + return contactFeatureStarts != null + && listContains(contactFeatureStarts, feature); } - return false; + + return features == null ? false : containsFeature(feature); } + + abstract protected boolean containsFeature(SequenceFeature feature); + /** - * Answers the index of the first element in the given list which follows or - * matches the given feature in the sort order. If no such element, answers - * the length of the list. + * Deletes the given feature from the store, returning true if it was found + * (and deleted), else false. This method makes no assumption that the feature + * is in the 'expected' place in the store, in case it has been modified since + * it was added. * - * @param list - * @param feature - * - * @return + * @param sf */ - protected int binarySearchForAdd(List list, SequenceFeature feature) + + @Override + public synchronized boolean delete(SequenceFeature sf) { - // TODO binary search! - int i = 0; - while (i < list.size()) + boolean removed = false; + + /* + * try contact positions (and if found, delete + * from both lists of contact positions) + */ + if (!removed && contactFeatureStarts != null) { - if (startOrdering.compare(nonNestedFeatures.get(i), feature) >= 0) + removed = contactFeatureStarts.remove(sf); + if (removed) { - break; + contactFeatureEnds.remove(sf); } - i++; } - return i; + + boolean removedNonPositional = false; + + /* + * if not found, try non-positional features + */ + if (!removed && nonPositionalFeatures != null) + { + removedNonPositional = nonPositionalFeatures.remove(sf); + removed = removedNonPositional; + } + + /* + * if not found, try nested features + */ + if (!removed && features != null) + { + removed = features.remove(sf); + } + + if (removed) + { + rescanAfterDelete(); + } + + return removed; + } + + abstract protected void findContactFeatures(long from, long to, + List result); + + abstract protected int findFirstBegin(List list, + long pos); + + abstract protected int findFirstEnd(List list, long pos); + + @Override + public List findOverlappingFeatures(long start, long end) + { + return findOverlappingFeatures(start, end, null); + } + + @Override + public List getContactFeatures() + { + return getContactFeatures(new ArrayList<>()); } /** - * Add a contact feature to the lists that hold them ordered by start (first - * contact) and by end (second contact) position, ensuring the lists remain - * ordered + * Answers a list of all contact features. If there are none, returns an + * immutable empty list. * - * @param feature + * @return */ - protected synchronized void addContactFeature(SequenceFeature feature) + + @Override + public List getContactFeatures( + List result) { - // TODO binary search for insertion points! - if (contactFeatureStarts == null) - { - contactFeatureStarts = new ArrayList(); - } - if (contactFeatureEnds == null) + if (contactFeatureStarts != null) { - contactFeatureEnds = new ArrayList(); + result.addAll(contactFeatureStarts); } - contactFeatureStarts.add(feature); - Collections.sort(contactFeatureStarts, startOrdering); - contactFeatureEnds.add(feature); - Collections.sort(contactFeatureEnds, endOrdering); + return result; } /** - * Returns a (possibly empty) list of entries whose range overlaps the given - * range. The returned list is not ordered. Contact features are included if - * either of the contact points lies within the range. + * Answers the number of positional (or non-positional) features stored. + * Contact features count as 1. * - * @param start - * start position of overlap range (inclusive) - * @param end - * end position of overlap range (inclusive) + * @param positional * @return */ - public List findOverlappingFeatures(long start, long end) + + @Override + public int getFeatureCount(boolean positional) { - List result = new ArrayList(); + if (!positional) + { + return nonPositionalFeatures == null ? 0 + : nonPositionalFeatures.size(); + } - findNonNestedFeatures(start, end, result); + return (contactFeatureStarts == null ? 0 : contactFeatureStarts.size()) + + features.size(); - findContactFeatures(start, end, result); + } - if (nestedFeatures != null) + /** + * Answers the set of distinct feature groups stored, possibly including null, + * as an unmodifiable view of the set. The parameter determines whether the + * groups for positional or for non-positional features are returned. + * + * @param positionalFeatures + * @return + */ + + @Override + public Set getFeatureGroups(boolean positionalFeatures) + { + if (positionalFeatures) + { + return Collections.unmodifiableSet(positionalFeatureGroups); + } + else { - result.addAll(nestedFeatures.findOverlaps(start, end)); + return nonPositionalFeatureGroups == null + ? Collections. emptySet() + : Collections.unmodifiableSet(nonPositionalFeatureGroups); } + } - return result; + @Override + public Collection getFeatures() + { + return features; } /** - * Adds contact features to the result list where either the second or the - * first contact position lies within the target range. + * Answers a list of all either positional or non-positional features whose + * feature group matches the given group (which may be null) * - * @param from - * @param to - * @param result + * @param positional + * @param group + * @return */ - protected void findContactFeatures(long from, long to, - List result) + + @Override + public List getFeaturesForGroup(boolean positional, + String group) { - if (contactFeatureStarts != null) + List result = new ArrayList<>(); + + /* + * if we know features don't include the target group, no need + * to inspect them for matches + */ + if (positional && !positionalFeatureGroups.contains(group) + || !positional && !nonPositionalFeatureGroups.contains(group)) { - findContactStartFeatures(from, to, result); + return result; } - if (contactFeatureEnds != null) + + if (positional) { - findContactEndFeatures(from, to, result); + addFeaturesForGroup(group, contactFeatureStarts, result); + addFeaturesForGroup(group, features, result); } + else + { + addFeaturesForGroup(group, nonPositionalFeatures, result); + } + return result; } /** - * @param from - * @param to - * @param result + * Answers the maximum score held for positional or non-positional features. + * This may be Float.NaN if there are no features, are none has a non-NaN + * score. + * + * @param positional + * @return */ - protected void findContactEndFeatures(long from, long to, - List result) + + @Override + public float getMaximumScore(boolean positional) { - // TODO binary search for startPosition - for (int startPosition = 0; startPosition < contactFeatureEnds.size(); startPosition++) - { - SequenceFeature sf = contactFeatureEnds.get(startPosition); - if (!sf.isContactFeature()) - { - System.err.println("Error! non-contact feature type " - + sf.getType() + " in contact features list"); - continue; - } - int begin = sf.getBegin(); - if (begin >= from && begin <= to) - { - /* - * this feature's first contact position lies in the search range - * so we don't include it in results a second time - */ - continue; - } - int end = sf.getEnd(); - if (end >= from && end <= to) - { - result.add(sf); - } - } + return positional ? positionalMaxScore : nonPositionalMaxScore; } /** - * Returns the index of the first contact feature found whose end (second - * contact position) is not before the given start position. If no such - * feature is found, returns the length of the contact features list. + * Answers the minimum score held for positional or non-positional features. + * This may be Float.NaN if there are no features, are none has a non-NaN + * score. * - * @param start + * @param positional * @return */ - protected int contactsBinarySearch(long start) + + @Override + public float getMinimumScore(boolean positional) { - // TODO binary search!! - int i = 0; - while (i < contactFeatureEnds.size()) - { - if (contactFeatureEnds.get(i).getEnd() >= start) - { - break; - } - i++; - } + return positional ? positionalMinScore : nonPositionalMinScore; + } - return i; + @Override + public List getNonPositionalFeatures() + { + return getNonPositionalFeatures(new ArrayList<>()); } /** - * Adds features to the result list that are at a single position which lies - * within the target range. Non-positional features (start=end=0) and contact - * features are excluded. + * Answers a list of all non-positional features. If there are none, returns + * an immutable empty list. * - * @param from - * @param to - * @param result + * @return */ - protected void findNonNestedFeatures(long from, long to, + + @Override + public List getNonPositionalFeatures( List result) { - int startIndex = binarySearch(nonNestedFeatures, from); - findNonNestedFeatures(startIndex, from, to, result); + if (nonPositionalFeatures != null) + { + result.addAll(nonPositionalFeatures); + } + return result; + } + + @Override + public List getPositionalFeatures() + { + return getPositionalFeatures(new ArrayList<>()); } /** - * Scans the list of non-nested features, starting from startIndex, to find - * those that overlap the from-to range, and adds them to the result list. - * Returns the index of the first feature whose start position is after the - * target range (or the length of the whole list if none such feature exists). + * Answers a list of all positional features stored, in no guaranteed order * - * @param startIndex - * @param from - * @param to - * @param result * @return */ - protected int findNonNestedFeatures(final int startIndex, long from, - long to, + + @Override + public List getPositionalFeatures( List result) { - int i = startIndex; - while (i < nonNestedFeatures.size()) + + /* + * add any contact features - from the list by start position + */ + if (contactFeatureStarts != null) { - SequenceFeature sf = nonNestedFeatures.get(i); - if (sf.getBegin() > to) - { - break; - } - int start = sf.getBegin(); - int end = sf.getEnd(); - if (sf.isContactFeature()) - { - end = start; - } - if (start <= to && end >= from) - { - result.add(sf); - } - i++; + result.addAll(contactFeatureStarts); } - return i; + + /* + * add any nested features + */ + if (features != null) + { + result.addAll(features); + } + + return result; } /** - * Performs a binary search of the (sorted) list to find the index of the - * first entry whose end position is not less than the target position (i.e. - * skip all features that properly precede the given position) + * Answers the total length of positional features (or zero if there are + * none). Contact features contribute a value of 1 to the total. + * + * @return + */ + + @Override + public int getTotalFeatureLength() + { + return totalExtent; + } + + /** + * Answers true if this store has no features, else false * - * @param features - * @param target * @return */ - protected int binarySearch(List features, long target) + + @Override + public boolean isEmpty() + { + boolean hasFeatures = (contactFeatureStarts != null + && !contactFeatureStarts.isEmpty()) + || (nonPositionalFeatures != null + && !nonPositionalFeatures.isEmpty()) + || features.size() > 0; + + return !hasFeatures; + } + + /** + * Rescan all features to recompute any cached values after an entry has been + * deleted. This is expected to be an infrequent event, so performance here is + * not critical. + */ + protected synchronized void rescanAfterDelete() { - int width = features.size() / 2; - int lastpos = width; - while (width > 0) + positionalFeatureGroups.clear(); + nonPositionalFeatureGroups.clear(); + totalExtent = 0; + positionalMinScore = Float.NaN; + positionalMaxScore = Float.NaN; + nonPositionalMinScore = Float.NaN; + nonPositionalMaxScore = Float.NaN; + /* + * scan non-positional features for groups and scores + */ + if (nonPositionalFeatures != null) { - int end = features.get(lastpos).getEnd(); - width = width / 2; - if (end > target) + for (SequenceFeature sf : nonPositionalFeatures) { - lastpos -= width; - } - else - { - lastpos += width; + nonPositionalFeatureGroups.add(sf.getFeatureGroup()); + float score = sf.getScore(); + nonPositionalMinScore = min(nonPositionalMinScore, score); + nonPositionalMaxScore = max(nonPositionalMaxScore, score); } } - // todo correct binary search - return lastpos > 1 ? lastpos - 2 : 0; - // return lastpos; + + /* + * scan positional features for groups, scores and extents + */ + + rescanPositional(contactFeatureStarts); + rescanPositional(features); + } + + private void rescanPositional(Collection sfs) + { + if (sfs == null) + { + return; + } + for (SequenceFeature sf : sfs) + { + positionalFeatureGroups.add(sf.getFeatureGroup()); + float score = sf.getScore(); + positionalMinScore = min(positionalMinScore, score); + positionalMaxScore = max(positionalMaxScore, score); + totalExtent += getFeatureLength(sf); + } } /** - * Adds contact features whose start position lies in the from-to range to the - * result list + * Adds the shift amount to the start and end of all positional features whose + * start position is at or after fromPosition. Returns true if at least one + * feature was shifted, else false. * - * @param from - * @param to - * @param result + * @param fromPosition + * @param shiftBy + * @return */ - protected void findContactStartFeatures(long from, long to, - List result) + + @Override + public synchronized boolean shiftFeatures(int fromPosition, int shiftBy) { - // TODO binary search for startPosition - for (int startPosition = 0; startPosition < contactFeatureStarts.size(); startPosition++) + /* + * Because begin and end are final fields (to ensure the data store's + * integrity), we have to delete each feature and re-add it as amended. + * (Although a simple shift of all values would preserve data integrity!) + */ + boolean modified = false; + for (SequenceFeature sf : getPositionalFeatures()) { - SequenceFeature sf = contactFeatureStarts.get(startPosition); - if (!sf.isContactFeature()) + if (sf.getBegin() >= fromPosition) { - System.err.println("Error! non-contact feature type " - + sf.getType() + " in contact features list"); - continue; - } - int begin = sf.getBegin(); - if (begin >= from && begin <= to) - { - result.add(sf); + modified = true; + int newBegin = sf.getBegin() + shiftBy; + int newEnd = sf.getEnd() + shiftBy; + + /* + * sanity check: don't shift left of the first residue + */ + if (newEnd > 0) + { + newBegin = Math.max(1, newBegin); + SequenceFeature sf2 = new SequenceFeature(sf, newBegin, newEnd, + sf.getFeatureGroup(), sf.getScore()); + addFeature(sf2); + } + delete(sf); } } + return modified; } + }