X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fdatamodel%2Fxdb%2Fembl%2FEmblFeatureLocations.java;h=94105ae6f5efec4f292e2c13ea7e8e8b0513d35e;hb=17e77c3f2949a0729322b4a8d907f3f34b6a9914;hp=fd4de3c4dc0c26881e7d34f874529b88021f1d89;hpb=b2f9a8d7bce642ff4011bc6d49e02bb0569fbb11;p=jalview.git

diff --git a/src/jalview/datamodel/xdb/embl/EmblFeatureLocations.java b/src/jalview/datamodel/xdb/embl/EmblFeatureLocations.java
index fd4de3c..94105ae 100644
--- a/src/jalview/datamodel/xdb/embl/EmblFeatureLocations.java
+++ b/src/jalview/datamodel/xdb/embl/EmblFeatureLocations.java
@@ -1,29 +1,36 @@
 /*
- * Jalview - A Sequence Alignment Editor and Viewer (Version 2.8.1)
- * Copyright (C) 2014 The Jalview Authors
+ * Jalview - A Sequence Alignment Editor and Viewer (Version 2.9)
+ * Copyright (C) 2015 The Jalview Authors
  * 
  * This file is part of Jalview.
  * 
  * Jalview is free software: you can redistribute it and/or
  * modify it under the terms of the GNU General Public License 
- * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+ * as published by the Free Software Foundation, either version 3
+ * of the License, or (at your option) any later version.
  *  
  * Jalview is distributed in the hope that it will be useful, but 
  * WITHOUT ANY WARRANTY; without even the implied warranty 
  * of MERCHANTABILITY or FITNESS FOR A PARTICULAR 
  * PURPOSE.  See the GNU General Public License for more details.
  * 
- * You should have received a copy of the GNU General Public License along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the GNU General Public License
+ * along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
  * The Jalview Authors are detailed in the 'AUTHORS' file.
  */
 package jalview.datamodel.xdb.embl;
 
-import java.util.Enumeration;
 import java.util.Vector;
 
+/**
+ * Data model for a &lt;loctaion&gt; child element of a &lt;feature&gt; read
+ * from an EMBL query reply
+ * 
+ * @see embl_mapping.xml
+ */
 public class EmblFeatureLocations
 {
-  Vector locElements;
+  Vector<EmblFeatureLocElement> locElements;
 
   String locationType;
 
@@ -66,7 +73,7 @@ public class EmblFeatureLocations
   /**
    * @return the locElements
    */
-  public Vector getLocElements()
+  public Vector<EmblFeatureLocElement> getLocElements()
   {
     return locElements;
   }
@@ -75,7 +82,7 @@ public class EmblFeatureLocations
    * @param locElements
    *          the locElements to set
    */
-  public void setLocElements(Vector locElements)
+  public void setLocElements(Vector<EmblFeatureLocElement> locElements)
   {
     this.locElements = locElements;
   }
@@ -108,12 +115,10 @@ public class EmblFeatureLocations
   {
     int sepos = 0;
     int[] se = new int[locElements.size() * 2];
-    if (locationType.equalsIgnoreCase("single"))
+    if (locationType.equalsIgnoreCase("single")) // TODO: or "simple" ?
     {
-      for (Enumeration le = locElements.elements(); le.hasMoreElements();)
+      for (EmblFeatureLocElement loce : locElements)
       {
-        EmblFeatureLocElement loce = (EmblFeatureLocElement) le
-                .nextElement();
         if (accession == null || loce.accession != null
                 && accession.equals(loce.accession))
         {
@@ -128,10 +133,8 @@ public class EmblFeatureLocations
     }
     else if (locationType.equalsIgnoreCase("join"))
     {
-      for (Enumeration le = locElements.elements(); le.hasMoreElements();)
+      for (EmblFeatureLocElement loce : locElements)
       {
-        EmblFeatureLocElement loce = (EmblFeatureLocElement) le
-                .nextElement();
         if (accession == null || loce.accession != null
                 && accession.equals(loce.accession))
         {
@@ -148,13 +151,17 @@ public class EmblFeatureLocations
     else if (locationType != null)
     {
       if (jalview.bin.Cache.log != null)
+      {
         jalview.bin.Cache.log
                 .error("EmbleFeatureLocations.getElementRanges cannot deal with locationType=='"
                         + locationType + "'");
+      }
       else
+      {
         System.err
                 .println("EmbleFeatureLocations.getElementRanges cannot deal with locationType=='"
                         + locationType + "'");
+      }
     }
     // trim range if necessary.
     if (se != null && sepos != se.length)