X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fext%2Fensembl%2FEnsemblGene.java;h=75a7154595a919bf1f7454224813c8e50a519e22;hb=ee19482a42988b76fdca9d46065ce2ca14ea73c5;hp=7648536487ea8ceb99a6fdf1f1044b3b80b78600;hpb=cd268aa5e06c4327489110c59c987e3e071eb038;p=jalview.git diff --git a/src/jalview/ext/ensembl/EnsemblGene.java b/src/jalview/ext/ensembl/EnsemblGene.java index 7648536..75a7154 100644 --- a/src/jalview/ext/ensembl/EnsemblGene.java +++ b/src/jalview/ext/ensembl/EnsemblGene.java @@ -23,7 +23,6 @@ package jalview.ext.ensembl; import jalview.api.FeatureColourI; import jalview.api.FeatureSettingsModelI; import jalview.datamodel.AlignmentI; -import jalview.datamodel.DBRefEntry; import jalview.datamodel.GeneLociI; import jalview.datamodel.Sequence; import jalview.datamodel.SequenceFeature; @@ -34,6 +33,7 @@ import jalview.io.gff.SequenceOntologyI; import jalview.schemes.FeatureColour; import jalview.schemes.FeatureSettingsAdapter; import jalview.util.MapList; +import jalview.util.Platform; import java.awt.Color; import java.io.UnsupportedEncodingException; @@ -62,6 +62,8 @@ public class EnsemblGene extends EnsemblSeqProxy EnsemblFeatureType.exon, EnsemblFeatureType.cds, EnsemblFeatureType.variation }; + private static final String CHROMOSOME = "chromosome"; + /** * Default constructor (to use rest.ensembl.org) */ @@ -138,7 +140,6 @@ public class EnsemblGene extends EnsemblSeqProxy * convert to a non-duplicated list of gene identifiers */ List geneIds = getGeneIds(query); - AlignmentI al = null; for (String geneId : geneIds) { @@ -150,14 +151,12 @@ public class EnsemblGene extends EnsemblSeqProxy { continue; } - + if (geneAlignment.getHeight() == 1) { // ensure id has 'correct' case for the Ensembl identifier geneId = geneAlignment.getSequenceAt(0).getName(); - findGeneLoci(geneAlignment.getSequenceAt(0), geneId); - getTranscripts(geneAlignment, geneId); } if (al == null) @@ -187,7 +186,7 @@ public class EnsemblGene extends EnsemblSeqProxy if (geneLoci != null) { seq.setGeneLoci(geneLoci.getSpeciesId(), geneLoci.getAssemblyId(), - geneLoci.getChromosomeId(), geneLoci.getMap()); + geneLoci.getChromosomeId(), geneLoci.getMapping()); } else { @@ -209,7 +208,7 @@ public class EnsemblGene extends EnsemblSeqProxy return false; } String[] tokens = description.split(":"); - if (tokens.length == 6 && tokens[0].startsWith(DBRefEntry.CHROMOSOME)) + if (tokens.length == 6 && tokens[0].startsWith(CHROMOSOME)) { String ref = tokens[1]; String chrom = tokens[2]; @@ -319,8 +318,8 @@ public class EnsemblGene extends EnsemblSeqProxy SequenceOntologyI.NMD_TRANSCRIPT_VARIANT, SequenceOntologyI.TRANSCRIPT, SequenceOntologyI.EXON, SequenceOntologyI.CDS }; - List sfs = gene.getFeatures().getFeaturesByOntology( - soTerms); + List sfs = gene.getFeatures() + .getFeaturesByOntology(soTerms); for (SequenceFeature sf : sfs) { gene.deleteFeature(sf); @@ -460,7 +459,7 @@ public class EnsemblGene extends EnsemblSeqProxy return; } - MapList geneMapping = loci.getMap(); + MapList geneMapping = loci.getMapping(); List exons = mapping.getFromRanges(); List transcriptLoci = new ArrayList<>(); @@ -470,8 +469,9 @@ public class EnsemblGene extends EnsemblSeqProxy transcriptLoci.add(geneMapping.locateInTo(exon[0], exon[1])); } - List transcriptRange = Arrays.asList(new int[] { - transcript.getStart(), transcript.getEnd() }); + List transcriptRange = Arrays + .asList(new int[] + { transcript.getStart(), transcript.getEnd() }); MapList mapList = new MapList(transcriptRange, transcriptLoci, 1, 1); transcript.setGeneLoci(loci.getSpeciesId(), loci.getAssemblyId(), @@ -539,10 +539,11 @@ public class EnsemblGene extends EnsemblSeqProxy @Override public String getTestQuery() { - return "ENSG00000157764"; // BRAF, 5 transcripts, reverse strand + return Platform.isJS() ? "ENSG00000123569" : "ENSG00000157764"; + // ENSG00000123569 // H2BFWT histone, 2 transcripts, reverse strand + // ENSG00000157764 // BRAF, 5 transcripts, reverse strand // ENSG00000090266 // NDUFB2, 15 transcripts, forward strand // ENSG00000101812 // H2BFM histone, 3 transcripts, forward strand - // ENSG00000123569 // H2BFWT histone, 2 transcripts, reverse strand } /** @@ -628,10 +629,10 @@ public class EnsemblGene extends EnsemblSeqProxy SequenceOntologyI so = SequenceOntologyFactory.getInstance(); @Override - public boolean isFeatureDisplayed(String type) + public boolean isFeatureHidden(String type) { - return (so.isA(type, SequenceOntologyI.EXON) - || so.isA(type, SequenceOntologyI.SEQUENCE_VARIANT)); + return (!so.isA(type, SequenceOntologyI.EXON) + && !so.isA(type, SequenceOntologyI.SEQUENCE_VARIANT)); } @Override