If you use Jalview, please cite:"
+ + " Waterhouse, A.M., Procter, J.B., Martin, D.M.A, Clamp, M. and Barton, G. J. (2009)"
+ + " Jalview Version 2 - a multiple sequence alignment editor and analysis workbench"
+ + " Bioinformatics doi: 10.1093/bioinformatics/btp033");
+ CITATION = sb.toString();
+ }
private static final String DEFAULT_AUTHORS = "The Jalview Authors (See AUTHORS file for current list)";
@@ -154,12 +183,14 @@ public class Desktop extends jalview.jbgui.GDesktop
private static final String EXPERIMENTAL_FEATURES = "EXPERIMENTAL_FEATURES";
- protected static final String CONFIRM_KEYBOARD_QUIT = "CONFIRM_KEYBOARD_QUIT";
+ public static final String CONFIRM_KEYBOARD_QUIT = "CONFIRM_KEYBOARD_QUIT";
public static HashMap savingFiles = new HashMap();
private JalviewChangeSupport changeSupport = new JalviewChangeSupport();
+ public static boolean nosplash = false;
+
/**
* news reader - null if it was never started.
*/
@@ -367,26 +398,54 @@ public class Desktop extends jalview.jbgui.GDesktop
doConfigureStructurePrefs();
setTitle(ChannelProperties.getProperty("app_name") + " "
+ Cache.getProperty("VERSION"));
- /*
- if (!Platform.isAMac())
- {
- // this.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
- }
- else
- {
- this.setDefaultCloseOperation(WindowConstants.DO_NOTHING_ON_CLOSE);
- }
- */
- try
- {
- APQHandlers.setAPQHandlers(this);
- } catch (Throwable t)
+ /**
+ * Set taskbar "grouped windows" name for linux desktops (works in GNOME and
+ * KDE). This uses sun.awt.X11.XToolkit.awtAppClassName which is not
+ * officially documented or guaranteed to exist, so we access it via
+ * reflection. There appear to be unfathomable criteria about what this
+ * string can contain, and it if doesn't meet those criteria then "java"
+ * (KDE) or "jalview-bin-Jalview" (GNOME) is used. "Jalview", "Jalview
+ * Develop" and "Jalview Test" seem okay, but "Jalview non-release" does
+ * not. The reflection access may generate a warning: WARNING: An illegal
+ * reflective access operation has occurred WARNING: Illegal reflective
+ * access by jalview.gui.Desktop () to field
+ * sun.awt.X11.XToolkit.awtAppClassName which I don't think can be avoided.
+ */
+ if (Platform.isLinux())
{
- System.out.println("Error setting APQHandlers: " + t.toString());
- // t.printStackTrace();
+ try
+ {
+ Toolkit xToolkit = Toolkit.getDefaultToolkit();
+ Field[] declaredFields = xToolkit.getClass().getDeclaredFields();
+ Field awtAppClassNameField = null;
+
+ if (Arrays.stream(declaredFields)
+ .anyMatch(f -> f.getName().equals("awtAppClassName")))
+ {
+ awtAppClassNameField = xToolkit.getClass()
+ .getDeclaredField("awtAppClassName");
+ }
+
+ String title = ChannelProperties.getProperty("app_name");
+ if (awtAppClassNameField != null)
+ {
+ awtAppClassNameField.setAccessible(true);
+ awtAppClassNameField.set(xToolkit, title);
+ }
+ else
+ {
+ jalview.bin.Console.debug("XToolkit: awtAppClassName not found");
+ }
+ } catch (Exception e)
+ {
+ jalview.bin.Console.debug("Error setting awtAppClassName");
+ jalview.bin.Console.trace(Cache.getStackTraceString(e));
+ }
}
+ setIconImages(ChannelProperties.getIconList());
+
addWindowListener(new WindowAdapter()
{
@@ -462,15 +521,17 @@ public class Desktop extends jalview.jbgui.GDesktop
checkURLLinks();
// Spawn a thread that shows the splashscreen
-
- SwingUtilities.invokeLater(new Runnable()
+ if (!nosplash)
{
- @Override
- public void run()
+ SwingUtilities.invokeLater(new Runnable()
{
- new SplashScreen(true);
- }
- });
+ @Override
+ public void run()
+ {
+ new SplashScreen(true);
+ }
+ });
+ }
// Thread off a new instance of the file chooser - this reduces the time
// it
@@ -480,11 +541,11 @@ public class Desktop extends jalview.jbgui.GDesktop
@Override
public void run()
{
- Cache.log.debug("Filechooser init thread started.");
+ jalview.bin.Console.debug("Filechooser init thread started.");
String fileFormat = Cache.getProperty("DEFAULT_FILE_FORMAT");
JalviewFileChooser.forRead(Cache.getProperty("LAST_DIRECTORY"),
fileFormat);
- Cache.log.debug("Filechooser init thread finished.");
+ jalview.bin.Console.debug("Filechooser init thread finished.");
}
}).start();
// Add the service change listener
@@ -495,8 +556,9 @@ public class Desktop extends jalview.jbgui.GDesktop
@Override
public void propertyChange(PropertyChangeEvent evt)
{
- Cache.log.debug("Firing service changed event for "
- + evt.getNewValue());
+ jalview.bin.Console
+ .debug("Firing service changed event for "
+ + evt.getNewValue());
JalviewServicesChanged(evt);
}
});
@@ -535,7 +597,6 @@ public class Desktop extends jalview.jbgui.GDesktop
}
});
desktop.addMouseListener(ma);
-
}
/**
@@ -562,8 +623,9 @@ public class Desktop extends jalview.jbgui.GDesktop
Cache.getDefault(Preferences.ADD_TEMPFACT_ANN, true));
ssm.setProcessSecondaryStructure(
Cache.getDefault(Preferences.STRUCT_FROM_PDB, true));
+ // JAL-3915 - RNAView is no longer an option so this has no effect
ssm.setSecStructServices(
- Cache.getDefault(Preferences.USE_RNAVIEW, true));
+ Cache.getDefault(Preferences.USE_RNAVIEW, false));
}
else
{
@@ -582,35 +644,39 @@ public class Desktop extends jalview.jbgui.GDesktop
@Override
public void run()
{
- Cache.log.debug("Starting news thread.");
+ jalview.bin.Console.debug("Starting news thread.");
jvnews = new BlogReader(me);
showNews.setVisible(true);
- Cache.log.debug("Completed news thread.");
+ jalview.bin.Console.debug("Completed news thread.");
}
}).start();
}
public void getIdentifiersOrgData()
{
- // Thread off the identifiers fetcher
- new Thread(new Runnable()
- {
- @Override
- public void run()
+ if (Cache.getProperty("NOIDENTIFIERSSERVICE") == null)
+ {// Thread off the identifiers fetcher
+ new Thread(new Runnable()
{
- Cache.log.debug("Downloading data from identifiers.org");
- try
- {
- UrlDownloadClient.download(IdOrgSettings.getUrl(),
- IdOrgSettings.getDownloadLocation());
- } catch (IOException e)
+ @Override
+ public void run()
{
- Cache.log.debug("Exception downloading identifiers.org data"
- + e.getMessage());
+ jalview.bin.Console
+ .debug("Downloading data from identifiers.org");
+ try
+ {
+ UrlDownloadClient.download(IdOrgSettings.getUrl(),
+ IdOrgSettings.getDownloadLocation());
+ } catch (IOException e)
+ {
+ jalview.bin.Console
+ .debug("Exception downloading identifiers.org data"
+ + e.getMessage());
+ }
}
- }
- }).start();
-
+ }).start();
+ ;
+ }
}
@Override
@@ -621,7 +687,7 @@ public class Desktop extends jalview.jbgui.GDesktop
void showNews(boolean visible)
{
- Cache.log.debug((visible ? "Showing" : "Hiding") + " news.");
+ jalview.bin.Console.debug((visible ? "Showing" : "Hiding") + " news.");
showNews.setSelected(visible);
if (visible && !jvnews.isVisible())
{
@@ -677,17 +743,17 @@ public class Desktop extends jalview.jbgui.GDesktop
ih = (int) (ih * sh);
while (ix >= screenSize.width)
{
- Cache.log.debug(
+ jalview.bin.Console.debug(
"Window geometry location recall error: shifting horizontal to within screenbounds.");
ix -= screenSize.width;
}
while (iy >= screenSize.height)
{
- Cache.log.debug(
+ jalview.bin.Console.debug(
"Window geometry location recall error: shifting vertical to within screenbounds.");
iy -= screenSize.height;
}
- Cache.log.debug(
+ jalview.bin.Console.debug(
"Got last known dimensions for " + windowName + ": x:" + ix
+ " y:" + iy + " width:" + iw + " height:" + ih);
}
@@ -825,15 +891,17 @@ public class Desktop extends jalview.jbgui.GDesktop
int w, int h, boolean resizable, boolean ignoreMinSize)
{
+ JFrame extFrame = new JFrame();
+ extFrame.setContentPane(frame);
// TODO: allow callers to determine X and Y position of frame (eg. via
// bounds object).
// TODO: consider fixing method to update entries in the window submenu with
// the current window title
- frame.setTitle(title);
- if (frame.getWidth() < 1 || frame.getHeight() < 1)
+ extFrame.setTitle(title);
+ if (extFrame.getWidth() < 1 || extFrame.getHeight() < 1)
{
- frame.setSize(w, h);
+ extFrame.setSize(w, h);
}
// THIS IS A PUBLIC STATIC METHOD, SO IT MAY BE CALLED EVEN IN
// A HEADLESS STATE WHEN NO DESKTOP EXISTS. MUST RETURN
@@ -849,7 +917,7 @@ public class Desktop extends jalview.jbgui.GDesktop
if (!ignoreMinSize)
{
- frame.setMinimumSize(
+ extFrame.setMinimumSize(
new Dimension(DEFAULT_MIN_WIDTH, DEFAULT_MIN_HEIGHT));
// Set default dimension for Alignment Frame window.
@@ -858,7 +926,7 @@ public class Desktop extends jalview.jbgui.GDesktop
// I did this here in order not to miss out on any Alignment frame.
if (frame instanceof AlignFrame)
{
- frame.setMinimumSize(new Dimension(ALIGN_FRAME_DEFAULT_MIN_WIDTH,
+ extFrame.setMinimumSize(new Dimension(ALIGN_FRAME_DEFAULT_MIN_WIDTH,
ALIGN_FRAME_DEFAULT_MIN_HEIGHT));
}
}
@@ -877,8 +945,8 @@ public class Desktop extends jalview.jbgui.GDesktop
}
/*
- * add an entry for the new frame in the Window menu
- * (and remove it when the frame is closed)
+ * add an entry for the new frame in the Window menu (and remove it when the
+ * frame is closed)
*/
final JMenuItem menuItem = new JMenuItem(title);
frame.addInternalFrameListener(new InternalFrameAdapter()
@@ -903,8 +971,7 @@ public class Desktop extends jalview.jbgui.GDesktop
PaintRefresher.RemoveComponent(frame);
/*
- * defensive check to prevent frames being
- * added half off the window
+ * defensive check to prevent frames being added half off the window
*/
if (openFrameCount > 0)
{
@@ -933,28 +1000,27 @@ public class Desktop extends jalview.jbgui.GDesktop
frame.setIcon(false);
} catch (java.beans.PropertyVetoException ex)
{
- // System.err.println(ex.toString());
+
}
}
});
setKeyBindings(frame);
- desktop.add(frame);
+ // desktop.add(frame);
windowMenu.add(menuItem);
- frame.toFront();
+ extFrame.pack();
+ extFrame.setVisible(true);
+ extFrame.toFront();
try
{
- frame.setSelected(true);
- frame.requestFocus();
- } catch (java.beans.PropertyVetoException ve)
- {
+ extFrame.requestFocus();
} catch (java.lang.ClassCastException cex)
{
- Cache.log.warn(
- "Squashed a possible GUI implementation error. If you can recreate this, please look at http://issues.jalview.org/browse/JAL-869",
+ jalview.bin.Console.warn(
+ "Squashed a possible GUI implementation error. If you can recreate this, please look at https://issues.jalview.org/browse/JAL-869",
cex);
}
}
@@ -1122,8 +1188,8 @@ public class Desktop extends jalview.jbgui.GDesktop
/*
* Call IdentifyFile to verify the file contains what its extension implies.
- * Skip this step for dynamically added file formats, because
- * IdentifyFile does not know how to recognise them.
+ * Skip this step for dynamically added file formats, because IdentifyFile does
+ * not know how to recognise them.
*/
if (FileFormats.getInstance().isIdentifiable(format))
{
@@ -1161,12 +1227,11 @@ public class Desktop extends jalview.jbgui.GDesktop
panel.add(label);
/*
- * the URL to fetch is
- * Java: an editable combobox with history
- * JS: (pending JAL-3038) a plain text field
+ * the URL to fetch is input in Java: an editable combobox with history JS:
+ * (pending JAL-3038) a plain text field
*/
JComponent history;
- String urlBase = "http://www.";
+ String urlBase = "https://www.";
if (Platform.isJS())
{
history = new JTextField(urlBase, 35);
@@ -1204,10 +1269,10 @@ public class Desktop extends jalview.jbgui.GDesktop
@SuppressWarnings("unchecked")
String url = (history instanceof JTextField
? ((JTextField) history).getText()
- : ((JComboBox) history).getSelectedItem()
- .toString());
+ : ((JComboBox) history).getEditor().getItem()
+ .toString().trim());
- if (url.toLowerCase().endsWith(".jar"))
+ if (url.toLowerCase(Locale.ROOT).endsWith(".jar"))
{
if (viewport != null)
{
@@ -1321,9 +1386,9 @@ public class Desktop extends jalview.jbgui.GDesktop
private void storeLastKnownDimensions(String string, Rectangle jc)
{
- Cache.log.debug("Storing last known dimensions for " + string + ": x:"
- + jc.x + " y:" + jc.y + " width:" + jc.width + " height:"
- + jc.height);
+ jalview.bin.Console.debug("Storing last known dimensions for " + string
+ + ": x:" + jc.x + " y:" + jc.y + " width:" + jc.width
+ + " height:" + jc.height);
Cache.setProperty(string + "SCREEN_X", jc.x + "");
Cache.setProperty(string + "SCREEN_Y", jc.y + "");
@@ -1360,7 +1425,8 @@ public class Desktop extends jalview.jbgui.GDesktop
public String getAboutMessage()
{
StringBuilder message = new StringBuilder(1024);
- message.append("
")
.append("Built: ")
.append(Cache.getDefault("BUILD_DATE", "unknown"))
@@ -1376,7 +1442,7 @@ public class Desktop extends jalview.jbgui.GDesktop
else if (!latestVersion.equals(Cache.getProperty("VERSION")))
{
boolean red = false;
- if (Cache.getProperty("VERSION").toLowerCase()
+ if (Cache.getProperty("VERSION").toLowerCase(Locale.ROOT)
.indexOf("automated build") == -1)
{
red = true;
@@ -1389,7 +1455,7 @@ public class Desktop extends jalview.jbgui.GDesktop
.append(Cache.getDefault("LATEST_VERSION", "..Checking.."))
.append(" is available for download from ")
.append(Cache.getDefault("www.jalview.org",
- "http://www.jalview.org"))
+ "https://www.jalview.org"))
.append(" !!");
if (red)
{
@@ -1400,6 +1466,8 @@ public class Desktop extends jalview.jbgui.GDesktop
message.append(Cache.getDefault("AUTHORFNAMES", DEFAULT_AUTHORS));
message.append(CITATION);
+ message.append("
");
+
return message.toString();
}
@@ -1413,7 +1481,7 @@ public class Desktop extends jalview.jbgui.GDesktop
{
if (Platform.isJS())
{
- BrowserLauncher.openURL("http://www.jalview.org/help.html");
+ BrowserLauncher.openURL("https://www.jalview.org/help.html");
}
else
/**
@@ -1486,17 +1554,16 @@ public class Desktop extends jalview.jbgui.GDesktop
protected void garbageCollect_actionPerformed(ActionEvent e)
{
// We simply collect the garbage
- Cache.log.debug("Collecting garbage...");
+ jalview.bin.Console.debug("Collecting garbage...");
System.gc();
- Cache.log.debug("Finished garbage collection.");
+ jalview.bin.Console.debug("Finished garbage collection.");
}
/*
* (non-Javadoc)
*
- * @see
- * jalview.jbgui.GDesktop#showMemusage_actionPerformed(java.awt.event.ActionEvent
- * )
+ * @see jalview.jbgui.GDesktop#showMemusage_actionPerformed(java.awt.event.
+ * ActionEvent )
*/
@Override
protected void showMemusage_actionPerformed(ActionEvent e)
@@ -1622,7 +1689,7 @@ public class Desktop extends jalview.jbgui.GDesktop
@Override
protected void preferences_actionPerformed(ActionEvent e)
{
- new Preferences();
+ Preferences.openPreferences();
}
/**
@@ -1701,7 +1768,7 @@ public class Desktop extends jalview.jbgui.GDesktop
+ chosenFile.getName(), oom);
} catch (Exception ex)
{
- Cache.log.error("Problems whilst trying to save to "
+ jalview.bin.Console.error("Problems whilst trying to save to "
+ chosenFile.getName(), ex);
JvOptionPane.showMessageDialog(me,
MessageManager.formatMessage(
@@ -1773,7 +1840,7 @@ public class Desktop extends jalview.jbgui.GDesktop
new OOMWarning("Whilst loading project from " + choice, oom);
} catch (Exception ex)
{
- Cache.log.error(
+ jalview.bin.Console.error(
"Problems whilst loading project from " + choice, ex);
JvOptionPane.showMessageDialog(Desktop.desktop,
MessageManager.formatMessage(
@@ -1996,9 +2063,8 @@ public class Desktop extends jalview.jbgui.GDesktop
}
/*
- * Restore the view's last exploded frame geometry if known. Multiple
- * views from one exploded frame share and restore the same (frame)
- * position and size.
+ * Restore the view's last exploded frame geometry if known. Multiple views from
+ * one exploded frame share and restore the same (frame) position and size.
*/
Rectangle geometry = ap.av.getExplodedGeometry();
if (geometry != null)
@@ -2087,6 +2153,7 @@ public class Desktop extends jalview.jbgui.GDesktop
{
source.showFeatureSettingsUI();
}
+
}
public JInternalFrame[] getAllFrames()
@@ -2280,6 +2347,9 @@ public class Desktop extends jalview.jbgui.GDesktop
10, getHeight() - fm.getHeight());
}
}
+
+ // output debug scale message. Important for jalview.bin.HiDPISettingTest2
+ Desktop.debugScaleMessage(Desktop.getDesktop().getGraphics());
}
}
@@ -2376,7 +2446,7 @@ public class Desktop extends jalview.jbgui.GDesktop
openGroovyConsole();
} catch (Exception ex)
{
- Cache.log.error("Groovy Shell Creation failed.", ex);
+ jalview.bin.Console.error("Groovy Shell Creation failed.", ex);
JvOptionPane.showInternalMessageDialog(Desktop.desktop,
MessageManager.getString("label.couldnt_create_groovy_shell"),
@@ -2398,9 +2468,9 @@ public class Desktop extends jalview.jbgui.GDesktop
/*
* We allow only one console at a time, so that AlignFrame menu option
- * 'Calculate | Run Groovy script' is unambiguous.
- * Disable 'Groovy Console', and enable 'Run script', when the console is
- * opened, and the reverse when it is closed
+ * 'Calculate | Run Groovy script' is unambiguous. Disable 'Groovy Console', and
+ * enable 'Run script', when the console is opened, and the reverse when it is
+ * closed
*/
Window window = (Window) groovyConsole.getFrame();
window.addWindowListener(new WindowAdapter()
@@ -2423,8 +2493,8 @@ public class Desktop extends jalview.jbgui.GDesktop
((Window) groovyConsole.getFrame()).setVisible(true);
/*
- * if we got this far, enable 'Run Groovy' in AlignFrame menus
- * and disable opening a second console
+ * if we got this far, enable 'Run Groovy' in AlignFrame menus and disable
+ * opening a second console
*/
enableExecuteGroovy(true);
}
@@ -2461,8 +2531,8 @@ public class Desktop extends jalview.jbgui.GDesktop
public void enableExecuteGroovy(boolean enabled)
{
/*
- * disable opening a second Groovy console
- * (or re-enable when the console is closed)
+ * disable opening a second Groovy console (or re-enable when the console is
+ * closed)
*/
groovyShell.setEnabled(!enabled);
@@ -2491,8 +2561,6 @@ public class Desktop extends jalview.jbgui.GDesktop
@Override
public void setProgressBar(String message, long id)
{
- // Platform.timeCheck("Desktop " + message, Platform.TIME_MARK);
-
if (progressBars == null)
{
progressBars = new Hashtable<>();
@@ -2625,13 +2693,36 @@ public class Desktop extends jalview.jbgui.GDesktop
this.inBatchMode = inBatchMode;
}
+ /**
+ * start service discovery and wait till it is done
+ */
public void startServiceDiscovery()
{
startServiceDiscovery(false);
}
+ /**
+ * start service discovery threads - blocking or non-blocking
+ *
+ * @param blocking
+ */
public void startServiceDiscovery(boolean blocking)
{
+ startServiceDiscovery(blocking, false);
+ }
+
+ /**
+ * start service discovery threads
+ *
+ * @param blocking
+ * - false means call returns immediately
+ * @param ignore_SHOW_JWS2_SERVICES_preference
+ * - when true JABA services are discovered regardless of user's JWS2
+ * discovery preference setting
+ */
+ public void startServiceDiscovery(boolean blocking,
+ boolean ignore_SHOW_JWS2_SERVICES_preference)
+ {
boolean alive = true;
Thread t0 = null, t1 = null, t2 = null;
// JAL-940 - JALVIEW 1 services are now being EOLed as of JABA 2.1 release
@@ -2649,7 +2740,8 @@ public class Desktop extends jalview.jbgui.GDesktop
(t0 = new Thread(discoverer)).start();
}
- if (Cache.getDefault("SHOW_JWS2_SERVICES", true))
+ if (ignore_SHOW_JWS2_SERVICES_preference
+ || Cache.getDefault("SHOW_JWS2_SERVICES", true))
{
t2 = jalview.ws.jws2.Jws2Discoverer.getDiscoverer()
.startDiscoverer(changeSupport);
@@ -2702,24 +2794,19 @@ public class Desktop extends jalview.jbgui.GDesktop
/*
* JalviewDialog jd =new JalviewDialog() {
*
- * @Override protected void cancelPressed() { // TODO
- * Auto-generated method stub
+ * @Override protected void cancelPressed() { // TODO Auto-generated method stub
*
- * }@Override protected void okPressed() { // TODO
- * Auto-generated method stub
+ * }@Override protected void okPressed() { // TODO Auto-generated method stub
*
- * }@Override protected void raiseClosed() { // TODO
- * Auto-generated method stub
+ * }@Override protected void raiseClosed() { // TODO Auto-generated method stub
*
- * } }; jd.initDialogFrame(new
- * JLabel("
" +
+ * ermsg +
* " It may be that you have invalid JABA URLs in your web service preferences,"
* + " or mis-configured HTTP proxy settings. " +
- * "Check the Connections and Web services tab of the"
- * +
- * " Tools->Preferences dialog box to change them.
"
- * ), true, true, "Web Service Configuration Problem", 450,
- * 400);
+ * "Check the Connections and Web services tab of the" +
+ * " Tools->Preferences dialog box to change them.
" ),
+ * true, true, "Web Service Configuration Problem", 450, 400);
*
* jd.waitForInput();
*/
@@ -2741,7 +2828,7 @@ public class Desktop extends jalview.jbgui.GDesktop
}
else
{
- Cache.log.error(
+ jalview.bin.Console.error(
"Errors reported by JABA discovery service. Check web services preferences.\n"
+ ermsg);
}
@@ -2834,15 +2921,8 @@ public class Desktop extends jalview.jbgui.GDesktop
{
if (url != null)
{
- if (Cache.log != null)
- {
- Cache.log.error("Couldn't handle string " + url + " as a URL.");
- }
- else
- {
- System.err.println(
- "Couldn't handle string " + url + " as a URL.");
- }
+ jalview.bin.Console
+ .error("Couldn't handle string " + url + " as a URL.");
}
// ignore any exceptions due to dud links.
}
@@ -2897,7 +2977,8 @@ public class Desktop extends jalview.jbgui.GDesktop
SwingUtilities.invokeAndWait(prompter);
} catch (Exception q)
{
- Cache.log.warn("Unexpected Exception in dialog thread.", q);
+ jalview.bin.Console.warn("Unexpected Exception in dialog thread.",
+ q);
}
}
});
@@ -2936,7 +3017,7 @@ public class Desktop extends jalview.jbgui.GDesktop
public void exportImage(Graphics g) throws Exception
{
paintAll(g);
- Cache.log.info("Successfully written snapshot to file "
+ jalview.bin.Console.info("Successfully written snapshot to file "
+ of.getAbsolutePath());
}
};
@@ -2970,16 +3051,15 @@ public class Desktop extends jalview.jbgui.GDesktop
}
/*
- * Processing in reverse order works, forwards order leaves the first panels
- * not visible. I don't know why!
+ * Processing in reverse order works, forwards order leaves the first panels not
+ * visible. I don't know why!
*/
for (int i = viewCount - 1; i >= 0; i--)
{
/*
- * Make new top and bottom frames. These take over the respective
- * AlignmentPanel objects, including their AlignmentViewports, so the
- * cdna/protein relationships between the viewports is carried over to the
- * new split frames.
+ * Make new top and bottom frames. These take over the respective AlignmentPanel
+ * objects, including their AlignmentViewports, so the cdna/protein
+ * relationships between the viewports is carried over to the new split frames.
*
* explodedGeometry holds the (x, y) position of the previously exploded
* SplitFrame, and the (width, height) of the AlignFrame component
@@ -3018,8 +3098,8 @@ public class Desktop extends jalview.jbgui.GDesktop
}
/*
- * Clear references to the panels (now relocated in the new SplitFrames)
- * before closing the old SplitFrame.
+ * Clear references to the panels (now relocated in the new SplitFrames) before
+ * closing the old SplitFrame.
*/
topPanels.clear();
bottomPanels.clear();
@@ -3120,28 +3200,6 @@ public class Desktop extends jalview.jbgui.GDesktop
Transferable t) throws Exception
{
- // BH 2018 changed List to List