X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fgui%2FFeatureRenderer.java;h=e22f506d662e1160d10dc0fceb1a7b5576f50b88;hb=e1aa3fdd1ca82abf5acc0cd3c2b86a5ca1083941;hp=6f6bc02f379d0c420e07f197c5d73c032d5fefa8;hpb=163ed5b997bbda48e4cdd950e87a8fe01baae7fb;p=jalview.git diff --git a/src/jalview/gui/FeatureRenderer.java b/src/jalview/gui/FeatureRenderer.java index 6f6bc02..e22f506 100644 --- a/src/jalview/gui/FeatureRenderer.java +++ b/src/jalview/gui/FeatureRenderer.java @@ -41,6 +41,7 @@ import java.awt.event.ItemEvent; import java.awt.event.ItemListener; import java.awt.event.MouseAdapter; import java.awt.event.MouseEvent; +import java.util.ArrayList; import java.util.Arrays; import java.util.Comparator; import java.util.List; @@ -63,8 +64,8 @@ import javax.swing.event.DocumentListener; * @author $author$ * @version $Revision$ */ -public class FeatureRenderer extends - jalview.renderer.seqfeatures.FeatureRenderer +public class FeatureRenderer + extends jalview.renderer.seqfeatures.FeatureRenderer { /* * defaults for creating a new feature are the last created @@ -179,15 +180,15 @@ public class FeatureRenderer extends final JSpinner end = new JSpinner(); start.setPreferredSize(new Dimension(80, 20)); end.setPreferredSize(new Dimension(80, 20)); - final FeatureRenderer me = this; final JLabel colour = new JLabel(); colour.setOpaque(true); // colour.setBorder(BorderFactory.createEtchedBorder()); colour.setMaximumSize(new Dimension(30, 16)); colour.addMouseListener(new MouseAdapter() { - FeatureColourChooser fcc = null; - + /* + * open colour chooser on click in colour panel + */ @Override public void mousePressed(MouseEvent evt) { @@ -204,28 +205,26 @@ public class FeatureRenderer extends } else { - if (fcc == null) + /* + * variable colour dialog - on OK, refetch the updated + * feature colour and update this display + */ + final String ft = features.get(featureIndex).getType(); + final String type = ft == null ? lastFeatureAdded : ft; + FeatureTypeSettings fcc = new FeatureTypeSettings( + FeatureRenderer.this, type); + fcc.setRequestFocusEnabled(true); + fcc.requestFocus(); + fcc.addActionListener(new ActionListener() { - final String ft = features.get(featureIndex).getType(); - final String type = ft == null ? lastFeatureAdded : ft; - fcc = new FeatureColourChooser(me, type); - fcc.setRequestFocusEnabled(true); - fcc.requestFocus(); - - fcc.addActionListener(new ActionListener() + @Override + public void actionPerformed(ActionEvent e) { - - @Override - public void actionPerformed(ActionEvent e) - { - fcol = fcc.getLastColour(); - fcc = null; - setColour(type, fcol); - updateColourButton(mainPanel, colour, fcol); - } - }); - - } + fcol = FeatureRenderer.this.getFeatureStyle(ft); + setColour(type, fcol); + updateColourButton(mainPanel, colour, fcol); + } + }); } } }); @@ -234,20 +233,26 @@ public class FeatureRenderer extends if (!create && features.size() > 1) { /* - * more than one feature at selected position - add a drop-down - * to choose the feature to amend + * more than one feature at selected position - + * add a drop-down to choose the feature to amend + * space pad text if necessary to make entries distinct */ gridPanel = new JPanel(new GridLayout(4, 1)); JPanel choosePanel = new JPanel(); - choosePanel.add(new JLabel(MessageManager - .getString("label.select_feature") - + ":")); - final JComboBox overlaps = new JComboBox(); + choosePanel.add(new JLabel( + MessageManager.getString("label.select_feature") + ":")); + final JComboBox overlaps = new JComboBox<>(); + List added = new ArrayList<>(); for (SequenceFeature sf : features) { - String text = sf.getType() + "/" + sf.getBegin() + "-" - + sf.getEnd() + " (" + sf.getFeatureGroup() + ")"; + String text = String.format("%s/%d-%d (%s)", sf.getType(), + sf.getBegin(), sf.getEnd(), sf.getFeatureGroup()); + while (added.contains(text)) + { + text += " "; + } overlaps.addItem(text); + added.add(text); } choosePanel.add(overlaps); @@ -264,8 +269,8 @@ public class FeatureRenderer extends name.setText(sf.getType()); description.setText(sf.getDescription()); group.setText(sf.getFeatureGroup()); - start.setValue(new Integer(sf.getBegin())); - end.setValue(new Integer(sf.getEnd())); + start.setValue(Integer.valueOf(sf.getBegin())); + end.setValue(Integer.valueOf(sf.getEnd())); SearchResultsI highlight = new SearchResults(); highlight.addResult(sequences.get(0), sf.getBegin(), @@ -273,13 +278,12 @@ public class FeatureRenderer extends alignPanel.getSeqPanel().seqCanvas.highlightSearchResults( highlight, false); - } FeatureColourI col = getFeatureStyle(name.getText()); if (col == null) { - col = new FeatureColour(ColorUtils - .createColourFromName(name.getText())); + col = new FeatureColour( + ColorUtils.createColourFromName(name.getText())); } oldcol = fcol = col; updateColourButton(mainPanel, colour, col); @@ -316,9 +320,8 @@ public class FeatureRenderer extends mainPanel.add(gridPanel, BorderLayout.NORTH); JPanel descriptionPanel = new JPanel(); - descriptionPanel.add(new JLabel(MessageManager - .getString("label.description:"), - JLabel.RIGHT)); + descriptionPanel.add(new JLabel( + MessageManager.getString("label.description:"), JLabel.RIGHT)); description.setFont(JvSwingUtils.getTextAreaFont()); description.setLineWrap(true); descriptionPanel.add(new JScrollPane(description)); @@ -354,8 +357,8 @@ public class FeatureRenderer extends name.setText(featureType); group.setText(featureGroup); - start.setValue(new Integer(firstFeature.getBegin())); - end.setValue(new Integer(firstFeature.getEnd())); + start.setValue(Integer.valueOf(firstFeature.getBegin())); + end.setValue(Integer.valueOf(firstFeature.getEnd())); description.setText(firstFeature.getDescription()); updateColourButton(mainPanel, colour, (oldcol = fcol = getFeatureStyle(featureType))); @@ -372,10 +375,11 @@ public class FeatureRenderer extends MessageManager.getString("action.cancel") }; } - String title = create ? MessageManager - .getString("label.create_new_sequence_features") + String title = create + ? MessageManager.getString("label.create_new_sequence_features") : MessageManager.formatMessage("label.amend_delete_features", - new String[] { sequences.get(0).getName() }); + new String[] + { sequences.get(0).getName() }); /* * show the dialog @@ -451,7 +455,7 @@ public class FeatureRenderer extends sequences.get(0).deleteFeature(sf); SequenceFeature newSf = new SequenceFeature(sf, enteredType, newBegin, newEnd, enteredGroup, sf.getScore()); - sf.setDescription(enteredDescription); + newSf.setDescription(enteredDescription); ffile.parseDescriptionHTML(newSf, false); // amend features dialog only updates one sequence at a time sequences.get(0).addSequenceFeature(newSf); @@ -481,7 +485,7 @@ public class FeatureRenderer extends featuresAdded(); - alignPanel.paintAlignment(true); + alignPanel.paintAlignment(true, true); return true; } @@ -491,7 +495,7 @@ public class FeatureRenderer extends } } - alignPanel.paintAlignment(true); + alignPanel.paintAlignment(true, true); return true; } @@ -528,7 +532,8 @@ public class FeatureRenderer extends { String msg = MessageManager.formatMessage("label.warning_hidden", MessageManager.getString("label.group"), group); - JvOptionPane.showMessageDialog(panel, msg, "", JvOptionPane.OK_OPTION); + JvOptionPane.showMessageDialog(panel, msg, "", + JvOptionPane.OK_OPTION); } }