X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fgui%2FPopupMenu.java;h=174772cadcc1dd7d204bd34bc55e41a210a11f1e;hb=f18077aa57dea5481ae537162871045f8557e2f0;hp=4ff525e1d0cfd00cdea47f6264f41d3d7b26dd4f;hpb=76d3286a73053be49a8cfd6842fffba4db111e08;p=jalview.git diff --git a/src/jalview/gui/PopupMenu.java b/src/jalview/gui/PopupMenu.java index 4ff525e..174772c 100644 --- a/src/jalview/gui/PopupMenu.java +++ b/src/jalview/gui/PopupMenu.java @@ -1,6 +1,6 @@ /* - * Jalview - A Sequence Alignment Editor and Viewer (Version 2.8.2) - * Copyright (C) 2014 The Jalview Authors + * Jalview - A Sequence Alignment Editor and Viewer ($$Version-Rel$$) + * Copyright (C) $$Year-Rel$$ The Jalview Authors * * This file is part of Jalview. * @@ -20,12 +20,38 @@ */ package jalview.gui; +import java.awt.Color; +import java.awt.event.ActionEvent; +import java.awt.event.ActionListener; +import java.util.Arrays; +import java.util.Collections; +import java.util.Hashtable; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.TreeMap; +import java.util.Vector; + +import javax.swing.ButtonGroup; +import javax.swing.JCheckBoxMenuItem; +import javax.swing.JColorChooser; +import javax.swing.JMenu; +import javax.swing.JMenuItem; +import javax.swing.JOptionPane; +import javax.swing.JPopupMenu; +import javax.swing.JRadioButtonMenuItem; + import jalview.analysis.AAFrequency; +import jalview.analysis.AlignmentAnnotationUtils; +import jalview.analysis.AlignmentUtils; import jalview.analysis.Conservation; import jalview.commands.ChangeCaseCommand; import jalview.commands.EditCommand; +import jalview.commands.EditCommand.Action; import jalview.datamodel.AlignmentAnnotation; +import jalview.datamodel.AlignmentI; import jalview.datamodel.Annotation; +import jalview.datamodel.ColumnSelection; import jalview.datamodel.DBRefEntry; import jalview.datamodel.PDBEntry; import jalview.datamodel.Sequence; @@ -54,21 +80,6 @@ import jalview.util.GroupUrlLink.UrlStringTooLongException; import jalview.util.MessageManager; import jalview.util.UrlLink; -import java.awt.Color; -import java.awt.event.ActionEvent; -import java.awt.event.ActionListener; -import java.util.Hashtable; -import java.util.Vector; - -import javax.swing.ButtonGroup; -import javax.swing.JCheckBoxMenuItem; -import javax.swing.JColorChooser; -import javax.swing.JMenu; -import javax.swing.JMenuItem; -import javax.swing.JOptionPane; -import javax.swing.JPopupMenu; -import javax.swing.JRadioButtonMenuItem; - /** * DOCUMENT ME! * @@ -77,6 +88,10 @@ import javax.swing.JRadioButtonMenuItem; */ public class PopupMenu extends JPopupMenu { + private static final String ALL_ANNOTATIONS = "All"; + + private static final String COMMA = ","; + JMenu groupMenu = new JMenu(); JMenuItem groupName = new JMenuItem(); @@ -125,6 +140,8 @@ public class PopupMenu extends JPopupMenu JMenuItem sequenceDetails = new JMenuItem(); JMenuItem sequenceSelDetails = new JMenuItem(); + + JMenuItem makeReferenceSeq = new JMenuItem(); JMenuItem chooseAnnotations = new JMenuItem(); @@ -176,6 +193,20 @@ public class PopupMenu extends JPopupMenu JMenu outputMenu = new JMenu(); + JMenu seqShowAnnotationsMenu = new JMenu(); + + JMenu seqHideAnnotationsMenu = new JMenu(); + + JMenuItem seqAddReferenceAnnotations = new JMenuItem( + MessageManager.getString("label.add_reference_annotations")); + + JMenu groupShowAnnotationsMenu = new JMenu(); + + JMenu groupHideAnnotationsMenu = new JMenu(); + + JMenuItem groupAddReferenceAnnotations = new JMenuItem( + MessageManager.getString("label.add_reference_annotations")); + JMenuItem sequenceFeature = new JMenuItem(); JMenuItem textColour = new JMenuItem(); @@ -193,6 +224,8 @@ public class PopupMenu extends JPopupMenu JMenu groupLinksMenu; + JMenuItem hideInsertions = new JMenuItem(); + /** * Creates a new PopupMenu object. * @@ -260,6 +293,29 @@ public class PopupMenu extends JPopupMenu outputMenu.add(item); } + /* + * Build menus for annotation types that may be shown or hidden, and for + * 'reference annotations' that may be added to the alignment. First for the + * currently selected sequence (if there is one): + */ + final List selectedSequence = (seq == null ? Collections + . emptyList() : Arrays.asList(seq)); + buildAnnotationTypesMenus(seqShowAnnotationsMenu, + seqHideAnnotationsMenu, selectedSequence); + configureReferenceAnnotationsMenu(seqAddReferenceAnnotations, + selectedSequence); + + /* + * And repeat for the current selection group (if there is one): + */ + final List selectedGroup = (ap.av.getSelectionGroup() == null ? Collections + . emptyList() : ap.av.getSelectionGroup() + .getSequences()); + buildAnnotationTypesMenus(groupShowAnnotationsMenu, + groupHideAnnotationsMenu, selectedGroup); + configureReferenceAnnotationsMenu(groupAddReferenceAnnotations, + selectedGroup); + try { jbInit(); @@ -272,6 +328,12 @@ public class PopupMenu extends JPopupMenu if (seq != null) { sequenceMenu.setText(sequence.getName()); + if (seq == ap.av.getAlignment().getSeqrep()) + { + makeReferenceSeq.setText("Unmark representative"); + } else { + makeReferenceSeq.setText("Mark as representative"); + } if (seq.getDatasetSequence().getPDBId() != null && seq.getDatasetSequence().getPDBId().size() > 0) @@ -285,7 +347,7 @@ public class PopupMenu extends JPopupMenu menuItem = new JMenuItem(); menuItem.setText(pdb.getId()); - menuItem.addActionListener(new java.awt.event.ActionListener() + menuItem.addActionListener(new ActionListener() { @Override public void actionPerformed(ActionEvent e) @@ -299,7 +361,6 @@ public class PopupMenu extends JPopupMenu ap.av.collateForPDB(new PDBEntry[] { pdb })[0], null, ap); } - }); viewStructureMenu.add(menuItem); @@ -320,36 +381,34 @@ public class PopupMenu extends JPopupMenu } // structureMenu.remove(colStructureMenu); } - if (ap.av.getAlignment().isNucleotide() == true) { AlignmentAnnotation[] aa = ap.av.getAlignment() .getAlignmentAnnotation(); - for (int i = 0; i < aa.length; i++) + for (int i = 0; aa != null && i < aa.length; i++) { - if (aa[i].getRNAStruc() != null) + if (aa[i].isValidStruc() && aa[i].sequenceRef == null) { final String rnastruc = aa[i].getRNAStruc(); - final String structureLine = aa[i].label; + final String structureLine = aa[i].label + " (alignment)"; menuItem = new JMenuItem(); menuItem.setText(MessageManager.formatMessage( - "label.2d_rna_structure_line", new String[] + "label.2d_rna_structure_line", new Object[] { structureLine })); menuItem.addActionListener(new java.awt.event.ActionListener() - { @Override public void actionPerformed(ActionEvent e) { - // System.out.println("1:"+structureLine); - System.out.println("1:sname" + seq.getName()); - System.out.println("2:seq" + seq); - - // System.out.println("3:"+seq.getSequenceAsString()); - System.out.println("3:strucseq" + rnastruc); - // System.out.println("4:struc"+seq.getRNA()); - System.out.println("5:name" + seq.getName()); - System.out.println("6:ap" + ap); + // // System.out.println("1:"+structureLine); + // System.out.println("1:sname" + seq.getName()); + // System.out.println("2:seq" + seq); + // + // // System.out.println("3:"+seq.getSequenceAsString()); + // System.out.println("3:strucseq" + rnastruc); + // // System.out.println("4:struc"+seq.getRNA()); + // System.out.println("5:name" + seq.getName()); + // System.out.println("6:ap" + ap); new AppVarna(structureLine, seq, seq.getSequenceAsString(), rnastruc, seq.getName(), ap); // new AppVarna(seq.getName(),seq,rnastruc,seq.getRNA(), @@ -368,14 +427,14 @@ public class PopupMenu extends JPopupMenu AlignmentAnnotation seqAnno[] = seq.getAnnotation(); for (int i = 0; i < seqAnno.length; i++) { - if (seqAnno[i].getRNAStruc() != null) + if (seqAnno[i].isValidStruc()) { final String rnastruc = seqAnno[i].getRNAStruc(); // TODO: make rnastrucF a bit more nice menuItem = new JMenuItem(); menuItem.setText(MessageManager.formatMessage( - "label.2d_rna_sequence_name", new String[] + "label.2d_rna_sequence_name", new Object[] { seq.getName() })); menuItem.addActionListener(new java.awt.event.ActionListener() { @@ -393,7 +452,6 @@ public class PopupMenu extends JPopupMenu } } } - } menuItem = new JMenuItem( @@ -412,7 +470,7 @@ public class PopupMenu extends JPopupMenu && ap.av.getSelectionGroup().getSize() > 1) { menuItem = new JMenuItem(MessageManager.formatMessage( - "label.represent_group_with", new String[] + "label.represent_group_with", new Object[] { seq.getName() })); menuItem.addActionListener(new java.awt.event.ActionListener() { @@ -481,7 +539,7 @@ public class PopupMenu extends JPopupMenu if (sg != null && sg.getSize() > 0) { groupName.setText(MessageManager.formatMessage("label.name_param", - new String[] + new Object[] { sg.getName() })); groupName.setText(MessageManager .getString("label.edit_name_and_description_current_group")); @@ -562,8 +620,7 @@ public class PopupMenu extends JPopupMenu SequenceI sqass = null; for (SequenceI sq : ap.av.getSequenceSelection()) { - Vector pes = sq.getDatasetSequence() - .getPDBId(); + Vector pes = sq.getDatasetSequence().getPDBId(); if (pes != null && pes.size() > 0) { reppdb.put(pes.get(0).getId(), pes.get(0)); @@ -586,13 +643,13 @@ public class PopupMenu extends JPopupMenu if (pdbe.size() == 1) { structureMenu.add(gpdbview = new JMenuItem(MessageManager - .formatMessage("label.view_structure_for", new String[] + .formatMessage("label.view_structure_for", new Object[] { sqass.getDisplayId(false) }))); } else { structureMenu.add(gpdbview = new JMenuItem(MessageManager - .formatMessage("label.view_all_structures", new String[] + .formatMessage("label.view_all_structures", new Object[] { new Integer(pdbe.size()).toString() }))); } gpdbview.setToolTipText(MessageManager @@ -612,7 +669,7 @@ public class PopupMenu extends JPopupMenu structureMenu.add(rpdbview = new JMenuItem(MessageManager .formatMessage( "label.view_all_representative_structures", - new String[] + new Object[] { new Integer(reppdb.size()).toString() }))); rpdbview.setToolTipText(MessageManager .getString("label.open_new_jmol_view_with_all_representative_structures_associated_current_selection_superimpose_using_alignment")); @@ -777,6 +834,135 @@ public class PopupMenu extends JPopupMenu } } + /** + * Add annotation types to 'Show annotations' and/or 'Hide annotations' menus. + * "All" is added first, followed by a separator. Then add any annotation + * types associated with the current selection. Separate menus are built for + * the selected sequence group (if any), and the selected sequence. + *

+ * Some annotation rows are always rendered together - these can be identified + * by a common graphGroup property > -1. Only one of each group will be marked + * as visible (to avoid duplication of the display). For such groups we add a + * composite type name, e.g. + *

+ * IUPredWS (Long), IUPredWS (Short) + * + * @param seq + */ + protected void buildAnnotationTypesMenus(JMenu showMenu, JMenu hideMenu, + List forSequences) + { + showMenu.removeAll(); + hideMenu.removeAll(); + + final List all = Arrays.asList(ALL_ANNOTATIONS); + addAnnotationTypeToShowHide(showMenu, forSequences, "", all, true, true); + addAnnotationTypeToShowHide(hideMenu, forSequences, "", all, true, + false); + showMenu.addSeparator(); + hideMenu.addSeparator(); + + final AlignmentAnnotation[] annotations = ap.getAlignment() + .getAlignmentAnnotation(); + + /* + * Find shown/hidden annotations types, distinguished by source (calcId), + * and grouped by graphGroup. Using LinkedHashMap means we will retrieve in + * the insertion order, which is the order of the annotations on the + * alignment. + */ + Map>> shownTypes = new LinkedHashMap>>(); + Map>> hiddenTypes = new LinkedHashMap>>(); + AlignmentAnnotationUtils.getShownHiddenTypes(shownTypes, + hiddenTypes, + AlignmentAnnotationUtils.asList(annotations), + forSequences); + + for (String calcId : hiddenTypes.keySet()) + { + for (List type : hiddenTypes.get(calcId)) + { + addAnnotationTypeToShowHide(showMenu, forSequences, + calcId, type, false, true); + } + } + // grey out 'show annotations' if none are hidden + showMenu.setEnabled(!hiddenTypes.isEmpty()); + + for (String calcId : shownTypes.keySet()) + { + for (List type : shownTypes.get(calcId)) + { + addAnnotationTypeToShowHide(hideMenu, forSequences, + calcId, type, false, false); + } + } + // grey out 'hide annotations' if none are shown + hideMenu.setEnabled(!shownTypes.isEmpty()); + } + + /** + * Returns a list of sequences - either the current selection group (if there + * is one), else the specified single sequence. + * + * @param seq + * @return + */ + protected List getSequenceScope(SequenceI seq) + { + List forSequences = null; + final SequenceGroup selectionGroup = ap.av.getSelectionGroup(); + if (selectionGroup != null && selectionGroup.getSize() > 0) + { + forSequences = selectionGroup.getSequences(); + } + else + { + forSequences = seq == null ? Collections. emptyList() + : Arrays.asList(seq); + } + return forSequences; + } + + /** + * Add one annotation type to the 'Show Annotations' or 'Hide Annotations' + * menus. + * + * @param showOrHideMenu + * the menu to add to + * @param forSequences + * the sequences whose annotations may be shown or hidden + * @param calcId + * @param types + * the label to add + * @param allTypes + * if true this is a special label meaning 'All' + * @param actionIsShow + * if true, the select menu item action is to show the annotation + * type, else hide + */ + protected void addAnnotationTypeToShowHide(JMenu showOrHideMenu, + final List forSequences, String calcId, + final List types, final boolean allTypes, + final boolean actionIsShow) + { + String label = types.toString(); // [a, b, c] + label = label.substring(1, label.length() - 1); // a, b, c + final JMenuItem item = new JMenuItem(label); + item.setToolTipText(calcId); + item.addActionListener(new java.awt.event.ActionListener() + { + @Override + public void actionPerformed(ActionEvent e) + { + AlignmentUtils.showOrHideSequenceAnnotations(ap.getAlignment(), types, + forSequences, allTypes, actionIsShow); + refresh(); + } + }); + showOrHideMenu.add(item); + } + private void buildGroupURLMenu(SequenceGroup sg, Vector groupLinks) { @@ -945,7 +1131,7 @@ public class PopupMenu extends JPopupMenu { JMenuItem item = new JMenuItem(label); item.setToolTipText(MessageManager.formatMessage( - "label.open_url_param", new String[] + "label.open_url_param", new Object[] { url })); item.addActionListener(new java.awt.event.ActionListener() { @@ -1047,8 +1233,7 @@ public class PopupMenu extends JPopupMenu }); chooseAnnotations.setText(MessageManager .getString("label.choose_annotations") + "..."); - chooseAnnotations - .addActionListener(new java.awt.event.ActionListener() + chooseAnnotations.addActionListener(new java.awt.event.ActionListener() { @Override public void actionPerformed(ActionEvent e) @@ -1263,6 +1448,14 @@ public class PopupMenu extends JPopupMenu }); outputMenu.setText(MessageManager.getString("label.out_to_textbox") + "..."); + seqShowAnnotationsMenu.setText(MessageManager + .getString("label.show_annotations")); + seqHideAnnotationsMenu.setText(MessageManager + .getString("label.hide_annotations")); + groupShowAnnotationsMenu.setText(MessageManager + .getString("label.show_annotations")); + groupHideAnnotationsMenu.setText(MessageManager + .getString("label.hide_annotations")); sequenceFeature.setText(MessageManager .getString("label.create_sequence_feature")); sequenceFeature.addActionListener(new ActionListener() @@ -1297,7 +1490,28 @@ public class PopupMenu extends JPopupMenu editSequence_actionPerformed(actionEvent); } }); + makeReferenceSeq.setText(MessageManager + .getString("label.mark_as_representative")); + makeReferenceSeq.addActionListener(new ActionListener() + { + + @Override + public void actionPerformed(ActionEvent actionEvent) + { + makeReferenceSeq_actionPerformed(actionEvent); + + } + }); + hideInsertions.setText(MessageManager.getString("label.hide_insertions")); + hideInsertions.addActionListener(new ActionListener() + { + @Override + public void actionPerformed(ActionEvent e) + { + hideInsertions_actionPerformed(e); + } + }); /* * annotationMenuItem.setText("By Annotation"); * annotationMenuItem.addActionListener(new ActionListener() { public void @@ -1307,8 +1521,24 @@ public class PopupMenu extends JPopupMenu groupMenu.add(sequenceSelDetails); add(groupMenu); add(sequenceMenu); - this.add(structureMenu); - groupMenu.add(chooseAnnotations); + add(structureMenu); + if (sequence!=null) + { + add(hideInsertions); + } + // annotations configuration panel suppressed for now + // groupMenu.add(chooseAnnotations); + + /* + * Add show/hide annotations to the Sequence menu, and to the Selection menu + * (if a selection group is in force). + */ + sequenceMenu.add(seqShowAnnotationsMenu); + sequenceMenu.add(seqHideAnnotationsMenu); + sequenceMenu.add(seqAddReferenceAnnotations); + groupMenu.add(groupShowAnnotationsMenu); + groupMenu.add(groupHideAnnotationsMenu); + groupMenu.add(groupAddReferenceAnnotations); groupMenu.add(editMenu); groupMenu.add(outputMenu); groupMenu.add(sequenceFeature); @@ -1317,6 +1547,7 @@ public class PopupMenu extends JPopupMenu groupMenu.add(jMenu1); sequenceMenu.add(sequenceName); sequenceMenu.add(sequenceDetails); + sequenceMenu.add(makeReferenceSeq); colourMenu.add(textColour); colourMenu.add(noColourmenuItem); colourMenu.add(clustalColour); @@ -1542,6 +1773,116 @@ public class PopupMenu extends JPopupMenu }); } + /** + * Check for any annotations on the underlying dataset sequences (for the + * current selection group) which are not 'on the alignment'.If any are found, + * enable the option to add them to the alignment. The criteria for 'on the + * alignment' is finding an alignment annotation on the alignment, matched on + * calcId, label and sequenceRef. + * + * A tooltip is also constructed that displays the source (calcId) and type + * (label) of the annotations that can be added. + * + * @param menuItem + * @param forSequences + */ + protected void configureReferenceAnnotationsMenu( + JMenuItem menuItem, List forSequences) + { + menuItem.setEnabled(false); + + /* + * Temporary store to hold distinct calcId / type pairs for the tooltip. + * Using TreeMap means calcIds are shown in alphabetical order. + */ + Map tipEntries = new TreeMap(); + final Map> candidates = new LinkedHashMap>(); + AlignmentI al = this.ap.av.getAlignment(); + AlignmentUtils.findAddableReferenceAnnotations(forSequences, + tipEntries, candidates, al); + if (!candidates.isEmpty()) + { + StringBuilder tooltip = new StringBuilder(64); + tooltip.append(MessageManager.getString("label.add_annotations_for")); + + /* + * Found annotations that could be added. Enable the menu item, and + * configure its tooltip and action. + */ + menuItem.setEnabled(true); + for (String calcId : tipEntries.keySet()) + { + tooltip.append("
" + calcId + "/" + tipEntries.get(calcId)); + } + String tooltipText = JvSwingUtils.wrapTooltip(true, + tooltip.toString()); + menuItem.setToolTipText(tooltipText); + + menuItem.addActionListener(new ActionListener() + { + @Override + public void actionPerformed(ActionEvent e) + { + addReferenceAnnotations_actionPerformed(candidates); + } + }); + } + } + + /** + * Add annotations to the sequences and to the alignment. + * + * @param candidates + * a map whose keys are sequences on the alignment, and values a list + * of annotations to add to each sequence + */ + protected void addReferenceAnnotations_actionPerformed( + Map> candidates) + { + final SequenceGroup selectionGroup = this.ap.av.getSelectionGroup(); + final AlignmentI alignment = this.ap.getAlignment(); + AlignmentUtils.addReferenceAnnotations(candidates, alignment, + selectionGroup); + refresh(); + } + + protected void makeReferenceSeq_actionPerformed(ActionEvent actionEvent) + { + if (!ap.av.getAlignment().hasSeqrep()) + { + // initialise the display flags so the user sees something happen + ap.av.setDisplayReferenceSeq(true); + ap.av.setColourByReferenceSeq(true); + ap.av.getAlignment().setSeqrep(sequence); + } + else + { + if (ap.av.getAlignment().getSeqrep() == sequence) + { + ap.av.getAlignment().setSeqrep(null); + } + else + { + ap.av.getAlignment().setSeqrep(sequence); + } + } + refresh(); + } + + protected void hideInsertions_actionPerformed(ActionEvent actionEvent) + { + if (sequence != null) + { + ColumnSelection cs = ap.av.getColumnSelection(); + if (cs == null) + { + cs = new ColumnSelection(); + } + cs.hideInsertionsFor(sequence); + ap.av.setColumnSelection(cs); + } + refresh(); + } protected void sequenceSelectionDetails_actionPerformed() { createSequenceDetailsReport(ap.av.getSequenceSelection()); @@ -1563,7 +1904,7 @@ public class PopupMenu extends JPopupMenu + MessageManager .formatMessage( "label.create_sequence_details_report_annotation_for", - new String[] + new Object[] { seq.getDisplayId(true) }) + "

"); new SequenceAnnotationReport(null) .createSequenceAnnotationReport( @@ -1572,16 +1913,18 @@ public class PopupMenu extends JPopupMenu true, true, false, - (ap.seqPanel.seqCanvas.fr != null) ? ap.seqPanel.seqCanvas.fr.minmax + (ap.getSeqPanel().seqCanvas.fr != null) ? ap + .getSeqPanel().seqCanvas.fr + .getMinMax() : null); contents.append("

"); } cap.setText("" + contents.toString() + ""); - Desktop.instance.addInternalFrame(cap, MessageManager.formatMessage( - "label.sequece_details_for", - (sequences.length == 1 ? new String[] - { sequences[0].getDisplayId(true) } : new String[] + Desktop.addInternalFrame(cap, MessageManager.formatMessage( + "label.sequence_details_for", + (sequences.length == 1 ? new Object[] + { sequences[0].getDisplayId(true) } : new Object[] { MessageManager.getString("label.selection") })), 500, 400); } @@ -1745,14 +2088,14 @@ public class PopupMenu extends JPopupMenu int threshold = SliderPanel.setPIDSliderSource(ap, sg.cs, getGroup() .getName()); - sg.cs.setThreshold(threshold, ap.av.getIgnoreGapsConsensus()); + sg.cs.setThreshold(threshold, ap.av.isIgnoreGapsConsensus()); SliderPanel.showPIDSlider(); } else // remove PIDColouring { - sg.cs.setThreshold(0, ap.av.getIgnoreGapsConsensus()); + sg.cs.setThreshold(0, ap.av.isIgnoreGapsConsensus()); } refresh(); @@ -1793,6 +2136,7 @@ public class PopupMenu extends JPopupMenu // todo correct way to guard against opening a duplicate panel? new AnnotationChooser(ap); } + /** * DOCUMENT ME! * @@ -2102,15 +2446,7 @@ public class PopupMenu extends JPopupMenu } int gsize = sg.getSize(); - SequenceI[] hseqs; - - hseqs = new SequenceI[gsize]; - - int index = 0; - for (int i = 0; i < gsize; i++) - { - hseqs[index++] = sg.getSequenceAt(i); - } + SequenceI[] hseqs = sg.getSequences().toArray(new SequenceI[gsize]); ap.av.hideSequence(hseqs); // refresh(); TODO: ? needed ? @@ -2134,7 +2470,8 @@ public class PopupMenu extends JPopupMenu if (sg != null) { - int[][] startEnd = ap.av.getVisibleRegionBoundaries(sg.getStartRes(), + List startEnd = ap.av.getVisibleRegionBoundaries( + sg.getStartRes(), sg.getEndRes() + 1); String description; @@ -2173,7 +2510,7 @@ public class PopupMenu extends JPopupMenu CutAndPasteTransfer cap = new CutAndPasteTransfer(); cap.setForInput(null); Desktop.addInternalFrame(cap, MessageManager.formatMessage( - "label.alignment_output_command", new String[] + "label.alignment_output_command", new Object[] { e.getActionCommand() }), 600, 500); String[] omitHidden = null; @@ -2182,7 +2519,8 @@ public class PopupMenu extends JPopupMenu // or we simply trust the user wants // wysiwig behaviour - cap.setText(new FormatAdapter().formatSequences(e.getActionCommand(), ap.av, true)); + cap.setText(new FormatAdapter().formatSequences(e.getActionCommand(), + ap.av, true)); } public void pdbFromFile_actionPerformed() @@ -2191,10 +2529,10 @@ public class PopupMenu extends JPopupMenu jalview.bin.Cache.getProperty("LAST_DIRECTORY")); chooser.setFileView(new jalview.io.JalviewFileView()); chooser.setDialogTitle(MessageManager.formatMessage( - "label.select_pdb_file_for", new String[] + "label.select_pdb_file_for", new Object[] { sequence.getDisplayId(false) })); chooser.setToolTipText(MessageManager.formatMessage( - "label.load_pdb_file_associate_with_sequence", new String[] + "label.load_pdb_file_associate_with_sequence", new Object[] { sequence.getDisplayId(false) })); int value = chooser.showOpenDialog(null); @@ -2204,7 +2542,8 @@ public class PopupMenu extends JPopupMenu String choice = chooser.getSelectedFile().getPath(); jalview.bin.Cache.setProperty("LAST_DIRECTORY", choice); new AssociatePdbFileWithSeq().associatePdbWithSeq(choice, - jalview.io.AppletFormatAdapter.FILE, sequence, true); + jalview.io.AppletFormatAdapter.FILE, sequence, true, + Desktop.instance); } } @@ -2286,7 +2625,7 @@ public class PopupMenu extends JPopupMenu System.arraycopy(features, 0, tfeatures, 0, rsize); features = tfeatures; seqs = rseqs; - if (ap.seqPanel.seqCanvas.getFeatureRenderer().amendFeatures(seqs, + if (ap.getSeqPanel().seqCanvas.getFeatureRenderer().amendFeatures(seqs, features, true, ap)) { ap.alignFrame.setShowSeqFeatures(true); @@ -2329,7 +2668,9 @@ public class PopupMenu extends JPopupMenu if (sg != null) { if (sequence == null) + { sequence = sg.getSequenceAt(0); + } EditNameDialog dialog = new EditNameDialog( sequence.getSequenceAsString(sg.getStartRes(), @@ -2342,7 +2683,7 @@ public class PopupMenu extends JPopupMenu { EditCommand editCommand = new EditCommand( MessageManager.getString("label.edit_sequences"), - EditCommand.REPLACE, dialog.getName().replace(' ', + Action.REPLACE, dialog.getName().replace(' ', ap.av.getGapCharacter()), sg.getSequencesAsArray(ap.av.getHiddenRepSequences()), sg.getStartRes(), sg.getEndRes() + 1, ap.av.getAlignment());