X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fgui%2FSeqCanvas.java;h=bd2862a3b8affddc0858182222080e86f83011fd;hb=875193c17720b95fa13a38703b1dd63949e12ca9;hp=7eb356b8928404ccc4e1d6e30f5ce1a448f18210;hpb=eb86f84d1835ee5be41ebfef365a9e11021c16c2;p=jalview.git

diff --git a/src/jalview/gui/SeqCanvas.java b/src/jalview/gui/SeqCanvas.java
index 7eb356b..bd2862a 100755
--- a/src/jalview/gui/SeqCanvas.java
+++ b/src/jalview/gui/SeqCanvas.java
@@ -31,6 +31,7 @@ import jalview.util.Comparison;
 import jalview.viewmodel.ViewportListenerI;
 import jalview.viewmodel.ViewportRanges;
 
+import java.awt.AlphaComposite;
 import java.awt.BasicStroke;
 import java.awt.BorderLayout;
 import java.awt.Color;
@@ -46,68 +47,58 @@ import java.util.List;
 import javax.swing.JComponent;
 
 /**
- * DOCUMENT ME!
+ * The Swing component on which the alignment sequences, and annotations (if
+ * shown), are drawn. This includes scales above, left and right (if shown) in
+ * Wrapped mode, but not the scale above in Unwrapped mode.
  * 
- * @author $author$
- * @version $Revision$
  */
 public class SeqCanvas extends JComponent implements ViewportListenerI
 {
-  private static String ZEROS = "0000000000";
+  private static final String ZEROS = "0000000000";
 
   final FeatureRenderer fr;
 
-  final SequenceRenderer sr;
-
   BufferedImage img;
 
-  Graphics2D gg;
-
-  int imgWidth;
-
-  int imgHeight;
-
   AlignViewport av;
 
-  boolean fastPaint = false;
-
-  boolean fastpainting = false;
-
   int cursorX = 0;
 
   int cursorY = 0;
 
-  int charHeight = 0;
+  private final SequenceRenderer seqRdr;
+
+  private boolean fastPaint = false;
 
-  int charWidth = 0;
+  private boolean fastpainting = false;
 
   private AnnotationPanel annotations;
 
   /*
    * measurements for drawing a wrapped alignment
    */
-  int labelWidthWest; // label left width in pixels if shown
-
   private int labelWidthEast; // label right width in pixels if shown
 
+  private int labelWidthWest; // label left width in pixels if shown
+
   private int wrappedSpaceAboveAlignment; // gap between widths
 
   private int wrappedRepeatHeightPx; // height in pixels of wrapped width
 
   private int wrappedVisibleWidths; // number of wrapped widths displayed
 
+  private Graphics2D gg;
+
   /**
    * Creates a new SeqCanvas object.
    * 
-   * @param av
-   *          DOCUMENT ME!
+   * @param ap
    */
   public SeqCanvas(AlignmentPanel ap)
   {
     this.av = ap.av;
-    updateViewport();
     fr = new FeatureRenderer(ap);
-    sr = new SequenceRenderer(av);
+    seqRdr = new SequenceRenderer(av);
     setLayout(new BorderLayout());
     PaintRefresher.Register(this, av.getSequenceSetId());
     setBackground(Color.white);
@@ -117,7 +108,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
 
   public SequenceRenderer getSequenceRenderer()
   {
-    return sr;
+    return seqRdr;
   }
 
   public FeatureRenderer getFeatureRenderer()
@@ -125,12 +116,6 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     return fr;
   }
 
-  private void updateViewport()
-  {
-    charHeight = av.getCharHeight();
-    charWidth = av.getCharWidth();
-  }
-
   /**
    * Draws the scale above a region of a wrapped alignment, consisting of a
    * column number every major interval (10 columns).
@@ -147,7 +132,8 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    */
   private void drawNorthScale(Graphics g, int startx, int endx, int ypos)
   {
-    updateViewport();
+    int charHeight = av.getCharHeight();
+    int charWidth = av.getCharWidth();
 
     /*
      * white fill the scale space (for the fastPaint case)
@@ -189,6 +175,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    * Draw the scale to the left or right of a wrapped alignment
    * 
    * @param g
+   *          graphics context, positioned at the start of the scale to be drawn
    * @param startx
    *          first column of wrapped width (0.. excluding any hidden columns)
    * @param endx
@@ -198,16 +185,21 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    * @param left
    *          if true, scale is left of residues, if false, scale is right
    */
-  void drawVerticalScale(Graphics g, int startx, int endx, int ypos,
-          boolean left)
+  void drawVerticalScale(Graphics g, final int startx, final int endx,
+          final int ypos, final boolean left)
   {
-    ypos += charHeight;
+    int charHeight = av.getCharHeight();
+    int charWidth = av.getCharWidth();
+
+    int yPos = ypos + charHeight;
+    int startX = startx;
+    int endX = endx;
 
     if (av.hasHiddenColumns())
     {
       HiddenColumns hiddenColumns = av.getAlignment().getHiddenColumns();
-      startx = hiddenColumns.adjustForHiddenColumns(startx);
-      endx = hiddenColumns.adjustForHiddenColumns(endx);
+      startX = hiddenColumns.adjustForHiddenColumns(startx);
+      endX = hiddenColumns.adjustForHiddenColumns(endx);
     }
     FontMetrics fm = getFontMetrics(av.getFont());
 
@@ -219,9 +211,9 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
        * find sequence position of first non-gapped position -
        * to the right if scale left, to the left if scale right
        */
-      int index = left ? startx : endx;
+      int index = left ? startX : endX;
       int value = -1;
-      while (index >= startx && index <= endx)
+      while (index >= startX && index <= endX)
       {
         if (!Comparison.isGap(seq.getCharAt(index)))
         {
@@ -242,28 +234,24 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
        * white fill the space for the scale
        */
       g.setColor(Color.white);
-      int y = (ypos + (i * charHeight)) - (charHeight / 5);
-      y -= charHeight; // fillRect: origin is top left of rectangle
-      int xpos = left ? 0 : labelWidthWest + charWidth
-              * av.getRanges().getViewportWidth();
-      g.fillRect(xpos, y, left ? labelWidthWest : labelWidthEast,
+      int y = (yPos + (i * charHeight)) - (charHeight / 5);
+      // fillRect origin is top left of rectangle
+      g.fillRect(0, y - charHeight, left ? labelWidthWest : labelWidthEast,
               charHeight + 1);
-      y += charHeight; // drawString: origin is bottom left of text
 
       if (value != -1)
       {
-
         /*
-         * draw scale value, right justified, with half a character width
-         * separation from the sequence data
+         * draw scale value, right justified within its width less half a
+         * character width padding on the right
          */
+        int labelSpace = left ? labelWidthWest : labelWidthEast;
+        labelSpace -= charWidth / 2; // leave space to the right
         String valueAsString = String.valueOf(value);
-        int justify = fm.stringWidth(valueAsString) + charWidth;
-        xpos = left ? labelWidthWest - justify + charWidth / 2
-                : getWidth() - justify - charWidth / 2;
-
+        int labelLength = fm.stringWidth(valueAsString);
+        int xOffset = labelSpace - labelLength;
         g.setColor(Color.black);
-        g.drawString(valueAsString, xpos, y);
+        g.drawString(valueAsString, xOffset, y);
       }
     }
   }
@@ -288,7 +276,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    */
   public void fastPaint(int horizontal, int vertical)
   {
-    if (fastpainting || gg == null)
+    if (fastpainting || gg == null || img == null)
     {
       return;
     }
@@ -297,8 +285,9 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
 
     try
     {
-      updateViewport();
-
+      int charHeight = av.getCharHeight();
+      int charWidth = av.getCharWidth();
+    
       ViewportRanges ranges = av.getRanges();
       int startRes = ranges.getStartRes();
       int endRes = ranges.getEndRes();
@@ -307,46 +296,47 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
       int transX = 0;
       int transY = 0;
 
-      gg.copyArea(horizontal * charWidth, vertical * charHeight, imgWidth,
-              imgHeight, -horizontal * charWidth, -vertical * charHeight);
+    gg.copyArea(horizontal * charWidth, vertical * charHeight,
+            img.getWidth(), img.getHeight(), -horizontal * charWidth,
+            -vertical * charHeight);
 
-      if (horizontal > 0) // scrollbar pulled right, image to the left
-      {
-        transX = (endRes - startRes - horizontal) * charWidth;
-        startRes = endRes - horizontal;
+    if (horizontal > 0) // scrollbar pulled right, image to the left
+    {
+      transX = (endRes - startRes - horizontal) * charWidth;
+      startRes = endRes - horizontal;
+    }
+    else if (horizontal < 0)
+    {
+      endRes = startRes - horizontal;
+    }
+    else if (vertical > 0) // scroll down
+    {
+      startSeq = endSeq - vertical;
+
+      if (startSeq < ranges.getStartSeq())
+      { // ie scrolling too fast, more than a page at a time
+        startSeq = ranges.getStartSeq();
       }
-      else if (horizontal < 0)
+      else
       {
-        endRes = startRes - horizontal;
+        transY = img.getHeight() - ((vertical + 1) * charHeight);
       }
-      else if (vertical > 0) // scroll down
-      {
-        startSeq = endSeq - vertical;
+    }
+    else if (vertical < 0)
+    {
+      endSeq = startSeq - vertical;
 
-        if (startSeq < ranges.getStartSeq())
-        { // ie scrolling too fast, more than a page at a time
-          startSeq = ranges.getStartSeq();
-        }
-        else
-        {
-          transY = imgHeight - ((vertical + 1) * charHeight);
-        }
-      }
-      else if (vertical < 0)
+      if (endSeq > ranges.getEndSeq())
       {
-        endSeq = startSeq - vertical;
-
-        if (endSeq > ranges.getEndSeq())
-        {
-          endSeq = ranges.getEndSeq();
-        }
+        endSeq = ranges.getEndSeq();
       }
+    }
 
-      gg.translate(transX, transY);
-      drawPanel(gg, startRes, endRes, startSeq, endSeq, 0);
-      gg.translate(-transX, -transY);
+    gg.translate(transX, transY);
+    drawPanel(gg, startRes, endRes, startSeq, endSeq, 0);
+    gg.translate(-transX, -transY);
 
-      repaint();
+    repaint();
     } finally
     {
       fastpainting = false;
@@ -356,74 +346,219 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   @Override
   public void paintComponent(Graphics g)
   {
-    updateViewport();
-    BufferedImage lcimg = img; // take reference since other threads may null
-    // img and call later.
-    super.paintComponent(g);
+    super.paintComponent(g);    
+    
+    int charHeight = av.getCharHeight();
+    int charWidth = av.getCharWidth();
+
+    ViewportRanges ranges = av.getRanges();
+
+    int width = getWidth();
+    int height = getHeight();
+
+    width -= (width % charWidth);
+    height -= (height % charHeight);
 
-    if (lcimg != null
-            && (fastPaint
-                    || (getVisibleRect().width != g.getClipBounds().width) || (getVisibleRect().height != g
-                    .getClipBounds().height)))
+    // selectImage is the selection group outline image
+    BufferedImage selectImage = drawSelectionGroup(
+            ranges.getStartRes(), ranges.getEndRes(),
+            ranges.getStartSeq(), ranges.getEndSeq());
+
+    BufferedImage cursorImage = drawCursor(ranges.getStartRes(),
+            ranges.getEndRes(), ranges.getStartSeq(), ranges.getEndSeq());
+
+    if ((img != null) && (fastPaint
+            || (getVisibleRect().width != g.getClipBounds().width)
+            || (getVisibleRect().height != g.getClipBounds().height)))
     {
+      BufferedImage lcimg = buildLocalImage(selectImage, cursorImage);
       g.drawImage(lcimg, 0, 0, this);
       fastPaint = false;
-      return;
     }
+    else if ((width > 0) && (height > 0))
+    {
+      // img is a cached version of the last view we drew, if any
+      // if we have no img or the size has changed, make a new one
+      if (img == null || width != img.getWidth()
+              || height != img.getHeight())
+      {
+        img = setupImage();
+        if (img == null)
+        {
+          return;
+        }
+        gg = (Graphics2D) img.getGraphics();
+        gg.setFont(av.getFont());
+      }
 
-    // this draws the whole of the alignment
-    imgWidth = getWidth();
-    imgHeight = getHeight();
+      if (av.antiAlias)
+      {
+        gg.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
+                RenderingHints.VALUE_ANTIALIAS_ON);
+      }
 
-    imgWidth -= (imgWidth % charWidth);
-    imgHeight -= (imgHeight % charHeight);
+      gg.setColor(Color.white);
+      gg.fillRect(0, 0, img.getWidth(), img.getHeight());
+
+      if (av.getWrapAlignment())
+      {
+        drawWrappedPanel(gg, getWidth(), getHeight(), ranges.getStartRes());
+      }
+      else
+      {
+        drawPanel(gg, ranges.getStartRes(), ranges.getEndRes(),
+                ranges.getStartSeq(), ranges.getEndSeq(), 0);
+      }
+
+      // lcimg is a local *copy* of img which we'll draw selectImage on top of
+      BufferedImage lcimg = buildLocalImage(selectImage, cursorImage);
+      g.drawImage(lcimg, 0, 0, this);
+    }
+  }
+  
+  /**
+   * Draw an alignment panel for printing
+   * 
+   * @param g1
+   *          Graphics object to draw with
+   * @param startRes
+   *          start residue of print area
+   * @param endRes
+   *          end residue of print area
+   * @param startSeq
+   *          start sequence of print area
+   * @param endSeq
+   *          end sequence of print area
+   */
+  public void drawPanelForPrinting(Graphics g1, int startRes, int endRes,
+          int startSeq, int endSeq)
+  {
+    drawPanel(g1, startRes, endRes, startSeq, endSeq, 0);
 
-    if ((imgWidth < 1) || (imgHeight < 1))
+    BufferedImage selectImage = drawSelectionGroup(startRes, endRes,
+            startSeq, endSeq);
+    if (selectImage != null)
     {
-      return;
+      ((Graphics2D) g1).setComposite(AlphaComposite
+              .getInstance(AlphaComposite.SRC_OVER));
+      g1.drawImage(selectImage, 0, 0, this);
     }
+  }
 
-    if (lcimg == null || imgWidth != lcimg.getWidth()
-            || imgHeight != lcimg.getHeight())
+  /**
+   * Draw a wrapped alignment panel for printing
+   * 
+   * @param g
+   *          Graphics object to draw with
+   * @param canvasWidth
+   *          width of drawing area
+   * @param canvasHeight
+   *          height of drawing area
+   * @param startRes
+   *          start residue of print area
+   */
+  public void drawWrappedPanelForPrinting(Graphics g, int canvasWidth,
+          int canvasHeight, int startRes)
+  {
+    SequenceGroup group = av.getSelectionGroup();
+
+    drawWrappedPanel(g, canvasWidth, canvasHeight, startRes);
+
+    if (group != null)
     {
+      BufferedImage selectImage = null;
       try
       {
-        lcimg = img = new BufferedImage(imgWidth, imgHeight,
-                BufferedImage.TYPE_INT_RGB);
-        gg = (Graphics2D) img.getGraphics();
-        gg.setFont(av.getFont());
+        selectImage = new BufferedImage(canvasWidth, canvasHeight,
+                BufferedImage.TYPE_INT_ARGB); // ARGB so alpha compositing works
       } catch (OutOfMemoryError er)
       {
         System.gc();
-        System.err.println("SeqCanvas OutOfMemory Redraw Error.\n" + er);
-        new OOMWarning("Creating alignment image for display", er);
-
-        return;
+        System.err.println("Print image OutOfMemory Error.\n" + er);
+        new OOMWarning("Creating wrapped alignment image for printing", er);
+      }
+      if (selectImage != null)
+      {
+        Graphics2D g2 = selectImage.createGraphics();
+        setupSelectionGroup(g2, selectImage);
+        drawWrappedSelection(g2, group, canvasWidth, canvasHeight,
+                startRes);
+
+        g2.setComposite(
+                AlphaComposite.getInstance(AlphaComposite.SRC_OVER));
+        g.drawImage(selectImage, 0, 0, this);
+        g2.dispose();
       }
     }
+  }
 
-    if (av.antiAlias)
+  /*
+   * Make a local image by combining the cached image img
+   * with any selection
+   */
+  private BufferedImage buildLocalImage(BufferedImage selectImage,
+          BufferedImage cursorImage)
+  {
+    // clone the cached image
+    BufferedImage lcimg = new BufferedImage(img.getWidth(), img.getHeight(),
+            img.getType());
+    Graphics2D g2d = lcimg.createGraphics();
+    g2d.drawImage(img, 0, 0, null);
+
+    // overlay selection group on lcimg
+    if (selectImage != null)
+    {
+      g2d.setComposite(
+              AlphaComposite.getInstance(AlphaComposite.SRC_OVER));
+      g2d.drawImage(selectImage, 0, 0, this);
+    }
+    // overlay cursor on lcimg
+    if (cursorImage != null)
     {
-      gg.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
-              RenderingHints.VALUE_ANTIALIAS_ON);
+      g2d.setComposite(AlphaComposite.getInstance(AlphaComposite.SRC_OVER));
+      g2d.drawImage(cursorImage, 0, 0, this);
     }
+    g2d.dispose();
 
-    gg.setColor(Color.white);
-    gg.fillRect(0, 0, imgWidth, imgHeight);
+    return lcimg;
+  }
 
-    ViewportRanges ranges = av.getRanges();
-    if (av.getWrapAlignment())
+  /*
+   * Set up a buffered image of the correct height and size for the sequence canvas
+   */
+  private BufferedImage setupImage()
+  {
+    BufferedImage lcimg = null;
+
+    int charWidth = av.getCharWidth();
+    int charHeight = av.getCharHeight();
+    
+    int width = getWidth();
+    int height = getHeight();
+
+    width -= (width % charWidth);
+    height -= (height % charHeight);
+
+    if ((width < 1) || (height < 1))
     {
-      drawWrappedPanel(gg, getWidth(), getHeight(), ranges.getStartRes());
+      return null;
     }
-    else
+
+    try
     {
-      drawPanel(gg, ranges.getStartRes(), ranges.getEndRes(),
-              ranges.getStartSeq(), ranges.getEndSeq(), 0);
-    }
+      lcimg = new BufferedImage(width, height,
+              BufferedImage.TYPE_INT_ARGB); // ARGB so alpha compositing works
+    } catch (OutOfMemoryError er)
+    {
+      System.gc();
+      System.err.println(
+              "Group image OutOfMemory Redraw Error.\n" + er);
+      new OOMWarning("Creating alignment image for display", er);
 
-    g.drawImage(lcimg, 0, 0, this);
+      return null;
+    }
 
+    return lcimg;
   }
 
   /**
@@ -437,29 +572,30 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    */
   public int getWrappedCanvasWidth(int canvasWidth)
   {
-    FontMetrics fm = getFontMetrics(av.getFont());
+    int charWidth = av.getCharWidth();
 
-    labelWidthEast = 0;
-    labelWidthWest = 0;
+    FontMetrics fm = getFontMetrics(av.getFont());
 
-    if (av.getScaleRightWrapped())
+    int labelWidth = 0;
+    
+    if (av.getScaleRightWrapped() || av.getScaleLeftWrapped())
     {
-      labelWidthEast = getLabelWidth(fm);
+      labelWidth = getLabelWidth(fm);
     }
 
-    if (av.getScaleLeftWrapped())
-    {
-      labelWidthWest = labelWidthEast > 0 ? labelWidthEast
-              : getLabelWidth(fm);
-    }
+    labelWidthEast = av.getScaleRightWrapped() ? labelWidth : 0;
+
+    labelWidthWest = av.getScaleLeftWrapped() ? labelWidth : 0;
 
     return (canvasWidth - labelWidthEast - labelWidthWest) / charWidth;
   }
 
   /**
-   * Returns a pixel width suitable for showing the largest sequence coordinate
-   * (end position) in the alignment. Returns 2 plus the number of decimal
-   * digits to be shown (3 for 1-10, 4 for 11-99 etc).
+   * Returns a pixel width sufficient to show the largest sequence coordinate
+   * (end position) in the alignment, calculated as the FontMetrics width of
+   * zeroes "0000000" limited to the number of decimal digits to be shown (3 for
+   * 1-10, 4 for 11-99 etc). One character width is added to this, to allow for
+   * half a character width space on either side.
    * 
    * @param fm
    * @return
@@ -477,13 +613,13 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
       maxWidth = Math.max(maxWidth, alignment.getSequenceAt(i).getEnd());
     }
 
-    int length = 2;
+    int length = 0;
     for (int i = maxWidth; i > 0; i /= 10)
     {
       length++;
     }
 
-    return fm.stringWidth(ZEROS.substring(0, length));
+    return fm.stringWidth(ZEROS.substring(0, length)) + av.getCharWidth();
   }
 
   /**
@@ -501,8 +637,6 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   public void drawWrappedPanel(Graphics g, int canvasWidth,
           int canvasHeight, final int startColumn)
   {
-    updateViewport();
-
     int wrappedWidthInResidues = calculateWrappedGeometry(canvasWidth,
             canvasHeight);
 
@@ -515,20 +649,19 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
      * draw one width at a time (including any scales or annotation shown),
      * until we have run out of either alignment or vertical space available
      */
-    int yposMax = canvasHeight;
-    // ensure room for at least one sequence
-    yposMax -= wrappedSpaceAboveAlignment - charHeight;
     int ypos = wrappedSpaceAboveAlignment;
     int maxWidth = ranges.getVisibleAlignmentWidth();
 
     int start = startColumn;
-    while ((ypos <= yposMax) && (start < maxWidth))
+    int currentWidth = 0;
+    while ((currentWidth < wrappedVisibleWidths) && (start < maxWidth))
     {
       int endColumn = Math
               .min(maxWidth, start + wrappedWidthInResidues - 1);
       drawWrappedWidth(g, ypos, start, endColumn, canvasHeight);
       ypos += wrappedRepeatHeightPx;
       start += wrappedWidthInResidues;
+      currentWidth++;
     }
 
     drawWrappedDecorators(g, startColumn);
@@ -550,20 +683,11 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    */
   protected int calculateWrappedGeometry(int canvasWidth, int canvasHeight)
   {
-    /*
-     * width of labels in pixels left and right (if shown)
-     */
-    int labelWidth = 0;
-    if (av.getScaleRightWrapped() || av.getScaleLeftWrapped())
-    {
-      FontMetrics fm = getFontMetrics(av.getFont());
-      labelWidth = getLabelWidth(fm);
-    }
-    labelWidthEast = av.getScaleRightWrapped() ? labelWidth : 0;
-    labelWidthWest = av.getScaleLeftWrapped() ? labelWidth : 0;
+    int charHeight = av.getCharHeight();
 
     /*
      * vertical space in pixels between wrapped widths of alignment
+     * - one character height, or two if scale above is drawn
      */
     wrappedSpaceAboveAlignment = charHeight
             * (av.getScaleAboveWrapped() ? 2 : 1);
@@ -573,15 +697,16 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
      */
     wrappedRepeatHeightPx = wrappedSpaceAboveAlignment;
     // add sequences
-    wrappedRepeatHeightPx += av.getRanges().getViewportHeight() * charHeight;
+    wrappedRepeatHeightPx += av.getRanges().getViewportHeight()
+            * charHeight;
     // add annotations panel height if shown
     wrappedRepeatHeightPx += getAnnotationHeight();
 
     /*
-     * number of visible widths (the last one may be part height)
+     * number of visible widths (the last one may be part height),
+     * ensuring a part height includes at least one sequence
      */
     ViewportRanges ranges = av.getRanges();
-    int xMax = ranges.getVisibleAlignmentWidth();
     wrappedVisibleWidths = canvasHeight / wrappedRepeatHeightPx;
     int remainder = canvasHeight % wrappedRepeatHeightPx;
     if (remainder >= (wrappedSpaceAboveAlignment + charHeight))
@@ -590,21 +715,22 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     }
 
     /*
+     * compute width in residues; this also sets East and West label widths
+     */
+    int wrappedWidthInResidues = getWrappedCanvasWidth(canvasWidth);
+
+    /*
      *  limit visibleWidths to not exceed width of alignment
      */
-    int viewportWidth = ranges.getViewportWidth();
-    int maxWidths = (xMax - ranges.getStartRes()) / viewportWidth;
-    if (xMax % viewportWidth > 0)
+    int xMax = ranges.getVisibleAlignmentWidth();
+    int startToEnd = xMax - ranges.getStartRes();
+    int maxWidths = startToEnd / wrappedWidthInResidues;
+    if (startToEnd % wrappedWidthInResidues > 0)
     {
       maxWidths++;
     }
     wrappedVisibleWidths = Math.min(wrappedVisibleWidths, maxWidths);
 
-    /*
-     * number of whole width residue columns we can show in each row
-     */
-    int wrappedWidthInResidues = (canvasWidth - labelWidthEast - labelWidthWest)
-            / charWidth;
     return wrappedWidthInResidues;
   }
 
@@ -618,8 +744,8 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    * @param endColumn
    * @param canvasHeight
    */
-  protected void drawWrappedWidth(Graphics g, int ypos,
-          int startColumn, int endColumn, int canvasHeight)
+  protected void drawWrappedWidth(Graphics g, int ypos, int startColumn,
+          int endColumn, int canvasHeight)
   {
     ViewportRanges ranges = av.getRanges();
     int viewportWidth = ranges.getViewportWidth();
@@ -628,9 +754,10 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
 
     /*
      * move right before drawing by the width of the scale left (if any)
-     * plus column offset from left margin (usually zero, but may not be
-     * when fast painting draws just a few columns)
+     * plus column offset from left margin (usually zero, but may be non-zero
+     * when fast painting is drawing just a few columns)
      */
+    int charWidth = av.getCharWidth();
     int xOffset = labelWidthWest
             + ((startColumn - ranges.getStartRes()) % viewportWidth)
             * charWidth;
@@ -650,10 +777,18 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
               viewportWidth * charWidth, (int) clip.getBounds().getHeight());
     }
 
+    /*
+     * white fill the region to be drawn (so incremental fast paint doesn't
+     * scribble over an existing image)
+     */
+    gg.setColor(Color.white);
+    gg.fillRect(0, ypos, (endx - startColumn + 1) * charWidth,
+            wrappedRepeatHeightPx);
+
     drawPanel(g, startColumn, endx, 0, av.getAlignment().getHeight() - 1,
             ypos);
 
-    int cHeight = av.getAlignment().getHeight() * charHeight;
+    int cHeight = av.getAlignment().getHeight() * av.getCharHeight();
 
     if (av.isShowAnnotation())
     {
@@ -678,8 +813,10 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
    * @param g
    * @param startColumn
    */
-  protected void drawWrappedDecorators(Graphics g, int startColumn)
+  protected void drawWrappedDecorators(Graphics g, final int startColumn)
   {
+    int charWidth = av.getCharWidth();
+
     g.setFont(av.getFont());
     g.setColor(Color.black);
 
@@ -688,50 +825,60 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     int viewportWidth = ranges.getViewportWidth();
     int maxWidth = ranges.getVisibleAlignmentWidth();
     int widthsDrawn = 0;
+    int startCol = startColumn;
+
     while (widthsDrawn < wrappedVisibleWidths)
     {
-      int endColumn = Math.min(maxWidth, startColumn + viewportWidth - 1);
+      int endColumn = Math.min(maxWidth, startCol + viewportWidth - 1);
 
       if (av.getScaleLeftWrapped())
       {
-        drawVerticalScale(g, startColumn, endColumn - 1, ypos, true);
+        drawVerticalScale(g, startCol, endColumn - 1, ypos, true);
       }
 
       if (av.getScaleRightWrapped())
       {
-        drawVerticalScale(g, startColumn, endColumn, ypos, false);
+        int x = labelWidthWest + viewportWidth * charWidth;
+        g.translate(x, 0);
+        drawVerticalScale(g, startCol, endColumn, ypos, false);
+        g.translate(-x, 0);
       }
 
-      g.translate(labelWidthWest, 0);
-
       /*
        * white fill region of scale above and hidden column markers
        * (to support incremental fast paint of image)
        */
+      g.translate(labelWidthWest, 0);
       g.setColor(Color.white);
       g.fillRect(0, ypos - wrappedSpaceAboveAlignment, viewportWidth
-              * charWidth, wrappedSpaceAboveAlignment);
+              * charWidth + labelWidthWest, wrappedSpaceAboveAlignment);
       g.setColor(Color.black);
+      g.translate(-labelWidthWest, 0);
+
+      g.translate(labelWidthWest, 0);
 
       if (av.getScaleAboveWrapped())
       {
-        drawNorthScale(g, startColumn, endColumn, ypos);
+        drawNorthScale(g, startCol, endColumn, ypos);
       }
 
       if (av.hasHiddenColumns() && av.getShowHiddenMarkers())
       {
-        drawHiddenColumnMarkers(g, ypos, startColumn, endColumn);
+        drawHiddenColumnMarkers(g, ypos, startCol, endColumn);
       }
 
       g.translate(-labelWidthWest, 0);
 
       ypos += wrappedRepeatHeightPx;
-      startColumn += viewportWidth;
+      startCol += viewportWidth;
       widthsDrawn++;
     }
   }
 
   /**
+   * Draws markers (triangles) above hidden column positions between startColumn
+   * and endColumn.
+   * 
    * @param g
    * @param ypos
    * @param startColumn
@@ -740,6 +887,9 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   protected void drawHiddenColumnMarkers(Graphics g, int ypos,
           int startColumn, int endColumn)
   {
+    int charHeight = av.getCharHeight();
+    int charWidth = av.getCharWidth();
+
     g.setColor(Color.blue);
     HiddenColumns hidden = av.getAlignment().getHiddenColumns();
     List<Integer> positions = hidden.findHiddenRegionPositions();
@@ -747,7 +897,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     {
       int res = pos - startColumn;
 
-      if (res < 0 || res > endColumn - startColumn)
+      if (res < 0 || res > endColumn - startColumn + 1)
       {
         continue;
       }
@@ -761,7 +911,67 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
           xMiddle + charHeight / 4, xMiddle };
       int yTop = ypos - (charHeight / 2);
       int[] yPoints = new int[] { yTop, yTop, yTop + 8 };
-      gg.fillPolygon(xPoints, yPoints, 3);
+      g.fillPolygon(xPoints, yPoints, 3);
+    }
+  }
+
+  /*
+   * Draw a selection group over a wrapped alignment
+   */
+  private void drawWrappedSelection(Graphics2D g, SequenceGroup group,
+          int canvasWidth,
+          int canvasHeight, int startRes)
+  {
+	int charHeight = av.getCharHeight();
+	int charWidth = av.getCharWidth();
+	  
+    // height gap above each panel
+    int hgap = charHeight;
+    if (av.getScaleAboveWrapped())
+    {
+      hgap += charHeight;
+    }
+
+    int cWidth = (canvasWidth - labelWidthEast - labelWidthWest)
+            / charWidth;
+    int cHeight = av.getAlignment().getHeight() * charHeight;
+
+    int startx = startRes;
+    int endx;
+    int ypos = hgap; // vertical offset
+    int maxwidth = av.getAlignment().getWidth();
+
+    if (av.hasHiddenColumns())
+    {
+      maxwidth = av.getAlignment().getHiddenColumns()
+              .findColumnPosition(maxwidth);
+    }
+
+    // chop the wrapped alignment extent up into panel-sized blocks and treat
+    // each block as if it were a block from an unwrapped alignment
+    while ((ypos <= canvasHeight) && (startx < maxwidth))
+    {
+      // set end value to be start + width, or maxwidth, whichever is smaller
+      endx = startx + cWidth - 1;
+
+      if (endx > maxwidth)
+      {
+        endx = maxwidth;
+      }
+
+      g.translate(labelWidthWest, 0);
+
+      drawUnwrappedSelection(g, group, startx, endx, 0,
+              av.getAlignment().getHeight() - 1,
+              ypos);
+
+      g.translate(-labelWidthWest, 0);
+
+      // update vertical offset
+      ypos += cHeight + getAnnotationHeight() + hgap;
+
+      // update horizontal offset
+      startx += cWidth;
     }
   }
 
@@ -802,7 +1012,9 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   public void drawPanel(Graphics g1, final int startRes, final int endRes,
           final int startSeq, final int endSeq, final int yOffset)
   {
-    updateViewport();
+    int charHeight = av.getCharHeight();
+    int charWidth = av.getCharWidth();
+
     if (!av.hasHiddenColumns())
     {
       draw(g1, startRes, endRes, startSeq, endSeq, yOffset);
@@ -892,8 +1104,11 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   private void draw(Graphics g, int startRes, int endRes, int startSeq,
           int endSeq, int offset)
   {
+    int charHeight = av.getCharHeight();
+    int charWidth = av.getCharWidth();
+
     g.setFont(av.getFont());
-    sr.prepare(g, av.isRenderGaps());
+    seqRdr.prepare(g, av.isRenderGaps());
 
     SequenceI nextSeq;
 
@@ -908,13 +1123,13 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
         // empty
         continue;
       }
-      sr.drawSequence(nextSeq, av.getAlignment().findAllGroups(nextSeq),
+      seqRdr.drawSequence(nextSeq, av.getAlignment().findAllGroups(nextSeq),
               startRes, endRes, offset + ((i - startSeq) * charHeight));
 
       if (av.isShowSequenceFeatures())
       {
-        fr.drawSequence(g, nextSeq, startRes, endRes, offset
-                + ((i - startSeq) * charHeight), false);
+        fr.drawSequence(g, nextSeq, startRes, endRes,
+                offset + ((i - startSeq) * charHeight), false);
       }
 
       /*
@@ -929,7 +1144,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
         {
           for (int r = 0; r < visibleResults.length; r += 2)
           {
-            sr.drawHighlightedText(nextSeq, visibleResults[r],
+            seqRdr.drawHighlightedText(nextSeq, visibleResults[r],
                     visibleResults[r + 1], (visibleResults[r] - startRes)
                             * charWidth, offset
                             + ((i - startSeq) * charHeight));
@@ -937,12 +1152,12 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
         }
       }
 
-      if (av.cursorMode && cursorY == i && cursorX >= startRes
+      /*      if (av.cursorMode && cursorY == i && cursorX >= startRes
               && cursorX <= endRes)
       {
-        sr.drawCursor(nextSeq, cursorX, (cursorX - startRes) * charWidth,
+        seqRdr.drawCursor(nextSeq, cursorX, (cursorX - startRes) * charWidth,
                 offset + ((i - startSeq) * charHeight));
-      }
+      }*/
     }
 
     if (av.getSelectionGroup() != null
@@ -961,15 +1176,11 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     // ///////////////////////////////////
     // Now outline any areas if necessary
     // ///////////////////////////////////
-    SequenceGroup group = av.getSelectionGroup();
 
-    int sx = -1;
-    int sy = -1;
-    int ex = -1;
+    SequenceGroup group = null;
     int groupIndex = -1;
-    int visWidth = (endRes - startRes + 1) * charWidth;
 
-    if ((group == null) && (av.getAlignment().getGroups().size() > 0))
+    if (av.getAlignment().getGroups().size() > 0)
     {
       group = av.getAlignment().getGroups().get(0);
       groupIndex = 0;
@@ -977,169 +1188,368 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
 
     if (group != null)
     {
+      g.setStroke(new BasicStroke());
+      g.setColor(group.getOutlineColour());
+      
       do
       {
-        int oldY = -1;
-        int i = 0;
-        boolean inGroup = false;
-        int top = -1;
-        int bottom = -1;
+        drawPartialGroupOutline(g, group, startRes, endRes, startSeq,
+                endSeq, offset);
 
-        for (i = startSeq; i <= endSeq; i++)
+        groupIndex++;
+
+        g.setStroke(new BasicStroke());
+
+        if (groupIndex >= av.getAlignment().getGroups().size())
         {
-          sx = (group.getStartRes() - startRes) * charWidth;
-          sy = offset + ((i - startSeq) * charHeight);
-          ex = (((group.getEndRes() + 1) - group.getStartRes()) * charWidth) - 1;
+          break;
+        }
 
-          if (sx + ex < 0 || sx > visWidth)
-          {
-            continue;
-          }
+        group = av.getAlignment().getGroups().get(groupIndex);
 
-          if ((sx <= (endRes - startRes) * charWidth)
-                  && group.getSequences(null).contains(
-                          av.getAlignment().getSequenceAt(i)))
-          {
-            if ((bottom == -1)
-                    && !group.getSequences(null).contains(
-                            av.getAlignment().getSequenceAt(i + 1)))
-            {
-              bottom = sy + charHeight;
-            }
+      } while (groupIndex < av.getAlignment().getGroups().size());
 
-            if (!inGroup)
-            {
-              if (((top == -1) && (i == 0))
-                      || !group.getSequences(null).contains(
-                              av.getAlignment().getSequenceAt(i - 1)))
-              {
-                top = sy;
-              }
+    }
 
-              oldY = sy;
-              inGroup = true;
+  }
 
-              if (group == av.getSelectionGroup())
-              {
-                g.setStroke(new BasicStroke(1, BasicStroke.CAP_BUTT,
-                        BasicStroke.JOIN_ROUND, 3f, new float[] { 5f, 3f },
-                        0f));
-                g.setColor(Color.RED);
-              }
-              else
-              {
-                g.setStroke(new BasicStroke());
-                g.setColor(group.getOutlineColour());
-              }
-            }
-          }
-          else
-          {
-            if (inGroup)
-            {
-              if (sx >= 0 && sx < visWidth)
-              {
-                g.drawLine(sx, oldY, sx, sy);
-              }
 
-              if (sx + ex < visWidth)
-              {
-                g.drawLine(sx + ex, oldY, sx + ex, sy);
-              }
+  /*
+   * Draw the selection group as a separate image and overlay
+   */
+  private BufferedImage drawSelectionGroup(int startRes, int endRes,
+          int startSeq, int endSeq)
+  {
+    // get a new image of the correct size
+    BufferedImage selectionImage = setupImage();
 
-              if (sx < 0)
-              {
-                ex += sx;
-                sx = 0;
-              }
+    if (selectionImage == null)
+    {
+      return null;
+    }
 
-              if (sx + ex > visWidth)
-              {
-                ex = visWidth;
-              }
+    SequenceGroup group = av.getSelectionGroup();
+    if (group == null)
+    {
+      // nothing to draw
+      return null;
+    }
 
-              else if (sx + ex >= (endRes - startRes + 1) * charWidth)
-              {
-                ex = (endRes - startRes + 1) * charWidth;
-              }
+    // set up drawing colour
+    Graphics2D g = (Graphics2D) selectionImage.getGraphics();
 
-              if (top != -1)
-              {
-                g.drawLine(sx, top, sx + ex, top);
-                top = -1;
-              }
+    setupSelectionGroup(g, selectionImage);
 
-              if (bottom != -1)
-              {
-                g.drawLine(sx, bottom, sx + ex, bottom);
-                bottom = -1;
-              }
+    if (!av.getWrapAlignment())
+    {
+      drawUnwrappedSelection(g, group, startRes, endRes, startSeq, endSeq,
+              0);
+    }
+    else
+    {
+      drawWrappedSelection(g, group, getWidth(), getHeight(),
+              av.getRanges().getStartRes());
+    }
 
-              inGroup = false;
-            }
-          }
+    g.dispose();
+    return selectionImage;
+  }
+
+  /**
+   * Draw the cursor as a separate image and overlay
+   * 
+   * @param startRes
+   *          start residue of area to draw cursor in
+   * @param endRes
+   *          end residue of area to draw cursor in
+   * @param startSeq
+   *          start sequence of area to draw cursor in
+   * @param endSeq
+   *          end sequence of are to draw cursor in
+   * @return a transparent image of the same size as the sequence canvas, with
+   *         the cursor drawn on it, if any
+   */
+  private BufferedImage drawCursor(int startRes, int endRes, int startSeq,
+          int endSeq)
+  {
+    // define our cursor image
+    BufferedImage cursorImage = null;
+
+    if (av.cursorMode && cursorY >= startSeq && cursorY <= endSeq
+            && cursorX >= startRes && cursorX <= endRes)
+    {
+      // get a new image of the correct size
+      cursorImage = setupImage();
+      Graphics2D g = (Graphics2D) cursorImage.getGraphics();
+
+      // get the character the cursor is drawn at
+      SequenceI seq = av.getAlignment().getSequenceAt(cursorY);
+      char s = seq.getCharAt(cursorX);
+
+      int offset = 0;
+      if (av.getWrapAlignment())
+      {
+        // work out the correct offset for the cursor
+        offset = wrappedSpaceAboveAlignment;
+        int currentWidth = 0;
+        while ((currentWidth < wrappedVisibleWidths)
+                && (currentWidth < cursorX))
+        {
+          offset += wrappedRepeatHeightPx;
+          currentWidth++;
         }
+      }
+
+      seqRdr.drawCursor(g, s,
+              (cursorX - startRes) * av.getCharWidth(),
+              offset + ((cursorY - startSeq) * av.getCharHeight()));
+      g.dispose();
+    }
+
+    return cursorImage;
+  }
+
+  /*
+   * Set up graphics for selection group
+   */
+  private void setupSelectionGroup(Graphics2D g,
+          BufferedImage selectionImage)
+  {
+    // set background to transparent
+    g.setComposite(AlphaComposite.getInstance(AlphaComposite.CLEAR, 0.0f));
+    g.fillRect(0, 0, selectionImage.getWidth(), selectionImage.getHeight());
+
+    // set up foreground to draw red dashed line
+    g.setComposite(AlphaComposite.Src);
+    g.setStroke(new BasicStroke(1, BasicStroke.CAP_BUTT,
+            BasicStroke.JOIN_ROUND, 3f, new float[]
+    { 5f, 3f }, 0f));
+    g.setColor(Color.RED);
+  }
 
+  /*
+   * Draw a selection group over an unwrapped alignment
+   * @param g graphics object to draw with
+   * @param group selection group
+   * @param startRes start residue of area to draw
+   * @param endRes end residue of area to draw
+   * @param startSeq start sequence of area to draw
+   * @param endSeq end sequence of area to draw
+   * @param offset vertical offset (used when called from wrapped alignment code)
+   */
+  private void drawUnwrappedSelection(Graphics2D g, SequenceGroup group,
+          int startRes, int endRes, int startSeq, int endSeq, int offset)
+  {
+	int charWidth = av.getCharWidth();
+	  
+    if (!av.hasHiddenColumns())
+    {
+      drawPartialGroupOutline(g, group, startRes, endRes, startSeq, endSeq,
+              offset);
+    }
+    else
+    {
+      // package into blocks of visible columns
+      int screenY = 0;
+      int blockStart = startRes;
+      int blockEnd = endRes;
+
+      for (int[] region : av.getAlignment().getHiddenColumns()
+              .getHiddenColumnsCopy())
+      {
+        int hideStart = region[0];
+        int hideEnd = region[1];
+
+        if (hideStart <= blockStart)
+        {
+          blockStart += (hideEnd - hideStart) + 1;
+          continue;
+        }
+
+        blockEnd = hideStart - 1;
+
+        g.translate(screenY * charWidth, 0);
+        drawPartialGroupOutline(g, group,
+                blockStart, blockEnd, startSeq, endSeq, offset);
+
+        g.translate(-screenY * charWidth, 0);
+        screenY += blockEnd - blockStart + 1;
+        blockStart = hideEnd + 1;
+
+        if (screenY > (endRes - startRes))
+        {
+          // already rendered last block
+          break;
+        }
+      }
+
+      if (screenY <= (endRes - startRes))
+      {
+        // remaining visible region to render
+        blockEnd = blockStart + (endRes - startRes) - screenY;
+        g.translate(screenY * charWidth, 0);
+        drawPartialGroupOutline(g, group,
+                blockStart, blockEnd, startSeq, endSeq, offset);
+        
+        g.translate(-screenY * charWidth, 0);
+      }
+    }
+  }
+
+  /*
+   * Draw the selection group as a separate image and overlay
+   */
+  private void drawPartialGroupOutline(Graphics2D g, SequenceGroup group,
+          int startRes, int endRes, int startSeq, int endSeq,
+          int verticalOffset)
+  {
+	int charHeight = av.getCharHeight();
+	int charWidth = av.getCharWidth();
+	  
+    int visWidth = (endRes - startRes + 1) * charWidth;
+
+    int oldY = -1;
+    int i = 0;
+    boolean inGroup = false;
+    int top = -1;
+    int bottom = -1;
+
+    int sx = -1;
+    int sy = -1;
+    int xwidth = -1;
+
+    for (i = startSeq; i <= endSeq; i++)
+    {
+      // position of start residue of group relative to startRes, in pixels
+      sx = (group.getStartRes() - startRes) * charWidth;
+
+      // width of group in pixels
+      xwidth = (((group.getEndRes() + 1) - group.getStartRes()) * charWidth)
+              - 1;
+
+      sy = verticalOffset + (i - startSeq) * charHeight;
+
+      if (sx + xwidth < 0 || sx > visWidth)
+      {
+        continue;
+      }
+
+      if ((sx <= (endRes - startRes) * charWidth)
+              && group.getSequences(null)
+                      .contains(av.getAlignment().getSequenceAt(i)))
+      {
+        if ((bottom == -1) && !group.getSequences(null)
+                .contains(av.getAlignment().getSequenceAt(i + 1)))
+        {
+          bottom = sy + charHeight;
+        }
+
+        if (!inGroup)
+        {
+          if (((top == -1) && (i == 0)) || !group.getSequences(null)
+                  .contains(av.getAlignment().getSequenceAt(i - 1)))
+          {
+            top = sy;
+          }
+
+          oldY = sy;
+          inGroup = true;
+        }
+      }
+      else
+      {
         if (inGroup)
         {
-          sy = offset + ((i - startSeq) * charHeight);
+          // if start position is visible, draw vertical line to left of
+          // group
           if (sx >= 0 && sx < visWidth)
           {
             g.drawLine(sx, oldY, sx, sy);
           }
 
-          if (sx + ex < visWidth)
+          // if end position is visible, draw vertical line to right of
+          // group
+          if (sx + xwidth < visWidth)
           {
-            g.drawLine(sx + ex, oldY, sx + ex, sy);
+            g.drawLine(sx + xwidth, oldY, sx + xwidth, sy);
           }
 
           if (sx < 0)
           {
-            ex += sx;
+            xwidth += sx;
             sx = 0;
           }
 
-          if (sx + ex > visWidth)
-          {
-            ex = visWidth;
-          }
-          else if (sx + ex >= (endRes - startRes + 1) * charWidth)
+          // don't let width extend beyond current block, or group extent
+          // fixes JAL-2672
+          if (sx + xwidth >= (endRes - startRes + 1) * charWidth)
           {
-            ex = (endRes - startRes + 1) * charWidth;
+            xwidth = (endRes - startRes + 1) * charWidth - sx;
           }
-
+          
+          // draw horizontal line at top of group
           if (top != -1)
           {
-            g.drawLine(sx, top, sx + ex, top);
+            g.drawLine(sx, top, sx + xwidth, top);
             top = -1;
           }
 
+          // draw horizontal line at bottom of group
           if (bottom != -1)
           {
-            g.drawLine(sx, bottom - 1, sx + ex, bottom - 1);
+            g.drawLine(sx, bottom, sx + xwidth, bottom);
             bottom = -1;
           }
 
           inGroup = false;
         }
+      }
+    }
 
-        groupIndex++;
+    if (inGroup)
+    {
+      sy = verticalOffset + ((i - startSeq) * charHeight);
+      if (sx >= 0 && sx < visWidth)
+      {
+        g.drawLine(sx, oldY, sx, sy);
+      }
 
-        g.setStroke(new BasicStroke());
+      if (sx + xwidth < visWidth)
+      {
+        g.drawLine(sx + xwidth, oldY, sx + xwidth, sy);
+      }
 
-        if (groupIndex >= av.getAlignment().getGroups().size())
-        {
-          break;
-        }
+      if (sx < 0)
+      {
+        xwidth += sx;
+        sx = 0;
+      }
 
-        group = av.getAlignment().getGroups().get(groupIndex);
+      if (sx + xwidth > visWidth)
+      {
+        xwidth = visWidth;
+      }
+      else if (sx + xwidth >= (endRes - startRes + 1) * charWidth)
+      {
+        xwidth = (endRes - startRes + 1) * charWidth;
+      }
 
-      } while (groupIndex < av.getAlignment().getGroups().size());
+      if (top != -1)
+      {
+        g.drawLine(sx, top, sx + xwidth, top);
+        top = -1;
+      }
 
-    }
+      if (bottom != -1)
+      {
+        g.drawLine(sx, bottom - 1, sx + xwidth, bottom - 1);
+        bottom = -1;
+      }
 
+      inGroup = false;
+    }
   }
-
+  
   /**
    * Highlights search results in the visible region by rendering as white text
    * on a black background. Any previous highlighting is removed. Answers true
@@ -1164,14 +1574,11 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
       return false;
     }
     boolean wrapped = av.getWrapAlignment();
-
     try
     {
       fastPaint = !noFastPaint;
       fastpainting = fastPaint;
 
-      updateViewport();
-
       /*
        * to avoid redrawing the whole visible region, we instead
        * redraw just the minimal regions to remove previous highlights
@@ -1311,6 +1718,13 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   {
     String eventName = evt.getPropertyName();
 
+    if (eventName.equals(SequenceGroup.SEQ_GROUP_CHANGED))
+    {
+      fastPaint = true;
+      repaint();
+      return;
+    }
+
     int scrollX = 0;
     if (eventName.equals(ViewportRanges.STARTRES))
     {
@@ -1318,7 +1732,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
       // larger than the visible window
       ViewportRanges vpRanges = av.getRanges();
       scrollX = (int) evt.getNewValue() - (int) evt.getOldValue();
-      int range = vpRanges.getEndRes() - vpRanges.getStartRes();
+      int range = vpRanges.getViewportWidth();
       if (scrollX > range)
       {
         scrollX = range;
@@ -1334,9 +1748,10 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     // Here we only want to fastpaint on a scroll, with resize using a normal
     // paint, so scroll events are identified as changes to the horizontal or
     // vertical start value.
+
+    // scroll - startres and endres both change
     if (eventName.equals(ViewportRanges.STARTRES))
     {
-      // scroll - startres and endres both change
       if (av.getWrapAlignment())
       {
         fastPaintWrapped(scrollX);
@@ -1348,6 +1763,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     }
     else if (eventName.equals(ViewportRanges.STARTSEQ))
     {
+      // scroll
       fastPaint(0, (int) evt.getNewValue() - (int) evt.getOldValue());
     }
   }
@@ -1439,6 +1855,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
 
     ViewportRanges ranges = av.getRanges();
     int viewportWidth = ranges.getViewportWidth();
+    int charWidth = av.getCharWidth();
 
     /**
      * draw full height alignment in the second last row, last columns, if the
@@ -1450,7 +1867,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
 
     if (lastWidthPartHeight)
     {
-      int widthsAbove = visibleWidths - 2;
+      int widthsAbove = Math.max(0, visibleWidths - 2);
       int ypos = wrappedRepeatHeightPx * widthsAbove
               + wrappedSpaceAboveAlignment;
       int endRes = ranges.getEndRes();
@@ -1472,6 +1889,8 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     }
 
     /*
+     * draw newly visible columns in last wrapped width (none if we
+     * have reached the end of the alignment)
      * y-offset for drawing last width is height of widths above,
      * plus one gap row
      */
@@ -1480,7 +1899,6 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
             + wrappedSpaceAboveAlignment;
     int endRes = ranges.getEndRes();
     endRes += widthsAbove * viewportWidth;
-    endRes = Math.min(endRes, ranges.getVisibleAlignmentWidth());
     int startRes = endRes - columns + 1;
 
     /*
@@ -1497,7 +1915,10 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     gg.setFont(av.getFont());
     gg.setColor(Color.black);
 
-    drawWrappedWidth(gg, ypos, startRes, endRes, canvasHeight);
+    if (startRes < ranges.getVisibleAlignmentWidth())
+    {
+      drawWrappedWidth(gg, ypos, startRes, endRes, canvasHeight);
+    }
 
     /*
      * and finally, white fill any space below the visible alignment
@@ -1524,6 +1945,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     {
       return;
     }
+    int charWidth = av.getCharWidth();
 
     int canvasHeight = getHeight();
     ViewportRanges ranges = av.getRanges();
@@ -1596,6 +2018,7 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     }
   }
 
+  
   /**
    * Redraws any positions in the search results in the visible region of a
    * wrapped alignment. Any highlights are drawn depending on the search results
@@ -1612,11 +2035,13 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
     {
       return false;
     }
-  
+    int charHeight = av.getCharHeight();
+
     boolean matchFound = false;
 
+    calculateWrappedGeometry(getWidth(), getHeight());
     int wrappedWidth = av.getWrappedWidth();
-    int wrappedHeight = getRepeatHeightWrapped();
+    int wrappedHeight = wrappedRepeatHeightPx;
 
     ViewportRanges ranges = av.getRanges();
     int canvasHeight = getHeight();
@@ -1715,23 +2140,12 @@ public class SeqCanvas extends JComponent implements ViewportListenerI
   }
 
   /**
-   * Answers the height in pixels of a repeating section of the wrapped
-   * alignment, including space above, scale above if shown, sequences, and
-   * annotation panel if shown
+   * Answers the width in pixels of the left scale labels (0 if not shown)
    * 
    * @return
    */
-  protected int getRepeatHeightWrapped()
+  int getLabelWidthWest()
   {
-    // gap (and maybe scale) above
-    int repeatHeight = charHeight * (av.getScaleAboveWrapped() ? 2 : 1);
-
-    // add sequences
-    repeatHeight += av.getRanges().getViewportHeight() * charHeight;
-
-    // add annotations panel height if shown
-    repeatHeight += getAnnotationHeight();
-
-    return repeatHeight;
+    return labelWidthWest;
   }
 }