X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fgui%2FWsJobParameters.java;h=b19948999b9f6004f156629c357618938d17acd3;hb=a45774ee31d9f35d4eff46d54d7deab719afb092;hp=ce1c868ee31c54d766b6a43f3fae79b65ec72d8e;hpb=8a72704baf5131ce36224f1a837a986d4fe98f81;p=jalview.git

diff --git a/src/jalview/gui/WsJobParameters.java b/src/jalview/gui/WsJobParameters.java
index ce1c868..b199489 100644
--- a/src/jalview/gui/WsJobParameters.java
+++ b/src/jalview/gui/WsJobParameters.java
@@ -1,31 +1,55 @@
+/*
+ * Jalview - A Sequence Alignment Editor and Viewer (Version 2.7)
+ * Copyright (C) 2011 J Procter, AM Waterhouse, G Barton, M Clamp, S Searle
+ * 
+ * This file is part of Jalview.
+ * 
+ * Jalview is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License 
+ * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+ * 
+ * Jalview is distributed in the hope that it will be useful, but 
+ * WITHOUT ANY WARRANTY; without even the implied warranty 
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR 
+ * PURPOSE.  See the GNU General Public License for more details.
+ * 
+ * You should have received a copy of the GNU General Public License along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
+ */
 package jalview.gui;
 
+import jalview.gui.OptsAndParamsPage.OptionBox;
+import jalview.gui.OptsAndParamsPage.ParamBox;
+import jalview.ws.jws2.JabaParamStore;
+import jalview.ws.jws2.JabaPreset;
+import jalview.ws.jws2.Jws2Discoverer;
+import jalview.ws.jws2.Jws2Discoverer.Jws2Instance;
+import jalview.ws.params.ArgumentI;
+import jalview.ws.params.OptionI;
+import jalview.ws.params.ParamDatastoreI;
+import jalview.ws.params.ParameterI;
+import jalview.ws.params.ValueConstrainI;
+import jalview.ws.params.WsParamSetI;
+
 import java.awt.BorderLayout;
-import java.awt.Color;
 import java.awt.Component;
+import java.awt.Container;
 import java.awt.Dimension;
 import java.awt.FlowLayout;
 import java.awt.Font;
+import java.awt.GridBagConstraints;
+import java.awt.GridBagLayout;
 import java.awt.GridLayout;
 import java.awt.Rectangle;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
-import java.awt.event.ComponentEvent;
-import java.awt.event.ComponentListener;
-import java.awt.event.ContainerEvent;
-import java.awt.event.ContainerListener;
 import java.awt.event.ItemEvent;
 import java.awt.event.ItemListener;
-import java.awt.event.KeyEvent;
-import java.awt.event.KeyListener;
 import java.awt.event.MouseEvent;
 import java.awt.event.MouseListener;
 import java.awt.event.WindowEvent;
 import java.awt.event.WindowListener;
-import java.awt.event.WindowStateListener;
+import java.net.URL;
 import java.util.ArrayList;
-import java.util.EventObject;
-import java.util.HashSet;
 import java.util.Hashtable;
 import java.util.Iterator;
 import java.util.List;
@@ -35,26 +59,25 @@ import java.util.Vector;
 import javax.swing.JButton;
 import javax.swing.JCheckBox;
 import javax.swing.JComboBox;
+import javax.swing.JComponent;
 import javax.swing.JDialog;
 import javax.swing.JFrame;
 import javax.swing.JLabel;
-import javax.swing.JList;
+import javax.swing.JMenuItem;
 import javax.swing.JOptionPane;
 import javax.swing.JPanel;
+import javax.swing.JPopupMenu;
 import javax.swing.JScrollPane;
 import javax.swing.JSlider;
 import javax.swing.JSplitPane;
-import javax.swing.JTable;
+import javax.swing.JTabbedPane;
 import javax.swing.JTextArea;
 import javax.swing.JTextField;
-import javax.swing.ListSelectionModel;
-import javax.swing.SwingConstants;
-import javax.swing.SwingUtilities;
 import javax.swing.border.TitledBorder;
-import javax.swing.event.CellEditorListener;
 import javax.swing.event.ChangeEvent;
 import javax.swing.event.ChangeListener;
-import javax.swing.table.*;
+import javax.swing.event.DocumentEvent;
+import javax.swing.event.DocumentListener;
 
 import compbio.metadata.Argument;
 import compbio.metadata.Option;
@@ -62,20 +85,50 @@ import compbio.metadata.Parameter;
 import compbio.metadata.Preset;
 import compbio.metadata.PresetManager;
 import compbio.metadata.RunnerConfig;
-import compbio.metadata.ValueConstrain;
-import compbio.metadata.WrongParameterException;
 import compbio.metadata.ValueConstrain.Type;
 
-import jalview.ws.jws2.Jws2Discoverer;
-import jalview.ws.jws2.Jws2Discoverer.Jws2Instance;
-
+/**
+ * job parameter editing/browsing dialog box. User can browse existing settings
+ * (user + presets + Defaults), and any changes to parameters creates a modified
+ * user parameter set. LOGIC: If the parameter set is modified, and its name is
+ * a valid, non-existant user parameter set, then a save button is shown. If the
+ * parameter set is modified and its name is a valid, extant user parameter set,
+ * then an update button is shown. If user parameter set's name is edited, and
+ * old name exists as a writable user parameter set, then rename button is
+ * shown. If current parameter set is associated with a user defined parameter
+ * set, then : if set is modifed, a 'revert' button is shown. if set is not
+ * modified, a 'delete' button is shown.
+ * 
+ * @author JimP
+ * 
+ */
 public class WsJobParameters extends JPanel implements ItemListener,
-        ActionListener
+        ActionListener, DocumentListener, OptsParametersContainerI
 {
-  private static final int PARAM_WIDTH = 340, PARAM_HEIGHT = 150,
-          PARAM_CLOSEDHEIGHT = 80;
+  URL linkImageURL = getClass().getResource("/images/link.gif");
+
+  private static final String SVC_DEF = "Defaults"; // this is the null
+                                                    // parameter set as shown to
+                                                    // user
+
+  /**
+   * manager for options and parameters.
+   */
+  OptsAndParamsPage opanp = new OptsAndParamsPage(this);
+
+  /**
+   * panel containing job options
+   */
+  JPanel jobOptions = new JPanel();
+
+  /**
+   * panel containing job parameters
+   */
+  JPanel paramList = new JPanel();
 
-  private static final int OPTSET_HEIGHT = 30;
+  
+  
+  JPanel SetNamePanel = new JPanel();
 
   JPanel setDetails = new JPanel();
 
@@ -83,15 +136,18 @@ public class WsJobParameters extends JPanel implements ItemListener,
 
   JSplitPane jobPanel = new JSplitPane();
 
-  JPanel jobOptions = new JPanel();
 
   JScrollPane jobOptionsPane = new JScrollPane();
 
   JPanel jobParameters = new JPanel();
 
-  JButton savmodified = new JButton();
+  JButton createpref = new JButton();
 
-  JButton renmodified = new JButton();
+  JButton deletepref = new JButton();
+
+  JButton revertpref = new JButton();
+
+  JButton updatepref = new JButton();
 
   JButton startjob = new JButton();
 
@@ -103,21 +159,23 @@ public class WsJobParameters extends JPanel implements ItemListener,
 
   JScrollPane paramPane = new JScrollPane();
 
-  // JList paramList = new JList();
-  JPanel paramList = new JPanel();
+
+  JPanel optsAndparams = new JPanel();
 
   RunnerConfig serviceOptions;
 
-  private BorderLayout jparamLayout;
+  ParamDatastoreI paramStore;
+
+  private int MAX_OPTWIDTH = 200;
 
   WsJobParameters(Jws2Instance service)
   {
     this(service, null);
   }
 
-  public WsJobParameters(Jws2Instance service, Preset p)
+  public WsJobParameters(Jws2Instance service, WsParamSetI preset)
   {
-    this(null, service, p, null);
+    this(null, service, preset, null);
   }
 
   /**
@@ -125,16 +183,36 @@ public class WsJobParameters extends JPanel implements ItemListener,
    * @param desktop
    *          - if null, create new JFrame outside of desktop
    * @param service
-   * @param p
+   * @param preset
+   */
+  public WsJobParameters(JFrame parent, Jws2Instance service,
+          WsParamSetI preset, List<Argument> jobArgset)
+  {
+    this(parent, null, service, preset, jobArgset);
+  }
+
+  /**
+   * 
+   * @param parent
+   * @param paramStorei
+   * @param service
+   * @param preset
+   * @param jobArgset
    */
-  public WsJobParameters(JFrame parent, Jws2Instance service, Preset p,
-          List<Argument> jobArgset)
+  public WsJobParameters(JFrame parent, ParamDatastoreI paramStorei,
+          Jws2Instance service, WsParamSetI preset, List<Argument> jobArgset)
   {
     super();
     jbInit();
+    this.paramStore = paramStorei;
+    if (paramStore == null)
+    {
+      paramStore = service.getParamStore();
+    }
+    this.service = service;
     // argSetModified(false);
     // populate parameter table
-    initForService(service, p, jobArgset);
+    initForService(service, preset, jobArgset);
     // display in new JFrame attached to parent.
     validate();
   }
@@ -143,6 +221,11 @@ public class WsJobParameters extends JPanel implements ItemListener,
 
   JDialog frame = null;
 
+  /**
+   * shows a modal dialog containing the parameters.
+   * 
+   * @return
+   */
   public boolean showRunDialog()
   {
 
@@ -150,11 +233,23 @@ public class WsJobParameters extends JPanel implements ItemListener,
 
     frame.setTitle("Edit parameters for " + service.getActionText());
     Rectangle deskr = Desktop.instance.getBounds();
-    frame.setBounds(new Rectangle((int) (deskr.getCenterX() - 240),
-            (int) (deskr.getCenterY() - 92), 380, 385));
+    Dimension pref = this.getPreferredSize();
+    frame.setBounds(new Rectangle((int) (deskr.getCenterX() - pref.width/2),
+            (int) (deskr.getCenterY() - pref.height/2), pref.width, pref.height));
     frame.setContentPane(this);
+    
+    // should perhaps recover defaults from user prefs.
 
-    frame.setVisible(true);
+    frame.validate();
+    javax.swing.SwingUtilities.invokeLater(new Runnable()
+    {
+        public void run()
+        {
+          jobPanel.setDividerLocation(0.25); 
+
+        }
+      });
+  frame.setVisible(true);
 
     if (response > 0)
     {
@@ -165,53 +260,62 @@ public class WsJobParameters extends JPanel implements ItemListener,
 
   private void jbInit()
   {
-    savmodified.setText("Save");
-    savmodified.setToolTipText("Not implemented yet :) ");
-    savmodified.setFont(new java.awt.Font("Verdana", Font.PLAIN, 10));
-    savmodified.setForeground(Color.red);
-    savmodified.setHorizontalAlignment(SwingConstants.RIGHT);
-    savmodified.addActionListener(new ActionListener()
-    {
+    updatepref = JvSwingUtils.makeButton("Update",
+            "Update this existing user parameter set.",
+            new ActionListener()
+            {
 
-      public void actionPerformed(ActionEvent e)
-      {
-        savModified_actionPerformed(e);
-      }
-    });
-    renmodified.setText("Rename");
-    renmodified.setToolTipText("Not implemented yet :) ");
-    renmodified.setFont(new java.awt.Font("Verdana", Font.PLAIN, 10));
-    renmodified.setForeground(Color.red);
-    renmodified.setHorizontalAlignment(SwingConstants.CENTER);
-    renmodified.addActionListener(new ActionListener()
-    {
+              public void actionPerformed(ActionEvent e)
+              {
+                update_actionPerformed(e);
+              }
+            });
+    deletepref = JvSwingUtils.makeButton("Delete",
+            "Delete the currently selected user parameter set.",
+            new ActionListener()
+            {
 
-      public void actionPerformed(ActionEvent e)
-      {
-        renModified_actionPerformed(e);
-      }
-    });
-    renmodified.setVisible(false);
-    startjob.setFont(new java.awt.Font("Verdana", Font.PLAIN, 10));
-    startjob.setText("Start");
-    startjob.setToolTipText("Start Job");
-    startjob.addActionListener(new ActionListener()
-    {
-      public void actionPerformed(ActionEvent e)
-      {
-        startjob_actionPerformed(e);
-      }
-    });
-    canceljob.setFont(new java.awt.Font("Verdana", Font.PLAIN, 10));
-    canceljob.setText("Cancel");
-    canceljob.setToolTipText("Cancel Job");
-    canceljob.addActionListener(new ActionListener()
-    {
-      public void actionPerformed(ActionEvent e)
-      {
-        canceljob_actionPerformed(e);
-      }
-    });
+              public void actionPerformed(ActionEvent e)
+              {
+                delete_actionPerformed(e);
+              }
+            });
+    createpref = JvSwingUtils.makeButton("Create",
+            "Create a new parameter set with the current settings.",
+            new ActionListener()
+            {
+
+              public void actionPerformed(ActionEvent e)
+              {
+                create_actionPerformed(e);
+              }
+            });
+    revertpref = JvSwingUtils.makeButton("Revert",
+            "Undo all changes to the current parameter set",
+            new ActionListener()
+            {
+
+              public void actionPerformed(ActionEvent e)
+              {
+                revert_actionPerformed(e);
+              }
+            });
+    startjob = JvSwingUtils.makeButton("Start Job",
+            "Start Job with current settings.", new ActionListener()
+            {
+              public void actionPerformed(ActionEvent e)
+              {
+                startjob_actionPerformed(e);
+              }
+            });
+    canceljob = JvSwingUtils.makeButton("Cancel Job",
+            "Close this dialog and cancel job.", new ActionListener()
+            {
+              public void actionPerformed(ActionEvent e)
+              {
+                canceljob_actionPerformed(e);
+              }
+            });
 
     setDetails.setBorder(new TitledBorder("Details"));
     setDetails.setLayout(new BorderLayout());
@@ -219,71 +323,134 @@ public class WsJobParameters extends JPanel implements ItemListener,
     setDescr.setWrapStyleWord(true);
     setDescr.setLineWrap(true);
     setDescr.setBackground(getBackground());
-    setDescr.setEditable(false);
+    setDescr.setEditable(true);
+    setDescr.getDocument().addDocumentListener(this);
+    setDescr.setToolTipText("Click to edit the notes for this parameter set.");
     JScrollPane setDescrView = new JScrollPane();
     // setDescrView.setPreferredSize(new Dimension(350, 200));
     setDescrView.getViewport().setView(setDescr);
     setName.setEditable(true);
     setName.addItemListener(this);
     setName.getEditor().addActionListener(this);
-    savmodified.setEnabled(false); // initially unmodified parameters
-    // modified.setPreferredSize(new Dimension(15, 15));
-    JPanel SetNamePanel = new JPanel();
-    SetNamePanel.setLayout(new BorderLayout());
-    SetNamePanel.add(setName, BorderLayout.WEST);
-    SetNamePanel.add(renmodified, BorderLayout.CENTER);
-    SetNamePanel.add(savmodified, BorderLayout.EAST);
-    setDetails.add(SetNamePanel, BorderLayout.NORTH);
+    JPanel setNameInfo = new JPanel(new FlowLayout(FlowLayout.LEFT));
+    GridBagLayout gbl = new GridBagLayout();
+    SetNamePanel.setLayout(gbl);
+
+    JLabel setNameLabel = new JLabel("Current parameter set name :");
+    setNameLabel.setFont(new java.awt.Font("Verdana", Font.PLAIN, 10));
+    
+    setNameInfo.add(setNameLabel);
+    setNameInfo.add(setName);
+    
+    // initial button visibility
+    updatepref.setVisible(false);
+    deletepref.setVisible(false);
+    revertpref.setVisible(false);
+    createpref.setVisible(false);
+    JPanel setsavebuts = new JPanel();
+    setsavebuts.setLayout(new FlowLayout(FlowLayout.LEFT)); // GridLayout(1,2));
+    ((FlowLayout) setsavebuts.getLayout()).setHgap(10);
+    ((FlowLayout) setsavebuts.getLayout()).setVgap(0);
+    JPanel spacer = new JPanel();
+    spacer.setPreferredSize(new Dimension(2,30));
+    setsavebuts.add(spacer);
+    setsavebuts.add(deletepref);
+    setsavebuts.add(revertpref);
+    setsavebuts.add(createpref);
+    setsavebuts.add(updatepref);
+//    setsavebuts.setSize(new Dimension(150, 30));
+    JPanel buttonArea = new JPanel(new GridLayout(1, 1));
+    buttonArea.add(setsavebuts);
+    SetNamePanel.add(setNameInfo);
+    GridBagConstraints gbc = new GridBagConstraints();
+    gbc.gridheight = 2;
+    gbl.setConstraints(setNameInfo, gbc);
+    SetNamePanel.add(buttonArea);
+    gbc = new GridBagConstraints();
+    gbc.gridx = 0;
+    gbc.gridy = 2;
+    gbc.gridheight = 1;
+    gbl.setConstraints(buttonArea, gbc);
     setDetails.add(setDescrView, BorderLayout.CENTER);
-    // setDetails.setPreferredSize(new Dimension(360, 100));
-    jobParameters.setBorder(new TitledBorder("Parameters"));
-    jobParameters.setLayout(jparamLayout = new BorderLayout());
-    paramPane.setPreferredSize(new Dimension(360, 300));
-    paramPane.getVerticalScrollBar().setUnitIncrement(20);
-    // paramPanel.setPreferredSize(new Dimension(360, 300));
-    // TODO: relayout buttons nicely
-    paramPane.getViewport().setView(paramList);
-    jobParameters.add(paramPane, BorderLayout.CENTER);
-    JPanel jobOptionsPanel = new JPanel();
-    jobOptionsPanel.setLayout(new BorderLayout());
-    jobOptionsPanel.setBorder(new TitledBorder("Options"));
-    jobOptionsPane.getViewport().setView(jobOptions);
-    jobOptionsPanel.add(jobOptionsPane, BorderLayout.CENTER);
-    settingsPanel.setLeftComponent(jobOptionsPanel);
-    settingsPanel.setRightComponent(jobParameters);
-    settingsPanel.setOrientation(JSplitPane.VERTICAL_SPLIT);
-    settingsPanel.setDividerLocation(0.4);
 
+    jobParameters.setBorder(new TitledBorder("Parameters"));
+    paramPane.setPreferredSize(new Dimension(360, 400));
+    jobOptions.setBorder(new TitledBorder("Options"));
+    
+    paramList.setBorder(new TitledBorder("Parameters"));
+    
+    JPanel bjo=new JPanel(new BorderLayout()),bjp=new JPanel(new BorderLayout());
+    bjo.add(jobOptions, BorderLayout.CENTER);
+    bjp.add(paramList, BorderLayout.CENTER);
+    optsAndparams.setLayout(new BorderLayout()); 
+
+    optsAndparams.add(bjo, BorderLayout.CENTER);
+    optsAndparams.add(bjp, BorderLayout.SOUTH);
+    paramPane.setViewportView(optsAndparams);
+ 
     setLayout(new BorderLayout());
-    // setPreferredSize(new Dimension(400, 600));
-    // setSize(new Dimension(400, 600));
     jobPanel.setLeftComponent(setDetails);
-    jobPanel.setRightComponent(settingsPanel);
+    jobPanel.setRightComponent(paramPane);
     jobPanel.setOrientation(JSplitPane.VERTICAL_SPLIT);
-    jobPanel.setDividerLocation(0.8);
+
+    add(SetNamePanel, BorderLayout.NORTH);
     add(jobPanel, BorderLayout.CENTER);
+
     JPanel dialogpanel = new JPanel();
     dialogpanel.add(startjob);
     dialogpanel.add(canceljob);
     add(dialogpanel, BorderLayout.SOUTH);
   }
 
-  protected void renModified_actionPerformed(ActionEvent e)
+  protected void revert_actionPerformed(ActionEvent e)
   {
+    reInitDialog(lastParmSet);
 
-    // TODO Auto-generated method stub
-    // save current prefs with new name and delete user pref with old name
+  }
+
+  protected void update_actionPerformed(ActionEvent e)
+  {
+    if (isUserPreset)
+    {
+      String curname = ((String) setName.getSelectedItem()).trim();
+      _updatePreset(lastParmSet, curname);
+      lastParmSet = curname;
+      isUserPreset = true;
+      initArgSetModified();
+      syncSetNamesWithStore();
+    }
+  }
 
+  private void _deleteUserPreset(String lastParmSet2)
+  {
+    paramStore.deletePreset(lastParmSet2);
   }
 
-  protected void savModified_actionPerformed(ActionEvent e)
+  protected void delete_actionPerformed(ActionEvent e)
   {
-    // TODO Auto-generated method stub
-    // Store the current settings
-    // write out param file and name.
-    // update gui
-    initArgSetModified();  // reset the modification state
+    if (isUserPreset)
+    {
+      // delete current preset's saved entry
+      _deleteUserPreset(lastParmSet);
+    }
+    reInitDialog(null); // service default
+  }
 
+  protected void create_actionPerformed(ActionEvent e)
+  {
+    String curname = ((String) setName.getSelectedItem()).trim();
+    if (curname.length() > 0)
+    {
+      _storeCurrentPreset(curname);
+      lastParmSet = curname;
+      isUserPreset = true;
+      initArgSetModified();
+    }
+    else
+    {
+      // TODO: show warning
+      System.err.println("Invalid name. Not saved.");
+    }
   }
 
   protected void canceljob_actionPerformed(ActionEvent e)
@@ -307,84 +474,115 @@ public class WsJobParameters extends JPanel implements ItemListener,
   Jws2Instance service;
 
   /**
+   * list of service presets in the gui
+   */
+  Hashtable servicePresets = null;
+
+  /**
    * set if dialog is being set - so handlers will avoid spurious events
    */
   boolean settingDialog = false;
 
-  void initForService(Jws2Instance service, Preset p,
-          List<Argument> jobArgset)
+  void initForService(Jws2Instance service, WsParamSetI jabap,
+          List<Argument> jabajobArgset)
   {
+    WsParamSetI p = null;
+    List<ArgumentI> jobArgset = null;
     settingDialog = true;
-    this.service = service;
-    // TODO: Recover window geometry prefs for this service
-    // jobPanel.setDividerLocation(proportionalLocation)
-    // settingsPanel.setDividerLocation(proportionalLocation)
+    { // instantiate the abstract proxy for Jaba objects
+      jobArgset = jabajobArgset == null ? null : JabaParamStore
+              .getJwsArgsfromJaba(jabajobArgset);
+      p = jabap; // (jabap != null) ? paramStore.getPreset(jabap.getName()) :
+                 // null;
+    }
+
     Hashtable exnames = new Hashtable();
-    for (int i=0,iSize=setName.getItemCount(); i<iSize; i++)
+    for (int i = 0, iSize = setName.getItemCount(); i < iSize; i++)
     {
-      exnames.put((String) setName.getItemAt(i),setName.getItemAt(i));
+      exnames.put((String) setName.getItemAt(i), setName.getItemAt(i));
     }
+    servicePresets = new Hashtable();
     // Add the default entry - if not present already.
-    if (!exnames.contains("Defaults"))
+    if (!exnames.contains(SVC_DEF))
     {
-      setName.addItem("Defaults");
-      exnames.put("Defaults", "Defaults");
+      setName.addItem(SVC_DEF);
+      exnames.put(SVC_DEF, SVC_DEF);
+      servicePresets.put(SVC_DEF, SVC_DEF);
     }
-    serviceOptions = service.getRunnerConfig();
-    // add any presets not already added.
     String curname = (p == null ? "" : p.getName());
-    PresetManager prman = service.getPresets();
-    if (prman != null)
+    for (WsParamSetI pr : paramStore.getPresets())
     {
-      List prList = service.getPresets().getPresets();
-      if (prList != null)
+      if (!pr.isModifiable())
       {
-        for (Object pr : prList)
-        {
-          if (!exnames.contains(((Preset) pr).getName()))
-          {
-            setName.addItem(((Preset) pr).getName());
-          }
-        }
+        servicePresets.put(pr.getName(), "preset");
+      }
+      else
+      {
+      }
+      if (!exnames.contains(pr.getName()))
+      {
+        setName.addItem(pr.getName());
+      }
+    }
+    // TODO: if initial jobArgset matches a given user setting or preset then
+    // should recover setting accordingly
+    // updateTable(p, jobArgset);
+    if (p != null)
+    {
+      reInitDialog(p.getName());
+      initArgSetModified();
+    }
+    else
+    {
+      if (jobArgset != null && jobArgset.size() > 0)
+      {
+        curSetName = "Supplied Settings";
+        updateTable(p, jobArgset);
+      }
+      else
+      {
+        curSetName = null;
+        reInitDialog(null);
       }
     }
-    updateTable(p, jobArgset);
-    initArgSetModified();
     settingDialog = false;
 
   }
 
   @SuppressWarnings("unchecked")
-  private void updateTable(Preset p, List<Argument> jobArgset)
+  private void updateTable(WsParamSetI p, List<ArgumentI> jobArgset)
   {
-    List<Parameter> setargs = new ArrayList<Parameter>();
     // populate table from default parameter set.
-    List<Argument> args = serviceOptions.getArguments();
+    List<ArgumentI> args = paramStore.getServiceParameters();
 
     // split to params and required arguments
     {
-      for (Argument arg : args)
+      for (ArgumentI myarg : args)
       {
-        Argument myarg = (Argument) arg;
         // Ideally, Argument would implement isRequired !
-        if (myarg instanceof Parameter)
+        if (myarg instanceof ParameterI)
         {
-          Parameter parm = (Parameter) myarg;
-          addParameter(parm);
+          ParameterI parm = (ParameterI) myarg;
+          paramList.add(opanp.addParameter(parm));
         }
         else
         {
-          if (myarg instanceof Option)
+          if (myarg instanceof OptionI)
           {
-            Option opt = (Option) myarg;
-            addOption(opt);
-            // Apply default value, always.
-            selectOption(opt, opt.getDefaultValue());
+            OptionI opt = (OptionI) myarg;
+            OptionBox ob = opanp.addOption(opt);
+            jobOptions.add(ob, FlowLayout.LEFT);
+            ob.resetToDefault();
+            if (MAX_OPTWIDTH < ob.getPreferredSize().width)
+            {
+              MAX_OPTWIDTH = ob.getPreferredSize().width;
+            }
+
           }
           else
           {
             System.err.println("Ignoring unknown service argument type "
-                    + arg.getClass().getName());
+                    + myarg.getClass().getName());
           }
         }
       }
@@ -392,53 +590,29 @@ public class WsJobParameters extends JPanel implements ItemListener,
     }
     if (p != null)
     {
+      isUserPreset = false;
       // initialise setname
-      setName.setSelectedItem(lastSetName=p.getName());
-      setDescr.setText(lastDescrText=p.getDescription());
+      setName.setSelectedItem(lastSetName = p.getName());
+      setDescr.setText(lastDescrText = p.getDescription());
       // TODO - URL link
       try
       {
-        args = p.getArguments(serviceOptions);
-        // quick test of getArguments
-        for (Object rg: p.getOptions())
-        {
-          String _rg = ((String) rg).substring(1);// remove initial arg character -
-          String _rgv = _rg;
-          // select arg name
-          int _rgs = _rg.indexOf(" ");
-          if (_rgs>0)
-          {
-            _rgv = _rg.substring(_rgs+1);
-            _rg = _rg.substring(0,_rgs);
-          }
-          boolean found=false;
-          for (Argument ar:args)
-          {
-            if (ar.getName().equalsIgnoreCase(_rg) || ar.getDefaultValue()!=null && ar.getDefaultValue().equalsIgnoreCase(_rgv))
-            {
-              found = true;
-              continue;
-            }
-          }
-          if (!found)
-          {
-            System.err.println("Couldn't set Argument: "+rg.toString());
-          }
-        }
+        args = p.getArguments();
       } catch (Exception e)
       {
         e.printStackTrace();
       }
       // TODO: check if args should be unselected prior to resetting using the
       // preset
-      setargs.clear();
     }
     else
     {
       if (lastParmSet == null)
       {
+        isUserPreset = false;
         // first call - so create a dummy name
-        setName.setSelectedItem(lastSetName="Defaults");
+
+        setName.setSelectedItem(lastSetName = SVC_DEF);
       }
     }
 
@@ -450,554 +624,221 @@ public class WsJobParameters extends JPanel implements ItemListener,
     // get setargs from current object
     if (args != null)
     {
-      for (Argument arg : args)
+      for (ArgumentI arg : args)
       {
-        if (arg instanceof Parameter)
+        if (arg instanceof ParameterI)
         {
-          setargs.add((Parameter) arg);
+          opanp.setParameter((ParameterI) arg);
         }
         else
         {
-          if (arg instanceof Option)
+          if (arg instanceof OptionI)
           {
-            System.out.println("Setting option "+arg.getName()+" with "+arg.getDefaultValue());
-            selectOption((Option) arg, arg.getDefaultValue());
+            // System.out.println("Setting option "
+            // + System.identityHashCode(arg) + ":" + arg.getName()
+            // + " with " + arg.getDefaultValue());
+            opanp.selectOption((OptionI) arg, arg.getValue());
           }
         }
 
       }
     }
 
-    // mdl.setData(setargs);
-    // jobOptions.setLayout(new GridLayout(optSet.size() / 2 + 1, 2));
-    jobOptions.setPreferredSize(new Dimension(PARAM_WIDTH, optSet.size()
-            * OPTSET_HEIGHT));
-    jobOptions.setLayout(new GridLayout(optSet.size(), 1));
     refreshParamLayout();
-    // paramPanel.setLayout(new GridLayout(paramSet.size(), 1));
-    // paramList.va
-    // paramPane.getViewport().validate();
-    paramPane.validate();
-    validate();
+    revalidate();
   }
 
   private boolean isModified()
   {
-    return savmodified.isEnabled();
+    return modifiedElements.size() > 0;
   }
 
   private Hashtable modifiedElements = new Hashtable();
+
   /**
    * reset gui and modification state settings
    */
-  private void initArgSetModified() {
+  private void initArgSetModified()
+  {
     curSetName = null;
     modifiedElements.clear();
-    renmodified.setVisible(false);
-    savmodified.setEnabled(false);
-    
+    updateButtonDisplay();
   }
-  private void argSetModified(Object modifiedElement, boolean b)
+
+  private void updateButtonDisplay()
   {
-    if (!b)
-    {
-      modifiedElements.remove(modifiedElement);
-    }
-    else
+    boolean _update = false, _create = false, _delete = false, _revert = false;
+    if (modifiedElements.size() > 0)
     {
-      modifiedElements.put(modifiedElement, modifiedElement);
-    }
-    // set mod status based on presence of elements in table
-    savmodified.setEnabled(modifiedElements.size() > 0);
-    // special reveal if setName has been modified
-    if (modifiedElements.get(setName) != null)
-    {
-      if (curSetName != null && lastSetName!=null && !lastSetName.equals(curSetName))
+      // set modified
+      _revert = true;
+      _update = isUserPreset; // can only update user presets
+      if (!isUserPreset || modifiedElements.containsKey(setName))
       {
-        // also test to see if lastSetName exists in preset store
-        renmodified.setVisible(true);
+        // name modified - can create new preset
+        _create = true;
       }
     }
     else
     {
-      // setname isn't in modlist - so don't rename
-      renmodified.setEnabled(false);
+      // set unmodified
     }
+    // can still delete a user preset
+    _delete = isUserPreset;
+
+    createpref.setVisible(_create);
+    updatepref.setVisible(_update);
+    deletepref.setVisible(_delete);
+    revertpref.setVisible(_revert);
     validate();
   }
 
-  private void addParameter(Parameter parm)
+  public void argSetModified(Object modifiedElement, boolean b)
   {
-    ParamBox pb = paramSet.get(parm.getName());
-    if (pb == null)
+    if (settingDialog)
     {
-      pb = new ParamBox(this, parm);
-      paramSet.put(parm.getName(), pb);
-      paramList.add(pb);
+      return;
     }
-    pb.init();
-    // take the defaults from the parameter
-    pb.updateControls(parm);
-  }
-
-  private void selectOption(Option opt, String string)
-  {
-    OptionBox cb = optSet.get(opt.getName());
-    if (cb == null)
+    if (!b)
     {
-      cb = addOption(opt);
+      modifiedElements.remove(modifiedElement);
     }
-    if (string == null)
+    else
     {
-      // no value specified.
-      if (opt.isRequired())
-      {
-        // indicate option needs to be selected!
-      }
-      else
+      if (b && modifiedElement == setName
+              && modifiedElements.contains(modifiedElement))
       {
-        cb.enabled.setSelected(false);
+        // HACK! prevents iteration on makeSetNameValid
+        b = false;
       }
+      modifiedElements.put(modifiedElement, modifiedElement);
     }
-    else
+    // set mod status based on presence of elements in table
+    if (b && modifiedElements.size() > 0)
     {
-      cb.enabled.setSelected(true);
-
-      if (opt.getPossibleValues().contains(string))
-      {
-        cb.val.setSelectedItem(string);
-      }
-      else
-      {
-        throw new Error("Invalid value " + string + " for option " + opt);
-      }
-
+      makeSetNameValid(!isUserPreset);
+      SetNamePanel.revalidate();
     }
-    cb.setInitialValue();
+    updateButtonDisplay();
   }
 
-  Map<String, ParamBox> paramSet = new Hashtable<String, ParamBox>();
-
-  public class ParamBox extends JPanel implements ChangeListener,
-          ActionListener
+  private boolean isServicePreset(String selectedItem)
   {
-    JButton showDesc = new JButton();
-
-    JTextArea string = new JTextArea();
-
-    JScrollPane descPanel = new JScrollPane();
-
-    JSlider slider = null;
-
-    JTextField valueField = null;
-
-    ValueConstrain validator = null;
-
-    JPanel settingPanel = new JPanel();
-
-    JPanel controlPanel = new JPanel();
-
-    boolean integ = false;
-
-    boolean choice = false;
-
-    boolean descisvisible = false;
-
-    final WsJobParameters pmdialogbox;
-
-    public ParamBox(final WsJobParameters pmlayout, Parameter parm)
-    {
-      pmdialogbox = pmlayout;
-      setPreferredSize(new Dimension(PARAM_WIDTH, PARAM_CLOSEDHEIGHT));
-      setBorder(new TitledBorder(parm.getName()));
-      setLayout(null);
-      showDesc.setFont(new Font("Verdana", Font.PLAIN, 6));
-      showDesc.setText("+");
-      string.setFont(new Font("Verdana", Font.PLAIN, 11));
-      string.setBackground(getBackground());
-      // string.setSize(new Dimension(PARAM_WIDTH, 80));
-      string.setEditable(false);
-      descPanel.getViewport().setView(string);
-      // descPanel.setLocation(2,17);
-      descPanel.setVisible(false);
-      // string.setMinimumSize(new Dimension(140,80));
-      // string.setMaximumSize(new Dimension(280,80));
-      final ParamBox me = this;
-      showDesc.addActionListener(new ActionListener()
-      {
-
-        @Override
-        public void actionPerformed(ActionEvent e)
-        {
-          descisvisible = !descisvisible;
-          descPanel.setVisible(descisvisible);
-          me.setPreferredSize(new Dimension(PARAM_WIDTH,
-                  (descisvisible) ? PARAM_HEIGHT : PARAM_CLOSEDHEIGHT));
-          me.validate();
-          pmlayout.refreshParamLayout();
-        }
-      });
-      string.setWrapStyleWord(true);
-      string.setLineWrap(true);
-      string.setColumns(32);
-      string.setText(parm.getDescription());
-      JPanel firstrow = new JPanel();
-      firstrow.setLayout(null);
-      controlPanel.setLayout(new BorderLayout());
-      controlPanel.setBounds(new Rectangle(39, 10, PARAM_WIDTH - 70,
-              PARAM_CLOSEDHEIGHT - 50));
-      showDesc.setBounds(new Rectangle(10, 10, 16, 16));
-      firstrow.add(showDesc);
-      firstrow.add(controlPanel);
-      firstrow.setBounds(new Rectangle(10, 20, PARAM_WIDTH - 30,
-              PARAM_CLOSEDHEIGHT - 30));
-      add(firstrow);
-      validator = parm.getValidValue();
-      parameter = parm;
-      if (validator != null)
-      {
-        integ = validator.getType() == Type.Integer;
-      }
-      else
-      {
-        if (parameter.getPossibleValues() != null)
-        {
-          choice = true;
-        }
-      }
-      updateControls(parm);
-      descPanel.setBounds(new Rectangle(10, PARAM_CLOSEDHEIGHT,
-              PARAM_WIDTH - 20, PARAM_HEIGHT - PARAM_CLOSEDHEIGHT - 5));
-      add(descPanel);
-      validate();
-    }
-
-    public void init()
-    {
-      // reset the widget's initial value.
-      lastVal = null;
-    }
-
-    boolean adjusting = false;
-
-    Parameter parameter;
-
-    JComboBox choicebox;
-
-    public int getBoxHeight()
-    {
-      return (descisvisible ? PARAM_HEIGHT : PARAM_CLOSEDHEIGHT);
-    }
-
-    public void updateControls(Parameter parm)
-    {
-      adjusting = true;
-      boolean init = (choicebox==null && valueField==null);
-      float fVal = 0f;
-      int iVal = 0;
-      if (init)
-      {
-        if (choice)
-        {
-          choicebox = new JComboBox();
-          choicebox.addActionListener(this);
-          controlPanel.add(choicebox, BorderLayout.CENTER);
-        }
-        else
-        {
-          slider = new JSlider();
-          slider.addChangeListener(this);
-          valueField = new JTextField();
-          valueField.addActionListener(this);
-          valueField.setPreferredSize(new Dimension(60, 25));
-          controlPanel.add(slider, BorderLayout.WEST);
-          controlPanel.add(valueField, BorderLayout.EAST);
-
-        }
-      }
-
-      if (parm != null)
-      {
-        if (choice)
-        {
-          if (init) {
-            List vals = parm.getPossibleValues();
-            for (Object val : vals)
-            {
-              choicebox.addItem(val);
-            }
-          }
-          
-          if (parm.getDefaultValue() != null)
-          {
-            choicebox.setSelectedItem(parm.getDefaultValue());
-          }
-        }
-        else
-        {
-          valueField.setText(parm.getDefaultValue());
-        }
-      }
-      lastVal = updateSliderFromValueField();
-      adjusting = false;
-    }
-
-    Object lastVal;
+    return selectedItem.equals(SVC_DEF)
+            || servicePresets.containsKey(selectedItem);
+  }
 
-    public Parameter getParameter()
+  /**
+   * check if the current set name is a valid set name for saving, if not, then
+   * fix it.
+   */
+  private void makeSetNameValid(boolean newuserset)
+  {
+    boolean stn = settingDialog;
+    boolean renamed = false;
+    settingDialog = true;
+    String nm = (curSetName != null ? curSetName : (String) setName
+            .getSelectedItem());
+    // check if the name is reserved - if it is, rename it.
+    if (isServicePreset(nm))
     {
-      try
-      {
-        if (choice)
-        {
-          parameter.setDefaultValue((String) choicebox.getSelectedItem());
-        }
-        else
-        {
-          parameter.setDefaultValue(valueField.getText());
-        }
-      } catch (WrongParameterException e)
-      {
-        e.printStackTrace();
-        return null;
-      }
-      return parameter;
+      nm = "User " + nm;
+      renamed = true;
     }
-
-    public Object updateSliderFromValueField()
+    String tnm = nm;
+    if (newuserset)
     {
-      int iVal;
-      float fVal;
-      if (validator != null)
+      int i = 0;
+      while (paramStore.getPreset(tnm) != null)
       {
-        if (integ)
-        {
-          iVal = 0;
-          try
-          {
-            valueField.setText(valueField.getText().trim());
-            iVal = Integer.valueOf(valueField.getText());
-          } catch (Exception e)
-          {
-          }
-          ;
-          if (validator.getMin() != null && validator.getMax() != null)
-          {
-            slider.getModel().setRangeProperties(iVal, 1,
-                    validator.getMin().intValue(),
-                    validator.getMax().intValue(), true);
-          }
-          else
-          {
-            slider.setVisible(false);
-          }
-          return new int[]
-          { iVal };
-        }
-        else
-        {
-          fVal = 0f;
-          try
-          {
-            fVal = Float.valueOf(valueField.getText());
-          } catch (Exception e)
-          {
-          }
-          ;
-          if (validator.getMin() != null && validator.getMax() != null)
-          {
-            slider.getModel().setRangeProperties((int) fVal * 1000, 1,
-                    (int) validator.getMin().floatValue() * 1000,
-                    (int) validator.getMax().floatValue() * 1000, true);
-          }
-          else
-          {
-            slider.setVisible(false);
-          }
-          return new float[]
-          { fVal };
-        }
+        tnm = nm + " (" + (++i) + ")";
+        renamed = true;
       }
-      else
+      if (i > 0)
       {
-        if (!choice)
-        {
-          slider.setVisible(false);
-          return new String[]
-          { valueField.getText().trim() };
-        }
-        else
-        {
-          return new String[]
-          { (String) choicebox.getSelectedItem() };
-        }
+        nm = tnm;
       }
-
     }
 
-    @Override
-    public void stateChanged(ChangeEvent e)
+    boolean makeupdate = false;
+    // sync the gui with the preset database
+    for (int i = 0, iS = setName.getItemCount(); i < iS; i++)
     {
-      if (!adjusting)
+      String snm = (String) setName.getItemAt(i);
+      if (snm.equals(nm))
       {
-        valueField.setText(""
-                + ((integ) ? ("" + (int) slider.getValue())
-                        : ("" + (float) (slider.getValue() / 1000f))));
-        checkIfModified();
+        makeupdate = true;
+        // setName.setSelectedIndex(i);
       }
-
     }
-
-    @Override
-    public void actionPerformed(ActionEvent e)
+    if (!makeupdate)
     {
-      if (adjusting)
-      {
-        return;
-      }
-      if (!choice)
-      {
-        updateSliderFromValueField();
-      }
-      checkIfModified();
+      setName.addItem(curSetName = nm);
+      setName.setSelectedItem(curSetName);
     }
-
-    private void checkIfModified()
+    if (renamed)
     {
-      Object cstate = updateSliderFromValueField();
-      boolean notmod = false;
-      if (cstate.getClass() == lastVal.getClass())
-      {
-        if (cstate instanceof int[])
-        {
-          notmod = (((int[]) cstate)[0] == ((int[]) lastVal)[0]);
-        }
-        else if (cstate instanceof float[])
-        {
-          notmod = (((float[]) cstate)[0] == ((float[]) lastVal)[0]);
-        }
-        else if (cstate instanceof String[])
-        {
-          notmod = (((String[]) cstate)[0].equals(((String[]) lastVal)[0]));
-        }
-      }
-      pmdialogbox.argSetModified(this, !notmod);
+      settingDialog = false; // we need this name change to be registered.
+      argSetModified(setName, renamed);
     }
+    settingDialog = stn;
   }
 
-  Map<String, OptionBox> optSet = new Hashtable<String, OptionBox>();
 
-  public class OptionBox extends JPanel implements ActionListener
+  public void refreshParamLayout()
   {
-    JComboBox val = new JComboBox();
-
-    JCheckBox enabled = new JCheckBox();
-
-    Option option;
-
-    public OptionBox(Option opt)
-    {
-      option = opt;
-      setLayout(new BorderLayout());
-      enabled.setSelected(opt.isRequired()); // TODO: lock required options
-      enabled.setFont(new Font("Verdana", Font.PLAIN, 11));
-      enabled.setText(opt.getName());
-      enabled.setToolTipText(opt.getDescription());
-      enabled.addActionListener(this);
-      add(enabled, BorderLayout.NORTH);
-      if (opt.getPossibleValues().size() > 1)
-      {
-        setLayout(new GridLayout(1, 2));
-        for (Object str : opt.getPossibleValues())
-        {
-          val.addItem((String) str);
-        }
-        val.setSelectedItem((String) opt.getDefaultValue());
-        val.addActionListener(this);
-        add(val, BorderLayout.SOUTH);
-      }
-      // TODO: add actionListeners for popup (to open further info),
-      // and to update list of parameters if an option is enabled
-      // that takes a value.
-      setInitialValue();
-    }
-
-    boolean initEnabled = false;
-
-    String initVal = null;
-
-    public void setInitialValue()
+    FlowLayout fl = new FlowLayout(FlowLayout.LEFT);
+    int sep=fl.getVgap();
+    int os=0,s = jobOptions.getBorder().getBorderInsets(jobOptions).bottom+jobOptions.getBorder().getBorderInsets(jobOptions).top+2 * sep;
+    int w = 2 * fl.getHgap() + (MAX_OPTWIDTH > OptsAndParamsPage.PARAM_WIDTH ? MAX_OPTWIDTH : OptsAndParamsPage.PARAM_WIDTH);
+    jobOptions.setLayout(fl);
+    if (opanp.getOptSet().size() > 0)
     {
-      initEnabled = enabled.isSelected();
-      if (option.getPossibleValues() != null
-              && option.getPossibleValues().size() > 1)
+      
+      for (OptionBox pbox : opanp.getOptSet().values())
       {
-        initVal = (String) val.getSelectedItem();
+    	  pbox.revalidate();
+        s += sep + pbox.getPreferredSize().height; 
       }
+      jobOptions.setPreferredSize(new Dimension(w, s));
+      jobOptions.setLayout(new GridLayout(opanp.getOptSet().size(),1));
+      os=s;
     }
-
-    public Option getOptionIfEnabled()
+    else
     {
-      if (!enabled.isSelected())
-      {
-        return null;
-      }
-      try
-      {
-        if (val.getSelectedItem() != null)
-        {
-          option.setDefaultValue((String) val.getSelectedItem());
-        }
-      } catch (WrongParameterException e)
-      {
-        e.printStackTrace();
-        return null;
-      }
-      return option;
+      jobOptions.setVisible(false);
     }
 
-    @Override
-    public void actionPerformed(ActionEvent e)
+    // Now layout the parameters assuming they occupy one column - to calculate total height of options+parameters
+    fl = new FlowLayout(FlowLayout.CENTER);
+    // helpful hint from http://stackoverflow.com/questions/2743177/top-alignment-for-flowlayout
+    fl.setAlignOnBaseline(true);
+    if (opanp.getParamSet().size() > 0)
     {
-      if (e.getSource() != enabled)
-      {
-        enabled.setSelected(true);
-      }
-      checkIfModified();
-    }
+      paramList.setLayout(fl);
 
-    private void checkIfModified()
-    {
-      boolean notmod = (initEnabled == enabled.isSelected());
-      if (initVal != null)
+      s = 2 * sep;
+      for (ParamBox pbox : opanp.getParamSet().values())
       {
-        notmod = initVal.equals(val.getSelectedItem());
+        pbox.validate();
+        s += sep + pbox.getPreferredSize().height+pbox.getBorder().getBorderInsets(pbox).bottom; 
       }
-      argSetModified(this, !notmod);
+      
+      paramList.setPreferredSize(new Dimension(w, s));
+      os+=s+2*sep+paramList.getBorder().getBorderInsets(paramList).bottom+paramList.getBorder().getBorderInsets(paramList).top;
     }
-  }
-
-  private OptionBox addOption(Option opt)
-  {
-    OptionBox cb = optSet.get(opt.getName());
-    if (cb == null)
-    {
-      cb = new OptionBox(opt);
-      optSet.put(opt.getName(), cb);
-      jobOptions.add(cb);
-    }
-    return cb;
-  }
-
-  protected void refreshParamLayout()
-  {
-    int s = 100;
-    for (ParamBox pbox : paramSet.values())
+    else
     {
-      s += pbox.getBoxHeight();
+      paramList.setVisible(false);
     }
-    paramList.setPreferredSize(new Dimension(PARAM_WIDTH, s));
-    paramList.setLayout(new FlowLayout());
+    // TODO: waste some time trying to eliminate any unnecessary .validate calls here
+    paramList.validate();
+    jobOptions.validate();
+    // System.out.println("Size will be : "+w+","+os);
+    optsAndparams.validate();
+    paramPane.getViewport().validate();
+    paramPane.getVerticalScrollBar().setBlockIncrement(OptsAndParamsPage.PARAM_CLOSEDHEIGHT*2);
+    paramPane.validate();
     validate();
   }
 
@@ -1011,7 +852,7 @@ public class WsJobParameters extends JPanel implements ItemListener,
     jalview.ws.jws2.Jws2Discoverer disc = jalview.ws.jws2.Jws2Discoverer
             .getDiscoverer();
     int p = 0;
-    if (args.length > 3)
+    if (args.length > 0)
     {
       Vector<String> services = new Vector<String>();
       services.addElement(args[p++]);
@@ -1030,203 +871,324 @@ public class WsJobParameters extends JPanel implements ItemListener,
     for (Jws2Discoverer.Jws2Instance service : disc.getServices())
     {
       lastserv = service;
-      if (p < args.length && service.serviceType.equalsIgnoreCase(args[p]))
+      if (p >= args.length || service.serviceType.equalsIgnoreCase(args[p]))
       {
-        break;
-      }
-    }
-    if (lastserv != null)
-    {
-      List<Preset> prl = null;
-      Preset pr = null;
-      if (++p < args.length)
-      {
-        PresetManager prman = lastserv.getPresets();
-        if (prman != null)
+        if (lastserv != null)
         {
-          pr = prman.getPresetByName(args[p]);
-          if (pr == null)
+          List<Preset> prl = null;
+          Preset pr = null;
+          if (++p < args.length)
           {
-            // just grab the last preset.
-            prl = prman.getPresets();
+            PresetManager prman = lastserv.getPresets();
+            if (prman != null)
+            {
+              pr = prman.getPresetByName(args[p]);
+              if (pr == null)
+              {
+                // just grab the last preset.
+                prl = prman.getPresets();
+              }
+            }
           }
-        }
-      }
-      Iterator<Preset> en = (prl == null) ? null : prl.iterator();
-      while (true)
-      {
-        if (en != null)
-        {
-          if (!en.hasNext())
+          else
           {
-            en = prl.iterator();
+            PresetManager prman = lastserv.getPresets();
+            if (prman != null)
+            {
+              prl = prman.getPresets();
+            }
           }
-          pr = en.next();
-        }
-        WsJobParameters pgui = new WsJobParameters(lastserv, pr);
-        JFrame jf = new JFrame("Parameters for " + lastserv.getActionText());
-        JPanel cont = new JPanel();
-        // jf.setPreferredSize(new Dimension(600, 800));
-        cont.add(pgui);
-        jf.add(cont);
-        final Thread thr = Thread.currentThread();
-        jf.addWindowListener(new WindowListener()
-        {
-
-          @Override
-          public void windowActivated(WindowEvent e)
+          Iterator<Preset> en = (prl == null) ? null : prl.iterator();
+          while (en != null && en.hasNext())
           {
-            // TODO Auto-generated method stub
+            if (en != null)
+            {
+              if (!en.hasNext())
+              {
+                en = prl.iterator();
+              }
+              pr = en.next();
+            }
+            {
+              System.out.println("Testing opts dupes for "
+                      + lastserv.getUri() + " : "
+                      + lastserv.getActionText() + ":" + pr.getName());
+              List<Option> rg = lastserv.getRunnerConfig().getOptions();
+              for (Option o : rg)
+              {
+                try
+                {
+                  Option cpy = jalview.ws.jws2.ParameterUtils.copyOption(o);
+                } catch (Exception e)
+                {
+                  System.err.println("Failed to copy " + o.getName());
+                  e.printStackTrace();
+                } catch (Error e)
+                {
+                  System.err.println("Failed to copy " + o.getName());
+                  e.printStackTrace();
+                }
+              }
+            }
+            {
+              System.out.println("Testing param dupes:");
+              List<Parameter> rg = lastserv.getRunnerConfig()
+                      .getParameters();
+              for (Parameter o : rg)
+              {
+                try
+                {
+                  Parameter cpy = jalview.ws.jws2.ParameterUtils
+                          .copyParameter(o);
+                } catch (Exception e)
+                {
+                  System.err.println("Failed to copy " + o.getName());
+                  e.printStackTrace();
+                } catch (Error e)
+                {
+                  System.err.println("Failed to copy " + o.getName());
+                  e.printStackTrace();
+                }
+              }
+            }
+            {
+              System.out.println("Testing param write:");
+              List<String> writeparam = null, readparam = null;
+              try
+              {
+                writeparam = jalview.ws.jws2.ParameterUtils
+                        .writeParameterSet(
+                                pr.getArguments(lastserv.getRunnerConfig()),
+                                " ");
+                System.out.println("Testing param read :");
+                List<Option> pset = jalview.ws.jws2.ParameterUtils
+                        .processParameters(writeparam,
+                                lastserv.getRunnerConfig(), " ");
+                readparam = jalview.ws.jws2.ParameterUtils
+                        .writeParameterSet(pset, " ");
+                Iterator<String> o = pr.getOptions().iterator(), s = writeparam
+                        .iterator(), t = readparam.iterator();
+                boolean failed = false;
+                while (s.hasNext() && t.hasNext())
+                {
+                  String on = o.next(), sn = s.next(), st = t.next();
+                  if (!sn.equals(st))
+                  {
+                    System.out.println("Original was " + on
+                            + " Phase 1 wrote " + sn + "\tPhase 2 wrote "
+                            + st);
+                    failed = true;
+                  }
+                }
+                if (failed)
+                {
+                  System.out.println("Original parameters:\n"
+                          + pr.getOptions());
+                  System.out.println("Wrote parameters in first set:\n"
+                          + writeparam);
+                  System.out.println("Wrote parameters in second set:\n"
+                          + readparam);
+
+                }
+              } catch (Exception e)
+              {
+                e.printStackTrace();
+              }
+            }
+            WsJobParameters pgui = new WsJobParameters(lastserv,
+                    new JabaPreset(lastserv, pr));
+            JFrame jf = new JFrame("Parameters for "
+                    + lastserv.getActionText());
+            JPanel cont = new JPanel(new BorderLayout());
+            pgui.validate();
+            cont.setPreferredSize(pgui.getPreferredSize());
+            cont.add(pgui, BorderLayout.CENTER);
+            jf.setLayout(new BorderLayout());
+            jf.add(cont, BorderLayout.CENTER);
+            jf.validate();
+            final Thread thr = Thread.currentThread();
+            jf.addWindowListener(new WindowListener()
+            {
 
-          }
+              public void windowActivated(WindowEvent e)
+              {
+                // TODO Auto-generated method stub
 
-          @Override
-          public void windowClosed(WindowEvent e)
-          {
-          }
+              }
 
-          @Override
-          public void windowClosing(WindowEvent e)
-          {
-            thr.interrupt();
+              public void windowClosed(WindowEvent e)
+              {
+              }
 
-          }
+              public void windowClosing(WindowEvent e)
+              {
+                thr.interrupt();
 
-          @Override
-          public void windowDeactivated(WindowEvent e)
-          {
-            // TODO Auto-generated method stub
+              }
 
-          }
+              public void windowDeactivated(WindowEvent e)
+              {
+                // TODO Auto-generated method stub
 
-          @Override
-          public void windowDeiconified(WindowEvent e)
-          {
-            // TODO Auto-generated method stub
+              }
 
-          }
+              public void windowDeiconified(WindowEvent e)
+              {
+                // TODO Auto-generated method stub
 
-          @Override
-          public void windowIconified(WindowEvent e)
-          {
-            // TODO Auto-generated method stub
+              }
 
-          }
+              public void windowIconified(WindowEvent e)
+              {
+                // TODO Auto-generated method stub
 
-          @Override
-          public void windowOpened(WindowEvent e)
-          {
-            // TODO Auto-generated method stub
+              }
 
-          }
+              public void windowOpened(WindowEvent e)
+              {
+                // TODO Auto-generated method stub
 
-        });
-        jf.setVisible(true);
-        boolean inter = false;
-        while (!inter)
-        {
-          try
-          {
-            Thread.sleep(10000);
-          } catch (Exception e)
-          {
-            inter = true;
+              }
+
+            });
+            jf.setVisible(true);
+            boolean inter = false;
+            while (!inter)
+            {
+              try
+              {
+                Thread.sleep(10000);
+              } catch (Exception e)
+              {
+                inter = true;
+              }
+              ;
+            }
+            jf.dispose();
           }
-          ;
         }
-        jf.dispose();
       }
     }
   }
 
-  public List<Argument> getJobParams()
+  public List<ArgumentI> getJobParams()
+  {
+    return opanp.getCurrentSettings();
+  }
+
+  String lastParmSet = null;
+
+  /*
+   * Hashtable<String, Object[]> editedParams = new Hashtable<String,
+   * Object[]>();
+   * 
+   * store the given parameters in the user parameter set database.
+   * 
+   * @param storeSetName - lastParmSet
+   * 
+   * @param descr - setDescr.getText()
+   * 
+   * @param jobParams - getJobParams()
+   * 
+   * private void _storeUserPreset(String storeSetName, String descr,
+   * List<ArgumentI> jobParams) { // this is a simple hash store. Object[] pset;
+   * editedParams.put(storeSetName, pset = new Object[3]); pset[0] =
+   * storeSetName; pset[1] = descr; pset[2] = jobParams; // writeParam("Saving "
+   * + storeSetName + ": ", jobParams); }
+   * 
+   * private void writeParam(String nm, List<ArgumentI> params) { for (ArgumentI
+   * p : params) { System.out.println(nm + ":" + System.identityHashCode(p) +
+   * " Name: " + p.getName() + " Value: " + p.getDefaultValue()); } }
+   * 
+   * private Object[] _getUserPreset(String setName) { Object[] pset =
+   * editedParams.get(setName); // if (pset != null) // writeParam("Retrieving "
+   * + setName + ": ", (List<Argument>) pset[2]); return pset; }
+   * 
+   * * remove the given user preset from the preset stash
+   * 
+   * @param setName
+   * 
+   * private void _deleteUserPreset(String setName) {
+   * editedParams.remove(setName); }
+   */
+
+  private void syncSetNamesWithStore()
   {
-    List<Argument> argSet = new ArrayList<Argument>();
-    // recover options and parameters from GUI
-    for (OptionBox opts : optSet.values())
+    int n = 0;
+    // remove any set names in the drop down menu that aren't either a reserved
+    // setting, or a user defined or service preset.
+    Vector items = new Vector();
+    while (n < setName.getItemCount())
     {
-      Option opt = opts.getOptionIfEnabled();
-      if (opt != null)
+      String item = (String) setName.getItemAt(n);
+      if (!item.equals(SVC_DEF) && !paramStore.presetExists(item))
+      {
+        setName.removeItemAt(n);
+      }
+      else
       {
-        argSet.add(opt);
+        items.addElement(item);
+        n++;
       }
     }
-    for (ParamBox parambox : paramSet.values())
+    if (!items.contains(SVC_DEF))
     {
-      Parameter parm = parambox.getParameter();
-      if (parm != null)
+      setName.addItem(SVC_DEF);
+    }
+    for (WsParamSetI upn : paramStore.getPresets())
+    {
+      if (!items.contains(upn.getName()))
       {
-        argSet.add(parm);
+        setName.addItem(upn.getName());
       }
     }
-
-    return argSet;
   }
 
-  String lastParmSet = null;
-
-  Hashtable<String, Object[]> editedParams = new Hashtable<String, Object[]>();
-
   /**
-   * store the given parameters in the user parameter set database.
-   * 
-   * @param storeSetName
-   *          - lastParmSet
-   * @param descr
-   *          - setDescr.getText()
-   * @param jobParams
-   *          - getJobParams()
+   * true if lastParmSet is a user preset
    */
-  private void _storeUserPreset(String storeSetName, String descr,
-          List<Argument> jobParams)
-  {
-    // this is a simple hash store.
-    Object[] pset;
-    editedParams.put(storeSetName, pset = new Object[3]);
-    pset[0] = storeSetName;
-    pset[1] = descr;
-    pset[2] = jobParams;
-  }
-
-  private Object[] _getUserPreset(String setName)
-  {
-    return editedParams.get(setName);
-  }
+  boolean isUserPreset = false;
 
   private void reInitDialog(String nextPreset)
   {
     settingDialog = true;
-    // updateTable(null,null);
-    Object[] pset = _getUserPreset(nextPreset);
-    if (pset != null)
+    // updateTable(null,null); // first reset to defaults
+    WsParamSetI pset = null;
+    if (nextPreset != null && nextPreset.length() > 0)
     {
-      setDescr.setText((String) pset[1]);
-      updateTable(null, (List<Argument>) pset[2]);
-      lastParmSet = nextPreset;
-      validate();
+      pset = paramStore.getPreset(nextPreset);
     }
-    else
+    if (pset != null)
     {
-      // must be a default preset from service
-      Preset p = null;
-      try
-      {
-        PresetManager prman = service.getPresets();
-        if (prman != null)
-        {
-          p = prman.getPresetByName(nextPreset);
-        }
-      } catch (Exception ex)
+      if (pset.isModifiable())
       {
-        ex.printStackTrace();
+        isUserPreset = true;
+        setDescr.setText(pset.getDescription());
+        updateTable(null, pset.getArguments());
+        lastParmSet = nextPreset;
       }
-      if (p != null)
+      else
       {
-        updateTable(p, null);
+        isUserPreset = false;
+        setDescr.setText("");
+        // must be a default preset from service
+        updateTable(pset, null);
         lastParmSet = nextPreset;
       }
     }
+    else
+    {
+      isUserPreset = false;
+      // Service defaults
+      setDescr.setText("");
+      updateTable(null, null);
+      lastParmSet = SVC_DEF;
+    }
+
     initArgSetModified();
+    syncSetNamesWithStore();
+    setName.setSelectedItem(lastParmSet);
+    SetNamePanel.validate();
     validate();
     settingDialog = false;
 
@@ -1234,37 +1196,91 @@ public class WsJobParameters extends JPanel implements ItemListener,
 
   String curSetName = null;
 
-  @Override
   public void itemStateChanged(ItemEvent e)
   {
-    if (settingDialog)
-    {
-      // ignore event
-      return;
-    }
-    if (e.getSource() == setName)
+    if (e.getSource() == setName && e.getStateChange() == e.SELECTED)
     {
-      String setname = (String) setName.getSelectedItem();
+      final String setname = (String) setName.getSelectedItem();
+      System.out.println("Item state changed for " + setname
+              + " (handling ? " + !settingDialog + ")");
+      if (settingDialog)
+      {
+        // ignore event
+        return;
+      }
       if (setname == null)
       {
         return;
       }
-      if (curSetName == null || !setname.equals(curSetName))
+      javax.swing.SwingUtilities.invokeLater(new Runnable()
       {
-        if (isModified())
+        public void run()
         {
-          raiseQueryAndSave();
+          doPreferenceComboStateChange(setname);
         }
-        reInitDialog(setname);
+      });
+    }
+  }
+
+  private void doPreferenceComboStateChange(String setname)
+  {
+    // user has selected a different item from combo-box
+    if (isModified())
+    {
+      String lsetname = (curSetName != null) ? curSetName : lastParmSet;
+      if (lsetname.equals(setname))
+      {
+        // setname was just edited - so ignore this event.
+        return;
+      }
+      settingDialog = true;
+      System.out.println("Prompting to save " + lsetname);
+      if (javax.swing.JOptionPane
+              .showConfirmDialog(
+                      this,
+                      "Parameter set '"
+                              + lsetname
+                              + "' is modifed, and your changes will be lost.\nReally change preset ?",
+                      "Warning: Unsaved Changes",
+                      javax.swing.JOptionPane.OK_CANCEL_OPTION) != JOptionPane.OK_OPTION)
+      {
+        // revert the combobox to the current item
+        settingDialog = true;
+        setName.setSelectedItem(lsetname);
+        settingDialog = false;
+        // and leave.
+        return;
+        // System.out.println("Saving for " + lsetname);
+        // _storeCurrentPreset(lsetname);
+
       }
     }
+    settingDialog = true;
+    reInitDialog(setname);
+    settingDialog = false;
+
+  }
+
+  private void _renameExistingPreset(String oldName, String curSetName2)
+  {
+    paramStore.updatePreset(oldName, curSetName2, setDescr.getText(),
+            getJobParams());
   }
 
   /**
-   * ask the user if they wan't to save the current settings before switching
+   * store current settings as given name. You should then reset gui.
+   * 
+   * @param curSetName2
    */
-  private void raiseQueryAndSave()
+  private void _storeCurrentPreset(String curSetName2)
   {
+    paramStore.storePreset(curSetName2, setDescr.getText(), getJobParams());
+  }
+
+  private void _updatePreset(String lastParmSet2, String curname)
+  {
+    paramStore.updatePreset(lastParmSet2, curname, setDescr.getText(),
+            getJobParams());
 
   }
 
@@ -1278,7 +1294,6 @@ public class WsJobParameters extends JPanel implements ItemListener,
    */
   String lastDescrText = null;
 
-  @Override
   public void actionPerformed(ActionEvent e)
   {
     if (e.getSource() instanceof Component)
@@ -1287,27 +1302,87 @@ public class WsJobParameters extends JPanel implements ItemListener,
       if (src.getParent() == setName)
       {
         // rename any existing records we know about for this set.
-        curSetName = (String) e.getActionCommand();
-        System.err.println("Command " + curSetName + " : "
-                + setName.getSelectedItem());
-        if (curSetName.trim().equals(setName.getSelectedItem()))
+        String newname = (String) e.getActionCommand().trim();
+        String msg = null;
+        if (isServicePreset(newname))
         {
-          curSetName=null;
+          final String oldname = curSetName != null ? curSetName
+                  : lastParmSet;
+          final Component ourframe = this;
+          settingDialog = true;
+          setName.getEditor().setItem(oldname);
+          settingDialog = false;
+          javax.swing.SwingUtilities.invokeLater(new Runnable()
+          {
+            public void run()
+            {
+              JOptionPane.showMessageDialog(ourframe,
+                      "Invalid name - preset already exists.",
+                      "Invalid name", JOptionPane.WARNING_MESSAGE);
+            }
+          });
+
+          return;
         }
-        if (curSetName!=null)
+        curSetName = newname;
+        System.err.println("New name for user setting " + curSetName
+                + " (was " + setName.getSelectedItem() + ")");
+        if (curSetName.equals(setName.getSelectedItem()))
         {
-          argSetModified(setName, lastSetName!=null || !curSetName.equals(lastSetName));
+          curSetName = null;
+        }
+        if (curSetName != null)
+        {
+          argSetModified(setName, true);
           return;
         }
 
       }
     }
-    if (e.getSource() == setDescr)
+  }
+
+  private void checkDescrModified()
+  {
+    if (!settingDialog)
     {
-      if (lastDescrText != null)
-      {
-        argSetModified(setDescr, !setDescr.getText().equals(lastDescrText));
-      }
+
+      argSetModified(
+              setDescr,
+              (lastDescrText == null ? setDescr.getText().trim().length() > 0
+                      : !setDescr.getText().equals(lastDescrText)));
+
+    }
+  }
+
+  public void insertUpdate(DocumentEvent e)
+  {
+    checkDescrModified();
+  }
+
+  public void removeUpdate(DocumentEvent e)
+  {
+    checkDescrModified();
+  }
+
+  public void changedUpdate(DocumentEvent e)
+  {
+    checkDescrModified();
+  }
+
+  /**
+   * 
+   * @return null or the service preset selected by the user
+   */
+  public WsParamSetI getPreset()
+  {
+    if (isUserPreset || isModified()
+            || (lastParmSet != null && lastParmSet.equals(SVC_DEF)))
+    {
+      return null;
+    }
+    else
+    {
+      return paramStore.getPreset(lastParmSet);
     }
   }
-}
\ No newline at end of file
+}