X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fgui%2Fstructurechooser%2FTDBResultAnalyser.java;h=28861d9ff365b353a7b55709ae1554b97478e496;hb=fc3c0910b7086411d72104c0a2cf4b8b45a95015;hp=06dbe2daddb7ddb3cfd73f2196fe1a3fe26ac2cf;hpb=896b63f7908297dfe7a48e198d7bce847e2804b8;p=jalview.git diff --git a/src/jalview/gui/structurechooser/TDBResultAnalyser.java b/src/jalview/gui/structurechooser/TDBResultAnalyser.java index 06dbe2d..28861d9 100644 --- a/src/jalview/gui/structurechooser/TDBResultAnalyser.java +++ b/src/jalview/gui/structurechooser/TDBResultAnalyser.java @@ -1,3 +1,23 @@ +/* + * Jalview - A Sequence Alignment Editor and Viewer ($$Version-Rel$$) + * Copyright (C) $$Year-Rel$$ The Jalview Authors + * + * This file is part of Jalview. + * + * Jalview is free software: you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, either version 3 + * of the License, or (at your option) any later version. + * + * Jalview is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with Jalview. If not, see . + * The Jalview Authors are detailed in the 'AUTHORS' file. + */ package jalview.gui.structurechooser; import java.util.ArrayList; @@ -7,6 +27,7 @@ import java.util.Collection; import java.util.Collections; import java.util.Comparator; import java.util.List; +import java.util.Locale; import jalview.datamodel.SequenceI; import jalview.fts.api.FTSData; @@ -23,8 +44,8 @@ public class TDBResultAnalyser */ private static List EXP_CATEGORIES = Arrays .asList(new String[] - { "EXPERIMENTALLY DETERMINED", "DEEP-LEARNING", - "TEMPLATE-BASED" }); + { "EXPERIMENTALLY DETERMINED", "DEEP-LEARNING", "AB-INITIO", + "TEMPLATE-BASED", "CONFORMATIONAL ENSEMBLE" }); private SequenceI seq; @@ -40,22 +61,26 @@ public class TDBResultAnalyser private int idx_mqual; + private int idx_mqualtype; + private int idx_resol; /** * selection model */ - private String filter=null; + private String filter = null; + /** * limit to particular source */ - private String sourceFilter=null; + private String sourceFilter = null; private int idx_mprov; public TDBResultAnalyser(SequenceI seq, Collection collectedResults, - FTSRestRequest lastTdbRequest, String fieldToFilterBy, String string) + FTSRestRequest lastTdbRequest, String fieldToFilterBy, + String string) { this.seq = seq; this.collectedResults = collectedResults; @@ -68,14 +93,29 @@ public class TDBResultAnalyser idx_mprov = lastTdbRequest.getFieldIndex("Provider"); idx_mqual = lastTdbRequest.getFieldIndex("Confidence"); idx_resol = lastTdbRequest.getFieldIndex("Resolution"); + idx_mqualtype = lastTdbRequest.getFieldIndex("Confidence Score Type"); } - private final int scoreCategory(String cat) + + /** + * maintain and resolve categories to 'trust order' TODO: change the trust + * scheme to something comprehensible. + * + * @param cat + * @return 0 for null cat, less than zero for others + */ + public final int scoreCategory(String cat) { - // TODO: make quicker - int idx = EXP_CATEGORIES.indexOf(cat.toUpperCase()); + if (cat == null) + { + return 0; + } + String upper_cat = cat.toUpperCase(Locale.ROOT); + int idx = EXP_CATEGORIES.indexOf(upper_cat); if (idx == -1) { - System.out.println("Unknown category: '" + cat + "'"); + jalview.bin.Console.outPrintln("Unknown category: '" + cat + "'"); + EXP_CATEGORIES.add(upper_cat); + idx = EXP_CATEGORIES.size() - 1; } return -EXP_CATEGORIES.size() - idx; } @@ -93,15 +133,22 @@ public class TDBResultAnalyser // ignore anything outside the sequence region for (FTSData row : collectedResults) { - int up_s = (Integer) row.getSummaryData()[idx_ups]; - int up_e = (Integer) row.getSummaryData()[idx_upe]; - String provider = (String) row.getSummaryData()[idx_mprov]; - if (sourceFilter == null || sourceFilter.equals(provider)) + if (row.getSummaryData() != null + && row.getSummaryData()[idx_ups] != null) { - if (seq == row.getSummaryData()[0] && up_e > seq.getStart() - && up_s < seq.getEnd()) + int up_s = (Integer) row.getSummaryData()[idx_ups]; + int up_e = (Integer) row.getSummaryData()[idx_upe]; + String provider = (String) row.getSummaryData()[idx_mprov]; + String mcat = (String) row.getSummaryData()[idx_mcat]; + // this makes sure all new categories are in the score array. + int scorecat = scoreCategory(mcat); + if (sourceFilter == null || sourceFilter.equals(provider)) { - filteredResponse.add(row); + if (seq == row.getSummaryData()[0] && up_e > seq.getStart() + && up_s < seq.getEnd()) + { + filteredResponse.add(row); + } } } } @@ -117,9 +164,15 @@ public class TDBResultAnalyser int o1_s = (Integer) o1data[idx_ups]; int o1_e = (Integer) o1data[idx_upe]; int o1_cat = scoreCategory((String) o1data[idx_mcat]); + String o1_prov = ((String) o1data[idx_mprov]) + .toUpperCase(Locale.ROOT); int o2_s = (Integer) o2data[idx_ups]; int o2_e = (Integer) o2data[idx_upe]; int o2_cat = scoreCategory((String) o2data[idx_mcat]); + String o2_prov = ((String) o2data[idx_mprov]) + .toUpperCase(Locale.ROOT); + String o1_qualtype = (String) o1data[idx_mqualtype], + o2_qualtype = (String) o2data[idx_mqualtype]; if (o1_cat == o2_cat) { @@ -129,19 +182,60 @@ public class TDBResultAnalyser int o2_xtent = o2_e - o2_s; if (o1_xtent == o2_xtent) { + // EXPERIMENTAL DATA ALWAYS TRUMPS MODELS if (o1_cat == scoreCategory(EXP_CATEGORIES.get(0))) { - // experimental structures, so rank on quality - double o1_res = (Double) o1data[idx_resol]; - double o2_res = (Double) o2data[idx_resol]; - return (o2_res < o1_res) ? 1 : (o2_res == o1_res) ? 0 : -1; + if (o1_prov.equals(o2_prov)) + { + if ("PDBE".equals(o1_prov)) + { + if (eitherNull(idx_resol, o1data, o2data)) + { + return nonNullFirst(idx_resol, o1data, o2data); + } + // experimental structures, so rank on quality + double o1_res = (Double) o1data[idx_resol]; + double o2_res = (Double) o2data[idx_resol]; + return (o2_res < o1_res) ? 1 + : (o2_res == o1_res) ? 0 : -1; + } + else + { + return 0; // no change in order + } + } + else + { + // PDBe always ranked above all other experimentally + // determined categories + return "PDBE".equals(o1_prov) ? -1 + : "PDBE".equals(o2_prov) ? 1 : 0; + } } else { - // models, so rank on qmean - float o1_mq = (Float) o1data[idx_mqual]; - float o2_mq = (Float) o2data[idx_mqual]; - return (o2_mq < o1_mq) ? 1 : (o2_mq == o1_mq) ? 0 : -1; + // RANK ON QUALITY - DOWNRANK THOSE WITH NO QUALITY MEASURE + if (eitherNull(idx_mqualtype, o1data, o2data)) + { + return nonNullFirst(idx_mqualtype, o1data, o2data); + } + // ONLY COMPARE LIKE QUALITY SCORES + if (!o1_qualtype.equals(o2_qualtype)) + { + // prefer LDDT measure over others + return "pLDDT".equals(o1_qualtype) ? -1 + : "pLDDT".equals(o2_qualtype) ? 1 : 0; + } + // OR NO VALUE FOR THE QUALITY + if (eitherNull(idx_mqual, o1data, o2data)) + { + return nonNullFirst(idx_mqual, o1data, o2data); + } + // models, so rank on qmean - b + double o1_mq = (Double) o1data[idx_mqual]; + double o2_mq = (Double) o2data[idx_mqual]; + int res = (o2_mq < o1_mq) ? 1 : (o2_mq == o1_mq) ? 0 : -1; + return ("pLDDT".equals(o1_qualtype)) ? -res : res; } } else @@ -156,10 +250,29 @@ public class TDBResultAnalyser } else { + // if both are not experimental, then favour alphafold + if (o2_cat > 0 && o1_cat > 0) + { + return "ALPHAFOLD DB".equals(o1_prov) ? -1 + : "ALPHAFOLD DB".equals(o2_prov) ? 1 : 0; + } return o2_cat - o1_cat; } } + private int nonNullFirst(int idx_resol, Object[] o1data, + Object[] o2data) + { + return o1data[idx_resol] == o2data[idx_resol] ? 0 + : o1data[idx_resol] != null ? -1 : 1; + } + + private boolean eitherNull(int idx_resol, Object[] o1data, + Object[] o2data) + { + return (o1data[idx_resol] == null || o2data[idx_resol] == null); + } + @Override public boolean equals(Object obj) { @@ -170,49 +283,61 @@ public class TDBResultAnalyser } /** - * return list of structures to be marked as selected for this sequence according to given criteria - * @param filteredStructures - sorted, filtered structures from getFilteredResponse + * return list of structures to be marked as selected for this sequence + * according to given criteria + * + * @param filteredStructures + * - sorted, filtered structures from getFilteredResponse * */ public List selectStructures(List filteredStructures) { List selected = new ArrayList(); BitSet cover = new BitSet(); - cover.set(seq.getStart(),seq.getEnd()); + cover.set(seq.getStart(), seq.getEnd()); // walk down the list of structures, selecting some to add to selected - for (FTSData structure:filteredStructures) + // TODO: could do simple DP - double loop to select largest number of + // structures covering largest number of sites + for (FTSData structure : filteredStructures) { - Object[] odata=structure.getSummaryData(); + Object[] odata = structure.getSummaryData(); int o1_s = (Integer) odata[idx_ups]; int o1_e = (Integer) odata[idx_upe]; int o1_cat = scoreCategory((String) odata[idx_mcat]); BitSet scover = new BitSet(); // measure intersection - scover.set(o1_s,o1_e); + scover.set(o1_s, o1_e); scover.and(cover); - if (scover.cardinality()>4) + if (scover.cardinality() > 4) { selected.add(structure); // clear the range covered by this structure - cover.andNot(scover); + cover.andNot(scover); } } - // final step is to sort on length - this might help the superposition process - Collections.sort(selected,new Comparator() + if (selected.size() == 0) + { + return selected; + } + // final step is to sort on length - this might help the superposition + // process + Collections.sort(selected, new Comparator() { @Override public int compare(FTSData o1, FTSData o2) { Object[] o1data = o1.getSummaryData(); Object[] o2data = o2.getSummaryData(); - int o1_xt = ((Integer) o1data[idx_upe]) - ((Integer) o1data[idx_ups]); + int o1_xt = ((Integer) o1data[idx_upe]) + - ((Integer) o1data[idx_ups]); int o1_cat = scoreCategory((String) o1data[idx_mcat]); - int o2_xt = ((Integer) o2data[idx_upe]-(Integer) o2data[idx_ups]); + int o2_xt = ((Integer) o2data[idx_upe] - (Integer) o2data[idx_ups]); int o2_cat = scoreCategory((String) o2data[idx_mcat]); - return o2_xt-o1_xt; + return o2_xt - o1_xt; } }); - if (filter.equals(ThreeDBStructureChooserQuerySource.FILTER_FIRST_BEST_COVERAGE)) + if (filter.equals( + ThreeDBStructureChooserQuerySource.FILTER_FIRST_BEST_COVERAGE)) { return selected.subList(0, 1); }