X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fio%2FFileLoader.java;h=6cb1212e179215cf48625351e1af54b32e35dc81;hb=7897c6cb08b496285bcb5fa9ed2d9f7d887d0068;hp=f185205382238d21718ebee2d9e654d34c17840a;hpb=49685e6426d5ac136dce4907196751680c667670;p=jalview.git

diff --git a/src/jalview/io/FileLoader.java b/src/jalview/io/FileLoader.java
index f185205..6cb1212 100755
--- a/src/jalview/io/FileLoader.java
+++ b/src/jalview/io/FileLoader.java
@@ -46,15 +46,20 @@ public class FileLoader implements Runnable
   long memused;
 
   boolean raiseGUI = true;
+
   /**
-   * default constructor always raised errors in GUI dialog boxes 
+   * default constructor always raised errors in GUI dialog boxes
    */
-  public FileLoader() {
+  public FileLoader()
+  {
     this(true);
   }
+
   /**
-   * construct a Fileloader that may raise errors non-interactively 
-   * @param raiseGUI true if errors are to be raised as GUI dialog boxes
+   * construct a Fileloader that may raise errors non-interactively
+   * 
+   * @param raiseGUI
+   *                true if errors are to be raised as GUI dialog boxes
    */
   public FileLoader(boolean raiseGUI)
   {
@@ -235,7 +240,10 @@ public class FileLoader implements Runnable
       if (Desktop.desktop != null && Desktop.desktop.isShowMemoryUsage())
       {
         System.gc();
-        memused = (rt.maxMemory() - rt.totalMemory() + rt.freeMemory()); // free memory before load
+        memused = (rt.maxMemory() - rt.totalMemory() + rt.freeMemory()); // free
+                                                                          // memory
+                                                                          // before
+                                                                          // load
       }
       loadtime = -System.currentTimeMillis();
       Alignment al = null;
@@ -350,10 +358,9 @@ public class FileLoader implements Runnable
 
       updateRecentlyOpened();
 
-    }
-    catch (Exception er)
+    } catch (Exception er)
     {
-      System.err.println("Exception whilst opening file '"+file);
+      System.err.println("Exception whilst opening file '" + file);
       er.printStackTrace();
       if (raiseGUI)
       {
@@ -361,20 +368,15 @@ public class FileLoader implements Runnable
         {
           public void run()
           {
-            javax.swing.JOptionPane
-                    .showInternalMessageDialog(
-                            Desktop.desktop,
-                            "Encountered problems opening "
-                                    + file
-                                    + "!!"
-                                    , "File open error",
-                            javax.swing.JOptionPane.WARNING_MESSAGE);
+            javax.swing.JOptionPane.showInternalMessageDialog(
+                    Desktop.desktop, "Encountered problems opening " + file
+                            + "!!", "File open error",
+                    javax.swing.JOptionPane.WARNING_MESSAGE);
           }
         });
       }
       alignFrame = null;
-    }
-    catch (OutOfMemoryError er)
+    } catch (OutOfMemoryError er)
     {
 
       er.printStackTrace();
@@ -397,15 +399,19 @@ public class FileLoader implements Runnable
           }
         });
       }
-      else
-      {
-        System.err.println("Out of memory loading file " + file + "!!");
-      }
+      System.err.println("Out of memory loading file " + file + "!!");
+
     }
     loadtime += System.currentTimeMillis();
-
+    // TODO: Estimate percentage of memory used by a newly loaded alignment -
+    // warn if more memory will be needed to work with it
     // System.gc();
-    memused = memused - (rt.maxMemory() - rt.totalMemory() + rt.freeMemory()); // difference in free memory after load
+    memused = memused
+            - (rt.maxMemory() - rt.totalMemory() + rt.freeMemory()); // difference
+                                                                      // in free
+                                                                      // memory
+                                                                      // after
+                                                                      // load
     if (Desktop.desktop != null && Desktop.desktop.isShowMemoryUsage())
     {
       if (alignFrame != null)
@@ -416,11 +422,15 @@ public class FileLoader implements Runnable
                 + (loadtime / 1000.0) + "s, took an additional "
                 + (1.0 * memused / (1024.0 * 1024.0)) + " MB ("
                 + al.getHeight() + " seqs by " + al.getWidth() + " cols)");
-      } else {
-        // report that we didn't load anything probably due to an out of memory error
-        System.out.println("Failed to load '"+title+"' in "
+      }
+      else
+      {
+        // report that we didn't load anything probably due to an out of memory
+        // error
+        System.out.println("Failed to load '" + title + "' in "
                 + (loadtime / 1000.0) + "s, took an additional "
-                + (1.0 * memused / (1024.0 * 1024.0)) + " MB (alignment is null)");
+                + (1.0 * memused / (1024.0 * 1024.0))
+                + " MB (alignment is null)");
       }
     }
     // remove the visual delay indicator