X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fio%2FModellerDescription.java;h=e184d749b91f78e67f02dd9d61df3b4a8a8a59d3;hb=5a352aa2f3330ae269d9b70c4a7374c2518bfb2e;hp=442278ddad330aa84b70b0ad7e231805915914cc;hpb=3d0101179759ef157b088ea135423cd909512d9f;p=jalview.git

diff --git a/src/jalview/io/ModellerDescription.java b/src/jalview/io/ModellerDescription.java
index 442278d..e184d74 100755
--- a/src/jalview/io/ModellerDescription.java
+++ b/src/jalview/io/ModellerDescription.java
@@ -20,8 +20,14 @@
  */
 package jalview.io;
 
+import jalview.bin.Cache;
+import jalview.datamodel.DBRefEntry;
 import jalview.datamodel.SequenceI;
 
+import java.util.List;
+
+import com.stevesoft.pat.Regex;
+
 public class ModellerDescription
 {
   /**
@@ -85,7 +91,7 @@ public class ModellerDescription
 
     resCode(int v)
     {
-      val = new Integer(v);
+      val = Integer.valueOf(v);
       field = val.toString();
     }
   };
@@ -93,8 +99,7 @@ public class ModellerDescription
   private resCode validResidueCode(String field)
   {
     Integer val = null;
-    com.stevesoft.pat.Regex r = new com.stevesoft.pat.Regex(
-            "\\s*((([-0-9]+).?)|FIRST|LAST|@)");
+    Regex r = new Regex("\\s*((([-0-9]+).?)|FIRST|LAST|@)");
 
     if (!r.search(field))
     {
@@ -105,7 +110,7 @@ public class ModellerDescription
     {
       value = r.stringMatched(1);
     }
-    // jalview.bin.Cache.log.debug("from '" + field + "' matched '" + value +
+    // Cache.debug("from '" + field + "' matched '" + value +
     // "'");
     try
     {
@@ -160,7 +165,7 @@ public class ModellerDescription
                 }
                 else
                 {
-                  // jalview.bin.Cache.log.debug(
+                  // Cache.debug(
                   // "Ignoring non-Modeller description: invalid integer-like
                   // field '" + field + "'");
                   type = -1; /* invalid field! - throw the FieldSet away */
@@ -271,21 +276,19 @@ public class ModellerDescription
       if (seq.getDatasetSequence() != null
               && seq.getDatasetSequence().getDBRefs() != null)
       {
-        jalview.datamodel.DBRefEntry[] dbr = seq.getDatasetSequence()
-                .getDBRefs();
-        int i, j;
-        for (i = 0, j = dbr.length; i < j; i++)
+        List<DBRefEntry> dbr = seq.getDatasetSequence().getDBRefs();
+        for (int i = 0, ni = dbr.size(); i < ni; i++)
         {
-          if (dbr[i] != null)
+          DBRefEntry dbri = dbr.get(i);
+          if (dbri != null)
           {
             // JBPNote PDB dbRefEntry needs properties to propagate onto
             // ModellerField
             // JBPNote Need to get info from the user about whether the sequence
             // is the one being modelled, or if it is a template.
-            if (dbr[i].getSource()
-                    .equals(jalview.datamodel.DBRefSource.PDB))
+            if (dbri.getSource().equals(jalview.datamodel.DBRefSource.PDB))
             {
-              fields.put(Fields[LOCALID], dbr[i].getAccessionId());
+              fields.put(Fields[LOCALID], dbri.getAccessionId());
               t = 2;
               break;
             }