X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fschemes%2FColourSchemeProperty.java;h=fc92cd96b2f400fcb0cc4739d640f6b28df25877;hb=refs%2Fheads%2Fkjvdh%2Ffeatures%2Ftesting;hp=cee2cae354cb5454b719830a764aac4224d13b5c;hpb=a09d6f5c16b0e222806e035cd38bfb4c4eb92c75;p=jalview.git
diff --git a/src/jalview/schemes/ColourSchemeProperty.java b/src/jalview/schemes/ColourSchemeProperty.java
index cee2cae..fc92cd9 100755
--- a/src/jalview/schemes/ColourSchemeProperty.java
+++ b/src/jalview/schemes/ColourSchemeProperty.java
@@ -44,6 +44,9 @@ public class ColourSchemeProperty
* Returns a colour scheme for the given name, with which the given data may
* be coloured. The name is not case-sensitive, and may be one of
*
+ * - any currently registered colour scheme; Jalview by default
+ * provides
+ *
* - Clustal
* - Blosum62
* - % Identity
@@ -58,11 +61,13 @@ public class ColourSchemeProperty
* - Purine/Pyrimidine
* - T-Coffee Scores
* - RNA Helices
- * - User Defined
+ *
+ * - the name of a programmatically added colour scheme
* - an AWT colour name e.g. red
* - an AWT hex rgb colour e.g. ff2288
* - residue colours list e.g. D,E=red;K,R,H=0022FF;c=yellow
*
+ *
* If none of these formats is matched, the string is converted to a colour
* using a hashing algorithm. For name "None", returns null.
*
@@ -78,10 +83,16 @@ public class ColourSchemeProperty
return null;
}
- JalviewColourScheme scheme = JalviewColourScheme.forName(name);
+
+ /*
+ * if this is the name of a registered colour scheme, just
+ * create a new instance of it
+ */
+ ColourSchemeI scheme = ColourSchemes.getInstance().getColourScheme(name,
+ forData, null);
if (scheme != null)
{
- return scheme.getColourScheme(forData);
+ return scheme;
}
/*
@@ -91,14 +102,7 @@ public class ColourSchemeProperty
* e.g. "red" or "ff00ed",
* or failing that hash the name to a colour
*/
- UserColourScheme ucs = null;
- try
- {
- ucs = new UserColourScheme(name);
- } catch (Exception e)
- {
- // System.err.println("Ignoring exception when parsing colourscheme as applet-parameter");
- }
+ UserColourScheme ucs = new UserColourScheme(name);
return ucs;
}
@@ -145,8 +149,7 @@ public class ColourSchemeProperty
*/
public static String getColourName(ColourSchemeI cs)
{
- return cs == null ? ResidueColourScheme.NONE : cs
- .getSchemeName();
+ return cs == null ? ResidueColourScheme.NONE : cs.getSchemeName();
}
}