X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fschemes%2FRNAHelicesColour.java;h=9729a8347f2de9bc3a2e8c32ed7c5a2f070e7be7;hb=9ecc7ec6a4eb1d0713c2c050a79c5b04c2092309;hp=76592ba99f5c7550bb5c57e333906d2134ed9361;hpb=648ab7d29d683f065f1f11c3f8d373c7ca8d1cbf;p=jalview.git

diff --git a/src/jalview/schemes/RNAHelicesColour.java b/src/jalview/schemes/RNAHelicesColour.java
index 76592ba..9729a83 100644
--- a/src/jalview/schemes/RNAHelicesColour.java
+++ b/src/jalview/schemes/RNAHelicesColour.java
@@ -41,15 +41,10 @@ public class RNAHelicesColour extends ResidueColourScheme
 {
 
   /**
-   * Stores random colors generated for the number of helices
-   */
-  public Hashtable helixcolorhash = new Hashtable();
-
-  /**
    * Maps sequence positions to the RNA helix they belong to. Key: position,
-   * Value: helix
+   * Value: helix TODO: Revise or drop in favour of annotation position numbers
    */
-  public Hashtable positionsToHelix = new Hashtable();
+  public Hashtable<Integer, String> positionsToHelix = new Hashtable<Integer, String>();
 
   /**
    * Number of helices in the RNA secondary structure
@@ -65,12 +60,14 @@ public class RNAHelicesColour extends ResidueColourScheme
   {
     super(ResidueProperties.nucleotideIndex);
     this.annotation = annotation;
+    ColourSchemeProperty.resetRnaHelicesShading();
     refresh();
   }
 
   public RNAHelicesColour(AnnotatedCollectionI alignment)
   {
     super(ResidueProperties.nucleotideIndex);
+    ColourSchemeProperty.resetRnaHelicesShading();
     alignmentChanged(alignment, null);
   }
 
@@ -82,7 +79,6 @@ public class RNAHelicesColour extends ResidueColourScheme
   public RNAHelicesColour(RNAHelicesColour rnaHelicesColour)
   {
     super(ResidueProperties.nucleotideIndex);
-    helixcolorhash = rnaHelicesColour.helixcolorhash;
     annotation = rnaHelicesColour.annotation;
     refresh();
   }
@@ -95,11 +91,16 @@ public class RNAHelicesColour extends ResidueColourScheme
     // This loop will find the first rna structure annotation by which to colour
     // the sequences.
     AlignmentAnnotation[] annotations = alignment.getAlignmentAnnotation();
+    if (annotations == null)
+    {
+      return;
+    }
     for (int i = 0; i < annotations.length; i++)
     {
 
       // is this a sensible way of determining type of annotation?
-      if (annotations[i].getRNAStruc() != null)
+      if (annotations[i].visible && annotations[i].isRNA()
+              && annotations[i].isValidStruc())
       {
         annotation = annotations[i];
         break;
@@ -122,7 +123,7 @@ public class RNAHelicesColour extends ResidueColourScheme
       annotation.getRNAStruc();
       lastrefresh = annotation._rnasecstr.hashCode();
       numHelix = 0;
-      positionsToHelix = new Hashtable();
+      positionsToHelix = new Hashtable<Integer, String>();
 
       // Figure out number of helices
       // Length of rnasecstr is the number of pairs of positions that base pair
@@ -149,16 +150,7 @@ public class RNAHelicesColour extends ResidueColourScheme
         }
 
       }
-
-      // Generate random colors and store
-      for (int j = 0; j <= numHelix; j++)
-      {
-        if (!helixcolorhash.containsKey(Integer.toString(j)))
-        {
-          helixcolorhash.put(Integer.toString(j),
-                  jalview.util.ColorUtils.generateRandomColor(Color.white));
-        }
-      }
+      ColourSchemeProperty.initRnaHelicesShading(numHelix);
     }
   }
 
@@ -185,7 +177,7 @@ public class RNAHelicesColour extends ResidueColourScheme
    * @param c
    *          Character in sequence
    * @param j
-   *          Threshold
+   *          position in sequence - used to locate helix
    * 
    * @return Color in RGB
    */
@@ -195,15 +187,12 @@ public class RNAHelicesColour extends ResidueColourScheme
     refresh();
     Color currentColour = Color.white;
     String currentHelix = null;
-    currentHelix = (String) positionsToHelix.get(j);
-
+    currentHelix = positionsToHelix.get(j);
     if (currentHelix != null)
     {
-      currentColour = (Color) helixcolorhash.get(currentHelix);
+      currentColour = ColourSchemeProperty.rnaHelices[Integer
+              .parseInt(currentHelix)];
     }
-
-    // System.out.println(c + " " + j + " helix " + currentHelix + " " +
-    // currentColour);
     return currentColour;
   }
 
@@ -213,4 +202,4 @@ public class RNAHelicesColour extends ResidueColourScheme
   {
     return new RNAHelicesColour(this);
   }
-}
+}
\ No newline at end of file