X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Futil%2FMappingUtils.java;h=25cb810cf61228031d1d9e105cda92ee5a3c9e17;hb=0c97b70b61d6d02ce932d04a1621d2961db77c16;hp=c66fe00b9cb324dad69795f2b8b8b86a72b8b28e;hpb=f19db76149ae51db15f904890fb56b4c9aa25d8d;p=jalview.git

diff --git a/src/jalview/util/MappingUtils.java b/src/jalview/util/MappingUtils.java
index c66fe00..25cb810 100644
--- a/src/jalview/util/MappingUtils.java
+++ b/src/jalview/util/MappingUtils.java
@@ -29,7 +29,7 @@ import java.util.Map;
 
 import jalview.analysis.AlignmentSorter;
 import jalview.api.AlignViewportI;
-import jalview.bin.Cache;
+import jalview.bin.Console;
 import jalview.commands.CommandI;
 import jalview.commands.EditCommand;
 import jalview.commands.EditCommand.Action;
@@ -81,7 +81,7 @@ public final class MappingUtils
       action = action.getUndoAction();
     }
     // TODO write this
-    Cache.log.error("MappingUtils.mapCutOrPaste not yet implemented");
+    Console.error("MappingUtils.mapCutOrPaste not yet implemented");
   }
 
   /**
@@ -370,47 +370,50 @@ public final class MappingUtils
         int mappedEndResidue = 0;
         for (AlignedCodonFrame acf : codonFrames)
         {
-          for (SequenceToSequenceMapping map: acf.getMappings())
+          // rather than use acf.getCoveringMapping() we iterate through all
+          // mappings to make sure all CDS are selected for a protein
+          for (SequenceToSequenceMapping map : acf.getMappings())
           {
-          if (map.covers(selected) && map.covers(seq))
-          {
-            /*
-             * Found a sequence mapping. Locate the start/end mapped residues.
-             */
-            List<AlignedCodonFrame> mapping = Arrays
-                    .asList(new AlignedCodonFrame[]
-                    { acf });
-            // locate start 
-            SearchResultsI sr = buildSearchResults(selected,
-                    startResiduePos, mapping);
-            for (SearchResultMatchI m : sr.getResults())
-            {
-              mappedStartResidue = m.getStart();
-              mappedEndResidue = m.getEnd();
-            }
-            // locate end - allowing for adjustment of start range
-            sr = buildSearchResults(selected, endResiduePos, mapping);
-            for (SearchResultMatchI m : sr.getResults())
+            if (map.covers(selected) && map.covers(seq))
             {
-              mappedStartResidue = Math.min(mappedStartResidue,
-                      m.getStart());
-              mappedEndResidue = Math.max(mappedEndResidue, m.getEnd());
-            }
+              /*
+               * Found a sequence mapping. Locate the start/end mapped residues.
+               */
+              List<AlignedCodonFrame> mapping = Arrays
+                      .asList(new AlignedCodonFrame[]
+                      { acf });
+              // locate start
+              SearchResultsI sr = buildSearchResults(selected,
+                      startResiduePos, mapping);
+              for (SearchResultMatchI m : sr.getResults())
+              {
+                mappedStartResidue = m.getStart();
+                mappedEndResidue = m.getEnd();
+              }
+              // locate end - allowing for adjustment of start range
+              sr = buildSearchResults(selected, endResiduePos, mapping);
+              for (SearchResultMatchI m : sr.getResults())
+              {
+                mappedStartResidue = Math.min(mappedStartResidue,
+                        m.getStart());
+                mappedEndResidue = Math.max(mappedEndResidue, m.getEnd());
+              }
 
-            /*
-             * Find the mapped aligned columns, save the range. Note findIndex
-             * returns a base 1 position, SequenceGroup uses base 0
-             */
-            int mappedStartCol = seq.findIndex(mappedStartResidue) - 1;
-            minStartCol = minStartCol == -1 ? mappedStartCol
-                    : Math.min(minStartCol, mappedStartCol);
-            int mappedEndCol = seq.findIndex(mappedEndResidue) - 1;
-            maxEndCol = maxEndCol == -1 ? mappedEndCol
-                    : Math.max(maxEndCol, mappedEndCol);
-            mappedGroup.addSequence(seq, false);
-            break;
+              /*
+               * Find the mapped aligned columns, save the range. Note findIndex
+               * returns a base 1 position, SequenceGroup uses base 0
+               */
+              int mappedStartCol = seq.findIndex(mappedStartResidue) - 1;
+              minStartCol = minStartCol == -1 ? mappedStartCol
+                      : Math.min(minStartCol, mappedStartCol);
+              int mappedEndCol = seq.findIndex(mappedEndResidue) - 1;
+              maxEndCol = maxEndCol == -1 ? mappedEndCol
+                      : Math.max(maxEndCol, mappedEndCol);
+              mappedGroup.addSequence(seq, false);
+              break;
+            }
           }
-        }}
+        }
       }
     }
     mappedGroup.setStartRes(minStartCol < 0 ? 0 : minStartCol);
@@ -449,18 +452,21 @@ public final class MappingUtils
     {
       for (AlignedCodonFrame acf : mappings)
       {
-        SequenceI mappedSeq = mappingToNucleotide ? acf.getDnaForAaSeq(seq)
-                : acf.getAaForDnaSeq(seq);
-        if (mappedSeq != null)
+        for (SequenceI seq2 : mapTo.getSequences())
         {
-          for (SequenceI seq2 : mapTo.getSequences())
+          /*
+           * the corresponding peptide / CDS is the one for which there is
+           * a complete ('covering') mapping to 'seq'
+           */
+          SequenceI peptide = mappingToNucleotide ? seq2 : seq;
+          SequenceI cds = mappingToNucleotide ? seq : seq2;
+          SequenceToSequenceMapping s2s = acf.getCoveringMapping(cds,
+                  peptide);
+          if (s2s != null)
           {
-            if (seq2.getDatasetSequence() == mappedSeq)
-            {
-              mappedOrder.add(seq2);
-              j++;
-              break;
-            }
+            mappedOrder.add(seq2);
+            j++;
+            break;
           }
         }
       }
@@ -524,7 +530,7 @@ public final class MappingUtils
 
     if (colsel == null)
     {
-      return; // mappedColumns;
+      return;
     }
 
     char fromGapChar = mapFrom.getAlignment().getGapCharacter();
@@ -548,7 +554,7 @@ public final class MappingUtils
       mapHiddenColumns(regions.next(), codonFrames, newHidden,
               fromSequences, toSequences, fromGapChar);
     }
-    return; // mappedColumns;
+    return;
   }
 
   /**
@@ -666,7 +672,9 @@ public final class MappingUtils
          */
         for (SequenceI toSeq : toSequences)
         {
-          if (toSeq.getDatasetSequence() == mappedSeq)
+          if (toSeq.getDatasetSequence() == mappedSeq
+                  && mappedStartResidue >= toSeq.getStart()
+                  && mappedEndResidue <= toSeq.getEnd())
           {
             int mappedStartCol = toSeq.findIndex(mappedStartResidue);
             int mappedEndCol = toSeq.findIndex(mappedEndResidue);
@@ -835,7 +843,7 @@ public final class MappingUtils
     {
       if (range.length % 2 != 0)
       {
-        Cache.log.error(
+        Console.error(
                 "Error unbalance start/end ranges: " + ranges.toString());
         return 0;
       }
@@ -991,7 +999,7 @@ public final class MappingUtils
         /*
          * not coded for [start1, end1, start2, end2, ...]
          */
-        Cache.log.error(
+        Console.error(
                 "MappingUtils.removeEndPositions doesn't handle multiple  ranges");
         return;
       }
@@ -1002,7 +1010,7 @@ public final class MappingUtils
         /*
          * not coded for a reverse strand range (end < start)
          */
-        Cache.log.error(
+        Console.error(
                 "MappingUtils.removeEndPositions doesn't handle reverse strand");
         return;
       }