X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fviewmodel%2Fseqfeatures%2FFeatureRendererModel.java;h=87ebf1a90bef6f909973c62b02ae4e11aeb85026;hb=db4eacee27b836db4126dca551887bfc6652d72a;hp=30d14c2a10f644667d0e48fa1bb34a160349dd6e;hpb=497958b4e5217efaa3ddeece38f38c3a6e98cb96;p=jalview.git diff --git a/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java b/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java index 30d14c2..87ebf1a 100644 --- a/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java +++ b/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java @@ -1,3 +1,23 @@ +/* + * Jalview - A Sequence Alignment Editor and Viewer ($$Version-Rel$$) + * Copyright (C) $$Year-Rel$$ The Jalview Authors + * + * This file is part of Jalview. + * + * Jalview is free software: you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation, either version 3 + * of the License, or (at your option) any later version. + * + * Jalview is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with Jalview. If not, see . + * The Jalview Authors are detailed in the 'AUTHORS' file. + */ package jalview.viewmodel.seqfeatures; import jalview.api.AlignViewportI; @@ -119,8 +139,7 @@ public abstract class FeatureRendererModel implements } if (!fdi.isRegistered(featureType)) { - pushFeatureType(Arrays.asList(new String[] - { featureType })); + pushFeatureType(Arrays.asList(new String[] { featureType })); } fdi.setVisible(featureType); } @@ -163,7 +182,7 @@ public abstract class FeatureRendererModel implements types.toArray(neworder); if (renderOrder != null) { - System.arraycopy(neworder,0,neworder,renderOrder.length,ts); + System.arraycopy(neworder, 0, neworder, renderOrder.length, ts); System.arraycopy(renderOrder, 0, neworder, 0, renderOrder.length); } renderOrder = neworder; @@ -186,8 +205,7 @@ public abstract class FeatureRendererModel implements protected final byte[] normaliseScore(SequenceFeature sequenceFeature) { float[] mm = ((float[][]) minmax.get(sequenceFeature.type))[0]; - final byte[] r = new byte[] - { 0, (byte) 255 }; + final byte[] r = new byte[] { 0, (byte) 255 }; if (mm != null) { if (r[0] != 0 || mm[0] < 0.0) @@ -246,6 +264,7 @@ public abstract class FeatureRendererModel implements { ArrayList tmp = new ArrayList(); SequenceFeature[] features = sequence.getSequenceFeatures(); + if (features != null) { for (int i = 0; i < features.length; i++) @@ -322,9 +341,7 @@ public abstract class FeatureRendererModel implements for (int i = 0; i < alignment.getHeight(); i++) { SequenceI asq = alignment.getSequenceAt(i); - SequenceI dasq = asq.getDatasetSequence(); - SequenceFeature[] features = dasq != null ? dasq - .getSequenceFeatures() : asq.getSequenceFeatures(); + SequenceFeature[] features = asq.getSequenceFeatures(); if (features == null) { @@ -370,20 +387,19 @@ public abstract class FeatureRendererModel implements { allfeatures.add(features[index].getType()); } - if (features[index].score != Float.NaN) + if (!Float.isNaN(features[index].score)) { int nonpos = features[index].getBegin() >= 1 ? 0 : 1; float[][] mm = (float[][]) minmax.get(features[index].getType()); if (mm == null) { - mm = new float[][] - { null, null }; + mm = new float[][] { null, null }; minmax.put(features[index].getType(), mm); } if (mm[nonpos] == null) { - mm[nonpos] = new float[] - { features[index].score, features[index].score }; + mm[nonpos] = new float[] { features[index].score, + features[index].score }; } else @@ -434,8 +450,7 @@ public abstract class FeatureRendererModel implements { if (initOrders) { - setOrder(oldRender[j], (1 - (1 + (float) j) - / oldRender.length)); + setOrder(oldRender[j], (1 - (1 + (float) j) / oldRender.length)); } if (allfeatures.contains(oldRender[j])) { @@ -771,8 +786,7 @@ public abstract class FeatureRendererModel implements { if (renderOrder == null) { - return Arrays.asList(new String[] - {}); + return Arrays.asList(new String[] {}); } return Arrays.asList(renderOrder); } @@ -900,7 +914,7 @@ public abstract class FeatureRendererModel implements { for (int i = 0; i < typ.length; i++) { - if (feature_disp.isVisible(typ[i])) + if (!feature_disp.isVisible(typ[i])) { typ[i] = null; }