X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fworkers%2FAlignCalcManager.java;h=6a2d6ee132fb05d93b11815f0957a1ed3c77f5b4;hb=b2f9a8d7bce642ff4011bc6d49e02bb0569fbb11;hp=784c64e2a93e90e0c08ac47e62734b9a7f0cbb1a;hpb=ada5f73a98ed0f6e45d4462041fd7ef97ad4ccc8;p=jalview.git
diff --git a/src/jalview/workers/AlignCalcManager.java b/src/jalview/workers/AlignCalcManager.java
index 784c64e..6a2d6ee 100644
--- a/src/jalview/workers/AlignCalcManager.java
+++ b/src/jalview/workers/AlignCalcManager.java
@@ -1,10 +1,30 @@
+/*
+ * Jalview - A Sequence Alignment Editor and Viewer (Version 2.8.1)
+ * Copyright (C) 2014 The Jalview Authors
+ *
+ * This file is part of Jalview.
+ *
+ * Jalview is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+ *
+ * Jalview is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+ * PURPOSE. See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along with Jalview. If not, see .
+ * The Jalview Authors are detailed in the 'AUTHORS' file.
+ */
package jalview.workers;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.HashSet;
import java.util.Hashtable;
import java.util.List;
import java.util.Map;
+import java.util.Set;
import jalview.api.AlignCalcManagerI;
import jalview.api.AlignCalcWorkerI;
@@ -12,42 +32,99 @@ import jalview.datamodel.AlignmentAnnotation;
public class AlignCalcManager implements AlignCalcManagerI
{
- private volatile List restartable = new ArrayList();
+ private volatile List restartable = Collections
+ .synchronizedList(new ArrayList());
- private final List blackList = new ArrayList();
+ private volatile List blackList = Collections
+ .synchronizedList(new ArrayList());
/**
* global record of calculations in progress
*/
- private final Hashtable inProgress = new Hashtable();
+ private volatile Map inProgress = Collections
+ .synchronizedMap(new Hashtable());
/**
* record of calculations pending or in progress in the current context
*/
- private final Map> updating = new Hashtable>();
+ private volatile Map> updating = Collections
+ .synchronizedMap(new Hashtable>());
@Override
public void notifyStart(AlignCalcWorkerI worker)
{
- List upd = updating.get(worker.getClass());
- if (upd == null)
+ synchronized (updating)
{
- updating.put(worker.getClass(),
- upd = new ArrayList());
+ List upd = updating.get(worker.getClass());
+ if (upd == null)
+ {
+ updating.put(
+ worker.getClass(),
+ upd = Collections
+ .synchronizedList(new ArrayList()));
+ }
+ synchronized (upd)
+ {
+ upd.add(worker);
+ }
}
- upd.add(worker);
}
@Override
- public synchronized boolean alreadyDoing(AlignCalcWorkerI worker)
+ public boolean alreadyDoing(AlignCalcWorkerI worker)
+ {
+ synchronized (inProgress)
+ {
+ return inProgress.containsKey(worker.getClass());
+ }
+ }
+
+ /*
+ * (non-Javadoc)
+ *
+ * @see jalview.api.AlignCalcManagerI#isPending(jalview.api.AlignCalcWorkerI)
+ */
+ @Override
+ public boolean isPending(AlignCalcWorkerI workingClass)
+ {
+ List upd;
+ synchronized (updating)
+ {
+ upd = updating.get(workingClass.getClass());
+ if (upd == null)
+ {
+ return false;
+ }
+ synchronized (upd)
+ {
+ if (upd.size() > 1)
+ {
+ return true;
+ }
+ }
+ return false;
+ }
+ }
+
+ // TODO make into api method if needed ?
+ public int numberLive(AlignCalcWorkerI worker)
{
- return inProgress.containsKey(worker.getClass());
+ synchronized (updating)
+ {
+ List upd = updating.get(worker.getClass());
+ if (upd == null)
+ {
+ return 0;
+ }
+ ;
+ return upd.size();
+ }
}
@Override
- public synchronized boolean notifyWorking(AlignCalcWorkerI worker)
+ public boolean notifyWorking(AlignCalcWorkerI worker)
{
- // synchronized (inProgress)
+ synchronized (inProgress)
{
// TODO: decide if we should throw exceptions here if multiple workers
// start to work
@@ -66,92 +143,136 @@ public class AlignCalcManager implements AlignCalcManagerI
return true;
}
- private final HashSet canUpdate=new HashSet();
+ private final HashSet canUpdate = new HashSet();
+
@Override
- public synchronized void workerComplete(AlignCalcWorkerI worker)
+ public void workerComplete(AlignCalcWorkerI worker)
{
- inProgress.remove(worker.getClass());
- List upd = updating.get(worker.getClass());
- if (upd != null)
+ synchronized (inProgress)
{
- upd.remove(worker);
- canUpdate.add(worker);
+ // System.err.println("Worker "+worker.getClass()+" marked as complete.");
+ inProgress.remove(worker.getClass());
+ List upd = updating.get(worker.getClass());
+ if (upd != null)
+ {
+ synchronized (upd)
+ {
+ upd.remove(worker);
+ }
+ canUpdate.add(worker);
+ }
}
-
}
@Override
public void workerCannotRun(AlignCalcWorkerI worker)
{
- blackList.add(worker.getClass());
+ synchronized (blackList)
+ {
+ blackList.add(worker.getClass());
+ }
}
public boolean isBlackListed(Class workerType)
{
- return blackList.contains(workerType);
+ synchronized (blackList)
+ {
+ return blackList.contains(workerType);
+ }
}
@Override
public void startWorker(AlignCalcWorkerI worker)
{
- new Thread(worker).start();
+ // System.err.println("Starting "+worker.getClass());
+ // new Exception("").printStackTrace();
+ Thread tw = new Thread(worker);
+ tw.setName(worker.getClass().toString());
+ tw.start();
}
@Override
- public synchronized boolean isWorking(AlignCalcWorkerI worker)
+ public boolean isWorking(AlignCalcWorkerI worker)
{
- // System.err.println("isWorking : worker "+(worker!=null ?
- // worker.getClass():"null")+ " "+hashCode());
- return worker != null && inProgress.get(worker.getClass()) == worker;
+ synchronized (inProgress)
+ {// System.err.println("isWorking : worker "+(worker!=null ?
+ // worker.getClass():"null")+ " "+hashCode());
+ return worker != null && inProgress.get(worker.getClass()) == worker;
+ }
}
@Override
public boolean isWorking()
{
- // System.err.println("isWorking "+hashCode());
- return inProgress.size() > 0;
+ synchronized (inProgress)
+ {
+ // System.err.println("isWorking "+hashCode());
+ return inProgress.size() > 0;
+ }
}
@Override
public void registerWorker(AlignCalcWorkerI worker)
{
- if (!restartable.contains(worker))
+ synchronized (restartable)
{
- restartable.add(worker);
+ if (!restartable.contains(worker))
+ {
+ restartable.add(worker);
+ }
+ startWorker(worker);
}
- startWorker(worker);
}
@Override
public void restartWorkers()
{
- for (AlignCalcWorkerI worker : restartable)
+ synchronized (restartable)
{
- startWorker(worker);
+ for (AlignCalcWorkerI worker : restartable)
+ {
+ startWorker(worker);
+ }
}
}
@Override
public boolean workingInvolvedWith(AlignmentAnnotation alignmentAnnotation)
{
- if (isWorking())
+ synchronized (inProgress)
{
- for (List workers: updating.values())
+ for (AlignCalcWorkerI worker : inProgress.values())
{
- for (AlignCalcWorkerI worker:workers)
if (worker.involves(alignmentAnnotation))
{
return true;
}
}
}
+ synchronized (updating)
+ {
+ for (List workers : updating.values())
+ {
+ for (AlignCalcWorkerI worker : workers)
+ if (worker.involves(alignmentAnnotation))
+ {
+ return true;
+ }
+ }
+ }
return false;
}
@Override
public void updateAnnotationFor(Class workerClass)
{
- for (AlignCalcWorkerI worker:canUpdate.toArray(new AlignCalcWorkerI[0]))
+
+ AlignCalcWorkerI[] workers;
+ synchronized (canUpdate)
+ {
+ workers = canUpdate.toArray(new AlignCalcWorkerI[0]);
+ }
+ for (AlignCalcWorkerI worker : workers)
{
if (workerClass.equals(worker.getClass()))
{
@@ -164,37 +285,97 @@ public class AlignCalcManager implements AlignCalcManagerI
public List getRegisteredWorkersOfClass(
Class workerClass)
{
- List workingClass=new ArrayList();
- for (AlignCalcWorkerI worker:canUpdate.toArray(new AlignCalcWorkerI[0]))
+ List workingClass = new ArrayList();
+ AlignCalcWorkerI[] workers;
+ synchronized (canUpdate)
+ {
+ workers = canUpdate.toArray(new AlignCalcWorkerI[0]);
+ }
+ for (AlignCalcWorkerI worker : workers)
{
if (workerClass.equals(worker.getClass()))
{
workingClass.add(worker);
}
}
- return (workingClass.size()==0) ? null : workingClass;
+ return (workingClass.size() == 0) ? null : workingClass;
}
@Override
public boolean startRegisteredWorkersOfClass(Class workerClass)
{
- List workers=getRegisteredWorkersOfClass(workerClass);
- if (workers==null)
- {
- return false;
- }
- for (AlignCalcWorkerI worker: workers) {
- startWorker(worker);
- }
- return true;
+ List workers = getRegisteredWorkersOfClass(workerClass);
+ if (workers == null)
+ {
+ return false;
+ }
+ for (AlignCalcWorkerI worker : workers)
+ {
+ if (!isPending(worker))
+ {
+ startWorker(worker);
+ }
+ else
+ {
+ System.err.println("Pending exists for " + workerClass);
+ }
+ }
+ return true;
}
@Override
public void workerMayRun(AlignCalcWorkerI worker)
{
- if (blackList.contains(worker.getClass()))
+ synchronized (blackList)
{
- blackList.remove(worker.getClass());
+ if (blackList.contains(worker.getClass()))
+ {
+ blackList.remove(worker.getClass());
+ }
}
}
+
+ @Override
+ public void removeRegisteredWorkersOfClass(Class typeToRemove)
+ {
+ List workers = getRegisteredWorkersOfClass(typeToRemove);
+ List removable = new ArrayList();
+ Set toremovannot = new HashSet();
+ synchronized (restartable)
+ {
+ for (AlignCalcWorkerI worker : restartable)
+ {
+ if (typeToRemove.equals(worker.getClass()))
+ {
+ removable.add(worker);
+ toremovannot.add(worker);
+ }
+ }
+ restartable.removeAll(removable);
+ }
+ synchronized (canUpdate)
+ {
+ for (AlignCalcWorkerI worker : canUpdate)
+ {
+ if (typeToRemove.equals(worker.getClass()))
+ {
+ removable.add(worker);
+ toremovannot.add(worker);
+ }
+ }
+ canUpdate.removeAll(removable);
+ }
+ // TODO: finish testing this extension
+
+ /*
+ * synchronized (inProgress) { // need to kill or mark as dead any running
+ * threads... (inProgress.get(typeToRemove)); }
+ *
+ * if (workers == null) { return; } for (AlignCalcWorkerI worker : workers)
+ * {
+ *
+ * if (isPending(worker)) { worker.abortAndDestroy(); startWorker(worker); }
+ * else { System.err.println("Pending exists for " + workerClass); } }
+ */
+ }
}