X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fws%2Fdbsources%2FEmblXmlSource.java;h=ca90d6085bb23c37339ba31a94bf3a2cf40a20ad;hb=788e840cc150aa4777a370cebfdf5d17589bbbaf;hp=008522136f00a787cda134b3f3e0cfad4ea7c3ac;hpb=9fe87bd08ab29b6fe53364f387d7a2e3a8d39994;p=jalview.git diff --git a/src/jalview/ws/dbsources/EmblXmlSource.java b/src/jalview/ws/dbsources/EmblXmlSource.java index 0085221..ca90d60 100644 --- a/src/jalview/ws/dbsources/EmblXmlSource.java +++ b/src/jalview/ws/dbsources/EmblXmlSource.java @@ -63,14 +63,14 @@ public abstract class EmblXmlSource extends EbiFileRetrievedProxy try { reply = dbFetch.fetchDataAsFile( - emprefx.toLowerCase() + ":" + query.trim(), "emblxml", null, - ".xml"); + emprefx.toLowerCase() + ":" + query.trim(), "display=xml", + "xml"); } catch (Exception e) { stopQuery(); throw new Exception(MessageManager.formatMessage( - "exception.ebiembl_retrieval_failed_on", new String[] { - emprefx.toLowerCase(), query.trim() }), e); + "exception.ebiembl_retrieval_failed_on", new String[] + { emprefx.toLowerCase(), query.trim() }), e); } return getEmblSequenceRecords(emprefx, query, reply); } @@ -91,7 +91,7 @@ public abstract class EmblXmlSource extends EbiFileRetrievedProxy File reply) throws Exception { EmblFile efile = null; - List seqs = new ArrayList(); + List seqs = new ArrayList<>(); if (reply != null && reply.exists()) { @@ -102,8 +102,13 @@ public abstract class EmblXmlSource extends EbiFileRetrievedProxy } } - List peptides = new ArrayList(); - if (efile != null) + /* + * invalid accession gets a reply with no elements, text content of + * EmbFile reads something like (e.g.) this ungrammatical phrase + * Entry: display type is either not supported or entry is not found. + */ + List peptides = new ArrayList<>(); + if (efile != null && efile.getEntries() != null) { for (EmblEntry entry : efile.getEntries()) {