X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fws%2Frest%2FHttpResultSet.java;h=5bfe3b5fe9636b5c034b0584029b9ad881567966;hb=f3133c4f086cbdf59a7ce7fe465d2a5fa4a0fd60;hp=d682da184d1c5a6068990179b8f5157e34c57717;hpb=37de9310bec3501cbc6381e0c3dcb282fcaad812;p=jalview.git diff --git a/src/jalview/ws/rest/HttpResultSet.java b/src/jalview/ws/rest/HttpResultSet.java index d682da1..5bfe3b5 100644 --- a/src/jalview/ws/rest/HttpResultSet.java +++ b/src/jalview/ws/rest/HttpResultSet.java @@ -50,7 +50,7 @@ import org.apache.james.mime4j.parser.MimeStreamParser; * */ -public class HttpResultSet extends FileParse +public class HttpResultSet extends FileParse implements AutoCloseable { private HttpRequestBase cachedRequest; @@ -89,7 +89,7 @@ public class HttpResultSet extends FileParse */ public List createResultDataProviders() { - List dp = new ArrayList(); + List dp = new ArrayList<>(); for (JvDataType type : restJob.rsd.getResultDataTypes()) { dp.add(new SimpleDataProvider(type, this, null)); @@ -106,14 +106,13 @@ public class HttpResultSet extends FileParse */ public Object[] parseResultSet() throws Exception, Error { - List dp = new ArrayList(); + List dp = new ArrayList<>(); Object[] results = null; if (en == null) { - throw new Error( - MessageManager - .getString("error.implementation_error_need_to_have_httpresponse")); + throw new Error(MessageManager.getString( + "error.implementation_error_need_to_have_httpresponse")); } jalview.io.packed.JalviewDataset ds = restJob.newJalviewDataset(); // Decide how we deal with content. @@ -155,8 +154,8 @@ public class HttpResultSet extends FileParse if (!(en instanceof MultipartEntity)) { // assume content is simple text stream that can be read from - String enc = (en.getContentEncoding() == null) ? null : en - .getContentEncoding().getValue(); + String enc = (en.getContentEncoding() == null) ? null + : en.getContentEncoding().getValue(); if (en.getContentType() != null) { Cache.log.debug("Result Type: " + en.getContentType().toString()); @@ -201,7 +200,7 @@ public class HttpResultSet extends FileParse } @Override - protected void finalize() throws Throwable + public void close() { dataIn = null; cachedRequest = null; @@ -216,7 +215,8 @@ public class HttpResultSet extends FileParse } catch (Error ex) { } - super.finalize(); + // no finalize for FileParse + // super.close(); } /**