X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=src%2Fjalview%2Fws%2Fuimodel%2FPDBRestResponse.java;h=889a324fa861273221b7f5d14987272d24ac4c52;hb=fd235cc7542d6e308e054a8a76580a6c511ae631;hp=5a1f53deba07af73a828b404b339366e3d6704e7;hpb=a17368a2ea84c23fc5e65b8ea3c08086926758e4;p=jalview.git diff --git a/src/jalview/ws/uimodel/PDBRestResponse.java b/src/jalview/ws/uimodel/PDBRestResponse.java index 5a1f53d..889a324 100644 --- a/src/jalview/ws/uimodel/PDBRestResponse.java +++ b/src/jalview/ws/uimodel/PDBRestResponse.java @@ -24,7 +24,6 @@ package jalview.ws.uimodel; import jalview.ws.dbsources.PDBRestClient.PDBDocField; import java.util.Collection; -import java.util.List; import java.util.Objects; import javax.swing.DefaultListModel; @@ -149,8 +148,8 @@ public class PDBRestResponse public PDBResponseSummary(JSONObject doc, PDBRestRequest request) { - StringBuilder summaryBuilder = new StringBuilder(); - List diplayFields = request.getWantedFields(); + StringBuilder summaryBuilder = new StringBuilder(); + Collection diplayFields = request.getWantedFields(); String associatedSeq = request.getAssociatedSequence(); int colCounter = 0; summaryData = new String[(associatedSeq != null) ? diplayFields @@ -165,54 +164,22 @@ public class PDBRestResponse for (PDBDocField field : diplayFields) { - if (field.equals(PDBDocField.MOLECULE_TYPE) - && doc.get(PDBDocField.MOLECULE_TYPE.getCode()) != null) - { - String moleculeType = doc - .get(PDBDocField.MOLECULE_TYPE.getCode()).toString(); - if (moleculeType.equalsIgnoreCase("protein")) - { - summaryBuilder.append(""); - } - if (moleculeType.equalsIgnoreCase("dna")) - { - summaryBuilder.append(""); - } - if (moleculeType.equalsIgnoreCase("rna")) - { - summaryBuilder.append(""); - } - if (moleculeType.equalsIgnoreCase("sugar")) - { - summaryBuilder.append(""); - } - summaryData[colCounter++] = moleculeType; - } - else if (field.equals(PDBDocField.PDB_ID) + if (field.equals(PDBDocField.PDB_ID) && doc.get(PDBDocField.PDB_ID.getCode()) != null) { this.pdbId = doc.get(PDBDocField.PDB_ID.getCode()).toString(); - summaryBuilder.append(this.pdbId).append(" | "); summaryData[colCounter++] = this.pdbId; } - else if (doc.get(field.getCode()) != null) + else { - summaryBuilder.append(field.getName()).append(": ") - .append(doc.get(field.getCode())).append(" | "); - summaryData[colCounter++] = doc.get(field.getCode()).toString(); + String value = (doc.get(field.getCode()) == null) ? "" : doc.get( + field.getCode()).toString(); + summaryBuilder.append(field.getName()).append(": ").append(value) + .append(" | "); + summaryData[colCounter++] = value; } } - int endIndex = summaryBuilder.lastIndexOf(" | "); - String fSummary = summaryBuilder.toString().substring(0, endIndex); - this.concatenatedSummaryData = fSummary.trim(); + this.concatenatedSummaryData = summaryBuilder.toString(); summaryBuilder = null; }