X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=test%2Fjalview%2Fdatamodel%2Ffeatures%2FFeatureAttributesTest.java;h=0846ec26814e1a875f819773cadc9fb3e3924d27;hb=e1348f9e5966f70d5d96ed907f9a93794529b309;hp=4b7a435cafd236f06e6a169b27cd7435a1b4603e;hpb=9e926ac4305fd9dff38b6e079e55b4f50664d544;p=jalview.git

diff --git a/test/jalview/datamodel/features/FeatureAttributesTest.java b/test/jalview/datamodel/features/FeatureAttributesTest.java
index 4b7a435..0846ec2 100644
--- a/test/jalview/datamodel/features/FeatureAttributesTest.java
+++ b/test/jalview/datamodel/features/FeatureAttributesTest.java
@@ -12,6 +12,7 @@ import java.util.HashMap;
 import java.util.Map;
 
 import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
 import junit.extensions.PA;
@@ -20,9 +21,19 @@ public class FeatureAttributesTest
 {
 
   /**
+   * clear down attributes map before tests
+   */
+  @BeforeClass(alwaysRun = true)
+  public void setUp()
+  {
+    FeatureAttributes fa = FeatureAttributes.getInstance();
+    ((Map<?, ?>) PA.getValue(fa, "attributes")).clear();
+  }
+
+  /**
    * clear down attributes map after tests
    */
-  @AfterMethod
+  @AfterMethod(alwaysRun = true)
   public void tearDown()
   {
     FeatureAttributes fa = FeatureAttributes.getInstance();
@@ -56,7 +67,7 @@ public class FeatureAttributesTest
         "csq", "AF" }) < 0);
   }
 
-  @Test
+  @Test(groups = "Functional")
   public void testGetMinMax()
   {
     SequenceFeature sf = new SequenceFeature("Pfam", "desc", 10, 20,
@@ -65,12 +76,14 @@ public class FeatureAttributesTest
     assertNull(fa.getMinMax("Pfam", "kd"));
     sf.setValue("domain", "xyz");
     assertNull(fa.getMinMax("Pfam", "kd"));
-    sf.setValue("kd", "some text");
-    assertNull(fa.getMinMax("Pfam", "kd"));
     sf.setValue("kd", "1.3");
     assertEquals(fa.getMinMax("Pfam", "kd"), new float[] { 1.3f, 1.3f });
     sf.setValue("kd", "-2.6");
     assertEquals(fa.getMinMax("Pfam", "kd"), new float[] { -2.6f, 1.3f });
+    // setting 'mixed' character and numeric values wipes the min/max value
+    sf.setValue("kd", "some text");
+    assertNull(fa.getMinMax("Pfam", "kd"));
+
     Map<String, String> csq = new HashMap<>();
     csq.put("AF", "-3");
     sf.setValue("CSQ", csq);
@@ -88,7 +101,7 @@ public class FeatureAttributesTest
    * Test the method that returns an attribute description, provided it is
    * recorded and unique
    */
-  @Test
+  @Test(groups = "Functional")
   public void testGetDescription()
   {
     FeatureAttributes fa = FeatureAttributes.getInstance();
@@ -102,7 +115,7 @@ public class FeatureAttributesTest
     assertNull(fa.getDescription("Pfam", "kd"));
   }
 
-  @Test
+  @Test(groups = "Functional")
   public void testDatatype()
   {
     FeatureAttributes fa = FeatureAttributes.getInstance();