X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=test%2Fjalview%2Fdatamodel%2Ffeatures%2FNCListTest.java;h=3561a78c2e8b62197a328ae77435119f0adbf33a;hb=661f8bc80f969f31d7aeceb9af7d01374c8e1f35;hp=65c8c91cd0ec6b85a6a8577624630ab18b2dfff6;hpb=452f34ba2e3d65c29390df2b9d3637c4444ecbe2;p=jalview.git

diff --git a/test/jalview/datamodel/features/NCListTest.java b/test/jalview/datamodel/features/NCListTest.java
index 65c8c91..3561a78 100644
--- a/test/jalview/datamodel/features/NCListTest.java
+++ b/test/jalview/datamodel/features/NCListTest.java
@@ -12,6 +12,8 @@ import java.util.Comparator;
 import java.util.List;
 import java.util.Random;
 
+import junit.extensions.PA;
+
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
@@ -212,20 +214,20 @@ public class NCListTest
       assertEquals(ncl.size(), features.size());
       int toDelete = random.nextInt(features.size());
       SequenceFeature entry = features.get(toDelete);
-      String lastDeleted = "'" + entry.toString() + "'";
       assertTrue(ncl.contains(entry), String.format(
-              "NCList doesn't contain entry [%d] %s!", deleted,
-              lastDeleted));
+              "NCList doesn't contain entry [%d] '%s'!", deleted,
+              entry.toString()));
+
       ncl.delete(entry);
       assertFalse(ncl.contains(entry), String.format(
-              "NCList still contains deleted entry [%d] %s!", deleted,
-              lastDeleted));
+              "NCList still contains deleted entry [%d] '%s'!", deleted,
+              entry.toString()));
       features.remove(toDelete);
       deleted++;
 
       assertTrue(ncl.isValid(), String.format(
-              "NCList invalid after %d deletions, last deleted was %s",
-              deleted, lastDeleted));
+              "NCList invalid after %d deletions, last deleted was '%s'",
+              deleted, entry.toString()));
 
       /*
        * brute force check that deleting one entry didn't delete any others
@@ -234,8 +236,8 @@ public class NCListTest
       {
         SequenceFeature sf = features.get(i);
         assertTrue(ncl.contains(sf), String.format(
-                "NCList doesn't contain entry [%d] %s after deleting %s!",
-                i, sf.toString(), lastDeleted));
+                        "NCList doesn't contain entry [%d] %s after deleting '%s'!",
+                        i, sf.toString(), entry.toString()));
       }
     }
     assertEquals(ncl.size(), 0); // all gone
@@ -584,22 +586,22 @@ public class NCListTest
     assertEquals(ncl.toString(), "[40-50 [42-44 [43-43], 46-48]]");
     assertTrue(ncl.isValid());
 
-    r1.start = 43;
+    PA.setValue(r1, "start", 43);
     assertFalse(ncl.isValid()); // r2 not inside r1
-    r1.start = 40;
+    PA.setValue(r1, "start", 40);
     assertTrue(ncl.isValid());
 
-    r3.start = 41;
+    PA.setValue(r3, "start", 41);
     assertFalse(ncl.isValid()); // r3 should precede r2
-    r3.start = 46;
+    PA.setValue(r3, "start", 46);
     assertTrue(ncl.isValid());
 
-    r4.start = 41;
+    PA.setValue(r4, "start", 41);
     assertFalse(ncl.isValid()); // r4 not inside r2
-    r4.start = 43;
+    PA.setValue(r4, "start", 43);
     assertTrue(ncl.isValid());
 
-    r4.start = 44;
+    PA.setValue(r4, "start", 44);
     assertFalse(ncl.isValid()); // r4 has reverse range
   }