X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=test%2Fjalview%2Fio%2FAnnotatedPDBFileInputTest.java;h=e369a0249b33a70c96d4d47f7f373bfc7f55a982;hb=4ea2f7c6e700c5137c62a09a93d0127f8d58158b;hp=e14a4782a8ba51f04dc6fffc698a52f292fc5986;hpb=df2bf54c7050c42db156e96e73bbabce63e718d7;p=jalview.git

diff --git a/test/jalview/io/AnnotatedPDBFileInputTest.java b/test/jalview/io/AnnotatedPDBFileInputTest.java
index e14a478..e369a02 100644
--- a/test/jalview/io/AnnotatedPDBFileInputTest.java
+++ b/test/jalview/io/AnnotatedPDBFileInputTest.java
@@ -24,6 +24,15 @@ import static org.testng.AssertJUnit.assertEquals;
 import static org.testng.AssertJUnit.assertNotNull;
 import static org.testng.AssertJUnit.assertTrue;
 
+import java.io.File;
+import java.util.List;
+
+import org.junit.Assert;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
 import jalview.bin.Cache;
 import jalview.datamodel.AlignmentAnnotation;
 import jalview.datamodel.AlignmentI;
@@ -32,18 +41,11 @@ import jalview.datamodel.SequenceFeature;
 import jalview.datamodel.SequenceI;
 import jalview.datamodel.features.SequenceFeatures;
 import jalview.gui.AlignFrame;
+import jalview.gui.Desktop;
 import jalview.gui.JvOptionPane;
 import jalview.structure.StructureImportSettings;
 import jalview.structure.StructureImportSettings.StructureParser;
 
-import java.io.File;
-import java.util.List;
-
-import org.testng.annotations.AfterClass;
-import org.testng.annotations.BeforeClass;
-import org.testng.annotations.BeforeMethod;
-import org.testng.annotations.Test;
-
 public class AnnotatedPDBFileInputTest
 {
 
@@ -101,20 +103,21 @@ public class AnnotatedPDBFileInputTest
     }
   }
 
-  @Test(groups = { "Functional" })
+  @Test(groups = { "Functional" }, enabled = false)
   public void checkPDBannotationSource()
   {
-
+    Assert.fail(
+            "This test is incorrect - does not verify that JmolParser's annotation rows can be recognised as generated by the Jmol parser.");
     for (SequenceI asq : al.getSequences())
     {
       for (AlignmentAnnotation aa : asq.getAnnotation())
       {
 
         System.out.println("CalcId: " + aa.getCalcId());
-        if (StructureImportSettings.getDefaultPDBFileParser().equals(
-                StructureParser.JALVIEW_PARSER))
+        if (StructureImportSettings.getDefaultPDBFileParser()
+                .equals(StructureParser.JALVIEW_PARSER))
         {
-          assertTrue(MCview.PDBfile.isCalcIdForFile(aa, pdbId));
+          assertTrue(mc_view.PDBfile.isCalcIdForFile(aa, pdbId));
         }
       }
     }
@@ -180,10 +183,9 @@ public class AnnotatedPDBFileInputTest
             break;
           }
         }
-        assertTrue(
-                "Couldn't find sequence associated annotation "
-                        + aa.label
-                        + " on the sequence it is associated with.\nSequence associated editing will fail.",
+        assertTrue("Couldn't find sequence associated annotation "
+                + aa.label
+                + " on the sequence it is associated with.\nSequence associated editing will fail.",
                 found);
       }
     }
@@ -195,8 +197,9 @@ public class AnnotatedPDBFileInputTest
   @BeforeClass(alwaysRun = true)
   public static void setUpBeforeClass() throws Exception
   {
-    jalview.bin.Jalview.main(new String[] { "-props",
-        "test/jalview/io/testProps.jvprops" });
+    jalview.bin.Jalview
+            .main(new String[]
+            { "--props", "test/jalview/io/testProps.jvprops" });
   }
 
   /**
@@ -205,8 +208,8 @@ public class AnnotatedPDBFileInputTest
   @AfterClass(alwaysRun = true)
   public static void tearDownAfterClass() throws Exception
   {
-    jalview.gui.Desktop.instance.closeAll_actionPerformed(null);
-
+    if (Desktop.instance != null)
+      Desktop.instance.closeAll_actionPerformed(null);
   }
 
   @Test(groups = { "Functional" })
@@ -216,11 +219,12 @@ public class AnnotatedPDBFileInputTest
     String inFile = "examples/1gaq.txt";
     String tfile = File.createTempFile("JalviewTest", ".jvp")
             .getAbsolutePath();
-    AlignFrame af = new jalview.io.FileLoader().LoadFileWaitTillLoaded(
-            inFile, DataSourceType.FILE);
+    AlignFrame af = new jalview.io.FileLoader()
+            .LoadFileWaitTillLoaded(inFile, DataSourceType.FILE);
     assertTrue("Didn't read input file " + inFile, af != null);
+    af.saveAlignment(tfile, FileFormat.Jalview);
     assertTrue("Failed to store as a project.",
-            af.saveAlignment(tfile, FileFormat.Jalview));
+            af.isSaveAlignmentSuccessful());
     af.closeMenuItem_actionPerformed(true);
     af = null;
     af = new jalview.io.FileLoader().LoadFileWaitTillLoaded(tfile,
@@ -234,21 +238,21 @@ public class AnnotatedPDBFileInputTest
         sq = sq.getDatasetSequence();
       }
       assertNotNull(sq.getAllPDBEntries());
-      assertEquals("Expected only one PDB ID", 1, sq.getAllPDBEntries()
-              .size());
+      assertEquals("Expected only one PDB ID", 1,
+              sq.getAllPDBEntries().size());
       for (PDBEntry pdbentry : sq.getAllPDBEntries())
       {
-        System.err.println("PDB Entry " + pdbentry.getId() + " "
-                + pdbentry.getFile());
+        System.err.println(
+                "PDB Entry " + pdbentry.getId() + " " + pdbentry.getFile());
         boolean exists = false, found = false;
         for (AlignmentAnnotation ana : sq.getAnnotation())
         {
           System.err.println("CalcId " + ana.getCalcId());
           if (ana.getCalcId() != null
-                  && MCview.PDBfile.isCalcIdHandled(ana.getCalcId()))
+                  && mc_view.PDBfile.isCalcIdHandled(ana.getCalcId()))
           {
             exists = true;
-            if (MCview.PDBfile.isCalcIdForFile(ana, pdbentry.getId()))
+            if (mc_view.PDBfile.isCalcIdForFile(ana, pdbentry.getId()))
             {
               found = true;
             }
@@ -256,8 +260,10 @@ public class AnnotatedPDBFileInputTest
         }
         if (exists)
         {
-          assertTrue("Couldn't find any annotation for " + pdbentry.getId()
-                  + " (file handle " + pdbentry.getFile() + ")", found);
+          assertTrue(
+                  "Couldn't find any annotation for " + pdbentry.getId()
+                          + " (file handle " + pdbentry.getFile() + ")",
+                  found);
         }
       }
     }