X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=test%2Fjalview%2Fio%2Fcache%2FJvCacheableInputBoxTest.java;h=3e0aa367a8b64029697d21f617e5f475f05a3b1e;hb=42ab9fcdad6ea5c39bca0fb8b5564c2d420dc183;hp=3ed15ac6f156c493839f9b886e7c381ff1c3eb90;hpb=4b0cc64ad6d62223f1cc63089ce3f3b551e726e5;p=jalview.git diff --git a/test/jalview/io/cache/JvCacheableInputBoxTest.java b/test/jalview/io/cache/JvCacheableInputBoxTest.java index 3ed15ac..3e0aa36 100644 --- a/test/jalview/io/cache/JvCacheableInputBoxTest.java +++ b/test/jalview/io/cache/JvCacheableInputBoxTest.java @@ -20,8 +20,11 @@ */ package jalview.io.cache; +import java.lang.reflect.InvocationTargetException; import java.util.LinkedHashSet; +import javax.swing.SwingUtilities; + import org.junit.Assert; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; @@ -52,28 +55,23 @@ public class JvCacheableInputBoxTest cacheBox.addItem(testInput); cacheBox.setSelectedItem(testInput); - /* try { + // This delay is essential to prevent the assertion below from executing + // before swing thread finishes updating the combo-box SwingUtilities.invokeAndWait(() -> { - */ - try - { - // This delay is essential to prevent the - // assertion below from executing before - // swing thread finishes updating the combo-box - Thread.sleep(10); - } catch (InterruptedException e) + try + { + Thread.sleep(1); + } catch (InterruptedException e) + { + e.printStackTrace(); + } + }); + } catch (InvocationTargetException | InterruptedException e) { e.printStackTrace(); } - ; /* - }); - } catch (InvocationTargetException | InterruptedException e) - { - e.printStackTrace(); - } - */ userInput = cacheBox.getUserInput(); Assert.assertEquals(testInput, userInput); } @@ -86,27 +84,22 @@ public class JvCacheableInputBoxTest cacheBox.setSelectedItem(testInput); cacheBox.updateCache(); - /* try { + // This delay is to let cacheBox.updateCache() finish updating the cache SwingUtilities.invokeAndWait(() -> { - */ - try - { - // This delay is to let - // cacheBox.updateCache() finish updating the cache - Thread.sleep(1); - } catch (InterruptedException e) + try + { + Thread.sleep(1); + } catch (InterruptedException e) + { + e.printStackTrace(); + } + }); + } catch (InvocationTargetException | InterruptedException e) { e.printStackTrace(); } - ; /* - }); - } catch (InvocationTargetException | InterruptedException e) - { - e.printStackTrace(); - } - */ LinkedHashSet foundCache = appCache .getAllCachedItemsFor(TEST_CACHE_KEY); Assert.assertTrue(foundCache.contains(testInput));