X-Git-Url: http://source.jalview.org/gitweb/?a=blobdiff_plain;f=test%2Fjalview%2Frenderer%2FResidueColourFinderTest.java;h=81fb2c003ec936fe94633ebfac3c60d94c579c1b;hb=3af9017e1f6c6d045c6c0d41245fcd7bfdae32a6;hp=dd7a45769b97cd4746dc07c59affee8ed284a6b4;hpb=fb548a8458941602b0b8b45da5aaf60206e10ec2;p=jalview.git

diff --git a/test/jalview/renderer/ResidueColourFinderTest.java b/test/jalview/renderer/ResidueColourFinderTest.java
index dd7a457..81fb2c0 100644
--- a/test/jalview/renderer/ResidueColourFinderTest.java
+++ b/test/jalview/renderer/ResidueColourFinderTest.java
@@ -57,17 +57,28 @@ public class ResidueColourFinderTest
 
     // @see ResidueProperties.zappo
     assertEquals(Color.pink,
-            rcf.getResidueColour(av.getResidueShading(), null, seq, 0,
+            rcf.getResidueColour(true, av.getResidueShading(), null, seq, 0,
                     null)); // M
     assertEquals(Color.green,
-            rcf.getResidueColour(av.getResidueShading(), null, seq, 2,
+            rcf.getResidueColour(true, av.getResidueShading(), null, seq, 2,
                     null)); // T
     assertEquals(Color.magenta,
-            rcf.getResidueColour(av.getResidueShading(), null, seq, 5,
+            rcf.getResidueColour(true, av.getResidueShading(), null, seq, 5,
                     null)); // G
     assertEquals(Color.orange,
-            rcf.getResidueColour(av.getResidueShading(), null, seq, 12,
+            rcf.getResidueColour(true, av.getResidueShading(), null, seq,
+                    12,
                     null)); // F
+
+    // everything is white if showBoxes is false
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 0, null)); // M
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 2, null)); // T
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 5, null)); // G
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 12, null)); // F
   }
 
   @Test(groups = { "Functional" })
@@ -78,10 +89,18 @@ public class ResidueColourFinderTest
     final AlignViewport av = new AlignViewport(al);
     ResidueColourFinder rcf = new ResidueColourFinder();
 
-    assertEquals(Color.white, rcf.getResidueColour(av.getResidueShading(),
+    assertEquals(Color.white,
+            rcf.getResidueColour(true, av.getResidueShading(),
             null, seq, 0, null));
-    assertEquals(Color.white, rcf.getResidueColour(av.getResidueShading(),
+    assertEquals(Color.white,
+            rcf.getResidueColour(true, av.getResidueShading(),
             null, seq, 2, null));
+
+    // no change if showBoxes is false
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 0, null));
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 2, null));
   }
 
   @Test(groups = { "Functional" })
@@ -101,19 +120,32 @@ public class ResidueColourFinderTest
 
     av.setGlobalColourScheme(new UserColourScheme(newColours));
 
-    // gap colour not specified so gaps are null
-    assertEquals(null, rcf.getResidueColour(av.getResidueShading(),
+    // gap colour not specified so gap colour is null
+    // this is consistent with previous behaviour, but may not be correct?
+    assertEquals(null, rcf.getResidueColour(true, av.getResidueShading(),
             null, seq, 3, null));
 
     newColours[23] = Color.pink;
     av.setGlobalColourScheme(new UserColourScheme(newColours));
 
     // gap colour specified as pink
-    assertEquals(Color.pink, rcf.getResidueColour(av.getResidueShading(),
+    assertEquals(Color.pink, rcf.getResidueColour(true,
+            av.getResidueShading(),
+            null, seq, 3, null));
+
+    // everything is white if showBoxes is false
+    newColours[23] = null;
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(),
             null, seq, 3, null));
-  }
 
-  // TODO more tests for getResidueBoxColour covering groups, feature rendering,
-  // gaps, overview...
+    newColours[23] = Color.pink;
+    av.setGlobalColourScheme(new UserColourScheme(newColours));
+
+    // gap colour specified as pink
+    assertEquals(Color.white, rcf.getResidueColour(false,
+            av.getResidueShading(), null, seq, 3, null));
+  }
 
+  // TODO more tests for getResidueColour covering groups, feature rendering...
 }