From: kiramt <k.mourao@dundee.ac.uk>
Date: Wed, 4 Oct 2017 07:57:16 +0000 (+0100)
Subject: JAL-2674 tidy
X-Git-Tag: Release_2_10_4~55^2~1^2~88
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=1e263f063aeb478185020687227ea688be7d0847;p=jalview.git

JAL-2674 tidy
---

diff --git a/src/jalview/datamodel/HiddenColumns.java b/src/jalview/datamodel/HiddenColumns.java
index 839cee2..a6b4f82 100644
--- a/src/jalview/datamodel/HiddenColumns.java
+++ b/src/jalview/datamodel/HiddenColumns.java
@@ -701,21 +701,19 @@ public class HiddenColumns
     try
     {
       LOCK.readLock().lock();
-      int fpos = seq.getStart();
-      int lpos = seq.getEnd();
       int start = 0;
 
       if (hiddenColumns == null || hiddenColumns.size() == 0)
       {
-        int ifpos = seq.findIndex(fpos) - 1;
-        int ilpos = seq.findIndex(lpos) - 1;
+        int ifpos = seq.findIndex(seq.getStart()) - 1;
+        int ilpos = seq.findIndex(seq.getEnd()) - 1;
         return new int[] { ifpos, ifpos, ilpos };
       }
 
       // Simply walk along the sequence whilst watching for hidden column
       // boundaries
       Iterator<int[]> regions = iterator();
-      int spos = fpos;
+      int spos = seq.getStart();
       int hideStart = seq.getLength();
       int hideEnd = -1;
       int visPrev = 0;
@@ -723,8 +721,7 @@ public class HiddenColumns
       int firstP = -1;
       int lastP = -1;
       boolean foundStart = false;
-      for (int p = 0, pLen = seq.getLength(); spos <= seq.getEnd()
-              && p < pLen; p++)
+      for (int p = 0; spos <= seq.getEnd() && p < seq.getLength(); p++)
       {
         if (!Comparison.isGap(seq.getCharAt(p)))
         {
@@ -753,11 +750,9 @@ public class HiddenColumns
           {
             if (!foundStart)
             {
-              fpos = spos;
               start = p;
               foundStart = true;
             }
-            lpos = spos;
           }
           // look for next sequence position
           spos++;