From: gmungoc <g.m.carstairs@dundee.ac.uk>
Date: Mon, 17 Apr 2017 14:44:20 +0000 (+0100)
Subject: JAL-2446 comment updates
X-Git-Tag: Release_2_10_3b1~316
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=289a9b77b55b7a82f3fcc29bde33b23e3e80e1d4;p=jalview.git

JAL-2446 comment updates
---

diff --git a/src/jalview/datamodel/features/FeatureStore.java b/src/jalview/datamodel/features/FeatureStore.java
index ddee921..721ac18 100644
--- a/src/jalview/datamodel/features/FeatureStore.java
+++ b/src/jalview/datamodel/features/FeatureStore.java
@@ -256,8 +256,6 @@ public class FeatureStore
       }
       if (insertPosition < nonNestedFeatures.size())
       {
-        // FIXME may have to test more than one feature here
-        // e.g. add [40-60] to [20-42, 30-50, 45-55]
         if (encloses(feature, nonNestedFeatures.get(insertPosition)))
         {
           return false;
diff --git a/src/jalview/datamodel/features/NCList.java b/src/jalview/datamodel/features/NCList.java
index 6471e42..0af9d50 100644
--- a/src/jalview/datamodel/features/NCList.java
+++ b/src/jalview/datamodel/features/NCList.java
@@ -412,8 +412,12 @@ public class NCList<T extends ContiguousI>
    */
   protected int findFirstOverlap(long from)
   {
-    // TODO binary search
-    // for now quick cheat linear search
+    /*
+     * The NCList paper describes binary search for this step,
+     * but this not implemented here as (a) I haven't understood it yet
+     * and (b) it seems to imply complications for adding to an NCList
+     */
+
     int i = 0;
     if (subranges != null)
     {