From: gmungoc <g.m.carstairs@dundee.ac.uk>
Date: Thu, 6 Feb 2020 15:21:30 +0000 (+0000)
Subject: JAL-3509 better placement of call to notifyFeaturesChanged()
X-Git-Tag: Release_2_11_2_0~40^2~4
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=40fab5648f95fde7cbd6eca36c0b1378bca7aa25;p=jalview.git

JAL-3509 better placement of call to notifyFeaturesChanged()
---

diff --git a/src/jalview/ext/jmol/JalviewJmolBinding.java b/src/jalview/ext/jmol/JalviewJmolBinding.java
index 8a7cd23..e607ef8 100644
--- a/src/jalview/ext/jmol/JalviewJmolBinding.java
+++ b/src/jalview/ext/jmol/JalviewJmolBinding.java
@@ -755,8 +755,6 @@ public abstract class JalviewJmolBinding extends AAStructureBindingModel
         FeatureSettingsModelI colours = new Pdb().getFeatureColourScheme();
         ((AppJmol) getViewer()).getAlignmentPanel().av
                 .applyFeaturesStyle(colours);
-        // ... and refresh again to ensure FeatureSettings is in synch!
-        fr.notifyFeaturesChanged();
       }
       refreshGUI();
       loadNotifiesHandled++;
diff --git a/src/jalview/gui/AlignViewport.java b/src/jalview/gui/AlignViewport.java
index 3c520e3..55abea6 100644
--- a/src/jalview/gui/AlignViewport.java
+++ b/src/jalview/gui/AlignViewport.java
@@ -1098,6 +1098,8 @@ public class AlignViewport extends AlignmentViewport
       fr.orderFeatures(featureSettings);
     }
     fr.setTransparency(featureSettings.getTransparency());
+
+    fr.notifyFeaturesChanged();
   }
 
   public String getViewName()