From: gmungoc <g.m.carstairs@dundee.ac.uk>
Date: Mon, 23 Jul 2018 10:56:11 +0000 (+0100)
Subject: JAL-3048 javadoc and code tidy
X-Git-Tag: Release_2_11_4_0~45^2~18^2~506^2
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=4499c22043eb437cbb95eb9a26edb82e9ddec88f;p=jalview.git

JAL-3048 javadoc and code tidy
---

diff --git a/src/jalview/bin/Cache.java b/src/jalview/bin/Cache.java
index 1f031b2..b6315f3 100755
--- a/src/jalview/bin/Cache.java
+++ b/src/jalview/bin/Cache.java
@@ -604,18 +604,13 @@ public class Cache
   }
 
   /**
-   * These methods are used when checking if the saved preference is different
-   * to the default setting
+   * Answers the value of the given property, or the supplied default value if
+   * the property is not set
    */
   public static String getDefault(String property, String def)
   {
-    String string = getProperty(property);
-    if (string != null)
-    {
-      return string;
-    }
-
-    return def;
+    String value = getProperty(property);
+    return value == null ? def : value;
   }
 
   /**