From: Jim Procter <j.procter@dundee.ac.uk>
Date: Tue, 14 Sep 2021 17:55:40 +0000 (+0100)
Subject: JAL-3829 more info on test fail - seems to be flaky
X-Git-Tag: Release_2_11_2_0~35^2^2~2
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=55d5f13809722084ebd354dc0a732abe9e991f9f;p=jalview.git

JAL-3829 more info on test fail - seems to be flaky
---

diff --git a/test/jalview/gui/StructureChooserTest.java b/test/jalview/gui/StructureChooserTest.java
index ad3cfc1..57aa23c 100644
--- a/test/jalview/gui/StructureChooserTest.java
+++ b/test/jalview/gui/StructureChooserTest.java
@@ -20,6 +20,7 @@
  */
 package jalview.gui;
 
+import static org.testng.Assert.assertEquals;
 import static org.testng.AssertJUnit.assertEquals;
 import static org.testng.AssertJUnit.assertNotNull;
 import static org.testng.AssertJUnit.assertTrue;
@@ -46,6 +47,8 @@ import jalview.ws.params.InvalidArgumentException;
 import java.util.Collection;
 import java.util.Vector;
 
+import javax.swing.JComboBox;
+
 import org.junit.Assert;
 import org.testng.annotations.AfterMethod;
 import org.testng.annotations.BeforeClass;
@@ -137,10 +140,21 @@ public class StructureChooserTest
 
     SequenceI[] selectedSeqs = new SequenceI[] { seq };
     StructureChooser sc = new StructureChooser(selectedSeqs, seq, null);
+    
+    // if structures are not discovered then don't
+    // populate filter options
     sc.populateFilterComboBox(false, false);
     int optionsSize = sc.getCmbFilterOption().getItemCount();
-    assertEquals(2, optionsSize); // if structures are not discovered then don't
-                                  // populate filter options
+    System.out.println("Items (no data, no cache): ");
+    StringBuilder items = new StringBuilder();
+    for (int p=0;p<optionsSize;p++)
+    {
+      items.append
+      ("- ").append(sc.getCmbFilterOption().getItemAt(p).getName()).append("\n");
+
+    }
+    // report items when this fails - seems to be a race condition
+    assertEquals(optionsSize,2,items.toString()); 
 
     sc.populateFilterComboBox(true, false);
     optionsSize = sc.getCmbFilterOption().getItemCount();